summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-06-23Remove expired PDPsJim Hahn19-774/+271
Added code to remove PDPs for which no message has been received for a while. Added a max-age field to the request-map parameters, changing the parameters class to use a Builder, in the process. Deleted the PdpTracker class, as its functionality was replaced by the expiration checker. Changed port numbers in some tests, due to collisions in junit tests. Issue-ID: POLICY-3407 Change-Id: Ifbfbc03b833a4f11ee5e910e256ee42e21a0afab Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-22Update timestamp of PDP recordJim Hahn1-9/+18
Modified the code to update the record timestamp when a heartbeat is received from a PDP. Also used Map operations instead of List operations to construct policy deploy/undeploy lists so they can be constructed in O(N) instead of O(N^2). Issue-ID: POLICY-2898 Change-Id: Ic7b2b9a249fa0563b625e98855c79f96c6ee81d4 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-18Fix new checkstyle issues in papJim Hahn3-5/+3
The new version of checkstyle identified new issues. Fixed those. Issue-ID: POLICY-3287 Change-Id: I18a34cbc6197266375981031106acc38385c69b5 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-15Use new filtering methods in PAPJim Hahn2-4/+8
Modified PAP to use the new filter parameters classes instead of the old methods that take lots of parameters. Issue-ID: POLICY-3094 Change-Id: I46ac6d95a8f1e56ced8ed39474eb5a1031142dd7 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-10Sonars in papJim Hahn1-1/+1
Fixed sonars: -use correct class name in logger Issue-ID: POLICY-3287 Change-Id: I62fab4b48151d8f2ca32ad5d2951e7359210e2c0 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-03remove quoting the groups var in policy-pap.shjhh1-1/+1
Issue-ID: POLICY-3331 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Idccfa3761b9a7d9d8907f105a261c9c7c85e70c5 (cherry picked from commit 689ec7f2a61c0f5347d807f70244588590cd9b8a)
2021-06-03Update junits for bean validator field nameJim Hahn1-4/+4
Now that the bean validator uses the serialized field name in its error messages, updated the junits to use the serialized names, too. Issue-ID: POLICY-3333 Change-Id: I5d447851b72f460fa71e57936847664e2c789462 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-02Fix build failure and remove unused importswaynedunican3-4/+1
Issue-ID: POLICY-3339 Change-Id: I0c9bd25e63b24ba3ac7e38a77e963fcdbaa4d26a Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-06-01Merge "support external configuration of pdp groups"Jim Hahn6-34/+126
2021-05-27support external configuration of pdp groupsjhh6-34/+126
- modify policy-pap.sh to optionally provision a custom group if such a file is present. Issue-ID: POLICY-3331 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ib53bc14ee6b9471ab48f5a792b4283db3ed53b93 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-05-27Update PAP to check for deployed policies onlywaynedunican14-83/+85
Have PAP compare the returned list against the delta deployment list instead of comparing against the full list of policies as is the current behaviour. Any references to "get" or "set" policies methods have also been removed Issue-ID: POLICY-3263 Change-Id: I0efe03e835db3c4b2136f7e742bba0e78dc2ac44 Signed-off-by: waynedunican <wayne.dunican@est.tech> Signed-off-by: WayneDunican <wayne.dunican@est.tech>
2021-05-13Remove csit folder from policy/papRam Krishna Verma6-272/+0
The csit test files for all repos have been consolidated in policy/docker to maintain them at single place and allow us to trigger verify jobs in gerrit reviews. Issue-ID: POLICY-3257 Change-Id: I8f80d6a8b56fd5c931f2ba1801c855c125d9704c Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-06Fix sonars in policy-papJim Hahn33-130/+118
Fixed: - use "var" instead of actual type - remove unused parameter - remove un-thrown exception from method declaration - call isPresent() before Optional.get() - check empty list before invoking doesNotContain() Issue-ID: POLICY-3285 Change-Id: Ic90dccfd591c102ce29f14084f025b3ca69587dc Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-06Merge "Query deployed policies by regex"Ram Krishna Verma4-16/+187
2021-05-06Query deployed policies by regexarkadiusz.adamski4-16/+187
- Query deployed policies by regex on the name, for a given policy type Issue-ID: POLICY-2535 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: Ia2be683d044b22e4104ae14e2ce301882091c8ea
2021-05-05Remove deprecated robot methods in pap csitRam Krishna Verma1-12/+12
Removing the deprecated methods from pap csit as they will be no longer supported by robot framework. Issue-ID: POLICY-3257 Change-Id: I2aab85a6704ab12b732ef97e23db6acd60e0e7c0 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-03Merge "Remove GroupValidationResult"Jim Hahn11-70/+67
2021-04-28Remove GroupValidationResultJim Hahn11-70/+67
Removed GroupValidationResult, replacing it with BeanValidationResult. Modified the ParameterGroup subclasses to use BeanValidator, adding annotations where needed to trigger the validations that had been automatically performed by GroupValidationResult. Issue-ID: POLICY-2059 Change-Id: I9597dc84e8a81ac5b8954bb2ce4ad0d7e2a3a4a7 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-27Fixing issue where PdpHeartbeats are incorrectly processed by PAPa.sreekumar1-2/+6
The below 2 issues are fixed in this review: 1) When updating the policiesToBeUndeployed, the policies list in the message itself was getting removed, which resulted in incorrect processing. This was the reason for continuos UPDATE and STATE_CHANGE messages from PAP to PDP. 2) In case if the policy list in heartbeat doesn't include one or more policies that are supposed to be deployed(as per DB), the PAP should send UPDATE messages to PDP asking to deploy them too. But this was not working as the policiesToBeDeployed list was not getting initialized properly before getting processed. Change-Id: I06dbfd1d40bae8a510fc5500fbd38fb87c203c0d Issue-ID: POLICY-3248 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-04-16Merge "Address plugin-not-found issues"Ram Krishna Verma1-31/+0
2021-04-16Refactor PapCommandLineArguments classadheli.tavares3-256/+29
CMD Args class to extend functionality from Common CMD class. Issue-ID: POLICY-3129 Change-Id: Ia00cf7b0277e779811eaac556eebe11da95ed380 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-04-15Address plugin-not-found issuesJim Hahn1-31/+0
Removed references to archetype-packaging and lifecycle-mapping, where unnecessary due to pom inheritance. Issue-ID: POLICY-3136 Change-Id: I7483ccd96876f9babb64c0899eb03d6cf0b195f2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-07Merge "Use sh instead of ash in PAP"Pamela Dragosh1-2/+2
2021-04-07Use sh instead of ash in PAPJim Hahn1-2/+2
Issue-ID: POLICY-3160 Change-Id: I79c41aa584efd3f4c617fd7c6de9ccf3862eb34d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-01Merge "PAP S3P jmx file changes"Pamela Dragosh2-29/+236
2021-03-31PAP S3P jmx file changeswaynedunican2-29/+236
Issue-ID: POLICY-3110 Change-Id: I679dc16fedccda496e2030e8a0cc2e74b8787d9d Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-29Validate parameters of REST callsJim Hahn7-2/+125
Added code to validate the parameters of the REST calls. As it turned out, validation only needed to be added to one call. Issue-ID: POLICY-2542 Change-Id: Ia9aabf75e06d6d5f996be9e3ed804218319f70c2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-19Delete keystores from papJim Hahn3-5/+6
The Keystore is no longer needed in the tarball, as it is supplied externally by the CSITs and Helm charts. Deleted that file. Also modified the junits to use utils-test to generates keystores at runtime, thus deleted the junit keystore file, too. Issue-ID: POLICY-3143 Change-Id: I2b0c4868613e0923aad87844dd16f3ac236d4291 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-18Bump policy references to latest snapshot versionsliamfallon1-3/+3
Issue-ID: POLICY-3105 Change-Id: I81d6d343a22b2e27d1b7109d5a918e792ce674fb Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-03-16Update policy-keystore with newer certificatesjhh2-0/+0
Issue-ID: POLICY-3139 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I728118f2eb691dddb93b36c832eb4c8a72e0d5af
2021-03-12Bump PAP to 2.5.0-SNAPSHOTliamfallon9-10/+10
Issue-ID: POLICY-3105 Change-Id: I558a09dcc5a28df1a978f760b5fe0eeee72aeb30 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-03-10Merge "Bump pap to 2.4.2-SNAPSHOT"Pamela Dragosh9-9/+9
2021-03-10Bump pap to 2.4.2-SNAPSHOTwaynedunican9-9/+9
Issue-ID: POLICY-3127 Change-Id: I0949f9e03a538e3f9ba463697885b799fd0b2acb Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-10Release pap 2.4.1 dockerwaynedunican1-0/+8
Issue-ID: POLICY-3127 Change-Id: I87b64768b13e376e38a670e3fb687b137050275b Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-10Release pap 2.4.1 maven artifactswaynedunican1-0/+5
Issue-ID: POLICY-3127 Change-Id: I9ef1b95a8f2591f6cbdd8106142d015ccd507567 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-10Point to policy-models 2.4.1waynedunican1-2/+2
Issue-ID: POLICY-3127 Change-Id: I97af3ae7c118cb5ec316a4b8bbb4c0bfff328f06 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-05Use models 2.4.1-SNAPSHOT in PAPJim Hahn1-2/+2
Done to resolve EntityNotFoundException in windriver lab and in junit tests. Issue-ID: POLICY-3125 Change-Id: I5dbdf732154ee725ae9555722cde5d1f2008223c Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-24Update info.yaml in papRam Krishna Verma1-2/+2
Issue-ID: POLICY-3028 Change-Id: Ic84724605ac2fc56c1391b0e0a2ad6f10e551545 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-23Bump pap to 2.4.1-SNAPSHOTRam Krishna Verma9-9/+9
Issue-ID: POLICY-3088 Change-Id: I74f23c31db609ca61592ec62b0594445bb8bf68c Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-23Release pap 2.4.0 docker imageRam Krishna Verma1-0/+8
Issue-ID: POLICY-3088 Change-Id: I1d7264a4808a787955f17537b4710f1585d92727 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-23Release pap 2.4.0 versionRam Krishna Verma1-0/+5
Issue-ID: POLICY-3088 Change-Id: I7bbbb1008e74e8245c1ae0b31a204b2548913e8b Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-23Point to released version of jreRam Krishna Verma1-1/+1
Issue-ID: POLICY-3088 Change-Id: I467866accd2d573478282560ebe81a7923f62dc9 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-23Point to released version of dependenciesRam Krishna Verma1-3/+3
Issue-ID: POLICY-3088 Change-Id: Ie1cfd8b08a48881738966b1ce86f5f9c88a6e537 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-22Support Policy updates between PAP and PDPswaynedunican11-28/+300
Change to send only the policies that need to be updated (deployed/undeployed) rather than full of policies to DMaap via the PDP_UPDATE message Issue-ID: POLICY-2112 Change-Id: I65f8bf46f230afb9d4b6937cb89af1d9f05d2fbd Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-02-22Merge "Refactor Pap code to use Instant from Date"Jim Hahn3-9/+10
2021-02-19Refactor Pap code to use Instant from Daterameshiyer273-9/+10
Issue-ID: POLICY-3069 Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech> Change-Id: I0e1b8ccc41749cd53a299397c8399f833279df59
2021-02-19Update Pdp policy status during registration or State changea.sreekumar4-18/+180
The Pdp Policy Status is not updated during the pdp heartbeat handling/registration flow, or during State change. When a PDP goes down the pdppolicystatus gets cleared. But when the PDP comes back online, PAP deploys the right policies into it, but the deployment status was not getting updated. Similarly, when the State is changed to PASSIVE, the status should be undeployed, and when the state is changed back to ACTIVE, then the status should be deployed for any active policies in any PDP. These issues are fixed here. Updating postman collection. Also updating the csit test to check for 202 instead of 200 for the deployment api response. Change-Id: I1e05f22df23daaa8da8be1376413e995be2376f3 Issue-ID: POLICY-2526 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-18Update PAP CSIT to check 202 responseJim Hahn1-2/+2
Issue-ID: POLICY-2526 Change-Id: I3f4e1289fb4c8aeb4833d3e76b473cf36f907783 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-17Updating PAP deployment API to reflect actual statusa.sreekumar9-78/+535
Change-Id: I5281937fe5a742916c0c86983f71e280bbe126b2 Issue-ID: POLICY-2526 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-12Fix sonars from dependency upgradeJim Hahn7-23/+22
The dependency upgrades in policy-parent caused some new sonars. In particular, initMocks() has been deprecated - replaced with calls to the Mockito Runner and one call to openMocks(). Issue-ID: POLICY-2911 Change-Id: I6f28af9af41a1e5c83dead2eabf580731ffb9526 Signed-off-by: Jim Hahn <jrh3@att.com>