summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-07-05Revert "Add listener to collect PDP statistics"Jim Hahn3-375/+1
This reverts commit 7b4a8ec06c8266f368a31cdafe75cf8a59304c83. Reason for revert: Decided to have the whole heartbeat processing use its own subscription, thus no need for a new class/topic just to collect statistics. Issue-ID: POLICY-3405 Change-Id: I71580f877dae86a058ee881bc10f7bd1f57ff338 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-30Add listener to collect PDP statisticsJim Hahn3-1/+375
This new class will be tied into the existing code via the next review. Issue-ID: POLICY-3405 Change-Id: I4317ccba3eda6863ce96a6db4ef20816e59a7f2d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-30Add ability to turn on/off pdp statisticsRam Krishna Verma12-36/+66
Adding an ability in pap to turn on/off processing of pdp statistics. By default it will be turned on and can be changed via configuration. Issue-ID: POLICY-3450 Change-Id: I093fe3f1390769f9acf2cfe85dd0d4edf0539de8 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-06-29Fix sonars in papJim Hahn2-4/+4
Fixed: - indentation - use isEmpty() - use isZero() Issue-ID: POLICY-3287 Change-Id: Idcfba3a6839a47c3136fca8500128990ed64dcb1 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-29Merge "Set "source" name in PAP PdpMessages"Jim Hahn7-16/+22
2021-06-29Merge "PolicyAudit creation when deploy/undeploy triggered."Jim Hahn17-141/+425
2021-06-29Set "source" name in PAP PdpMessagesJim Hahn7-16/+22
Used the unique name generator to initialize the PAP_NAME constant which is then stuffed into the various outgoing PdpMessages. Issue-ID: POLICY-3409 Change-Id: I45d26403b4f3de4b040cad779f29c82f35bacf42 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-28Merge "Send pdp-update if PDP response doesn't match DB"Jim Hahn8-17/+199
2021-06-28Update pap for checkstyle 8.43liamfallon10-154/+280
Updates are indentation changes on annotations. Issue-ID: POLICY-3209 Change-Id: I3878ea476550e7522605e53bffa5c9c123030cdf Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-06-25Send pdp-update if PDP response doesn't match DBJim Hahn8-17/+199
Because multiple PAPs can be updating the DB, it's possible that a pdp-update sent by a PAP does not reflect the latest deployment data in the DB. To solve that problem, modified code to compare any response received from a PDP with what's in the DB, potentially generating a new pdp-update (and/or pdp-state-change). Issue-ID: POLICY-3426 Change-Id: I241994330d7645c0fffe66abc33de67d71d77250 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-25PolicyAudit creation when deploy/undeploy triggered.adheli.tavares17-141/+426
Creates audits for policy when: - deploy - undeploy - undeploy when failure Issue-ID: POLICY-2899 Change-Id: Ib1a7cc4f826b5dceefcd5c7ba5250647f2cc0121 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-06-25Fix broken junitsJim Hahn2-2/+2
Some junits are broken since adding the expiration timer. Changed the length of the heartbeat in an attempt to fix it. Issue-ID: POLICY-3407 Change-Id: I81046476e243a0bf20ae9db9259be4464418e73e Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-23Remove expired PDPsJim Hahn19-774/+271
Added code to remove PDPs for which no message has been received for a while. Added a max-age field to the request-map parameters, changing the parameters class to use a Builder, in the process. Deleted the PdpTracker class, as its functionality was replaced by the expiration checker. Changed port numbers in some tests, due to collisions in junit tests. Issue-ID: POLICY-3407 Change-Id: Ifbfbc03b833a4f11ee5e910e256ee42e21a0afab Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-22Update timestamp of PDP recordJim Hahn1-9/+18
Modified the code to update the record timestamp when a heartbeat is received from a PDP. Also used Map operations instead of List operations to construct policy deploy/undeploy lists so they can be constructed in O(N) instead of O(N^2). Issue-ID: POLICY-2898 Change-Id: Ic7b2b9a249fa0563b625e98855c79f96c6ee81d4 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-18Fix new checkstyle issues in papJim Hahn3-5/+3
The new version of checkstyle identified new issues. Fixed those. Issue-ID: POLICY-3287 Change-Id: I18a34cbc6197266375981031106acc38385c69b5 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-15Use new filtering methods in PAPJim Hahn2-4/+8
Modified PAP to use the new filter parameters classes instead of the old methods that take lots of parameters. Issue-ID: POLICY-3094 Change-Id: I46ac6d95a8f1e56ced8ed39474eb5a1031142dd7 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-10Sonars in papJim Hahn1-1/+1
Fixed sonars: -use correct class name in logger Issue-ID: POLICY-3287 Change-Id: I62fab4b48151d8f2ca32ad5d2951e7359210e2c0 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-03remove quoting the groups var in policy-pap.shjhh1-1/+1
Issue-ID: POLICY-3331 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Idccfa3761b9a7d9d8907f105a261c9c7c85e70c5 (cherry picked from commit 689ec7f2a61c0f5347d807f70244588590cd9b8a)
2021-06-03Update junits for bean validator field nameJim Hahn1-4/+4
Now that the bean validator uses the serialized field name in its error messages, updated the junits to use the serialized names, too. Issue-ID: POLICY-3333 Change-Id: I5d447851b72f460fa71e57936847664e2c789462 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-02Fix build failure and remove unused importswaynedunican3-4/+1
Issue-ID: POLICY-3339 Change-Id: I0c9bd25e63b24ba3ac7e38a77e963fcdbaa4d26a Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-06-01Merge "support external configuration of pdp groups"Jim Hahn6-34/+126
2021-05-27support external configuration of pdp groupsjhh6-34/+126
- modify policy-pap.sh to optionally provision a custom group if such a file is present. Issue-ID: POLICY-3331 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ib53bc14ee6b9471ab48f5a792b4283db3ed53b93 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-05-27Update PAP to check for deployed policies onlywaynedunican14-83/+85
Have PAP compare the returned list against the delta deployment list instead of comparing against the full list of policies as is the current behaviour. Any references to "get" or "set" policies methods have also been removed Issue-ID: POLICY-3263 Change-Id: I0efe03e835db3c4b2136f7e742bba0e78dc2ac44 Signed-off-by: waynedunican <wayne.dunican@est.tech> Signed-off-by: WayneDunican <wayne.dunican@est.tech>
2021-05-13Remove csit folder from policy/papRam Krishna Verma6-272/+0
The csit test files for all repos have been consolidated in policy/docker to maintain them at single place and allow us to trigger verify jobs in gerrit reviews. Issue-ID: POLICY-3257 Change-Id: I8f80d6a8b56fd5c931f2ba1801c855c125d9704c Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-06Fix sonars in policy-papJim Hahn33-130/+118
Fixed: - use "var" instead of actual type - remove unused parameter - remove un-thrown exception from method declaration - call isPresent() before Optional.get() - check empty list before invoking doesNotContain() Issue-ID: POLICY-3285 Change-Id: Ic90dccfd591c102ce29f14084f025b3ca69587dc Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-06Merge "Query deployed policies by regex"Ram Krishna Verma4-16/+187
2021-05-06Query deployed policies by regexarkadiusz.adamski4-16/+187
- Query deployed policies by regex on the name, for a given policy type Issue-ID: POLICY-2535 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: Ia2be683d044b22e4104ae14e2ce301882091c8ea
2021-05-05Remove deprecated robot methods in pap csitRam Krishna Verma1-12/+12
Removing the deprecated methods from pap csit as they will be no longer supported by robot framework. Issue-ID: POLICY-3257 Change-Id: I2aab85a6704ab12b732ef97e23db6acd60e0e7c0 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-05-03Merge "Remove GroupValidationResult"Jim Hahn11-70/+67
2021-04-28Remove GroupValidationResultJim Hahn11-70/+67
Removed GroupValidationResult, replacing it with BeanValidationResult. Modified the ParameterGroup subclasses to use BeanValidator, adding annotations where needed to trigger the validations that had been automatically performed by GroupValidationResult. Issue-ID: POLICY-2059 Change-Id: I9597dc84e8a81ac5b8954bb2ce4ad0d7e2a3a4a7 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-27Fixing issue where PdpHeartbeats are incorrectly processed by PAPa.sreekumar1-2/+6
The below 2 issues are fixed in this review: 1) When updating the policiesToBeUndeployed, the policies list in the message itself was getting removed, which resulted in incorrect processing. This was the reason for continuos UPDATE and STATE_CHANGE messages from PAP to PDP. 2) In case if the policy list in heartbeat doesn't include one or more policies that are supposed to be deployed(as per DB), the PAP should send UPDATE messages to PDP asking to deploy them too. But this was not working as the policiesToBeDeployed list was not getting initialized properly before getting processed. Change-Id: I06dbfd1d40bae8a510fc5500fbd38fb87c203c0d Issue-ID: POLICY-3248 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-04-16Merge "Address plugin-not-found issues"Ram Krishna Verma1-31/+0
2021-04-16Refactor PapCommandLineArguments classadheli.tavares3-256/+29
CMD Args class to extend functionality from Common CMD class. Issue-ID: POLICY-3129 Change-Id: Ia00cf7b0277e779811eaac556eebe11da95ed380 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-04-15Address plugin-not-found issuesJim Hahn1-31/+0
Removed references to archetype-packaging and lifecycle-mapping, where unnecessary due to pom inheritance. Issue-ID: POLICY-3136 Change-Id: I7483ccd96876f9babb64c0899eb03d6cf0b195f2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-07Merge "Use sh instead of ash in PAP"Pamela Dragosh1-2/+2
2021-04-07Use sh instead of ash in PAPJim Hahn1-2/+2
Issue-ID: POLICY-3160 Change-Id: I79c41aa584efd3f4c617fd7c6de9ccf3862eb34d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-01Merge "PAP S3P jmx file changes"Pamela Dragosh2-29/+236
2021-03-31PAP S3P jmx file changeswaynedunican2-29/+236
Issue-ID: POLICY-3110 Change-Id: I679dc16fedccda496e2030e8a0cc2e74b8787d9d Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-29Validate parameters of REST callsJim Hahn7-2/+125
Added code to validate the parameters of the REST calls. As it turned out, validation only needed to be added to one call. Issue-ID: POLICY-2542 Change-Id: Ia9aabf75e06d6d5f996be9e3ed804218319f70c2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-19Delete keystores from papJim Hahn3-5/+6
The Keystore is no longer needed in the tarball, as it is supplied externally by the CSITs and Helm charts. Deleted that file. Also modified the junits to use utils-test to generates keystores at runtime, thus deleted the junit keystore file, too. Issue-ID: POLICY-3143 Change-Id: I2b0c4868613e0923aad87844dd16f3ac236d4291 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-18Bump policy references to latest snapshot versionsliamfallon1-3/+3
Issue-ID: POLICY-3105 Change-Id: I81d6d343a22b2e27d1b7109d5a918e792ce674fb Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-03-16Update policy-keystore with newer certificatesjhh2-0/+0
Issue-ID: POLICY-3139 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I728118f2eb691dddb93b36c832eb4c8a72e0d5af
2021-03-12Bump PAP to 2.5.0-SNAPSHOTliamfallon9-10/+10
Issue-ID: POLICY-3105 Change-Id: I558a09dcc5a28df1a978f760b5fe0eeee72aeb30 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-03-10Merge "Bump pap to 2.4.2-SNAPSHOT"Pamela Dragosh9-9/+9
2021-03-10Bump pap to 2.4.2-SNAPSHOTwaynedunican9-9/+9
Issue-ID: POLICY-3127 Change-Id: I0949f9e03a538e3f9ba463697885b799fd0b2acb Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-10Release pap 2.4.1 dockerwaynedunican1-0/+8
Issue-ID: POLICY-3127 Change-Id: I87b64768b13e376e38a670e3fb687b137050275b Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-10Release pap 2.4.1 maven artifactswaynedunican1-0/+5
Issue-ID: POLICY-3127 Change-Id: I9ef1b95a8f2591f6cbdd8106142d015ccd507567 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-10Point to policy-models 2.4.1waynedunican1-2/+2
Issue-ID: POLICY-3127 Change-Id: I97af3ae7c118cb5ec316a4b8bbb4c0bfff328f06 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2021-03-05Use models 2.4.1-SNAPSHOT in PAPJim Hahn1-2/+2
Done to resolve EntityNotFoundException in windriver lab and in junit tests. Issue-ID: POLICY-3125 Change-Id: I5dbdf732154ee725ae9555722cde5d1f2008223c Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-24Update info.yaml in papRam Krishna Verma1-2/+2
Issue-ID: POLICY-3028 Change-Id: Ic84724605ac2fc56c1391b0e0a2ad6f10e551545 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>