1 files changed, 12 insertions, 27 deletions

diff --git a/main/src/test/java/org/onap/policy/pap/main/rest/TestPolicyComponentsHealthCheckControllerV1.java b/main/src/test/java/org/onap/policy/pap/main/rest/TestPolicyComponentsHealthCheckControllerV1.java
index b49d7704..e07d35c1 100644
--- a/main/src/test/java/org/onap/policy/pap/main/rest/TestPolicyComponentsHealthCheckControllerV1.java
+++ b/main/src/test/java/org/onap/policy/pap/main/rest/TestPolicyComponentsHealthCheckControllerV1.java
@@ -2,6 +2,7 @@
  * ============LICENSE_START=======================================================
  *  Copyright (C) 2019-2020 Nordix Foundation.
  *  Modifications Copyright (C) 2020-2021 AT&T Inc.
+ *  Modifications Copyright (C) 2021 Bell Canada. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,20 +25,16 @@ package org.onap.policy.pap.main.rest;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 
-import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import javax.ws.rs.client.Invocation;
 import javax.ws.rs.core.GenericType;
 import javax.ws.rs.core.Response;
-import org.junit.AfterClass;
-import org.junit.BeforeClass;
 import org.junit.Test;
 import org.onap.policy.common.endpoints.parameters.RestClientParameters;
-import org.onap.policy.common.parameters.ParameterService;
 import org.onap.policy.pap.main.parameters.PapParameterGroup;
-import org.powermock.reflect.Whitebox;
+import org.springframework.beans.factory.annotation.Autowired;
 
 /**
  * Class to perform unit test of {@link PolicyComponentsHealthCheckControllerV1}.
@@ -47,29 +44,10 @@ import org.powermock.reflect.Whitebox;
 public class TestPolicyComponentsHealthCheckControllerV1 extends CommonPapRestServer {
 
     private static final String ENDPOINT = "components/healthcheck";
-    private static List<RestClientParameters> savedRestClientParameters;
+    private List<RestClientParameters> savedRestClientParameters;
 
-    /**
-     * Set up for the test class.
-     */
-    @BeforeClass
-    public static void setUpClass() {
-        // To skip calling to the remote components
-        PapParameterGroup papParameterGroup = ParameterService.get("PapGroup");
-        List<RestClientParameters> lo = Whitebox.getInternalState(papParameterGroup, "healthCheckRestClientParameters");
-        savedRestClientParameters = new ArrayList<>(lo);
-        lo.clear();
-    }
-
-    /**
-     * Tear down for the test class.
-     */
-    @AfterClass
-    public static void tearDownClass() {
-        PapParameterGroup papParameterGroup = ParameterService.get("PapGroup");
-        List<RestClientParameters> lo = Whitebox.getInternalState(papParameterGroup, "healthCheckRestClientParameters");
-        lo.addAll(savedRestClientParameters);
-    }
+    @Autowired
+    private PapParameterGroup papParameterGroup;
 
     @Test
     public void testSwagger() throws Exception {
@@ -79,6 +57,10 @@ public class TestPolicyComponentsHealthCheckControllerV1 extends CommonPapRestSe
     @Test
     @SuppressWarnings("unchecked")
     public void testPolicyComponentsHealthCheck() throws Exception {
+        // take out the other components for healthcheck
+        savedRestClientParameters = papParameterGroup.getHealthCheckRestClientParameters();
+        papParameterGroup.setHealthCheckRestClientParameters(null);
+
         Invocation.Builder invocationBuilder = sendRequest(ENDPOINT);
         Response response = invocationBuilder.get();
         assertEquals(Response.Status.OK.getStatusCode(), response.getStatus());
@@ -86,5 +68,8 @@ public class TestPolicyComponentsHealthCheckControllerV1 extends CommonPapRestSe
         result = (Map<String, Object>) response.readEntity(GenericType.forInstance(result));
         // No PDP configured, healthy is false
         assertFalse((Boolean) result.get("healthy"));
+
+        // put back the other components
+        papParameterGroup.setHealthCheckRestClientParameters(savedRestClientParameters);
     }
 }