Fixed sonar issues in policy-pap

Reduced technical debt by fixing sonar issues

Issue-ID: POLICY-4536
Change-Id: I3f4ff8cae7d22c5d2d062e98475592425e3c98c4
Signed-off-by: Suresh Charan <suresh.charan@bell.ca>

1 files changed, 3 insertions, 5 deletions

diff --git a/main/src/main/java/org/onap/policy/pap/main/comm/PdpStatusMessageHandler.java b/main/src/main/java/org/onap/policy/pap/main/comm/PdpStatusMessageHandler.java
index 4d142114..dc4a030b 100644
--- a/main/src/main/java/org/onap/policy/pap/main/comm/PdpStatusMessageHandler.java
+++ b/main/src/main/java/org/onap/policy/pap/main/comm/PdpStatusMessageHandler.java
@@ -2,7 +2,7 @@
  * ============LICENSE_START=======================================================
  *  Copyright (C) 2019-2021,2023 Nordix Foundation.
  *  Modifications Copyright (C) 2019-2021 AT&T Intellectual Property.
- *  Modifications Copyright (C) 2021-2022 Bell Canada. All rights reserved.
+ *  Modifications Copyright (C) 2021-2023 Bell Canada. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -159,10 +159,8 @@ public class PdpStatusMessageHandler extends PdpMessageGenerator {
                 return true;
             }
 
-            if (exceptionClazz.isInstance(thrown)) {
-                if (isDuplicateKeyException(thrown.getCause(), exceptionClazz)) {
-                    return true;
-                }
+            if (exceptionClazz.isInstance(thrown) && isDuplicateKeyException(thrown.getCause(), exceptionClazz)) {
+                return true;
             }
 
             thrown = thrown.getCause();