diff options
author | jrh3 <jrh3@att.com> | 2019-06-14 10:31:40 -0400 |
---|---|---|
committer | jrh3 <jrh3@att.com> | 2019-06-14 10:36:34 -0400 |
commit | 82cc7e0ccf799e0ea5d9afd033a3cff88468b6bf (patch) | |
tree | eb10d3d9278656866b1323d7a50d650ce0e98b33 /main/src/main/java/org/onap/policy/pap/main/comm/PdpMessageGenerator.java | |
parent | a240d7a4020d0346040fe4d86682a6ab8fcd757a (diff) |
Fix sonar issues in PAP
Replace string concatenation with "{}" place-holders in logging
statements.
Refactored PdpStatusMessageHandler and PdpGroupStateChangeProvider
to extract common/duplicate code block into PdpMessageGenerator.
Refactored selectPdpGroupsForRegistration() to reduce "cyclomatic complexity";
extracted selectPdpSubGroupsForRegistration from it.
Issue-ID: POLICY-1791
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: Ia0ebc1cf41cd2fa288130b4a58614a4983f47f8b
Signed-off-by: jrh3 <jrh3@att.com>
Diffstat (limited to 'main/src/main/java/org/onap/policy/pap/main/comm/PdpMessageGenerator.java')
-rw-r--r-- | main/src/main/java/org/onap/policy/pap/main/comm/PdpMessageGenerator.java | 129 |
1 files changed, 129 insertions, 0 deletions
diff --git a/main/src/main/java/org/onap/policy/pap/main/comm/PdpMessageGenerator.java b/main/src/main/java/org/onap/policy/pap/main/comm/PdpMessageGenerator.java new file mode 100644 index 00000000..e5246eb1 --- /dev/null +++ b/main/src/main/java/org/onap/policy/pap/main/comm/PdpMessageGenerator.java @@ -0,0 +1,129 @@ +/*- + * ============LICENSE_START======================================================= + * ONAP PAP + * ================================================================================ + * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.pap.main.comm; + +import java.util.LinkedList; +import java.util.List; +import org.onap.policy.common.parameters.ParameterService; +import org.onap.policy.common.utils.services.Registry; +import org.onap.policy.models.base.PfModelException; +import org.onap.policy.models.pdp.concepts.PdpStateChange; +import org.onap.policy.models.pdp.concepts.PdpSubGroup; +import org.onap.policy.models.pdp.concepts.PdpUpdate; +import org.onap.policy.models.pdp.enums.PdpState; +import org.onap.policy.models.provider.PolicyModelsProvider; +import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicy; +import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicyIdentifier; +import org.onap.policy.pap.main.PapConstants; +import org.onap.policy.pap.main.PolicyModelsProviderFactoryWrapper; +import org.onap.policy.pap.main.parameters.PapParameterGroup; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * PDP message generator used to generate PDP-UPDATE and PDP-STATE-CHANGE messages. + */ +public class PdpMessageGenerator { + private static final Logger LOGGER = LoggerFactory.getLogger(PdpMessageGenerator.class); + + private static final String PAP_GROUP_PARAMS_NAME = "PapGroup"; + + /** + * Lock used when updating PDPs. + */ + protected final Object updateLock; + + /** + * Used to send UPDATE and STATE-CHANGE requests to the PDPs. + */ + protected final PdpModifyRequestMap requestMap; + + /** + * Factory for PAP DAO. + */ + protected final PolicyModelsProviderFactoryWrapper modelProviderWrapper; + + /** + * Heart beat interval, in milliseconds, to pass to PDPs, or {@code null}. + */ + private final Long heartBeatMs; + + + /** + * Constructs the object. + * + * @param includeHeartBeat if the heart beat interval is to be included in any + * PDP-UPDATE messages + */ + public PdpMessageGenerator(boolean includeHeartBeat) { + modelProviderWrapper = Registry.get(PapConstants.REG_PAP_DAO_FACTORY, PolicyModelsProviderFactoryWrapper.class); + updateLock = Registry.get(PapConstants.REG_PDP_MODIFY_LOCK, Object.class); + requestMap = Registry.get(PapConstants.REG_PDP_MODIFY_MAP, PdpModifyRequestMap.class); + + if (includeHeartBeat) { + PapParameterGroup params = ParameterService.get(PAP_GROUP_PARAMS_NAME); + heartBeatMs = params.getPdpParameters().getHeartBeatMs(); + + } else { + heartBeatMs = null; + } + } + + protected PdpUpdate createPdpUpdateMessage(final String pdpGroupName, final PdpSubGroup subGroup, + final String pdpInstanceId, final PolicyModelsProvider databaseProvider) throws PfModelException { + + final PdpUpdate update = new PdpUpdate(); + update.setName(pdpInstanceId); + update.setPdpGroup(pdpGroupName); + update.setPdpSubgroup(subGroup.getPdpType()); + update.setPolicies(getToscaPolicies(subGroup, databaseProvider)); + update.setPdpHeartbeatIntervalMs(heartBeatMs); + + LOGGER.debug("Created PdpUpdate message - {}", update); + return update; + } + + private List<ToscaPolicy> getToscaPolicies(final PdpSubGroup subGroup, final PolicyModelsProvider databaseProvider) + throws PfModelException { + + final List<ToscaPolicy> policies = new LinkedList<>(); + for (final ToscaPolicyIdentifier policyIdentifier : subGroup.getPolicies()) { + policies.addAll(databaseProvider.getPolicyList(policyIdentifier.getName(), policyIdentifier.getVersion())); + } + + LOGGER.debug("Created ToscaPolicy list - {}", policies); + return policies; + } + + protected PdpStateChange createPdpStateChangeMessage(final String pdpGroupName, final PdpSubGroup subGroup, + final String pdpInstanceId, final PdpState pdpState) { + + final PdpStateChange stateChange = new PdpStateChange(); + stateChange.setName(pdpInstanceId); + stateChange.setPdpGroup(pdpGroupName); + stateChange.setPdpSubgroup(subGroup.getPdpType()); + stateChange.setState(pdpState == null ? PdpState.ACTIVE : pdpState); + + LOGGER.debug("Created PdpStateChange message - {}", stateChange); + return stateChange; + } +} |