summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJim Hahn <jrh3@att.com>2020-04-09 10:05:08 -0400
committerJim Hahn <jrh3@att.com>2020-04-09 11:27:00 -0400
commit4e716dd24d0fce3149698419927feb8d7833274b (patch)
tree690fff3a5e077e1f6a0565c75cab5c1380526bc1
parent528dd61499765478af180922ed48f687b361f58e (diff)
Remaining sonar issues in pap
Addressed these remaining sonar issues: - main arg validation - TODO item regarding subgroup updates with no PDPs - after discussion, it was decided to not do this Issue-ID: POLICY-2305 Change-Id: Ib2b340d029679d6cd2b2a558318b25d38b830833 Signed-off-by: Jim Hahn <jrh3@att.com>
-rw-r--r--main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeployProvider.java2
-rw-r--r--main/src/main/java/org/onap/policy/pap/main/startstop/Main.java6
2 files changed, 5 insertions, 3 deletions
diff --git a/main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeployProvider.java b/main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeployProvider.java
index ed77a437..4c0accd3 100644
--- a/main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeployProvider.java
+++ b/main/src/main/java/org/onap/policy/pap/main/rest/PdpGroupDeployProvider.java
@@ -263,8 +263,6 @@ public class PdpGroupDeployProvider extends ProviderBase {
}
- // TODO add code to ensure that dbsub has at least one PDP instance if policies is not empty
-
Set<String> pdps = dbsub.getPdpInstances().stream().map(Pdp::getInstanceId).collect(Collectors.toSet());
for (ToscaPolicyIdentifier policyId : deployed) {
diff --git a/main/src/main/java/org/onap/policy/pap/main/startstop/Main.java b/main/src/main/java/org/onap/policy/pap/main/startstop/Main.java
index fc3ebbce..1f478d77 100644
--- a/main/src/main/java/org/onap/policy/pap/main/startstop/Main.java
+++ b/main/src/main/java/org/onap/policy/pap/main/startstop/Main.java
@@ -156,7 +156,11 @@ public class Main {
*
* @param args the arguments
*/
- public static void main(final String[] args) {
+ public static void main(final String[] args) { // NOSONAR
+ /*
+ * NOTE: arguments are validated by the constructor, thus sonar is disabled.
+ */
+
new Main(args);
}
}