summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authora.sreekumar <ajith.sreekumar@bell.ca>2020-12-04 10:22:17 +0000
committera.sreekumar <ajith.sreekumar@bell.ca>2020-12-04 10:23:47 +0000
commit2a4864b9bf9c1ee64199ea5a2e6b3b021e80b68e (patch)
tree52b1ea4849d9ef3697fc25c4af0bd531d9932a30
parent14a8a2f30a202d816b32b658969d0210e976320d (diff)
Fixing sonar issues in policy-pap
Change-Id: I0f81906098c310aa5c437a2c06b708ae27560af8 Issue-ID: POLICY-2911 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
-rw-r--r--main/src/main/java/org/onap/policy/pap/main/comm/MultiPdpStatusListener.java5
-rw-r--r--main/src/main/java/org/onap/policy/pap/main/comm/msgdata/RequestImpl.java3
-rw-r--r--main/src/main/java/org/onap/policy/pap/main/notification/PolicyCommonTracker.java3
-rw-r--r--main/src/main/java/org/onap/policy/pap/main/rest/ProviderBase.java3
4 files changed, 9 insertions, 5 deletions
diff --git a/main/src/main/java/org/onap/policy/pap/main/comm/MultiPdpStatusListener.java b/main/src/main/java/org/onap/policy/pap/main/comm/MultiPdpStatusListener.java
index f3cac7e3..65f448e2 100644
--- a/main/src/main/java/org/onap/policy/pap/main/comm/MultiPdpStatusListener.java
+++ b/main/src/main/java/org/onap/policy/pap/main/comm/MultiPdpStatusListener.java
@@ -3,6 +3,7 @@
* ONAP PAP
* ================================================================================
* Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
+ * Modifications Copyright (C) 2020 Bell Canada. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -55,7 +56,7 @@ public abstract class MultiPdpStatusListener implements TypedMessageListener<Pdp
*
* @param id ID for which to wait
*/
- public MultiPdpStatusListener(String id) {
+ protected MultiPdpStatusListener(String id) {
unseenIds.add(id);
}
@@ -64,7 +65,7 @@ public abstract class MultiPdpStatusListener implements TypedMessageListener<Pdp
*
* @param ids IDs for which to wait
*/
- public MultiPdpStatusListener(Collection<String> ids) {
+ protected MultiPdpStatusListener(Collection<String> ids) {
if (ids.isEmpty()) {
allSeen.countDown();
diff --git a/main/src/main/java/org/onap/policy/pap/main/comm/msgdata/RequestImpl.java b/main/src/main/java/org/onap/policy/pap/main/comm/msgdata/RequestImpl.java
index d1ac3d15..7e0397a5 100644
--- a/main/src/main/java/org/onap/policy/pap/main/comm/msgdata/RequestImpl.java
+++ b/main/src/main/java/org/onap/policy/pap/main/comm/msgdata/RequestImpl.java
@@ -3,6 +3,7 @@
* ONAP PAP
* ================================================================================
* Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved.
+ * Modifications Copyright (C) 2020 Bell Canada. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -106,7 +107,7 @@ public abstract class RequestImpl implements Request {
*
* @throws IllegalArgumentException if a required parameter is not set
*/
- public RequestImpl(@NonNull RequestParams params, @NonNull String name, @NonNull PdpMessage message) {
+ protected RequestImpl(@NonNull RequestParams params, @NonNull String name, @NonNull PdpMessage message) {
params.validate();
this.name = name;
diff --git a/main/src/main/java/org/onap/policy/pap/main/notification/PolicyCommonTracker.java b/main/src/main/java/org/onap/policy/pap/main/notification/PolicyCommonTracker.java
index 5f702daf..bd14ffb9 100644
--- a/main/src/main/java/org/onap/policy/pap/main/notification/PolicyCommonTracker.java
+++ b/main/src/main/java/org/onap/policy/pap/main/notification/PolicyCommonTracker.java
@@ -3,6 +3,7 @@
* ONAP PAP
* ================================================================================
* Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved.
+ * Modifications Copyright (C) 2020 Bell Canada. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -53,7 +54,7 @@ public abstract class PolicyCommonTracker {
/**
* Constructs the object.
*/
- public PolicyCommonTracker() {
+ protected PolicyCommonTracker() {
super();
}
diff --git a/main/src/main/java/org/onap/policy/pap/main/rest/ProviderBase.java b/main/src/main/java/org/onap/policy/pap/main/rest/ProviderBase.java
index d567b6d3..0b8da90b 100644
--- a/main/src/main/java/org/onap/policy/pap/main/rest/ProviderBase.java
+++ b/main/src/main/java/org/onap/policy/pap/main/rest/ProviderBase.java
@@ -4,6 +4,7 @@
* ================================================================================
* Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
* Modifications Copyright (C) 2020 Nordix Foundation.
+ * Modifications Copyright (C) 2020 Bell Canada. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -76,7 +77,7 @@ public abstract class ProviderBase {
/**
* Constructs the object.
*/
- public ProviderBase() {
+ protected ProviderBase() {
this.updateLock = Registry.get(PapConstants.REG_PDP_MODIFY_LOCK, Object.class);
this.requestMap = Registry.get(PapConstants.REG_PDP_MODIFY_MAP, PdpModifyRequestMap.class);
this.daoFactory = Registry.get(PapConstants.REG_PAP_DAO_FACTORY, PolicyModelsProviderFactoryWrapper.class);