summaryrefslogtreecommitdiffstats
path: root/models-sim/policy-models-sim-pdp/src
AgeCommit message (Collapse)AuthorFilesLines
2021-06-21Use lombok for errors pap, pdp, sim-dmaap, sim-pdpJim Hahn3-27/+14
Issue-ID: POLICY-3396 Change-Id: Ib2c9bc5dc199e15ae9ca077031c0f2cfbc5b6a81 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-27Remove policies field from PdpUpdate messagewaynedunican3-10/+21
Issue-ID: POLICY-3323 Change-Id: I14dafe4a20f95e2ebe4279e5b6ae141e2ee4fc48 Signed-off-by: waynedunican <wayne.dunican@est.tech> Signed-off-by: WayneDunican <wayne.dunican@est.tech>
2021-05-10Fix sonars in policy-models impls & simulatorsJim Hahn7-30/+34
Fixed: - use "var" Issue-ID: POLICY-3094 Change-Id: I65da54cae5a58966f21f981c6cea1259bfdf4239 Signed-off-by: Jim Hahn <jrh3@att.com> simulators Change-Id: I1144568485e62e0c72194caaf21ebf1ba88a6fef Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-29Remove GroupValidationResultJim Hahn5-24/+28
Removed GroupValidationResult, replacing it with BeanValidationResult. Modified the ParameterGroup subclasses to use BeanValidator, adding annotations where needed to trigger the validations that had been automatically performed by GroupValidationResult. Issue-ID: POLICY-2059 Change-Id: I245e4a647fcbb718faa63a7543f9f81c85da958c Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-19Refactor CommandLineArguments classesadheli.tavares3-253/+36
All CMD Args simulator classes to extend from CMD class on Common. Fix all unit tests accordingly. Issue-ID: POLICY-3129 Change-Id: If69e432679772df15b06ce7e316c7c876b69773d Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-03-19Delete keystores from modelsJim Hahn1-0/+0
The Keystores are no longer needed in the tarballs, as they are supplied externally by the CSITs and Helm charts. Deleted those files. Also modified the junits to use utils-test to generate keystores at runtime, thus deleted the junit keystore file, too. Issue-ID: POLICY-3143 Change-Id: Idd24b735a908476765d40bdcb5c741257edc7bb6 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-16Update policy-keystore with newer certificatesjhh1-0/+0
Issue-ID: POLICY-3139 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Id4a882b40ef142d0414518c5d5ab90367f0bbb73 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2021-01-06Changed identifiers to concept identifiersliamfallon1-5/+5
The policy models tosca classes ToscaPolicyIdentifier and ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA concept, not just TOSCA policies so they are renamed to ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion respectively. The class ToscaPolicyTypeIdentifier is redundant and is replaced by ToscaConceptIdentifier. Issue-ID: POLICY-2900 Change-Id: Id0a37c42ea4e74f07b47e1694c4f8291c35879c9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-24update default keystoresjhh1-0/+0
Issue-ID: POLICY-2827 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I7622d382aec1bd4ba62405355854d1bad510a892
2020-09-04Revert "point to 2.1.0 policy-alpine base - model-sim"Jim Hahn2-2/+6
This reverts commit e46f74d64fe69d33d5038704b64993aa9cab59fc. Reason for revert: some CSITs broken because the can't find the image Issue-ID: POLICY-2789 Change-Id: Id6355c21789281a3f25467b3bd6e2e48d22533f5 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-09-04point to 2.1.0 policy-alpine base - model-simTaka Cho2-6/+2
In G-rel, using 2.1.0 base. Issue-ID: POLICY-2789 Change-Id: I165debaf20267c0b1c3141bff805a29595f1eccf Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-21Fix some sonars in policy-modelsJim Hahn1-3/+4
Fixed the following sonar issues in some of the project directories: - use assertNull, assertEquals, etc. - swap assertEquals arguments - extract a constant - don't invoke toString() in logger calls - TODOs - generic types Issue-ID: POLICY-2714 Change-Id: Id8803f9bf617ea9fc173a67b8606600709b55bdc Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-18Changes for Checkstyle 8.32liamfallon6-7/+1
Issue-ID: POLICY-2188 Change-Id: I6db16763c1d2d80ff934302081a8dfc16afa7d9a Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-06-12Merge "Change related to log4j removal needed in models"Ram Krishna Verma1-3/+2
2020-06-12Remove logback.xml files bundled as part of jara.sreekumar3-56/+2
Change-Id: I4d603ea67eca5d8d75b9df004e1ff4a6be2b2a9e Issue-ID: POLICY-2627 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-06-11Change related to log4j removal needed in modelsuj426b1-3/+2
Change-Id: I449aef2c1f83edecc88c379525b8da6c80e9d35f Issue-ID: POLICY-2623 Signed-off-by: uj426b <uj426b@att.com>
2020-04-17Updating pdp-simulator as per recent changes to send PdpGroup in statusa.sreekumar8-9/+15
Change-Id: Ic2ad6bd7f65633eef73d6432f244be77d7c760f9 Issue-ID: POLICY-2499 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-04-16Fixing minor bug in policy-models/pdp-simulator scripta.sreekumar1-2/+2
Change-Id: I3b7bdfdd2fdd73b38cf7996457f6bea735752d46 Issue-ID: POLICY-2499 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-04-09Disable sonar main args for modelsJim Hahn1-0/+4
Issue-ID: POLICY-2305 Change-Id: Ie8c45fb767ec9b2f9b1b541532fede52306c36b4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-07Address sonar issues in modelsJim Hahn3-4/+14
Addressed the following sonar issues: - use RE2 instead of java.util Pattern for "+" and "*" - don't use deprecated methods - for Date(long), sonar appeared not to parse the argument's type correctly. Modified the code slightly to make sonar happy - duplicate blocks of code - either log or throw - missing assert in junit - for SDNR & VFC, eliminated threads, as they are unnecessary - duplicate code block in different branches - useless assignments - redeclaring abstract methods - cyclomatic complexity - used lombok in some cases (e.g., EqualsAndHashCode) - assert argument order - actually deleted ControlLoopTargetType, because it is not needed and sonar complains regardless of which order is used - add private constructor to utility classes - use StandardCharsets instead of literals Also: - added logback-test.xml to SO to eliminate the voluminous output from the junit test Issue-ID: POLICY-2305 Change-Id: I586c331781bedbd54a115a71847d04d293689445 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-27Cleanup sonar bugs and security hotspotPamela Dragosh1-3/+3
Just some trivial sonar bugs for missing argument and a couple sonar overrides to clear security hotspots. Issue-ID: POLICY-2165 Change-Id: I392e5fee458465c66313a16a8912e23a3a119848 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-17renew policy certs till 03/17/2021jhh1-0/+0
Issue-ID: POLICY-2402 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I42919180d73058bc78cc70a29a6d5d45823aa9eb
2020-02-18Add safe entity delete, fix multiple entity getliamfallon1-20/+0
This review implements checks on whether entities are being used or referenced propr to allowing deletes. The review also fixes bugs on multiple entity get returning 4040 not found Issue-ID: POLICY-1402 Change-Id: I9cebb9a873098740e9ff4be6284d6307e19838bd Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-01-17Update Dockerfiles for java11 in policy-modelsJim Hahn3-21/+4
Also modified docker build scripts so they work with SNAPSHOT or release versions of the tarballs. Issue-ID: POLICY-1586 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: Ib5b8c0b83d7736180ab213b0b67d457eab7ee48e
2020-01-10Remove supportedPolicyTypes from PdpStatusramverma1-3/+2
Removing supportedPolicyTypes from PdpStatus in policy/models as it is no longer expected from the Pdps to send it as part of the heartbeat or initial registration message. Instead the PdpGroupName is expected from the Pdps in the initial registration message. Issue-ID: POLICY-2256 Change-Id: I14b76a737027e146d69d89c2fe2c3f098a89e196 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-10-14Clean up minor things in policy-modelsliamfallon1-6/+12
Cleam up of some minor eclipse, checkstyle, and Sonar issues in policy-models Issue-ID: POLICY-2165 Change-Id: Id5682fd60e1a6cebbf716d9c258453aa53ca2482 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-08-22update keystorejhh1-0/+0
Issue-ID: POLICY-1988 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I565d8ca294750b748ba2709eedab032cd5eb0936 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-07-31Use new addTopic() method in modelsJim Hahn5-28/+9
Replaced ParameterUtils with the use of the new addTopic(TopicParameterGroup) method. Used separate addTopicXxx() methods per review comment. Change-Id: I755b75f986a5c42f01bcad5a22472a46766d192d Issue-ID: POLICY-1953 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-08Fix models due to sonar changes in commonJim Hahn2-7/+6
Fixed breakages due to changes made in policy/common to satisfy sonar. Change-Id: I7de701e743664afb5963a454c59478d1a1c83e87 Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-05Remove topic.properties and incorporate into overall config file for ↵a.sreekumar18-118/+149
pdp-simulator Change-Id: Iac882c7ffb28a80ef474d15a90307cd68b78d417 Issue-ID: POLICY-1744 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2019-06-18Change getCanonicalName to getName in modelsJim Hahn1-1/+2
Per javadocs, getName() should generally be used instead of Class.getCanonicalName(). This change only applies to classes; it does not apply to File objects. Note: this impacts the output from PfValidationMessage, as it will now list the names of embedded classes with a "$" separator instead of a ".". Change-Id: I2cd64bc0281dd324bf80eac57335a7299a516447 Issue-ID: POLICY-1646 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-06-17Fix simple sonar issues in models: errors to sim-pdpJim Hahn11-96/+64
models-errors models-pdp models-provider models-sim-pdp Also had to work around this checkstyle issue: src/test/java/org/onap/policy/models/sim/pdp/comm/ TestPdpStateChangeListener.java:[77,32] (javadoc) JavadocMethod: Unable to get class information for @throws tag 'PdpSimulatorException'. The error appears to be bogus, as PdpSimulatorException is on the "throws" line thus indicating that the class IS accessible to the above java file. Change-Id: Iaca58457a32b00121000fc0bab12a8be4cb19bac Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-06-03Fix dmaap-sim docker chmodJim Hahn1-1/+2
The chmod in the docker builder for my local VM does not appear to support the "+x" style options. Modified the dmaap-simulator docker file to use "755" instead. Also fixed the PDP simulator. Change-Id: I3dd906d2ef63303f8c8872ce38a5711d61e35c3e Issue-ID: POLICY-1829 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-05-14Adding pdp simulator for testing purposes2.0.12.0.0a.sreekumar46-0/+3225
Change-Id: I809e229bf363f3b18942b20521b05e2dc06643b4 Issue-ID: POLICY-1768 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>