aboutsummaryrefslogtreecommitdiffstats
path: root/models-pap/src
AgeCommit message (Collapse)AuthorFilesLines
2022-02-16Fix issue with GeneratedValue in PfGeneratedIdKeya.sreekumar3-400/+63
PfGeneratedIdKey class (which is used as a composite key in JpaPolicyAudit and JpaPdpStatistics) uses GeneratedValue in a wrong way and not according to the specification. This review fixes it. PfGeneratedIdKey class is removed, and the generatedId is directly specified in the JpaPolicyAudit and JpaPdpStatistics classes. Note: These classes are only used by PAP, so the related methods for db interaction is removed as PAP directly talks to DB using spring repository layer. Also the only end result this change brings is that the 'generatedId' alone will be used as the primary key instead of 'generatedId, name and version' together. Corresponding changes in DB Migrator: https://gerrit.onap.org/r/c/policy/docker/+/127139 PAP: https://gerrit.onap.org/r/c/policy/pap/+/127130 Change-Id: Ib4ea8b60ffe5c2480746569c0354bf474a6b7006 Issue-ID: POLICY-3897 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-07-12Add default min records for policy auditRam Krishna Verma2-3/+6
Adding default min records as 10 for policy audit provider. This is inline with our discussions and design doumented here https://wiki.onap.org/display/DW/PAP+REST+API+changes+for+Istanbul+release Issue-ID: POLICY-3340 Change-Id: I5bab5f186f2591b1a2f2c42e9851ad88f73c8dfb Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-07-12Handle numRecords default setting when built as 0.adheli.tavares2-119/+23
Check the numRecord to be set as DEFAULT_MAX_RECORDS when not added to the auditFilter (builder set it to 0). Issue-ID: POLICY-3340 Change-Id: I25ad83bbea71ddd82064aec3069ffa4cbce5aac1 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-06-21Use lombok for errors pap, pdp, sim-dmaap, sim-pdpJim Hahn1-12/+3
Issue-ID: POLICY-3396 Change-Id: Ib2c9bc5dc199e15ae9ca077031c0f2cfbc5b6a81 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-15Fix sonar in policy/modelsRam Krishna Verma2-3/+5
use "var" for local variables Issue-ID: POLICY-3077 Change-Id: Ia1ea62e03c016d336c9b11b07b0ea941ba905497 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-06-14Fix sonars in policy-modelsJim Hahn2-19/+83
Fixed: - too many parameters in method call Fixed it by introducing PfFilterParameters. However, classes having the Builder annotation are not easily subclassed, so introduced an interface, too. Issue-ID: POLICY-3094 Change-Id: Ida99522a542b1296b367c55b7e8f8e83783c2e4f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-03Exposing the Audit provider through Models provider.adheli.tavares2-2/+32
Change-Id: I4a3a28b6dbbfbad533a69cf46c545ece7e0b147e Issue-ID: POLICY-2899 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-05-28Handling Policy deploy/undeploy audit modelsadheli.tavares6-0/+791
Added a new Entity to store information when a Pdp Policy is deployed or undeployed and its create/retrieve methods. Change-Id: I35b3608c878bbfbbee0a99a124d100a48fe08131 Issue-ID: POLICY-2899 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-02-17PAP Deployment API changes - change url to uria.sreekumar2-10/+17
Change-Id: I6fa4b001a0c4573a34e1cefe0d32ca969ca5096e Issue-ID: POLICY-2526 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-02-15Updating PAP deployment API to reflect actual statusa.sreekumar2-0/+70
Change-Id: I1fb0232d2f5fe37e95e87babb233a824212439ff Issue-ID: POLICY-2526 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-01-06Changed identifiers to concept identifiersliamfallon9-26/+306
The policy models tosca classes ToscaPolicyIdentifier and ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA concept, not just TOSCA policies so they are renamed to ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion respectively. The class ToscaPolicyTypeIdentifier is redundant and is replaced by ToscaConceptIdentifier. Issue-ID: POLICY-2900 Change-Id: Id0a37c42ea4e74f07b47e1694c4f8291c35879c9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-06-18Changes for Checkstyle 8.32liamfallon1-1/+0
Issue-ID: POLICY-2188 Change-Id: I6db16763c1d2d80ff934302081a8dfc16afa7d9a Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-12-04Adding Response model class for PdpGroup Create/Update operationa.sreekumar1-0/+35
Change-Id: Ifa3b4c1e51a1446f47adf8d263989440bddfa8b9 Issue-ID: POLICY-2273 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2019-10-31Change field names in policy notifications to match wikiJim Hahn3-9/+36
Field names looked like "policyType.name". Changed them to look like "policy-type", instead, to match the wiki for the notifications to be sent to DCAE. Change-Id: Ib3cef1712fd12a44db8acdcff2245d800b21137a Issue-ID: POLICY-2190 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-10-24Changed the serialized name of policy notificationsJim Hahn1-1/+1
Changed the serialized name of the policy identifier from "policy" to "policy-id". Change-Id: I7188b65428728b65fef38c70e9fae99202ab0eea Issue-ID: POLICY-1841 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-10-17Add PolicyNotification.isEmpty() methodJim Hahn2-0/+22
Change-Id: I5cf5f21b968975018bd1f18daa1653289b837d2e Issue-ID: POLICY-1841 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-10-15Add PAP Policy Notification classesJim Hahn4-0/+229
Added classes that PAP will use to publish to DMaaP to indicate policy status changes (i.e., added/removed from PDPs). Modified serialized name of the policy identified to match other uses (e.g., PAP REST API calls). Added policy type, per review comments. Change-Id: I66131fa9ae0b63081f239e7f402b7fea65c434a5 Issue-ID: POLICY-1841 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-06-27Use ToStringTester from utils-testramverma1-1/+1
Changing ToStringTester from utils to utils-test Bump up common to 1.5.1-SNAPSHOT Change-Id: I7427673c73bd1cc52d5f24a0542e89eb33a39ae8 Issue-ID: POLICY-1746 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-04-05Add undeploy response to models-papJim Hahn4-3/+38
Also modified toString() methods on other response classes to invoke the super class' toString() so the error message is printed. Change-Id: I7147da8acd521ed30d40aa6cbf2d8fd43715179b Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-04Updates to models from scrum on 4/4Jim Hahn1-1/+1
Moved ToscaPolicyIdentXxx classes from models-pdp to models-tosca, and added methods to retrieve them from a ToscaPolicy. Removed version and instance fields from PdpStatus. Chose to leave "description" field in the PAP/PDP messages. The PDPs can ignore them or leave them null. In a PdpUpdate message, the description will be the description associated with the PdpGroup. In a PdpStatus message, the PDP could choose to provide a description of the PDP, itself (or the type of PDP). Added comments to that effect. Moved name, group, and subgroup fields into PdpMessage. Fixed typos in comments. Updated licenses. Change "long" to "Long" in PdpUpdate. Use lombok @ToString instead of override. Fixed merge conflict. Change-Id: Icd928f9a7630b838ad4b0b5556e899dc21b7872b Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-03Updating PdpStatistics modelramverma1-44/+0
Change-Id: Ic3ae28997dd1db14c16bdfd24a5d936393fa8da4 Issue-ID: POLICY-1443 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-04-03Clean up models-pap based on updates to models-pdpJim Hahn10-376/+2
Change-Id: I5e55dd669200e4fc28f58379bbaa61e5d3331610 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-29Merge "Update comment in models-pap."Jorge Hernandez1-1/+1
2019-03-29Update comment in models-pap.Jim Hahn1-1/+1
Change-Id: If51abf12cec951d82738ce7579b583fa97a1a26b Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-29Merge "Add @NonNull to PolicyIdent"Pamela Dragosh1-0/+2
2019-03-28Add @NonNull to PolicyIdentJim Hahn1-0/+2
Change-Id: Ib10c92addfe4803dc28f82a7f844920134336b8a Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-27Add support for legacy guard policiesliamfallon1-86/+0
Support for legacy guard policies added. Support for translation of all legacy policies to TOSCA format now complete. Fix merge problems with dummy provider implementation. Issue-ID: POLICY-1095 Change-Id: I3dd1775b78d39078a884e1834502b832ff40be18 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-03-25Add PolicyIdentOptVersionJim Hahn11-279/+100
Added additional PolicyIdentXxx classes. Added PdpDeployPolicies, which makes use of it, thus eliminating the need for PdpPolicies, which will be deleted once the PAP has been modified to use the new code. Added Validated class to facilitate field validation. Added utility methods to Validated class. Use new validator methods in PolicyIdentXxx classes. Use addError() method in validator class. Use parameter types instead of "?". Use static Validator instead of local. Get "result" from each call to a validateXxx() method. Derived PolicyIdentOptVersion from PfConceptKey. Moved PolicyIdent classes to models-pdp. Added PolicyIdent classes to models-pap. Also removed copy constructors from classes in models-pap, as those are plain POJOs that will not be copied. Copy constructors will be added to new classes that will be added to models-pdp in a separate review. Forgot to include the new Ident classes in models-pap. Change-Id: I923132c464c7802ee3e9225685cde44f36c64620 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-23Use enums from models-pdp in models-papJim Hahn4-6/+6
Modified models-pap to use enums from models-pdp instead of from pdp-common. Change-Id: I3bc296358c672dff9c218c734583a135e5503e4c Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-22Merge "Add models-pdp to models repo"Pamela Dragosh2-6/+6
2019-03-22Add models-pdp to models repoJim Hahn2-6/+6
Also changed supportedPolicyTypes to PfConceptKey. Updated licenses. Removed trailing whitespace from pom. Provide default request id. Rebased to fix merge conflict. Added SupportedPolicyType class. Renamed SupportedPolicyType to PolicyTypeIdent, and moved it to models-base. Also updated models-pap to use it. Deleted models-pdp Policy and replaced it with ToscaPolicy. Updated test method name. Change-Id: Id65f769c2f308c6b56e79978bd50b84f2e0b3d02 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-22Implement Database providerliamfallon1-0/+86
This review brings in the structure of the database provider with complete unit test coverage. The provider delegates the details of each database interactino to the appropriate package in the model. Resolved merge conflict. Issue-ID: POLICY-1195 Change-Id: I9d01146415531d18bc9648dcf232b425bc09578d Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-03-21Add copy constructors for models-papJim Hahn8-11/+342
Also added a method to PfUtils to simplify cloning lists. Change-Id: Iae667be02cced57b0b9578e0a96c5cda38111b97 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-20Adding classes to models-papramverma6-5/+80
Change-Id: I59acfeeef5e2b93d7d16dbf5c26811a037e255c1 Issue-ID: POLICY-1541 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-03-15Merge "Adding PdpStatistics model to mdoels-pap"Jorge Hernandez1-0/+44
2019-03-15Adding PdpStatistics model to mdoels-papramverma1-0/+44
Change-Id: Ie229b76fbd848811fe919d28eead19060a487157 Issue-ID: POLICY-1541 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-03-15Add list of policy groups to API modelsJim Hahn1-0/+37
The PDP Group Deploy REST API should take a list of PdpGroup, not a single PdpGroup. Change-Id: I0d626ce16793f5bcb3d34b697116f8545861d9f6 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-14Add classes for PDP "simple" REST APIsJim Hahn4-10/+80
Change-Id: I81a624a9cfb93df488bbd447f3ee24d1880048d6 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-13Move PDP Group classes to concepts subdirectoryJim Hahn2-2/+2
Had already done this, but apparently it didn't make it into a review. Change-Id: If4b8083ec0ea6286e6531b6f229405473a8d8430 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-13Added PDP Group model classesjh73582-0/+78
Change-Id: I16298228f9e390362d4783750274703a4db57811 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-12Adding models-pap module to policy/modelsramverma4-0/+188
1) Adding models-pap module to policy/models for storing models required by PAP REST API's. 2) Adding test cases. Change-Id: I4e8c38f1ebe96e7a50a188f19f4f4a5bed835f99 Issue-ID: POLICY-1541 Signed-off-by: ramverma <ram.krishna.verma@est.tech>