Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: POLICY-4669
Change-Id: I0157ae0ea7151658308c7e6d429098f16824c190
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
Removing last annotations in order to remove dependencies in parent
Issue-ID: POLICY-3465
Change-Id: Id7a070120d452e33af805b08b37dd1eba1374615
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
Issue-ID: POLICY-4533
Change-Id: I77a6c44c96013963e141265758629cae83e49876
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The latest verison of H2 does not allow colums called "user" or indexes
using an underscore in their name.
Issue-ID: POLICY-4488
Change-Id: I1db62768b0c0f85543c2f7d3681243f8386825e7
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
PfGeneratedIdKey class (which is used as a composite key
in JpaPolicyAudit and JpaPdpStatistics) uses GeneratedValue
in a wrong way and not according to the specification.
This review fixes it. PfGeneratedIdKey class is removed, and the
generatedId is directly specified in the JpaPolicyAudit and
JpaPdpStatistics classes.
Note: These classes are only used by PAP, so the related methods for db
interaction is removed as PAP directly talks to DB using spring
repository layer. Also the only end result this change brings is that the
'generatedId' alone will be used as the primary key instead of
'generatedId, name and version' together.
Corresponding changes in
DB Migrator: https://gerrit.onap.org/r/c/policy/docker/+/127139
PAP: https://gerrit.onap.org/r/c/policy/pap/+/127130
Change-Id: Ib4ea8b60ffe5c2480746569c0354bf474a6b7006
Issue-ID: POLICY-3897
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Adding default min records as 10 for policy audit provider.
This is inline with our discussions and design doumented here
https://wiki.onap.org/display/DW/PAP+REST+API+changes+for+Istanbul+release
Issue-ID: POLICY-3340
Change-Id: I5bab5f186f2591b1a2f2c42e9851ad88f73c8dfb
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Check the numRecord to be set as DEFAULT_MAX_RECORDS when not added to
the auditFilter (builder set it to 0).
Issue-ID: POLICY-3340
Change-Id: I25ad83bbea71ddd82064aec3069ffa4cbce5aac1
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
Issue-ID: POLICY-3396
Change-Id: Ib2c9bc5dc199e15ae9ca077031c0f2cfbc5b6a81
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
use "var" for local variables
Issue-ID: POLICY-3077
Change-Id: Ia1ea62e03c016d336c9b11b07b0ea941ba905497
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Fixed:
- too many parameters in method call
Fixed it by introducing PfFilterParameters. However, classes having the
Builder annotation are not easily subclassed, so introduced an
interface, too.
Issue-ID: POLICY-3094
Change-Id: Ida99522a542b1296b367c55b7e8f8e83783c2e4f
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I4a3a28b6dbbfbad533a69cf46c545ece7e0b147e
Issue-ID: POLICY-2899
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
Added a new Entity to store information when a Pdp Policy is deployed or
undeployed and its create/retrieve methods.
Change-Id: I35b3608c878bbfbbee0a99a124d100a48fe08131
Issue-ID: POLICY-2899
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
Change-Id: I6fa4b001a0c4573a34e1cefe0d32ca969ca5096e
Issue-ID: POLICY-2526
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Change-Id: I1fb0232d2f5fe37e95e87babb233a824212439ff
Issue-ID: POLICY-2526
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: Id0a37c42ea4e74f07b47e1694c4f8291c35879c9
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Change-Id: Ifa3b4c1e51a1446f47adf8d263989440bddfa8b9
Issue-ID: POLICY-2273
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
|
|
Field names looked like "policyType.name". Changed them to look like
"policy-type", instead, to match the wiki for the notifications to be
sent to DCAE.
Change-Id: Ib3cef1712fd12a44db8acdcff2245d800b21137a
Issue-ID: POLICY-2190
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Changed the serialized name of the policy identifier from "policy"
to "policy-id".
Change-Id: I7188b65428728b65fef38c70e9fae99202ab0eea
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I5cf5f21b968975018bd1f18daa1653289b837d2e
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added classes that PAP will use to publish to DMaaP to indicate policy
status changes (i.e., added/removed from PDPs).
Modified serialized name of the policy identified to match other uses
(e.g., PAP REST API calls).
Added policy type, per review comments.
Change-Id: I66131fa9ae0b63081f239e7f402b7fea65c434a5
Issue-ID: POLICY-1841
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Also modified toString() methods on other response classes to
invoke the super class' toString() so the error message is printed.
Change-Id: I7147da8acd521ed30d40aa6cbf2d8fd43715179b
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Moved ToscaPolicyIdentXxx classes from models-pdp to models-tosca,
and added methods to retrieve them from a ToscaPolicy.
Removed version and instance fields from PdpStatus.
Chose to leave "description" field in the PAP/PDP messages. The
PDPs can ignore them or leave them null. In a PdpUpdate message,
the description will be the description associated with the PdpGroup.
In a PdpStatus message, the PDP could choose to provide a description
of the PDP, itself (or the type of PDP).
Added comments to that effect.
Moved name, group, and subgroup fields into PdpMessage.
Fixed typos in comments.
Updated licenses.
Change "long" to "Long" in PdpUpdate.
Use lombok @ToString instead of override.
Fixed merge conflict.
Change-Id: Icd928f9a7630b838ad4b0b5556e899dc21b7872b
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: Ic3ae28997dd1db14c16bdfd24a5d936393fa8da4
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
Change-Id: I5e55dd669200e4fc28f58379bbaa61e5d3331610
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change-Id: If51abf12cec951d82738ce7579b583fa97a1a26b
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change-Id: Ib10c92addfe4803dc28f82a7f844920134336b8a
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Support for legacy guard policies added.
Support for translation of all legacy policies to
TOSCA format now complete.
Fix merge problems with dummy provider implementation.
Issue-ID: POLICY-1095
Change-Id: I3dd1775b78d39078a884e1834502b832ff40be18
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Added additional PolicyIdentXxx classes. Added PdpDeployPolicies, which
makes use of it, thus eliminating the need for PdpPolicies, which will be
deleted once the PAP has been modified to use the new code.
Added Validated class to facilitate field validation.
Added utility methods to Validated class.
Use new validator methods in PolicyIdentXxx classes.
Use addError() method in validator class.
Use parameter types instead of "?".
Use static Validator instead of local.
Get "result" from each call to a validateXxx() method.
Derived PolicyIdentOptVersion from PfConceptKey.
Moved PolicyIdent classes to models-pdp.
Added PolicyIdent classes to models-pap.
Also removed copy constructors from classes in models-pap, as those
are plain POJOs that will not be copied. Copy constructors will be
added to new classes that will be added to models-pdp in a separate
review.
Forgot to include the new Ident classes in models-pap.
Change-Id: I923132c464c7802ee3e9225685cde44f36c64620
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Modified models-pap to use enums from models-pdp instead of
from pdp-common.
Change-Id: I3bc296358c672dff9c218c734583a135e5503e4c
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Also changed supportedPolicyTypes to PfConceptKey.
Updated licenses.
Removed trailing whitespace from pom.
Provide default request id.
Rebased to fix merge conflict.
Added SupportedPolicyType class.
Renamed SupportedPolicyType to PolicyTypeIdent, and moved it to
models-base. Also updated models-pap to use it.
Deleted models-pdp Policy and replaced it with ToscaPolicy.
Updated test method name.
Change-Id: Id65f769c2f308c6b56e79978bd50b84f2e0b3d02
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This review brings in the structure of the database provider
with complete unit test coverage. The provider delegates
the details of each database interactino to the appropriate
package in the model.
Resolved merge conflict.
Issue-ID: POLICY-1195
Change-Id: I9d01146415531d18bc9648dcf232b425bc09578d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Also added a method to PfUtils to simplify cloning lists.
Change-Id: Iae667be02cced57b0b9578e0a96c5cda38111b97
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I59acfeeef5e2b93d7d16dbf5c26811a037e255c1
Issue-ID: POLICY-1541
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
|
|
Change-Id: Ie229b76fbd848811fe919d28eead19060a487157
Issue-ID: POLICY-1541
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|
|
The PDP Group Deploy REST API should take a list of PdpGroup, not a
single PdpGroup.
Change-Id: I0d626ce16793f5bcb3d34b697116f8545861d9f6
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I81a624a9cfb93df488bbd447f3ee24d1880048d6
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Had already done this, but apparently it didn't make it into a review.
Change-Id: If4b8083ec0ea6286e6531b6f229405473a8d8430
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Change-Id: I16298228f9e390362d4783750274703a4db57811
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
1) Adding models-pap module to policy/models for storing models required
by PAP REST API's.
2) Adding test cases.
Change-Id: I4e8c38f1ebe96e7a50a188f19f4f4a5bed835f99
Issue-ID: POLICY-1541
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
|