Age | Commit message (Collapse) | Author | Files | Lines |
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4854
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I08327729a19bd25c1d1e2d250f0fda7bf8464b0b
|
|
Issue-ID: POLICY-4669
Change-Id: I0157ae0ea7151658308c7e6d429098f16824c190
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4662
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I1a25ce15a06c13e57e37f1a36bb390f145e1a21a
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4648
Signed-off-by: rameshiyer27 <ramesh.murugan.iyer@est.tech>
Change-Id: Icb311d1eb36c3263e3e9fe996f49771124e68289
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4570
Signed-off-by: saul.gill <saul.gill@est.tech>
Change-Id: Ie25a8dc3903b0f3536defa87570b5cb65120e8b7
|
|
- Upgrade Hibernate
- Upgrade Mockito
- Upgrade Mockserver
- Remove Powermock (no longer supported) and replace with spring-test ReflectionTestUtils
- Upgrade Spring Framework
- Add spring-security to allow authentication on unit tests using MockMVC
Minor clean-up
- Replace deprecated authorization configuraiton on spring boot applications with SecurityFilterChain bean
- Change @LocalPort include on tests to use test include rather than runtime include
- Remove unused imports
- Remove unused constants and variables
- Add deprecation annotations where required
Issue-ID: POLICY-4482
Change-Id: Ie8d6ee1e8bcdad282bcef3cad409c5c109e907f1
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4484
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I89001c25b23e41b2d53adaa7b405f6cf5d124cb1
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4408
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ie62a24c34694977b9bbbab9554bce5b54648afb7
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4408
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Icc6e8bf7de2a207946fbba5eb3bdbabd0a347c49
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4343
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I0192824c0bf84e444690020aa33b69467a162052
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4073
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I0101973870c989f148e76c52c81fda410451d441
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I5851243a29a820aeab21525f3396752340d41a49
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I9017a7f0c84d9981f49baab59744e8f273aa91df
|
|
policy/models updated to its latest own and reference snapshots
*** This commit is generated by a PF release script ***
Issue-ID: POLICY-3982
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ia409ca1501edff6e1014d06a7fdee805befc5e17
|
|
Typecasting Map to NavigableMap leads to ClassCastException.
The usages of the get methods in delete policy, policyType
endpoints in policy/api (using spring data jpa) cause the
unchecked class-cast exception. Fix is to instead copy the
Map entries into a newly created TreeMap instance.
Issue-ID: POLICY-3924
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I60625980d6f2692ffa7dd3bd9f53d10b43c13f4a
|
|
PfGeneratedIdKey class (which is used as a composite key
in JpaPolicyAudit and JpaPdpStatistics) uses GeneratedValue
in a wrong way and not according to the specification.
This review fixes it. PfGeneratedIdKey class is removed, and the
generatedId is directly specified in the JpaPolicyAudit and
JpaPdpStatistics classes.
Note: These classes are only used by PAP, so the related methods for db
interaction is removed as PAP directly talks to DB using spring
repository layer. Also the only end result this change brings is that the
'generatedId' alone will be used as the primary key instead of
'generatedId, name and version' together.
Corresponding changes in
DB Migrator: https://gerrit.onap.org/r/c/policy/docker/+/127139
PAP: https://gerrit.onap.org/r/c/policy/pap/+/127130
Change-Id: Ib4ea8b60ffe5c2480746569c0354bf474a6b7006
Issue-ID: POLICY-3897
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
Issues identified in the entity classes are fixed in this
review. Some fixes doesn't affect the table structure at all.
Tables actually affected by some of these fixes are not really used today, and doesn't
contain any data. A separate review is raised for the db-migrator
changes.
Change-Id: I0efdf2c5f17e12225f1b443b5fe8e27c578229f7
Issue-ID: POLICY-3871
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
|
|
*** This commit is generated by a PF release script ***
This commit updates the snapshot of the repo to the next patch version.
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I7cdc8887455227b8315598add584593188332729
|
|
Issue-ID: POLICY-3696
Change-Id: I66ec28e3a51a8f388b56ccbf211f71698cf5e8aa
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-3696
Change-Id: Idbdbbe56e5daac2ce8ce780d2c8ce5ff54b8e006
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-3587
Change-Id: Idca2237777c1f7bda3fab89934dc97b9360fbc3d
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-3396
Change-Id: I7b37efc13a25e0e27d63a85a3ee291e91a4e1682
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed:
- a few other "var" cases
- use re2j instead of java.util.regex
- use correct class for constants
- remove unused constants
Issue-ID: POLICY-3094
Change-Id: Ifcb2b0623e8df0527f0a279e666d062422978ded
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Issue-ID: POLICY-2059
Change-Id: I245e4a647fcbb718faa63a7543f9f81c85da958c
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
This will provide an alternative unique key.
It will be used in place of PfTimestampKey in the PdpStatistics table.
We make use of the @GeneratedValue annotation to provide this feature.
Added DummyGeneratedIdEntity and unit tests
Added PfFilterFactory class
Added new filter classes
Issue-ID: POLICY-3189
Change-Id: I097eab318d2cb958e1157e35825fd6d35d429a25
Signed-off-by: ktimoney <kevin.timoney@est.tech>
|
|
|
|
Due to the precision of time stamps being saved to the nearest second,
a millisecond precision timestamp was being compared to a second
precision timestamp, causing the write to fail. This change fixes that.
A unit test is also added to test for this on the provider.
In addition, a USE-MARIADB flag is being introduced, which allows unit
tests to be run against a locally installed MariaDB instance so that the
unit tests can be verified against MariaDB locally rather than H2, the
default in Gerrit.
Issue-ID: POLICY-3146
Change-Id: I878f160956e89506743dc074679ee81ac1c48216
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Tests refactoring to reduce number of assertions
Issue-ID: POLICY-3094
Change-Id: I445462f0ec5d49474b10c1940c7fa12e687636de
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
|
|
Tests refactoring to reduce number of assertions
Removed lines 167-169 in PfKeyImplTest
Issue-ID: POLICY-3094
Change-Id: I94ef11068811c81108b0fbf3e5b878d02ab25306
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
Issue-ID: POLICY-3105
Change-Id: I01fe35f16609f9b8d98fb2083c8b18fc7ce3ccf3
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-3127
Change-Id: Ie37871c54dc5e7eab0ee7d553c6b38ea0e720a29
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Use of Timestamp in JPA classes appears to cause
EntityNotFoundException. Changed from Timestamp back to Date.
Issue-ID: POLICY-3125
Change-Id: I3ee29675849e3feda2641e9b240207c96fd975d4
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added casting for 4 asserts in policy/models/base
Issue-ID: POLICY-3094
Change-Id: Ibc97be3eca366a7e9b8b9611bc284f2473acff6e
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
|
|
Tests refactoring to reduce number of assertions to less then 25
Issue-ID: POLICY-3094
Change-Id: Icd3d83c7f8168dd81df13a584229eab36c646f37
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
|
|
Problem: When PfReferenceTimestamp Key is persisted in db, the parent
class fields are ignored which causes inconsistent data while saving and
fetching in db.
Fix: JPA is not supporting inheritance in @Embeddable classes. Hence
included the super class as @Embedded property in PfReferenceTimestamp
key. @Embedded properties are unable to be queried directly. Slightly
modified Dao methods to support querying @embedded fields.
Issue-ID: POLICY-3049
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: I5c2e03a5ae98525764a64dd6cce1a1298c5f9816
|
|
isNUllKey check for PfReferenceTimestamp key is always returning false as the parent class is
validating the child object in its method which has additional parameters (timestamp).
Fixing the issue by validating only the fields of parent class.
Issue-ID: POLICY-3069
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: Ie22d09552c9d0cedb7535bda359df0d70e1ebe77
|
|
Issue-ID: POLICY-3088
Change-Id: I7f6cc0ab5299200315c78f6e6c79c79349d2608c
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
Updated JPA classes to use java.sql.TImestamp rather than Instant.
Issue-ID: POLICY-3069
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: If5b874ec96931d4b8dd142d46a9980e83a4708fc
|
|
property
Issue-ID: POLICY-3011
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: I7a9db3a4fb0345e0979952e5c086523cc1d960f9
|
|
Addressed the following:
- make constructors protected
- check exception type
- too many assertions
- remove annotation lists
- use "<>"
- reduce cognitive complexity
- extract constant
- multiple method calls in one assert
- don't use eq() in verify()
- indentation
Issue-ID: POLICY-2905
Change-Id: I25bb3951f781250e9cdfe8f5f3b80cb63e129184
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Sometimes the exception thrown by the database providers has to be
converted to a runtime exception, especiall if the database provider is
running in a thread (called by the rum() method that does not return
exceptions). It is convenient to have a constructor on the
PfModelRuntimeException class that takes a PfModelException class as its
argument, thus creating the runtime exception.
Also the mapMap method in pfUtils is updated to allow the key of the map
to be templated. By doing this, the utility can be used for maps that
are keyed with types other than String (such as UUID).
Issue-ID: POLICY-2971
Change-Id: Ib0b3678de531fd383753a1cd0ce47a06f4079ec0
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Updated the code to place validation annotations directly on the
annotated types instead of using the @Items and @Entries annotations.
Also added/updated junits for validation code.
Issue-ID: POLICY-2648
Change-Id: Ia535da07a38cec77a74c5c3215b5ae784d7a4e1a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Today we can only handle a single service template in the database. We
should be able to handle multiple service templates and assign arbitrary
policy types and policies to maned and versioned service templates.
This review brings in the Java API in models provider for handling
service templates in this way and uses a simplistic single-teplate
implementation in models-tosca, that will work but still only handles a
single service template under the hood.
Issue-ID: POLICY-2900
Change-Id: Ia02dea8abe44b7f407e685090a4b8e0360889653
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Changes to the validation code broke the validation check for the
supportedPolicyTypes field in PdpSubGroup - it no longer supports wild-
cards in the name. Modified the validation annotation in
PfSearchableKey to allow wild-card names.
Issue-ID: POLICY-2648
Change-Id: Ibd2853025ce72ed88697dd9a7d6d5eed2b28475e
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Modified models to use annotations instead of function calls for most
field validations. Created a few new validation annotations for use
within models.
Per review comments:
- renamed Key to VerifyKey
- enhanced VerifyKey to imply "@Valid", unless disabled
Issue-ID: POLICY-2648
Change-Id: I2b53f218b0a2ab1ed1f5e278816a3509f1408972
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Policy models uses PfValidationXxx classes which are totally unrelated
to ValidationResult in policy common. This precludes the use of various
utility methods and annotations for doing validation. Modified policy
models to use ValidationResult instead.
This approach uses function calls, though a future approach could make
use of annotations instead.
Issue-ID: POLICY-2648
Change-Id: I9760f1dc46902ab6bef7f440f3caf5e951660a5d
Signed-off-by: Jim Hahn <jrh3@att.com>
|