aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-04-16CDS Operator should be genericJim Hahn4-4/+26
Like the SDNR Operator, the CDS Operator should work regardless of the operation name. Issue-ID: POLICY-2504 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I9a77838462bc5b91e2d95e7dcf1f8822bd45f04c
2020-04-16Merge "Add version to example yaml files"Pamela Dragosh10-32/+26
2020-04-16Merge "CDS actor was not registered"Jorge Hernandez6-16/+55
2020-04-16CDS actor was not registeredJim Hahn6-16/+55
Moved the spi file to register the actor and added a test to ensure that the registration worked. Also removed some deprecated code from the CDS junits. Issue-ID: POLICY-2501 Change-Id: I06f50ea8f074cdb7a89c7e387f9f31ea7cffa7e2 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-16Add version to example yaml filesJim Hahn10-32/+26
Determined that some of the yaml files were not suitable for use in the CSITs, because they were missing the "version" property. Added it where needed. Also added type_version where it was missing, as well. Issue-ID: POLICY-2491 Change-Id: I47bf0ec2b99d29580390a6e90512dfd903b042d6 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-16Merge "Fixing minor bug in policy-models/pdp-simulator script"Ram Krishna Verma1-2/+2
2020-04-16Fixing minor bug in policy-models/pdp-simulator scripta.sreekumar1-2/+2
Change-Id: I3b7bdfdd2fdd73b38cf7996457f6bea735752d46 Issue-ID: POLICY-2499 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-04-15Add example drools native artifact policiesjhh4-2/+47
Issue-ID: POLICY-2378 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iab36c4b3214bef90dfe4a6f00ff68df04e3de203 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-04-14Bump models to 2.2.5-SNAPSHOTRam Krishna Verma42-42/+42
Issue-ID: POLICY-2378 Change-Id: I5461bafd3c2d19f4f457da0816bba117a2d8b550 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-14Release models 2.2.4Ram Krishna Verma1-0/+4
Issue-ID: POLICY-2378 Change-Id: Ia31590fe8dc76cc8c6bea66b1bab6ba1bb96cb14 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-14Point to released commonRam Krishna Verma1-1/+1
Issue-ID: POLICY-2378 Change-Id: Ib956135eb681e8f9d9a7da9ecebc9c8d4fd615e6 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-14Merge "Example usecases as controller native policy"Ram Krishna Verma2-0/+211
2020-04-14Example usecases as controller native policyjhh2-0/+211
Issue-ID: POLICY-2489 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I94f8761982a6f257081a06667fccf9e089a9640e
2020-04-14Change length to a stringPamela Dragosh2-3/+3
This field is now a string. Issue-ID: POLICY-2486 Change-Id: Ie6707e29f2b069e3938897b62bd0591fd023016e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-13Fix strings in naming policyPamela Dragosh2-5/+5
Issue-ID: POLICY-2486 Change-Id: I89b2bfd2ac00c407aa90c34e898e9701cca54925 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-11Bump models patch 2.2.4-SNAPSHOTPamela Dragosh42-42/+42
Issue-ID: POLICY-2378 Change-Id: I51c6c57bdcc0299c25b5ee05f47c20f4542bc02d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-10Release models 2.2.3Pamela Dragosh1-0/+4
Issue-ID: POLICY-2378 Change-Id: I428d048da455d359eea01dc5136f424eaee95153 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-10Point to released parent and commonPamela Dragosh1-2/+2
parent 3.1.2 common 1.6.3 Issue-ID: POLICY-2378 Change-Id: I9cc0b0b8739f3fb017dc5a68584c12af9912bd29 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-09Merge "Disable sonar main args for models"Ram Krishna Verma3-1/+14
2020-04-09Merge "SDNR Actor enhancements"Jim Hahn9-222/+179
2020-04-09Disable sonar main args for modelsJim Hahn3-1/+14
Issue-ID: POLICY-2305 Change-Id: Ie8c45fb767ec9b2f9b1b541532fede52306c36b4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08SDNR Actor enhancementsJim Hahn9-222/+179
Made the following changes: - Enhanced SDNR Actor to support any operation name specified within the policy, constructing the same request, but passing a different "RPC name" and "Action" in the request. - Added ControlLoopResponse to OperationOutcome - Modified SDNR Actor to populate ControlLoopResponse Issue-ID: POLICY-2468 Change-Id: I50ee0674077d975f3cd211454656edc47d78520f Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08More sonar fixes in modelsJim Hahn4-27/+21
Addressed the following sonar issues: - missing assert in junit - duplicate code blocks - fixed those in the simulators - leaving the others in the concept classes for Liam/"G" Issue-ID: POLICY-2305 Change-Id: Icfe80afb378b4cdec4de3d33d0e33227e04845d8 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-07Address sonar issues in modelsJim Hahn41-830/+306
Addressed the following sonar issues: - use RE2 instead of java.util Pattern for "+" and "*" - don't use deprecated methods - for Date(long), sonar appeared not to parse the argument's type correctly. Modified the code slightly to make sonar happy - duplicate blocks of code - either log or throw - missing assert in junit - for SDNR & VFC, eliminated threads, as they are unnecessary - duplicate code block in different branches - useless assignments - redeclaring abstract methods - cyclomatic complexity - used lombok in some cases (e.g., EqualsAndHashCode) - assert argument order - actually deleted ControlLoopTargetType, because it is not needed and sonar complains regardless of which order is used - add private constructor to utility classes - use StandardCharsets instead of literals Also: - added logback-test.xml to SO to eliminate the voluminous output from the junit test Issue-ID: POLICY-2305 Change-Id: I586c331781bedbd54a115a71847d04d293689445 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Merge "Models junits are failing locally"Jim Hahn10-134/+135
2020-04-03Models junits are failing locallyJim Hahn11-135/+136
Junits were failing in my local eclipse environment. Fixed the following: - more cases of "is marked @NonNull but is null" (I thought Liam had already fixed all of these, but I'm still seeing errors, so fixed some more) - comparing "Instant" values in event time stamps assumes that the times will be different, but may not be, if the JVM is fast enough. Modified the test to set the times of the new events to Instant+1, to ensure that they are different from the original Issue-ID: POLICY-2305 Change-Id: Ic05bc6a58b559ba589583ce887711ee01f76691c Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-03Refer io.netty from policy/parentRam Krishna Verma2-5/+3
Issue-ID: POLICY-2467 Change-Id: If06f5fbf26269f7a34104bb2194258494a6488bf Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-02change drools op. policies controller namejhh11-14/+14
Issue-ID: POLICY-2465 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4f6cc6e7d40eb362374e0bef33772ab894b915fb
2020-04-01Set sub request ID before start callbackJim Hahn29-149/+162
Modified new actor code to generate the sub request ID before invoking the start callback. Issue-ID: POLICY-2461 Change-Id: I4adabd6efda2c30c0e2da31f95f01dd5fe546c0a Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-31Fix the policy model metadata for CLAMPsebdet1-1/+1
Fix the metadata section for CDS/operation, there was a mistake in the parameter value Issue-ID: CLAMP-801 Signed-off-by: sebdet <sebastien.determe@intl.att.com> Change-Id: Ic25173dc24874d0877969872f20ad4d8df0703fd
2020-03-30Test new actors against simulatorsJim Hahn34-32/+783
Also modified HttpParams to allow "path" to be blank to support any cases that really have no "path" to append to the context URI base path. Issue-ID: POLICY-2405 Change-Id: I49eebde6759659d2804b5a11c1504c37674bd0c4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-27Point to latest snapshotPamela Dragosh1-1/+1
Issue-ID: POLICY-2378 Change-Id: I5cd316100ee01b81a3cc59d57095beb6d97d7ec3 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-27Cleanup sonar bugs and security hotspotPamela Dragosh4-7/+7
Just some trivial sonar bugs for missing argument and a couple sonar overrides to clear security hotspots. Issue-ID: POLICY-2165 Change-Id: I392e5fee458465c66313a16a8912e23a3a119848 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-26Discard requests in APPC legacy actorJim Hahn2-1/+9
The new actor for legacy APPC attempts to discard request messages received on the response topic by discarding those that have a null response. Unfortunately, when it decodes them, the Response object creates a status object, even if there isn't one in the json message, thus the test fails and the actor treats it as a failed response. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I26cfb25443ff2ed394781d309f9097d50b8f160b Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-25Bump models 2.2.3-SNAPSHOTPamela Dragosh42-42/+42
Released 2.2.2 Issue-ID: POLICY-2378 Change-Id: I829f0dfc88aeaf1f9b7efad91c983628f2a5d706 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-25Release models 2.2.2Pamela Dragosh1-0/+4
This includes a change in the Operational Common policy type for CLAMP team via pairwise testing. Issue-ID: POLICY-2378 Change-Id: Ifd0790af8f90a3299c38cfbe4e3f677094c88aa7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-25Merge "Cleanup eclipse warnings"Pamela Dragosh4-52/+32
2020-03-25Change metadata for clampsebdet1-4/+8
Update metadata form clamp in the operational common model, so that it helps the user in the UI. Issue-ID: CLAMP-786 Signed-off-by: sebdet <sebastien.determe@intl.att.com> Change-Id: Ib44391bd58a478558c3881243839b65cf2b1846d
2020-03-25Cleanup eclipse warningsPamela Dragosh4-52/+32
Issue-ID: POLICY-2165 Change-Id: Iaad54af1b1210fe96fa44dcaa609834c46557877 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-24Security fixes for cds actor in policy/modelsRam Krishna Verma1-1/+1
Upgrading io.netty to 4.1.48.Final as the current version has security issues. Issue-ID: POLICY-2442 Change-Id: I5dbfdc7890c85571ef6b6bcc7a9f95310868f6a0 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-03-24Bump policy-models to version 2.2.2-SNAPSHOTliamfallon42-42/+42
Issue-ID: POLICY-2378 Change-Id: I644e45822154f57d2bf6a81e55df07e2e4ca6966 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-23Release models 2.2.1Pamela Dragosh1-0/+4
Releasing for RC0 Issue-ID: POLICY-2378 Change-Id: I9e1c17a966265ddc1f02f9d1225c08a668c3b844 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-23Merge "Add version to compliant operational policies"Pamela Dragosh3-9/+11
2020-03-23Add version to compliant operational policiesjhh3-9/+11
Issue-ID: POLICY-2356 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I5636ec4e92ff87fdefb9a6372a150ad021aeec16 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-23New Guard actor request structure is incorrectJim Hahn14-128/+71
Missing various fields within the request structure (e.g., ONAPName). Fixed. In the process, also modified makeGuardPayload() so that it only constructs the inner "guard" JSON object, making it easier for invoking code to modify it. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I7d34a279845bb98425caf66565eab7513d310815
2020-03-23Update new SDNR actor with v2.0 structuresJim Hahn15-61/+379
SDNR v2.0 introduced an extra "input" and "output" layer within the body of the messages. Added POJOs to match that, and updated the actor to use the new POJOs so that no extra steps are needed during serialization or deserialization. Also modified the SDNR and APPC-LCM simulators to discard request messages when looking for the response, if the sink and source topics happen to be the same. Added the SDNR simulator. Added more coverage to the SDNR actor. Fixed a sonar issue in the SDNR junit code: - use a constant instead of a literal (i.e., for "ModifyConfig") Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I70914a299dd5e9ee8eaccb5d42a2596cab814091
2020-03-23Merge "Bug fixes in models simulators"Liam Fallon8-36/+112
2020-03-23Merge "Exception not propagated by processResponse"Liam Fallon2-6/+41
2020-03-20Fix legacy APPC handling of RequestJim Hahn2-4/+5
Legacy APPC uses the same topic for both requests and responses. Unfortunately, when the actor sees the request, thinking it's a response, it throws an exception because it can't find the status code. Fixed. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I6137fb21dbf1149ff2faca2407ba69be0de6d40b
2020-03-20Exception not propagated by processResponseJim Hahn2-6/+41
If the topic processResponse() method throws an exception, then the actor/operation is left in an incomplete state. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I6c5d149d4046fbfb970c8dd831fc3938516d1115