aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-05-15Cannot parse finishTime in legacy SO responsesJim Hahn6-52/+175
Adding the actual sample responses to the SO simulator broke the drools-apps junit for usecases. Fixed (in theory) by updating the legacy SO actor to properly decode the finishTime. Refactored the new SO actor, extracting the type adapter into its own class file so it could be shared between the new and legacy actors. Issue-ID: POLICY-2570 Change-Id: I061b603172440b1a91da16d09b4f2a0d289dfc41 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-15Cannot parse finishTime in SO responsesJim Hahn8-102/+346
The timestamp in SO responses appears to follow RFC-1123/RFC-822 format instead of ISO format. Added a type adapter for SO. In Guilin, we may want to consider combining the two type adapters for LocalDateTime so that either format is accepted. Also modified the SO simulator to return responses that are actual samples from SO. As part of that work, discovered that the legacy SO actor is not able to parse these timestamps either. However, as that code is now deprecated, left it as is. Issue-ID: POLICY-2570 Change-Id: I322318d1007e36eef47bb8867fd8ed01cb60223a Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-14SO poll should not require request IDJim Hahn10-37/+196
When SO is polled for the result of a previous request, it does not necessarily include the originally returned request ID in the response. This causes the SO actor to generate a "missing request ID in response" exception. Modified the actor to only extract the request ID from the first response and cache it for subsequeent responses. Testing this required the SO simulator to be modified so that it would return an INCOMPLETE on the initial request, forcing the actor to poll until it returns a COMPLETE. Made this a settable flag so that it could be enabled just to test the SO actor without impacting other components (e.g., drools-apps, CSITs). Also fixed a couple of checkstyle issues in the simulators. Issue-ID: POLICY-2568 Change-Id: Ifad8b3c0c2c0b03cb82da693c2cf5ced44ede105 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-12Fix race condition in AaiCqResponseJim Hahn4-75/+66
The JAXB unmarshaller used by AaiCqResponse is not thread safe. As a result, if two responses are decoded at the same time, it will generate exceptions. Issue-ID: POLICY-2556 Change-Id: I5e81d5f3c39b9ba321c146dc6f4f73e558aaca3e Signed-off-by: Jim Hahn <jrh3@att.com>
2020-05-11Merge "Policy DB contents removed on DB deadlock"Pamela Dragosh8-205/+201
2020-05-10Policy DB contents removed on DB deadlockliamfallon8-205/+201
When a DB deadlock occurs, the DB contents can sometimes be deleted becasue the DB removes the Service Template object and recreates a new one in two separate DB transactions. This change makes sure that the object remove and re-create is in a sngle DB transaction, so the operation will either happen or not happen so the DB will not be cleared. Legacy policy handling must also use the SimpleToscaProvider rather than accessing the DB directly, as SimpleToscaProvider keeps the DB structure correct. Issue-ID: POLICY-2548 Change-Id: I263a41cd1d8bec5d7b421045b3b14aad6e6c66d3 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-05-10Merge "Add another blacklist entry for testing"Liam Fallon1-1/+2
2020-05-08Add another blacklist entry for testingPamela Dragosh1-1/+2
So I can adequately test blacklist. Issue-ID: POLICY-2490 Change-Id: I60c9a0fb0d597c1517a756b96dfcc32fcd39dd37 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-08Add missing payload section in vFW examplesjhh3-1/+8
Issue-ID: POLICY-2552 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I7acc7a7771ded3bc76c3fe420c93c077d84f0d31
2020-05-07Fix simultaneous get access to policy providerliamfallon1-71/+86
When a "get" is executed while a "create" or "delete" is underway, the DB sessions overlp and data is lost in the database. "get" requests must also be synchronized. Issue-ID: POLICY-2533 Change-Id: Idbe155568e5d793fe82b7cc3aad5ef121e8209b9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-05-06Make type and type_version mandatory on policiesliamfallon3-17/+86
Up until now, the "type" and "type_version" fields defaulted to "NULL" and "0.0.0" respectively when they were not specified because the "type_version" field was not always specified on policies in previous releases. In cases where the "type_version" field was not specified, it was assumend that a "0.0.0" version of the policy type existed. In parallel, if the version field was not specified on the policy type, the version was stored as 0.0.0. This behaviour is now changed and the "type" and "type_version" fields are now always mandatory. Issue-ID: POLICY-2538 Change-Id: I4279adfa86f531205879dbb87986453604624032 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-05-05Point to released parent,commonPamela Dragosh1-2/+2
Issue-ID: POLICY-2514 Change-Id: Ib7bb52f147c30e9a4c588d29cb13495905ee1ac6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-05-05Policy delete should only return deleted policyliamfallon3-48/+93
The policy type delete and policy delete now only return what is deleted in the service template. Issue-ID: POLICY-2534 Change-Id: I1b8d10c22d4392b0bbb655aa6876ac900ebc81df Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-05-04Fix simultaneous write access to policy providerliamfallon4-38/+87
This change serializes write access to the policy database via the AUthorative TOSCA provider by making sure that only one request is executed at a time. His change should be repolaced by proper session handling in the next release of the Policy Framework project. Issue-ID: POLICY-2533 Change-Id: I5fe4c0f2846981a66eb2f4e1da936fe3c9490ae5 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-04-28modifications in example sdnc naming policyjhh2-14/+17
Issue-ID: POLICY-2525 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I7c6880b63b3ff8f986fb0de27656eda8f6e596a2 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-04-27Remove provided scope for endpoints in model-impl/cdsa.sreekumar1-1/+0
Change-Id: Ic3571df8ed874267fb803d1f384ec5cb02fb80bb Issue-ID: POLICY-2524 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-04-24Bump models patch 2.2.6-SNAPSHOTPamela Dragosh42-44/+44
Also point to parent, common snapshots Issue-ID: POLICY-2510 Change-Id: Iad79c341bcfb8cb6bb828ee71e199ba3bb9a838b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-24Release 2.2.5 models artifactsPamela Dragosh1-0/+4
Issue-ID: POLICY-2510 Change-Id: I224eb922ff4efe61a6826e8d6a61160645ea3ed2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-20Merge "Test latest policy version is returned"Jim Hahn1-13/+63
2020-04-20Merge "Update monitoring policies to match DCAE"Pamela Dragosh6-77/+51
2020-04-20Test latest policy version is returnedliamfallon1-13/+63
Load 21 versions of the same policy and make sure that the latest version is returned when the LATEST policy is set on the version filter. Issue-ID: POLICY-2352 Change-Id: Iddee33ae53096e18ed2ec67b0c3e837d1d7410a9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-04-19Merge "Add PNF support to new CDS actor"Ram Krishna Verma20-189/+881
2020-04-17Add PNF support to new CDS actorJim Hahn20-189/+881
Made the following updates: - added new A&AI get-PNF Operation by refactoring AaiGetOperation, separating out Tenant and PNF operations - added PNF support to the CDS actor - added logging to the CDS Handler - added get-pnf to the A&AI simulator Issue-ID: POLICY-2505 Change-Id: Iff140e7c864f762790d8e2ecaba62c161c859e6e Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-17Update monitoring policies to match DCAEPamela Dragosh6-77/+51
From testing last Wednesday 4/15. Update our policies to match what DCAE is loading and is used for Integration E2E testing. https://git.onap.org/dcaegen2/platform/blueprints/tree/blueprints/k8s-tca.yaml Issue-ID: POLICY-2507 Change-Id: I2492e214625099884113ac0bc76e26181f992f0e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-17Updating pdp-simulator as per recent changes to send PdpGroup in statusa.sreekumar8-9/+15
Change-Id: Ic2ad6bd7f65633eef73d6432f244be77d7c760f9 Issue-ID: POLICY-2499 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-04-16CDS Operator should be genericJim Hahn4-4/+26
Like the SDNR Operator, the CDS Operator should work regardless of the operation name. Issue-ID: POLICY-2504 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I9a77838462bc5b91e2d95e7dcf1f8822bd45f04c
2020-04-16Merge "Add version to example yaml files"Pamela Dragosh10-32/+26
2020-04-16Merge "CDS actor was not registered"Jorge Hernandez6-16/+55
2020-04-16CDS actor was not registeredJim Hahn6-16/+55
Moved the spi file to register the actor and added a test to ensure that the registration worked. Also removed some deprecated code from the CDS junits. Issue-ID: POLICY-2501 Change-Id: I06f50ea8f074cdb7a89c7e387f9f31ea7cffa7e2 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-16Add version to example yaml filesJim Hahn10-32/+26
Determined that some of the yaml files were not suitable for use in the CSITs, because they were missing the "version" property. Added it where needed. Also added type_version where it was missing, as well. Issue-ID: POLICY-2491 Change-Id: I47bf0ec2b99d29580390a6e90512dfd903b042d6 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-16Merge "Fixing minor bug in policy-models/pdp-simulator script"Ram Krishna Verma1-2/+2
2020-04-16Fixing minor bug in policy-models/pdp-simulator scripta.sreekumar1-2/+2
Change-Id: I3b7bdfdd2fdd73b38cf7996457f6bea735752d46 Issue-ID: POLICY-2499 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2020-04-15Add example drools native artifact policiesjhh4-2/+47
Issue-ID: POLICY-2378 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Iab36c4b3214bef90dfe4a6f00ff68df04e3de203 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-04-14Bump models to 2.2.5-SNAPSHOTRam Krishna Verma42-42/+42
Issue-ID: POLICY-2378 Change-Id: I5461bafd3c2d19f4f457da0816bba117a2d8b550 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-14Release models 2.2.4Ram Krishna Verma1-0/+4
Issue-ID: POLICY-2378 Change-Id: Ia31590fe8dc76cc8c6bea66b1bab6ba1bb96cb14 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-14Point to released commonRam Krishna Verma1-1/+1
Issue-ID: POLICY-2378 Change-Id: Ib956135eb681e8f9d9a7da9ecebc9c8d4fd615e6 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-14Merge "Example usecases as controller native policy"Ram Krishna Verma2-0/+211
2020-04-14Example usecases as controller native policyjhh2-0/+211
Issue-ID: POLICY-2489 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I94f8761982a6f257081a06667fccf9e089a9640e
2020-04-14Change length to a stringPamela Dragosh2-3/+3
This field is now a string. Issue-ID: POLICY-2486 Change-Id: Ie6707e29f2b069e3938897b62bd0591fd023016e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-13Fix strings in naming policyPamela Dragosh2-5/+5
Issue-ID: POLICY-2486 Change-Id: I89b2bfd2ac00c407aa90c34e898e9701cca54925 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-11Bump models patch 2.2.4-SNAPSHOTPamela Dragosh42-42/+42
Issue-ID: POLICY-2378 Change-Id: I51c6c57bdcc0299c25b5ee05f47c20f4542bc02d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-10Release models 2.2.3Pamela Dragosh1-0/+4
Issue-ID: POLICY-2378 Change-Id: I428d048da455d359eea01dc5136f424eaee95153 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-10Point to released parent and commonPamela Dragosh1-2/+2
parent 3.1.2 common 1.6.3 Issue-ID: POLICY-2378 Change-Id: I9cc0b0b8739f3fb017dc5a68584c12af9912bd29 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-09Merge "Disable sonar main args for models"Ram Krishna Verma3-1/+14
2020-04-09Merge "SDNR Actor enhancements"Jim Hahn9-222/+179
2020-04-09Disable sonar main args for modelsJim Hahn3-1/+14
Issue-ID: POLICY-2305 Change-Id: Ie8c45fb767ec9b2f9b1b541532fede52306c36b4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08SDNR Actor enhancementsJim Hahn9-222/+179
Made the following changes: - Enhanced SDNR Actor to support any operation name specified within the policy, constructing the same request, but passing a different "RPC name" and "Action" in the request. - Added ControlLoopResponse to OperationOutcome - Modified SDNR Actor to populate ControlLoopResponse Issue-ID: POLICY-2468 Change-Id: I50ee0674077d975f3cd211454656edc47d78520f Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08More sonar fixes in modelsJim Hahn4-27/+21
Addressed the following sonar issues: - missing assert in junit - duplicate code blocks - fixed those in the simulators - leaving the others in the concept classes for Liam/"G" Issue-ID: POLICY-2305 Change-Id: Icfe80afb378b4cdec4de3d33d0e33227e04845d8 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-07Address sonar issues in modelsJim Hahn41-830/+306
Addressed the following sonar issues: - use RE2 instead of java.util Pattern for "+" and "*" - don't use deprecated methods - for Date(long), sonar appeared not to parse the argument's type correctly. Modified the code slightly to make sonar happy - duplicate blocks of code - either log or throw - missing assert in junit - for SDNR & VFC, eliminated threads, as they are unnecessary - duplicate code block in different branches - useless assignments - redeclaring abstract methods - cyclomatic complexity - used lombok in some cases (e.g., EqualsAndHashCode) - assert argument order - actually deleted ControlLoopTargetType, because it is not needed and sonar complains regardless of which order is used - add private constructor to utility classes - use StandardCharsets instead of literals Also: - added logback-test.xml to SO to eliminate the voluminous output from the junit test Issue-ID: POLICY-2305 Change-Id: I586c331781bedbd54a115a71847d04d293689445 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Merge "Models junits are failing locally"Jim Hahn10-134/+135