aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-08-25Address more sonar issues in policy-modelsJim Hahn27-92/+49
Addressed sonar issues: - diamond operator Also removed a number of the "NOSONAR" comments now that we know how to address them without disabling sonar. Issue-ID: POLICY-2714 Change-Id: I440f4fa955968fd911616c2b6ee61b4b4d013821 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-24Merge "Remove legacy operational policy from models"Jim Hahn23-1326/+14
2020-08-24Remove deprecated SDC and Model-yamlPamela Dragosh95-16663/+0
Deprecated as we now use TOSCA and the SDC catalog objects isn't useful for control loop design and implementation. Issue-ID: POLICY-2428 Change-Id: Ib4adfbf25ba70c3cad47a8494333a1f20a5c4e23 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-20Sonar Fixes policy/models, removing model-yamluj426b25-204/+222
Change-Id: Icd82ea1aef90e4d638b13958519aac5ed5a53f73 Issue-ID: POLICY-2714 Signed-off-by: uj426b <uj426b@att.com>
2020-08-19Merge "Upgrade new tcagen2 policy type"Jim Hahn17-36/+36
2020-08-19Upgrade new tcagen2 policy typePamela Dragosh17-36/+36
The old cdap policy type is deprecated by DCAE. Thus, we are simply replacing with the new tcagen2 policy type. Issue-ID: POLICY-2772 Change-Id: I1442340729b5f820f2e265b9b86f6f6f84f49bca Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-18Make targetEntity a propertyJim Hahn23-125/+194
The target entity is not always known when an Operation is first constructed, thus it should be treated as an Operation property instead of being included within the ControlLoopParams. Started the process of moving it from the Params to the properties. Also fixed a bug in custom query - it was setting the outcome response to the String response instead of setting it to the AaiCqResponse object. Also added logging when an Operation's properties are set. Issue-ID: POLICY-2746 Change-Id: I56c0cd90985f6140363548b0b8d031471b586e88 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-18Merge "Remove event context from Operation post processor"Ram Krishna Verma2-5/+8
2020-08-17Remove event context from Operation post processorJim Hahn2-5/+8
Some operations, notably A&AI, post-process data by putting it into the event context. However, with the new strategy, the event context may not be populated. Modified the code to see if the context exists before putting the data into it. Issue-ID: POLICY-2746 Change-Id: Ie3b1bd13b4ac5ee59629daaebc05a62e6ef3c804 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-17Add new guard filter policy typePamela Dragosh1-0/+65
New policy type for testing and preloading. Issue-ID: POLICY-2590 Change-Id: Ic542c61bd402387870306fce9a1977b169052ef9 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-14Remove legacy operational policy from modelsRam Krishna Verma23-1326/+14
Removing all the legacy operational policy related concepts, providers, examples etc from models repo. Issue-ID: POLICY-2764 Change-Id: Ie820271381674ccc4eaef0bd6379f673f67701e7 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-08-14Merge "Do not require context in ControlLoopOperationParams"Ram Krishna Verma2-13/+89
2020-08-14Remove annotations from dmaap common test classJim Hahn4-82/+43
Jenkins builds are randomly failing in the junits for the dmaap simulator. From the console output, it appears that the simulator is being shut down before all of the test methods have executed. Moved the code for managing the "Main" object from the common superclass to the only subclass that needed it. Issue-ID: POLICY-2749 Change-Id: I2615bbef9b790dbb633ed7f123aeb3f880826862 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-13Do not require context in ControlLoopOperationParamsJim Hahn2-13/+89
Modified ControlLoopOperationParams so that the request ID can be provided instead of the context. However, if the request ID is not provided, then it still requires a context. (This requirement should be lifted in a subsequent review). Issue-ID: POLICY-2746 Change-Id: Ib00f46f2fe56430d700ee2edfba12f2c1a106a3f Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-07Merge "Modify Actors to use properties when provided"Pamela Dragosh26-212/+999
2020-08-06Modify Actors to use properties when providedJim Hahn26-212/+999
Modified the Actors to use properties when the application provides them instead of going to the event context for the data. This sometimes entailed moving code out of the Operation subclass constructor that used or validated the context data. Combined some property names and renamed others. Changed VF Count from AtomicInteger to Integer. Issue-ID: POLICY-2746 Change-Id: Ib8730538309bb77d2f4f6161e9a20a49362d8972 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-06Exclude javaparser due to license issueJim Hahn1-0/+6
javaparser is included indirectly by aai-schema jar. Modified the pom to excluded javaparser when including aai-schema jar. Verified that models aai code still works and that drools-apps use case tests still work. Issue-ID: POLICY-2736 Change-Id: Iba137cf7ee4be6f2e35e3053413a4a9068860823 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-04Skip preprocessor step in ActorsJim Hahn13-41/+110
Modified Actors to skip the preprocessor step if the "preprocessed" flag is set to true in the parameters. Did not add any error checking code to ensure the data was actually available to the operation - will add that once the properties are being set by the application code. Extracted common code in GrpcOperationTest into the setup method. Issue-ID: POLICY-2746 Change-Id: Id70c31a2c96a7aaa9d73cc70cdf4f55f8a4e087f Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-31Add property lists to ActorsJim Hahn45-64/+489
Modified the Actor code to provide a list of properties needed by the actor to perform a given operation. Added a build() method to the parameter class so invokers can build an operation and set its properties prior to starting it. Added a "preprocessed" field to the parameter class so invokers can indicate that the Actor need not perform any preprocessing steps. Will modify the actors, in a subsequent review, to observe the flag. Added "properties" to Operation so invokers can set the properties. Will modify the actors, in a subsequent review, to use the property values instead of the event context. Tweaked a few Actors to get values using the "params" object instead of reaching inside to the event object that it contains. Addressed review comment(s): - add prefix to other property names Issue-ID: POLICY-2746 Change-Id: I65996aef5cec5afe25e8287c0b2f5f322c532ca5 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-31Allocate unique port for dmaap simulator junitsJim Hahn4-17/+28
The junits for the dmaap simulator were randomly failing, because the port was already in use. Modified the junits to allocate their own, individual ports. Issue-ID: POLICY-2749 Change-Id: I3f3858091ee8f36ed00346ad9fa002a76d0348ae Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-30Update INFO.yaml in policy-modelsTaka Cho1-12/+16
Verified with Jessica W that the "type" should still be "Addition", even when updating the PTL. Updated to Mature, per TSC. Issue-ID: POLICY-2738 Change-Id: Ibfa990f73e565db4630ff6bc373cea626eb9fc2a Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-24Add Ajith to policy/models infoJim Hahn1-17/+11
Issue-ID: POLICY-2738 Change-Id: Ic3e9f9ee6641410356ff27f4d405fd606e6c44ff Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-21Fix some sonars in policy-modelsJim Hahn74-550/+469
Fixed the following sonar issues in some of the project directories: - use assertNull, assertEquals, etc. - swap assertEquals arguments - extract a constant - don't invoke toString() in logger calls - TODOs - generic types Issue-ID: POLICY-2714 Change-Id: Id8803f9bf617ea9fc173a67b8606600709b55bdc Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-17Merge "Support vDNS RainyDay test Case."Jim Hahn1-3/+12
2020-07-17Support vDNS RainyDay test Case.uj426b1-3/+12
Modifying simulator to handle failure sent from Policy Json. Change-Id: I52a9f8da4ad06b535262f202418868f79fea4510 Issue-ID: POLICY-2432 Signed-off-by: uj426b <uj426b@att.com>
2020-07-17point to SNAPSHOT version for modelTaka Cho1-1/+1
Issue-ID: POLICY-2695 Change-Id: Ife95d9a265646563c2ec2f171a764c6f164edacc Signed-off-by: Taka Cho <takamune.cho@att.com>
2020-07-13Remove legacy actor code from modelsJim Hahn24-4544/+2
Deleted legacy actor code. That includes deleting most of the XxxManager classes. Issue-ID: POLICY-2559 Change-Id: I1ef1b900ca1d23e88da64b2c95a18986feb1b765 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-09Bump policy/models to 2.3.1-SNAPSHOTRam Krishna Verma43-43/+43
Issue-ID: POLICY-2695 Change-Id: I64473cc81ae48942010472f15faac75c13cb0b7d Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-09Release policy/models 2.3.0Ram Krishna Verma1-0/+4
Issue-ID: POLICY-2695 Change-Id: Ic801aa2c69c204d4c3bfebbba329c6d254bc3a98 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-09Refer to released parent & common in policy/modelsRam Krishna Verma1-2/+2
Issue-ID: POLICY-2695 Change-Id: I4e30b08822095bddbb720e3785b7493bfddff749 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-02Rename XxxActorServiceProvider to XxxActorJim Hahn27-142/+141
Renamed the actors and their test classes. Addressed review comments: - some license dates Issue-ID: POLICY-2684 Change-Id: Ic9d83e146ef36bb305496d541166cb9f80544025 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-01Fix broken models build due to json upgradeJim Hahn2-6/+7
The json dependency was moved to policy-parent and the "version" property removed which broke the policy-models build. Removed the "version" from the pom. Also removed the jetty-security "version" from the pom, as it is no longer needed either. Also added asm dependency, because upgrade of openpojo version caused breakage in one of the TestPojos. Issue-ID: POLICY-2387 Change-Id: I3c2315b3cbea05de76b6dfcc289f9323af77745b Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-29Merge "Add CDS simulator to policy-models"Ram Krishna Verma10-20/+446
2020-06-26Add CDS simulator to policy-modelsJim Hahn10-20/+446
Added CDS simulator to policy-models. Added a test case to the CDS Actor to verify that it works with the simulator. Issue-ID: POLICY-2676 Change-Id: I9b10de3bde93c69e82df983f77eecc253de8a1a2 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-26Clean up of Pair classes - modelswaynedunican13-361/+308
Removed Pair class from policy-models and replaced with Aoache Common Pair class Issue-ID: POLICY-2202 Change-Id: I786467ac02ecb2d433dba94deba45785be3dcf23 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-06-24Updating models dependencies to latest versionsRossC6-14/+11
Issue-ID: POLICY-2387 Change-Id: Id89dac64139490f6d9b83b295cfe99c43ed657cf Signed-off-by: RossC <ross.carter@est.tech>
2020-06-19Merge "Changes for Checkstyle 8.32"Ram Krishna Verma227-455/+97
2020-06-18Merge "make vDNS example use modelVersion string"Ram Krishna Verma4-4/+4
2020-06-18Changes for Checkstyle 8.32liamfallon230-459/+97
Issue-ID: POLICY-2188 Change-Id: I6db16763c1d2d80ff934302081a8dfc16afa7d9a Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-06-18Replaced try/catch blocks in policy/models with assertj assertions.waynedunican3-33/+20
Issue-ID: POLICY-2451 Change-Id: I095beb674196d5ec5c4dd9b93d3a56cca5ee4788 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-06-18make vDNS example use modelVersion stringjhh4-4/+4
Issue-ID: POLICY-2652 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I2b632b8380f32715d1e0b526445f445cae79e90d Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-06-16Merge "Adding 'name' to yamls and json in model"Pamela Dragosh53-6/+97
2020-06-15Merge "Moving common polling code into HttpOperation"Ram Krishna Verma40-1081/+861
2020-06-12Moving common polling code into HttpOperationJim Hahn40-1081/+861
SO and VFC have duplicate code for polling. Moved it into the common superclass. Issue-ID: POLICY-2632 Change-Id: I27128bfb2d54ef522b6b44ff569819a8463f3454 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-06-12Merge "Change related to log4j removal needed in models"Ram Krishna Verma1-3/+2
2020-06-12Adding 'name' to yamls and json in modeladitya.puthuparambil53-6/+97
Issue-ID: POLICY-2052 Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech> Change-Id: I3629a2b6f9e93f6d8166e63862d15dd0198865af
2020-06-12Remove logback.xml files bundled as part of jara.sreekumar9-177/+6
Change-Id: I4d603ea67eca5d8d75b9df004e1ff4a6be2b2a9e Issue-ID: POLICY-2627 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2020-06-11Change related to log4j removal needed in modelsuj426b1-3/+2
Change-Id: I449aef2c1f83edecc88c379525b8da6c80e9d35f Issue-ID: POLICY-2623 Signed-off-by: uj426b <uj426b@att.com>
2020-06-11Merge "Default ActorImpl should have an "operations" property"Pamela Dragosh16-50/+61
2020-06-11Merge "Fixing issue with Jacoco coverage being stored above project directory"Pamela Dragosh2-10/+10