summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-04-06Guaranteed linear-time latestVersion()Jim Hahn1-13/+18
This is a proposed revision of the latestVersion() method that's guaranteed to be linear time. Still makes use of the slick idea of sorting the list so that items with the same name are adjacent and in order by version. Revised to use an array list, which is more like the original code. Change-Id: If047d4d9630c426c6335f52cb7e5bdda7b6cc0a9 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-05Add unit tests for models-baseliamfallon5-6/+45
Brings coverage in models-base up over 99% Issue-ID: POLICY-1095 Change-Id: Ie1c9f3f132715275f44f349a415a8bb34a0115c9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-05Missed simulator REST call SDNCPamela Dragosh1-0/+21
Forgot this as part of this review: https://gerrit.onap.org/r/#/c/84338/ Issue-ID: POLICY-1264 Change-Id: I8b95cd43b593fd9a79c62b3398a5d44bb7b0c794 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-05Merge "Complete filters for Database Fetches"Pamela Dragosh27-86/+440
2019-04-05Complete filters for Database Fetchesliamfallon27-86/+440
This review completes the implementaiton of the filters for fetching policy types, policies, and PDP groups from the database. It also fixes bugs in Policy type creation. Yaml in some of the policy type examples modified so that it is syntatically correct. Proeprties now stored as a blob in DB as they can be big. Issue-ID: POLICY-1095 Change-Id: I6aef88ee2905afa58d778d82832f2b55d794fe9c Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-05remove dependency of drool-application/yaml in actorsning.xi82-3/+15595
Issue-ID: POLICY-1264 Change-Id: Ie89749cf25d6880fd2884eb6935f36f046114b23 Signed-off-by: ning.xi <ning.xi@est.tech>
2019-04-05Merge "move two modules from drools-application to models"Jorge Hernandez21-13/+1587
2019-04-05move two modules from drools-application to modelsning.xi21-13/+1587
Also removed reference to drools logging util. Issue-ID: POLICY-1264 Change-Id: I7795f23b2b06fcb98f4099c3a6c303561a68e55f Signed-off-by: ning.xi <ning.xi@est.tech> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-05Update SDNC changesPamela Dragosh9-20/+314
Per this review: https://gerrit.onap.org/r/#/c/83945/ Copying those changes into policy/models before removal in drools-applications. Issue-ID: POLICY-1264 Change-Id: I151816e78293af813d24ca1164ca364a3c54f87c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-04Updates to models from scrum on 4/4Jim Hahn25-70/+237
Moved ToscaPolicyIdentXxx classes from models-pdp to models-tosca, and added methods to retrieve them from a ToscaPolicy. Removed version and instance fields from PdpStatus. Chose to leave "description" field in the PAP/PDP messages. The PDPs can ignore them or leave them null. In a PdpUpdate message, the description will be the description associated with the PdpGroup. In a PdpStatus message, the PDP could choose to provide a description of the PDP, itself (or the type of PDP). Added comments to that effect. Moved name, group, and subgroup fields into PdpMessage. Fixed typos in comments. Updated licenses. Change "long" to "Long" in PdpUpdate. Use lombok @ToString instead of override. Fixed merge conflict. Change-Id: Icd928f9a7630b838ad4b0b5556e899dc21b7872b Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-04Add filters on policy objectsliamfallon5-7/+169
I just raised this review to shwo where I'm going with the filters. They are not complete yet. Issue-ID: POLICY-1095 Change-Id: I7b602a32bb67159b893f3b3cefea5d88038c4e5f Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-04Merge "Add filter obejcts for concepts"Pamela Dragosh16-359/+355
2019-04-04Merge "Add ApiModelProperty annotation to authorative models"Pamela Dragosh8-6/+27
2019-04-04Add filter obejcts for conceptsliamfallon16-359/+355
This review: - Fixes the bug in getting policies where the key fields were null - Removes complex version checks from DAO interface - Simplifies provider API by introducing filter objects for searches Issue-ID: POLICY-1095 Change-Id: I5ab7471c03e8b61849e7882ed18541acd627dc39 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-03Add ApiModelProperty annotation to authorative modelsChenfei Gao8-6/+27
Add @ApiModelProperty to authorative models for the fields that have different serialized names from their property names. Issue-ID: POLICY-1515 Change-Id: Id6509afe5cc741a6253fc0d1f98ae6b22d31f0d9 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-04-03Updating PdpStatistics modelramverma2-47/+4
Change-Id: Ic3ae28997dd1db14c16bdfd24a5d936393fa8da4 Issue-ID: POLICY-1443 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-04-03Merge "Clean up models-pap based on updates to models-pdp"Jorge Hernandez10-376/+2
2019-04-03Merge "Add impl of more PDP persistence"Liam Fallon11-75/+504
2019-04-03Clean up models-pap based on updates to models-pdpJim Hahn10-376/+2
Change-Id: I5e55dd669200e4fc28f58379bbaa61e5d3331610 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-03Add impl of more PDP persistenceliamfallon11-75/+504
Add the implementation of more metods in the PDP provider. Issue-ID: POLICY-1095 Change-Id: Ie02189cad7a262a453e1f731190525f838648401 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-03Changing PAP model as per discussionramverma13-128/+83
1) Changing PAP models to use ToscaPolicyIdentifier instead of actual ToscaPolicy itself. 2) Deleting unused PdpHealthCheck message. As we decided to return heath check based on DB state. 3) Updating PdpStatus message to use ToscaPolicyIdentifier instead of actual ToscaPolicy itself. Pdp don't need to send the whole ToscaPolicy everytime in heartbeat to PAP. Instead the identifier is sufficient. Change-Id: I50ead8d8b6af118fd1da08071a2b0fc50584d4aa Issue-ID: POLICY-1443 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-04-03Merge "Add DecisionException"Jorge Hernandez2-0/+54
2019-04-02Add DecisionExceptionPamela Dragosh2-0/+54
Need this class to capture exceptions during decision and setup the ErrorResponse object to return from REST API. Issue-ID: POLICY-1440 Change-Id: I02cd4f93e671c0d543bf527f5de3cf6831f62c40 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-02Add persistence for PDP conceptsliamfallon23-90/+1501
This review adds the JPA annotations to PDP group/subgroup and PDP for persisting to the database. It also updates the Provider API as requested by other team members. Issue-ID: POLICY-1095 Change-Id: I8188afb763849ede9680f3751b464d9d76c27196 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-02Adding pdpHeartbeatIntervalMs to PdpUpdate messageramverma2-3/+6
Adding pdpHeartbeatIntervalMs to PdpUpdate message. The value of which can be used by Pdp to override its own interval for sending PdpStatus message as heartbeat to PAP. Change-Id: I720713b9b569cf09bf393ac797da29e7f330f8bf Issue-ID: POLICY-1443 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-04-02Merge "Remove pdpType from PdpUpdate"Liam Fallon2-5/+2
2019-04-02Merge "move actors code in drools-applications to policy/models"Pamela Dragosh186-344/+4823
2019-04-02Merge "Add extra methods to Provider interface"Pamela Dragosh10-129/+660
2019-04-01Remove PfConceptKey from models-pdp classesJim Hahn6-141/+65
PfConceptKey has different notions of "null", thus removing it from models-pdp. Change-Id: I3b0fc818a8283dcca0fb67ec6c3b6e2302d26196 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-01Remove pdpType from PdpUpdateJim Hahn2-5/+2
The pdpType field is redundant; it has the same value as the pdpSubgroup field. Change-Id: Id5cd0c726ffcf73aa82d35eb8cdbf1d7e3c2abc8 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-01Add extra methods to Provider interfaceliamfallon10-129/+660
This review provides the full specification of the Provider interfce and stups the new implemented methods into the relevant delegated providers. Issue-ID: POLICY-1095 Change-Id: I5f297f8dbbe4131ce910fce95459425ac8b7c3f9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-01Merge "Fix policy-models-pdp dependency"Pamela Dragosh1-1/+1
2019-04-01Fix policy-models-pdp dependencya.sreekumar1-1/+1
Change-Id: I97f33d295ef6871d6b4139e4f6c92d00e226c1e8 Issue-ID: POLICY-1443 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
2019-04-01Fix breakage from ToscaPolicy refactoringJim Hahn3-9/+13
A few tests in models-pdp broken when ToscaPolicy was moved and refactored. Change-Id: If8e17a140ebc4f8f83b1f5c7cb32a542dd6e5390 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-01Merge "Refactor to authorative TOSCA serializtion"Pamela Dragosh71-2852/+1869
2019-04-01Merge "Add copy constructors to more models-pdp classes"Liam Fallon4-2/+165
2019-04-01move actors code in drools-applications to policy/modelsning.xi186-344/+4823
remove white-space in policy/models Issue-ID: POLICY-1264 Change-Id: I8856fc7cd2c2a57af0031637870ca33c684bacf5 Signed-off-by: ning.xi <ning.xi@est.tech>
2019-04-01Refactor to authorative TOSCA serializtionliamfallon71-2852/+1869
This review refactors the TOSCA support to use authorative serialization and mapping. It removes the JPA entities from the Proider interface It brings the mapping support from and to authorative concepts out of the JSON serialization classes directly into the JPA classes It adapts the unit tests to work with the refactored structure. Apologies for the review size but it all had to be done in a single block of work. Issue-ID: POLICY-1095 Change-Id: I4827d1dc67ef7aac98cba230ffcd79c6de71e805 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-03-31Merge "Restructure for authorative models"Liam Fallon94-1117/+1196
2019-03-31Add copy constructors to more models-pdp classesJim Hahn4-2/+165
Change-Id: I9c6dc85b13e3e114f380dd9581f3f4c055889260 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-29Merge "fix code smell in model-impl"Jorge Hernandez18-160/+156
2019-03-29Merge "Update comment in models-pap."Jorge Hernandez1-1/+1
2019-03-29fix code smell in model-implHengye18-160/+156
Issue-ID: POLICY-1264 Change-Id: Idacb7151978373e48098790d9d86825410b65aa6 Signed-off-by: Hengye <yehui.wang@est.tech>
2019-03-29Update comment in models-pap.Jim Hahn1-1/+1
Change-Id: If51abf12cec951d82738ce7579b583fa97a1a26b Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-29Merge "Add @NonNull to PolicyIdent"Pamela Dragosh1-0/+2
2019-03-29Restructure for authorative modelsliamfallon94-1117/+1196
Use authorative models instead of the JPA stored models as the venacular models in the Policy Framework. The next step is to pass the authorative objects over the provider interface rather than the JPA obejcts. This change will be made in the next review. Minor changes to pdp objects to remove JPA things from them. These object will be the authorative in-memory obejcts on the PDP side and new JPA entity object will be introduced in a future review to persist them. Issue-ID: POLICY-1095 Change-Id: I40e7b713903980cb41bb315417111b67a9b17307 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-03-28Add @NonNull to PolicyIdentJim Hahn1-0/+2
Change-Id: Ib10c92addfe4803dc28f82a7f844920134336b8a Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-03-27Add support for legacy guard policiesliamfallon23-524/+1179
Support for legacy guard policies added. Support for translation of all legacy policies to TOSCA format now complete. Fix merge problems with dummy provider implementation. Issue-ID: POLICY-1095 Change-Id: I3dd1775b78d39078a884e1834502b832ff40be18 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-03-27Merge "Add PfConceptKey.isVersionNull()"Jorge Hernandez1-1/+11
2019-03-27Merge "Fix VF Module Create in guard"Jorge Hernandez9-8/+20