summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-06-21Merge "Use lombok for errors pap, pdp, sim-dmaap, sim-pdp"Jim Hahn8-72/+30
2021-06-21Use lombok for errors pap, pdp, sim-dmaap, sim-pdpJim Hahn8-72/+30
Issue-ID: POLICY-3396 Change-Id: Ib2c9bc5dc199e15ae9ca077031c0f2cfbc5b6a81 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-21Use lombok for events, base, daoJim Hahn15-143/+49
Issue-ID: POLICY-3396 Change-Id: I7b37efc13a25e0e27d63a85a3ee291e91a4e1682 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-18Merge "Use lombok annotations for sdnr, simulators"Jim Hahn15-162/+57
2021-06-18Merge "Use lombok annotations for so, vfc"Jim Hahn27-176/+43
2021-06-18Merge "Use lombok annotations for aai, appc, appclcm, cds"Jim Hahn17-145/+61
2021-06-18Merge "Use lombok annotations for tosca, rest, sdnc"Jim Hahn19-101/+28
2021-06-18Merge "Use lombok annotations for actors"Jim Hahn11-81/+46
2021-06-17Use lombok annotations for actorsJim Hahn11-81/+46
This is the last one for policy-models! Issue-ID: POLICY-3396 Change-Id: I05b114a57a720a6ae8ae073b80c8bded36d0d06d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-17Use lombok annotations for aai, appc, appclcm, cdsJim Hahn17-145/+61
Issue-ID: POLICY-3396 Change-Id: I81b6b0c7929809ffaeadadd6144e9b9f394bfdc8 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-17Use lombok annotations for tosca, rest, sdncJim Hahn19-101/+28
Issue-ID: POLICY-3396 Change-Id: I3c9e5ee7ea6da2bab4fe37504d39f7ce63868887 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-17Use lombok annotations for sdnr, simulatorsJim Hahn15-162/+57
Issue-ID: POLICY-3396 Change-Id: I16787f72b0529417c58b9e83a21880baaba92a3d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-17Use lombok annotations for so, vfcJim Hahn27-176/+43
Issue-ID: POLICY-3396 Change-Id: I33781c72dd1c0b9a7a525c23e81c4259fa32384f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-17Add example for policy chainingRam Krishna Verma1-0/+81
Adding example for policy chaining in drools-pdp. This will be later referenced in the documents in upcoming review. Issue-ID: POLICY-3382 Change-Id: If2189422cb7e9ac35fb93e0fd9ae44f1cd412686 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-06-15Replace method parameters with filter parametersJim Hahn8-104/+127
Added more methods taking filter parameters instead of individual method parameters. Removed the old methods. Added genOrderClause(). Issue-ID: POLICY-3094 Change-Id: Ie9d8c13a8d4a7f81e284f07fce3d96a35918a114 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-15Fix sonar in policy/modelsRam Krishna Verma2-3/+5
use "var" for local variables Issue-ID: POLICY-3077 Change-Id: Ia1ea62e03c016d336c9b11b07b0ea941ba905497 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-06-14Fix sonars in policy-modelsJim Hahn13-177/+451
Fixed: - too many parameters in method call Fixed it by introducing PfFilterParameters. However, classes having the Builder annotation are not easily subclassed, so introduced an interface, too. Issue-ID: POLICY-3094 Change-Id: Ida99522a542b1296b367c55b7e8f8e83783c2e4f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-03Merge "Exposing the Audit provider through Models provider."Liam Fallon10-2/+133
2021-06-03Fix junits for new bean validation field namesJim Hahn1-2/+2
Issue-ID: POLICY-3333 Change-Id: I339024677a2d090f61cc55d1b056b832c87d231a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-03Exposing the Audit provider through Models provider.adheli.tavares10-2/+133
Change-Id: I4a3a28b6dbbfbad533a69cf46c545ece7e0b147e Issue-ID: POLICY-2899 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-06-03Merge "Upgrade CDS dependency"Liam Fallon1-52/+5
2021-06-02Merge "Handling Policy deploy/undeploy audit models"Jim Hahn10-8/+842
2021-06-01Upgrade CDS dependencyRashmi Pujar1-52/+5
CDS client libraries are exposed by a different maven module making is much more cleaner to use. The only drawback is we need to go back to older version of grpc-testing artifact due to conflicts. Issue-ID: POLICY-3338 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca> Change-Id: I98c79de7f12feefbae7c42c4c8f26357801b44f9
2021-05-28Merge "No-sonar on the wrong line"Ram Krishna Verma1-2/+2
2021-05-28Merge "Remove policies field from PdpUpdate message"Jim Hahn5-25/+35
2021-05-28No-sonar on the wrong lineJim Hahn1-2/+2
Tried putting NOSONAR comment at the end of the statement, because it seems like checkstyle/sonar doesn't like comments in the middle of a statement. Nonetheless, sonar still reports an issue on the line with the "SELECT" statement, so I guess there's no choice but to move NOSONAR to the end of that line. Issue-ID: POLICY-3094 Change-Id: If26ad0b1e7dcc9c7aa963da10a9c5160a8fe272d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-28Handling Policy deploy/undeploy audit modelsadheli.tavares10-8/+842
Added a new Entity to store information when a Pdp Policy is deployed or undeployed and its create/retrieve methods. Change-Id: I35b3608c878bbfbbee0a99a124d100a48fe08131 Issue-ID: POLICY-2899 Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-05-27Fix more sonars in modelsJim Hahn2-2/+9
Fixed sonars: - SQL injection - use re2j instead of regex Issue-ID: POLICY-3094 Change-Id: I553bd6aa5832d71a5ac33320e2d0d022f9a00e98 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-27Remove policies field from PdpUpdate messagewaynedunican5-25/+35
Issue-ID: POLICY-3323 Change-Id: I14dafe4a20f95e2ebe4279e5b6ae141e2ee4fc48 Signed-off-by: waynedunican <wayne.dunican@est.tech> Signed-off-by: WayneDunican <wayne.dunican@est.tech>
2021-05-24Adjust indexes for Op History tableJim Hahn1-4/+4
Reordered one index to put requestId first, as that should significantly reduce the number of index entries to be examined. Added endtime to another index, which should also reduce the number of index entries to be examined for look-ups by time. Issue-ID: POLICY-2874 Change-Id: I29c10fb9cabb22b3520ed1b14d7fe3fd9db40a15 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-12Fix sonars in policy modelsJim Hahn14-79/+71
Fixed: - a few other "var" cases - use re2j instead of java.util.regex - use correct class for constants - remove unused constants Issue-ID: POLICY-3094 Change-Id: Ifcb2b0623e8df0527f0a279e666d062422978ded Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-11Merge "Fix sonars in policy models"Liam Fallon38-99/+95
2021-05-11Merge "Fix sonars in policy-models impls & simulators"Liam Fallon36-160/+153
2021-05-10Fix sonars in policy modelsJim Hahn38-99/+95
Fixed: - use "var" Issue-ID: POLICY-3094 Change-Id: Id5ea7ab049c2018744afa75a55d44e47f216d5bc Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-10Fix sonars in policy-models impls & simulatorsJim Hahn36-160/+153
Fixed: - use "var" Issue-ID: POLICY-3094 Change-Id: I65da54cae5a58966f21f981c6cea1259bfdf4239 Signed-off-by: Jim Hahn <jrh3@att.com> simulators Change-Id: I1144568485e62e0c72194caaf21ebf1ba88a6fef Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-07Fix sonars in policy-models actorsJim Hahn29-127/+116
Fixed: - use "var" - don't throw generic Exception Issue-ID: POLICY-3094 Change-Id: I020addb9511fd665b5fed48e7d40719e27039224 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-03Merge "Remove GroupValidationResult"Jim Hahn23-161/+96
2021-04-29Remove GroupValidationResultJim Hahn23-161/+96
Removed GroupValidationResult, replacing it with BeanValidationResult. Modified the ParameterGroup subclasses to use BeanValidator, adding annotations where needed to trigger the validations that had been automatically performed by GroupValidationResult. Issue-ID: POLICY-2059 Change-Id: I245e4a647fcbb718faa63a7543f9f81c85da958c Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-27Add correct filter type prefix to queryktimoney7-1/+217
Added unit tests Issue-ID: POLICY-3247 Change-Id: I27474948619b7256a1e504611531eecac15c27c1 Signed-off-by: ktimoney <kevin.timoney@est.tech>
2021-04-26Merge "Add a new key class which uses @GeneratedValue to base classes"Pamela Dragosh17-115/+1031
2021-04-22Add a new key class which uses @GeneratedValue to base classesktimoney17-115/+1031
This will provide an alternative unique key. It will be used in place of PfTimestampKey in the PdpStatistics table. We make use of the @GeneratedValue annotation to provide this feature. Added DummyGeneratedIdEntity and unit tests Added PfFilterFactory class Added new filter classes Issue-ID: POLICY-3189 Change-Id: I097eab318d2cb958e1157e35825fd6d35d429a25 Signed-off-by: ktimoney <kevin.timoney@est.tech>
2021-04-19Refactor CommandLineArguments classesadheli.tavares7-433/+61
All CMD Args simulator classes to extend from CMD class on Common. Fix all unit tests accordingly. Issue-ID: POLICY-3129 Change-Id: If69e432679772df15b06ce7e316c7c876b69773d Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
2021-04-12Close DB in junitsJim Hahn4-42/+70
Modified some of the junits to close the DB. In addition, one of the junits was apparently dependent on a previous test method adding records to the DB, thus the test methods were actually order dependent, even though no annotations were used to enforce the order. Modified that method to insert the data, itself, so the test methods are no longer order dependent. Issue-ID: POLICY-3171 Change-Id: I778c12796340f2a665b4ba00588c823c925c078c Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-08Use distinct names in DB junitsJim Hahn13-21/+30
Junits for models often use the same memory DB name which may leave garbage in the DB from one test to the next. Modified the code to use distinct names for each XxxTest class. Issue-ID: POLICY-3171 Change-Id: I2a4a0b4949d532d6949f5d39396288c54d03688b Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-26Merge "Fix Sonar Issues models-tosca-simple"Jim Hahn9-16/+203
2021-03-26Fix Sonar Issues models-tosca-simplelapentafd9-16/+203
Tests refactoring to reduce number of assertions Issue-ID: POLICY-3094 Change-Id: I8a9a02100e5d103f574cf2cb89d2e924d0f56507 Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2021-03-24Merge "Fix sonar issues for tests in policy-models"Jim Hahn5-116/+141
2021-03-22Merge "Delete keystores from models"Ram Krishna Verma6-5/+10
2021-03-19Fix write failure on PDP statisticsliamfallon16-34/+169
Due to the precision of time stamps being saved to the nearest second, a millisecond precision timestamp was being compared to a second precision timestamp, causing the write to fail. This change fixes that. A unit test is also added to test for this on the provider. In addition, a USE-MARIADB flag is being introduced, which allows unit tests to be run against a locally installed MariaDB instance so that the unit tests can be verified against MariaDB locally rather than H2, the default in Gerrit. Issue-ID: POLICY-3146 Change-Id: I878f160956e89506743dc074679ee81ac1c48216 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-03-19Delete keystores from modelsJim Hahn6-5/+10
The Keystores are no longer needed in the tarballs, as they are supplied externally by the CSITs and Helm charts. Deleted those files. Also modified the junits to use utils-test to generate keystores at runtime, thus deleted the junit keystore file, too. Issue-ID: POLICY-3143 Change-Id: Idd24b735a908476765d40bdcb5c741257edc7bb6 Signed-off-by: Jim Hahn <jrh3@att.com>