summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-04-10Finish unit test on policy-modelsliamfallon46-548/+1175
Unit test coverage well over 90% in policy-models-base policy-models-dao policy-models-pdp policy-models-tosca policy-models-provider Issue-ID: POLICY-1095 Change-Id: I7703e2ae8a93575ca478c3d809ff8c1fb9f0f334 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-09Add unit tests for policy type and policy filtersliamfallon12-10/+834
THis review adds unit tests for the authorative concepts in the models-tosc module and adds unit tests for the authorative and and database providers. Issue-ID: POLICY-1095 Change-Id: If98deea99658056030dd47725b0c0a4266d84106 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-09Merge "Parse new model ids from operational policy"Jorge Hernandez4-55/+122
2019-04-09Parse new model ids from operational policyPamela Dragosh4-55/+122
Companion review to https://gerrit.onap.org/r/#/c/84235/ Copies the required changes into policy/models. Issue-ID: POLICY-1545 Change-Id: I43fec36f60b5409d9e3df9d925de06209c81fd01 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-09Complete unit test for models-pdpliamfallon18-194/+1173
This review completes the unit test for the models-pdp module, for persistence of PDP groups and for PDP group filtering. Added unit test of filters for TOSCA policy types and policies. Added fix to allow filters to pass when the value being checked is null. Issue-ID: POLICY-1095 Change-Id: I982400ef39f0282d813d49e484a58207e03b8a63 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-09Merge "Code changes for OOF SON Use Case"Jorge Hernandez4-2/+274
2019-04-08Code changes for OOF SON Use CasePamela Dragosh4-2/+274
Companian review to https://gerrit.onap.org/r/#/c/84361/ Issue-ID: POLICY-1463 Change-Id: I2640f01c07890a4b1e8938175b637b84dcc19f3c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-08Add lists and tests for PDP filtersliamfallon13-86/+559
The policy type and policy filters for PDP groups are added in this review. Also filter tests for PDP group filter is completed. Issue-ID: POLICY-1095 Change-Id: Ia28776c809f2ab879af4007b3480621637a83f69 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-08Merge "Add bug fixes and tests for filters"Jorge Hernandez18-140/+570
2019-04-08Merge "Remove drools PDP dependency"Jorge Hernandez33-808/+235
2019-04-08Merge "Add PdpMessage.appliesTo()"Pamela Dragosh3-16/+168
2019-04-08Remove drools PDP dependencyPamela Dragosh33-808/+235
Removing working memory and use of PolicyEngine from drools in these classes. Cleaned up some unused imports and checkstyle. Issue-ID: POLICY-1264 Change-Id: Id059da9689a721b0eafc6b310adcbdad43574ce7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-08Add bug fixes and tests for filtersliamfallon18-140/+570
Fixed bugs on filtering where lack of null checks was blocking all results. Added unit test for PDP related JPA objects. Fixed cascading and orphan control on JPA objects. Added partial testing of PdpProvider. Added partial testing of filters. Changed tag for content of operational policies from "Content" to "content". Issue-ID: POLICY-1095 Change-Id: Ieb22e06955a8434b490bae7d0f6b77d4479515e8 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-08Merge "Add unit test for PDP groups"Jorge Hernandez10-70/+909
2019-04-08Merge "Clean up a couple of array lists"Pamela Dragosh3-1/+12
2019-04-08Merge "Add undeploy response to models-pap"Liam Fallon4-3/+38
2019-04-08Add unit test for PDP groupsliamfallon10-70/+909
Unit test for the JPA concepts in models-pdp. Issue-ID: POLICY-1095 Change-Id: Id33626f3789da45e36935edf564003651e9ce7c4 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-07Clean up a couple of array listsJim Hahn3-1/+12
Initialized initial array size for empty list. Add some junit tests to ensure that the returned lists are mutable. Updated license in filter class. Change-Id: I9c151eb50355a71f4d34ac46b41f8278cf913664 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-07Add PdpMessage.appliesTo()Jim Hahn3-16/+168
Added a method to determine if a message is applicable to a particular PDP. This is a common function that should have been added previously, as each PDP type has had to create an implementation of it. Nevertheless, this provides a "reference" implementation. Change-Id: I54073c77a9d2b4c1f902c5ac0bce9fa5fa485503 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-07Merge "Fix bugs on filters"Pamela Dragosh12-60/+374
2019-04-06Guaranteed linear-time latestVersion()Jim Hahn1-13/+18
This is a proposed revision of the latestVersion() method that's guaranteed to be linear time. Still makes use of the slick idea of sorting the list so that items with the same name are adjacent and in order by version. Revised to use an array list, which is more like the original code. Change-Id: If047d4d9630c426c6335f52cb7e5bdda7b6cc0a9 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-06Fix bugs on filtersliamfallon12-60/+374
Filters were not being invoked from providers. Filter for getting latest version was filtering out everything Filter on PDP state was not implemented. Issue-ID: POLICY-1095 Change-Id: If43ce48a57b010e05f75db8cfa80e63f2719ace1 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-05Add unit tests for models-baseliamfallon5-6/+45
Brings coverage in models-base up over 99% Issue-ID: POLICY-1095 Change-Id: Ie1c9f3f132715275f44f349a415a8bb34a0115c9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-05Missed simulator REST call SDNCPamela Dragosh1-0/+21
Forgot this as part of this review: https://gerrit.onap.org/r/#/c/84338/ Issue-ID: POLICY-1264 Change-Id: I8b95cd43b593fd9a79c62b3398a5d44bb7b0c794 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-05Add undeploy response to models-papJim Hahn4-3/+38
Also modified toString() methods on other response classes to invoke the super class' toString() so the error message is printed. Change-Id: I7147da8acd521ed30d40aa6cbf2d8fd43715179b Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-05Merge "Complete filters for Database Fetches"Pamela Dragosh27-86/+440
2019-04-05Complete filters for Database Fetchesliamfallon27-86/+440
This review completes the implementaiton of the filters for fetching policy types, policies, and PDP groups from the database. It also fixes bugs in Policy type creation. Yaml in some of the policy type examples modified so that it is syntatically correct. Proeprties now stored as a blob in DB as they can be big. Issue-ID: POLICY-1095 Change-Id: I6aef88ee2905afa58d778d82832f2b55d794fe9c Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-05remove dependency of drool-application/yaml in actorsning.xi82-3/+15595
Issue-ID: POLICY-1264 Change-Id: Ie89749cf25d6880fd2884eb6935f36f046114b23 Signed-off-by: ning.xi <ning.xi@est.tech>
2019-04-05Merge "move two modules from drools-application to models"Jorge Hernandez21-13/+1587
2019-04-05move two modules from drools-application to modelsning.xi21-13/+1587
Also removed reference to drools logging util. Issue-ID: POLICY-1264 Change-Id: I7795f23b2b06fcb98f4099c3a6c303561a68e55f Signed-off-by: ning.xi <ning.xi@est.tech> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-05Update SDNC changesPamela Dragosh9-20/+314
Per this review: https://gerrit.onap.org/r/#/c/83945/ Copying those changes into policy/models before removal in drools-applications. Issue-ID: POLICY-1264 Change-Id: I151816e78293af813d24ca1164ca364a3c54f87c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-04Updates to models from scrum on 4/4Jim Hahn25-70/+237
Moved ToscaPolicyIdentXxx classes from models-pdp to models-tosca, and added methods to retrieve them from a ToscaPolicy. Removed version and instance fields from PdpStatus. Chose to leave "description" field in the PAP/PDP messages. The PDPs can ignore them or leave them null. In a PdpUpdate message, the description will be the description associated with the PdpGroup. In a PdpStatus message, the PDP could choose to provide a description of the PDP, itself (or the type of PDP). Added comments to that effect. Moved name, group, and subgroup fields into PdpMessage. Fixed typos in comments. Updated licenses. Change "long" to "Long" in PdpUpdate. Use lombok @ToString instead of override. Fixed merge conflict. Change-Id: Icd928f9a7630b838ad4b0b5556e899dc21b7872b Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-04Add filters on policy objectsliamfallon5-7/+169
I just raised this review to shwo where I'm going with the filters. They are not complete yet. Issue-ID: POLICY-1095 Change-Id: I7b602a32bb67159b893f3b3cefea5d88038c4e5f Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-04Merge "Add filter obejcts for concepts"Pamela Dragosh16-359/+355
2019-04-04Merge "Add ApiModelProperty annotation to authorative models"Pamela Dragosh8-6/+27
2019-04-04Add filter obejcts for conceptsliamfallon16-359/+355
This review: - Fixes the bug in getting policies where the key fields were null - Removes complex version checks from DAO interface - Simplifies provider API by introducing filter objects for searches Issue-ID: POLICY-1095 Change-Id: I5ab7471c03e8b61849e7882ed18541acd627dc39 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-03Add ApiModelProperty annotation to authorative modelsChenfei Gao8-6/+27
Add @ApiModelProperty to authorative models for the fields that have different serialized names from their property names. Issue-ID: POLICY-1515 Change-Id: Id6509afe5cc741a6253fc0d1f98ae6b22d31f0d9 Signed-off-by: Chenfei Gao <cgao@research.att.com>
2019-04-03Updating PdpStatistics modelramverma2-47/+4
Change-Id: Ic3ae28997dd1db14c16bdfd24a5d936393fa8da4 Issue-ID: POLICY-1443 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-04-03Merge "Clean up models-pap based on updates to models-pdp"Jorge Hernandez10-376/+2
2019-04-03Merge "Add impl of more PDP persistence"Liam Fallon11-75/+504
2019-04-03Clean up models-pap based on updates to models-pdpJim Hahn10-376/+2
Change-Id: I5e55dd669200e4fc28f58379bbaa61e5d3331610 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-04-03Add impl of more PDP persistenceliamfallon11-75/+504
Add the implementation of more metods in the PDP provider. Issue-ID: POLICY-1095 Change-Id: Ie02189cad7a262a453e1f731190525f838648401 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-03Changing PAP model as per discussionramverma13-128/+83
1) Changing PAP models to use ToscaPolicyIdentifier instead of actual ToscaPolicy itself. 2) Deleting unused PdpHealthCheck message. As we decided to return heath check based on DB state. 3) Updating PdpStatus message to use ToscaPolicyIdentifier instead of actual ToscaPolicy itself. Pdp don't need to send the whole ToscaPolicy everytime in heartbeat to PAP. Instead the identifier is sufficient. Change-Id: I50ead8d8b6af118fd1da08071a2b0fc50584d4aa Issue-ID: POLICY-1443 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-04-03Merge "Add DecisionException"Jorge Hernandez2-0/+54
2019-04-02Add DecisionExceptionPamela Dragosh2-0/+54
Need this class to capture exceptions during decision and setup the ErrorResponse object to return from REST API. Issue-ID: POLICY-1440 Change-Id: I02cd4f93e671c0d543bf527f5de3cf6831f62c40 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-04-02Add persistence for PDP conceptsliamfallon23-90/+1501
This review adds the JPA annotations to PDP group/subgroup and PDP for persisting to the database. It also updates the Provider API as requested by other team members. Issue-ID: POLICY-1095 Change-Id: I8188afb763849ede9680f3751b464d9d76c27196 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-04-02Adding pdpHeartbeatIntervalMs to PdpUpdate messageramverma2-3/+6
Adding pdpHeartbeatIntervalMs to PdpUpdate message. The value of which can be used by Pdp to override its own interval for sending PdpStatus message as heartbeat to PAP. Change-Id: I720713b9b569cf09bf393ac797da29e7f330f8bf Issue-ID: POLICY-1443 Signed-off-by: ramverma <ram.krishna.verma@est.tech>
2019-04-02Merge "Remove pdpType from PdpUpdate"Liam Fallon2-5/+2
2019-04-02Merge "move actors code in drools-applications to policy/models"Pamela Dragosh186-344/+4823
2019-04-02Merge "Add extra methods to Provider interface"Pamela Dragosh10-129/+660