summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-04-10Release policy/models2.2.3jenkins-releng41-41/+41
2020-04-10Point to released parent and commonPamela Dragosh1-2/+2
parent 3.1.2 common 1.6.3 Issue-ID: POLICY-2378 Change-Id: I9cc0b0b8739f3fb017dc5a68584c12af9912bd29 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-04-09Merge "Disable sonar main args for models"Ram Krishna Verma3-1/+14
2020-04-09Merge "SDNR Actor enhancements"Jim Hahn9-222/+179
2020-04-09Disable sonar main args for modelsJim Hahn3-1/+14
Issue-ID: POLICY-2305 Change-Id: Ie8c45fb767ec9b2f9b1b541532fede52306c36b4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08SDNR Actor enhancementsJim Hahn9-222/+179
Made the following changes: - Enhanced SDNR Actor to support any operation name specified within the policy, constructing the same request, but passing a different "RPC name" and "Action" in the request. - Added ControlLoopResponse to OperationOutcome - Modified SDNR Actor to populate ControlLoopResponse Issue-ID: POLICY-2468 Change-Id: I50ee0674077d975f3cd211454656edc47d78520f Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-08More sonar fixes in modelsJim Hahn4-27/+21
Addressed the following sonar issues: - missing assert in junit - duplicate code blocks - fixed those in the simulators - leaving the others in the concept classes for Liam/"G" Issue-ID: POLICY-2305 Change-Id: Icfe80afb378b4cdec4de3d33d0e33227e04845d8 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-07Address sonar issues in modelsJim Hahn41-830/+306
Addressed the following sonar issues: - use RE2 instead of java.util Pattern for "+" and "*" - don't use deprecated methods - for Date(long), sonar appeared not to parse the argument's type correctly. Modified the code slightly to make sonar happy - duplicate blocks of code - either log or throw - missing assert in junit - for SDNR & VFC, eliminated threads, as they are unnecessary - duplicate code block in different branches - useless assignments - redeclaring abstract methods - cyclomatic complexity - used lombok in some cases (e.g., EqualsAndHashCode) - assert argument order - actually deleted ControlLoopTargetType, because it is not needed and sonar complains regardless of which order is used - add private constructor to utility classes - use StandardCharsets instead of literals Also: - added logback-test.xml to SO to eliminate the voluminous output from the junit test Issue-ID: POLICY-2305 Change-Id: I586c331781bedbd54a115a71847d04d293689445 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-06Merge "Models junits are failing locally"Jim Hahn10-134/+135
2020-04-03Models junits are failing locallyJim Hahn11-135/+136
Junits were failing in my local eclipse environment. Fixed the following: - more cases of "is marked @NonNull but is null" (I thought Liam had already fixed all of these, but I'm still seeing errors, so fixed some more) - comparing "Instant" values in event time stamps assumes that the times will be different, but may not be, if the JVM is fast enough. Modified the test to set the times of the new events to Instant+1, to ensure that they are different from the original Issue-ID: POLICY-2305 Change-Id: Ic05bc6a58b559ba589583ce887711ee01f76691c Signed-off-by: Jim Hahn <jrh3@att.com>
2020-04-03Refer io.netty from policy/parentRam Krishna Verma2-5/+3
Issue-ID: POLICY-2467 Change-Id: If06f5fbf26269f7a34104bb2194258494a6488bf Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-04-02change drools op. policies controller namejhh11-14/+14
Issue-ID: POLICY-2465 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I4f6cc6e7d40eb362374e0bef33772ab894b915fb
2020-04-01Set sub request ID before start callbackJim Hahn29-149/+162
Modified new actor code to generate the sub request ID before invoking the start callback. Issue-ID: POLICY-2461 Change-Id: I4adabd6efda2c30c0e2da31f95f01dd5fe546c0a Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-31Fix the policy model metadata for CLAMPsebdet1-1/+1
Fix the metadata section for CDS/operation, there was a mistake in the parameter value Issue-ID: CLAMP-801 Signed-off-by: sebdet <sebastien.determe@intl.att.com> Change-Id: Ic25173dc24874d0877969872f20ad4d8df0703fd
2020-03-30Test new actors against simulatorsJim Hahn34-32/+783
Also modified HttpParams to allow "path" to be blank to support any cases that really have no "path" to append to the context URI base path. Issue-ID: POLICY-2405 Change-Id: I49eebde6759659d2804b5a11c1504c37674bd0c4 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-27Point to latest snapshotPamela Dragosh1-1/+1
Issue-ID: POLICY-2378 Change-Id: I5cd316100ee01b81a3cc59d57095beb6d97d7ec3 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-27Cleanup sonar bugs and security hotspotPamela Dragosh4-7/+7
Just some trivial sonar bugs for missing argument and a couple sonar overrides to clear security hotspots. Issue-ID: POLICY-2165 Change-Id: I392e5fee458465c66313a16a8912e23a3a119848 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-26Discard requests in APPC legacy actorJim Hahn2-1/+9
The new actor for legacy APPC attempts to discard request messages received on the response topic by discarding those that have a null response. Unfortunately, when it decodes them, the Response object creates a status object, even if there isn't one in the json message, thus the test fails and the actor treats it as a failed response. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I26cfb25443ff2ed394781d309f9097d50b8f160b Signed-off-by: Jim Hahn <jrh3@att.com>
2020-03-25Bump models 2.2.3-SNAPSHOTPamela Dragosh42-42/+42
Released 2.2.2 Issue-ID: POLICY-2378 Change-Id: I829f0dfc88aeaf1f9b7efad91c983628f2a5d706 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-25Release models 2.2.2Pamela Dragosh1-0/+4
This includes a change in the Operational Common policy type for CLAMP team via pairwise testing. Issue-ID: POLICY-2378 Change-Id: Ifd0790af8f90a3299c38cfbe4e3f677094c88aa7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-25Merge "Cleanup eclipse warnings"Pamela Dragosh4-52/+32
2020-03-25Change metadata for clampsebdet1-4/+8
Update metadata form clamp in the operational common model, so that it helps the user in the UI. Issue-ID: CLAMP-786 Signed-off-by: sebdet <sebastien.determe@intl.att.com> Change-Id: Ib44391bd58a478558c3881243839b65cf2b1846d
2020-03-25Cleanup eclipse warningsPamela Dragosh4-52/+32
Issue-ID: POLICY-2165 Change-Id: Iaad54af1b1210fe96fa44dcaa609834c46557877 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-24Security fixes for cds actor in policy/modelsRam Krishna Verma1-1/+1
Upgrading io.netty to 4.1.48.Final as the current version has security issues. Issue-ID: POLICY-2442 Change-Id: I5dbfdc7890c85571ef6b6bcc7a9f95310868f6a0 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-03-24Bump policy-models to version 2.2.2-SNAPSHOTliamfallon42-42/+42
Issue-ID: POLICY-2378 Change-Id: I644e45822154f57d2bf6a81e55df07e2e4ca6966 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-23Release models 2.2.1Pamela Dragosh1-0/+4
Releasing for RC0 Issue-ID: POLICY-2378 Change-Id: I9e1c17a966265ddc1f02f9d1225c08a668c3b844 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-23Merge "Add version to compliant operational policies"Pamela Dragosh3-9/+11
2020-03-23Add version to compliant operational policiesjhh3-9/+11
Issue-ID: POLICY-2356 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I5636ec4e92ff87fdefb9a6372a150ad021aeec16 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2020-03-23New Guard actor request structure is incorrectJim Hahn14-128/+71
Missing various fields within the request structure (e.g., ONAPName). Fixed. In the process, also modified makeGuardPayload() so that it only constructs the inner "guard" JSON object, making it easier for invoking code to modify it. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I7d34a279845bb98425caf66565eab7513d310815
2020-03-23Update new SDNR actor with v2.0 structuresJim Hahn15-61/+379
SDNR v2.0 introduced an extra "input" and "output" layer within the body of the messages. Added POJOs to match that, and updated the actor to use the new POJOs so that no extra steps are needed during serialization or deserialization. Also modified the SDNR and APPC-LCM simulators to discard request messages when looking for the response, if the sink and source topics happen to be the same. Added the SDNR simulator. Added more coverage to the SDNR actor. Fixed a sonar issue in the SDNR junit code: - use a constant instead of a literal (i.e., for "ModifyConfig") Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I70914a299dd5e9ee8eaccb5d42a2596cab814091
2020-03-23Merge "Bug fixes in models simulators"Liam Fallon8-36/+112
2020-03-23Merge "Exception not propagated by processResponse"Liam Fallon2-6/+41
2020-03-20Fix legacy APPC handling of RequestJim Hahn2-4/+5
Legacy APPC uses the same topic for both requests and responses. Unfortunately, when the actor sees the request, thinking it's a response, it throws an exception because it can't find the status code. Fixed. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I6137fb21dbf1149ff2faca2407ba69be0de6d40b
2020-03-20Exception not propagated by processResponseJim Hahn2-6/+41
If the topic processResponse() method throws an exception, then the actor/operation is left in an incomplete state. Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I6c5d149d4046fbfb970c8dd831fc3938516d1115
2020-03-20Bug fixes in models simulatorsJim Hahn8-36/+112
Fixed these issues: - topics weren't started - appc topics were reversed - prevent appc simulator from responding to a response (i.e., infinite loop) Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I1f43be72d35f874fec98f48f1a112c055c00eee5
2020-03-20Merge "Add docker file for all simulators"Jim Hahn35-60/+2013
2020-03-20Test cascaded multiple revision getsliamfallon4-80/+776
This patch tests cascaded get requests with multiple revisions. Issue-ID: POLICY-2377 Change-Id: Ie7dc849d7b930b861d38c386a9950ae7e84e2a05 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-20Add docker file for all simulatorsJim Hahn35-60/+2013
Some CSITs may require multiple simulators. This adds a class that will start all of the simulators. A tarball is generated from which a docker image can be built. Added simulators for Topics: appc and appc-lcm. Fixed licenses in files in packages directory. Fixed per review comments: - add version to Dockerfile Issue-ID: POLICY-2434 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: Id7aa9cb5a5874f7b4185273ab0d2c074198554ff
2020-03-20Merge "Point to released common and parent"Liam Fallon1-2/+2
2020-03-20Merge "Misc simple sonar issue fixes"Liam Fallon4-11/+12
2020-03-19Point to released common and parentPamela Dragosh1-2/+2
common 1.6.2 and parent 3.1.1 Issue-ID: POLICY-2378 Change-Id: I668814f6d121db4f22050d2b6d307d5d3743ddf4 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-03-19Misc simple sonar issue fixesChris Ramstad4-11/+12
Issue-ID: POLICY-2389 Signed-off-by: Chris Ramstad <cramstad@ciena.com> Change-Id: I7ce91e331a128aaadaab5ac837e19873a3388164
2020-03-19Add unit test for Version fetch changeliamfallon2-0/+71
Issue-ID: POLICY-2377 Change-Id: Iaad1da84de058fcb50d24663156b4b0bcedd427e Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-19Allow fetch of old policy type verisonsliamfallon5-107/+154
Due to the problems with TOSCA and version handling, the filtering for policy types on old versions did not work. This change fixes that problem. Issue-ID: POLICY-2377 Change-Id: I462bd5710b9dea37475861d1021d28b2c7391a24 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-18Merge "renew policy certs till 03/17/2021"Pamela Dragosh2-0/+0
2020-03-18Return latest entity on null versionsliamfallon3-7/+10
This review amends the behaviour of "get" operations on entities to always return the latest version of an entity when the version of the search key is the null key (value of 0.0.0). Issue-ID: POLICY-2377 Change-Id: I4f7c12637c90bc1a83ce2ba5ef40e15b461a7d51 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-17renew policy certs till 03/17/2021jhh2-0/+0
Issue-ID: POLICY-2402 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I42919180d73058bc78cc70a29a6d5d45823aa9eb
2020-03-16Merge "Consistent returns on Service Template gets"Pamela Dragosh13-166/+700
2020-03-13Consistent returns on Service Template getsliamfallon13-166/+700
This review enables specification of versions of entities on incoming service templates using a ':' delimiter. So this will load version 1.00, version 2.0.0, and version 3.0.0: org.onap.entitiy:1.0.0: version: 1.0.0 org.onap.entity:2.0.0: version: 2.0.0 org.onap.entity version: 3.0.0 So this will load version 1.00, version 2.0.0, and version 4.0.0: org.onap.entitiy:1.0.0: version: 1.0.0 org.onap.entity:2.0.0: version: 2.0.0 org.onap.entity: version: 3.0.0 org.onap.entity: version: 4.0.0 This will load org.onap.entity:1.0.0 name: org.onap.entity version: 1.0.0 This will throw an exception org.onap.entity:1.0.0 name: org.onap.some.other.entity version: 1.0.0 This will throw an exception org.onap.entity:1.0.0: name: org.onap.entity version: 2.0.0 Issue-ID: POLICY-2377 Change-Id: I34bccf065b4ee4d2fe71b052bf009d4a40e2cba8 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-03-13Adding APEX example to policy modelsa.sreekumar1-0/+2896
Change-Id: Idc3da44d99d8d8228a9bc6be49039c2fa02b350e Issue-ID: POLICY-2424 Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>