summaryrefslogtreecommitdiffstats
path: root/models-interactions
diff options
context:
space:
mode:
authorJim Hahn <jrh3@att.com>2021-08-20 16:39:17 -0400
committerJim Hahn <jrh3@att.com>2021-08-20 16:52:14 -0400
commit62c469dc0045e81979ac14aecb105f2150592c3a (patch)
tree11f8e8e25174c4750960a816fd08e071cc748242 /models-interactions
parentf9506fa28790781dbba0cb7ac16e1f19350ea4ef (diff)
Fix sonars in models
Fixed: - use "var" - change constructor to protected - add equals() to subclasses Issue-ID: POLICY-3094 Change-Id: Ia62716b1a740b4475e54e496330f50aa7fb404d7 Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'models-interactions')
-rw-r--r--models-interactions/model-actors/actor.xacml/src/main/java/org/onap/policy/controlloop/actor/xacml/DecisionOperation.java2
-rw-r--r--models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/XacmlSimulatorJaxRs.java2
2 files changed, 2 insertions, 2 deletions
diff --git a/models-interactions/model-actors/actor.xacml/src/main/java/org/onap/policy/controlloop/actor/xacml/DecisionOperation.java b/models-interactions/model-actors/actor.xacml/src/main/java/org/onap/policy/controlloop/actor/xacml/DecisionOperation.java
index 9fbb3e268..0792dc6ea 100644
--- a/models-interactions/model-actors/actor.xacml/src/main/java/org/onap/policy/controlloop/actor/xacml/DecisionOperation.java
+++ b/models-interactions/model-actors/actor.xacml/src/main/java/org/onap/policy/controlloop/actor/xacml/DecisionOperation.java
@@ -53,7 +53,7 @@ public abstract class DecisionOperation extends HttpOperation<DecisionResponse>
* @param config configuration for this operation
* @param propertyNames names of properties required by this operation
*/
- public DecisionOperation(ControlLoopOperationParams params, HttpConfig config,
+ protected DecisionOperation(ControlLoopOperationParams params, HttpConfig config,
List<String> propertyNames) {
super(params, config, DecisionResponse.class, propertyNames);
this.config = (DecisionConfig) config;
diff --git a/models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/XacmlSimulatorJaxRs.java b/models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/XacmlSimulatorJaxRs.java
index 54023f6e5..36964210b 100644
--- a/models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/XacmlSimulatorJaxRs.java
+++ b/models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/XacmlSimulatorJaxRs.java
@@ -71,7 +71,7 @@ public class XacmlSimulatorJaxRs {
return func.apply(req);
}
- DecisionResponse response = new DecisionResponse();
+ var response = new DecisionResponse();
response.setMessage("unsupported action: " + req.getAction());
return response;
}