diff options
author | liamfallon <liam.fallon@est.tech> | 2019-12-10 13:57:32 +0000 |
---|---|---|
committer | liamfallon <liam.fallon@est.tech> | 2019-12-10 13:57:37 +0000 |
commit | 5a366fdab88b7205cedd2ba687109b80dc374544 (patch) | |
tree | 26a98347ddfe39c2c20fad20a487014c1a0f2263 /models-interactions/model-impl/appc | |
parent | db85df62efbf70597d9f7e965f68b77f4ddc1f1f (diff) |
Fix minor checksyle issues in models
New checkstyle profile flagged some minor issues in policy models.
Issue-ID: POLICY-2165
Change-Id: I17ed070a3d55601ad31e48fdfd29fff01d29fa42
Signed-off-by: liamfallon <liam.fallon@est.tech>
Diffstat (limited to 'models-interactions/model-impl/appc')
3 files changed, 7 insertions, 4 deletions
diff --git a/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/CommonHeader.java b/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/CommonHeader.java index 05507e60e..f0419efe9 100644 --- a/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/CommonHeader.java +++ b/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/CommonHeader.java @@ -29,6 +29,7 @@ import java.util.ArrayList; import java.util.Collection; import java.util.Map; import java.util.UUID; + import lombok.Getter; import lombok.Setter; @@ -58,7 +59,9 @@ public class CommonHeader implements Serializable { @SerializedName("Flags") private Collection<Map<String, String>> flags = new ArrayList<>(); - public CommonHeader() {} + public CommonHeader() { + // Default constructor + } /** * Construct an instance from an existing instance. diff --git a/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/util/Serialization.java b/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/util/Serialization.java index 735fb6234..30d4fcb0a 100644 --- a/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/util/Serialization.java +++ b/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/util/Serialization.java @@ -48,7 +48,9 @@ public final class Serialization { // .registerTypeAdapter(ResponseStatus1607.class, new gsonResponseStatus()) .create(); - private Serialization() {} + private Serialization() { + // Private constructor to prevent subclassing + } public static class GsonUtcAdapter implements JsonSerializer<ZonedDateTime>, JsonDeserializer<ZonedDateTime> { private static final Logger logger = LoggerFactory.getLogger(GsonUtcAdapter.class); diff --git a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java index 00ac99de5..3e09bec0a 100644 --- a/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java +++ b/models-interactions/model-impl/appc/src/test/java/org/onap/policy/appc/RequestTest.java @@ -22,10 +22,8 @@ package org.onap.policy.appc; import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotEquals; import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; import java.util.HashMap; import java.util.Map; |