Discard requests in APPC legacy actor

The new actor for legacy APPC attempts to discard request
messages received on the response topic by discarding those
that have a null response.  Unfortunately, when it decodes them,
the Response object creates a status object, even if there isn't
one in the json message, thus the test fails and the actor treats
it as a failed response.

Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I26cfb25443ff2ed394781d309f9097d50b8f160b
Signed-off-by: Jim Hahn <jrh3@att.com>

1 files changed, 6 insertions, 1 deletions

diff --git a/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/Response.java b/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/Response.java
index ae8b76423..fb70151f6 100644
--- a/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/Response.java
+++ b/models-interactions/model-impl/appc/src/main/java/org/onap/policy/appc/Response.java
@@ -38,8 +38,13 @@ public class Response implements Serializable {
     @SerializedName("CommonHeader")
     private CommonHeader commonHeader;
 
+    /**
+     * This should only be populated if the incoming message actually has a "Status"
+     * field. Otherwise, actor.appc will be unable to use this to distinguish between
+     * Request and Response objects.
+     */
     @SerializedName("Status")
-    private ResponseStatus status = new ResponseStatus();
+    private ResponseStatus status;
 
     @SerializedName("Payload")
     private Map<String, Object> payload = new HashMap<>();