Merge "Add Guard Actor"

5 files changed, 234 insertions, 0 deletions

diff --git a/models-interactions/model-actors/actor.guard/src/test/java/org/onap/policy/controlloop/actor/guard/GuardActorServiceProviderTest.java b/models-interactions/model-actors/actor.guard/src/test/java/org/onap/policy/controlloop/actor/guard/GuardActorServiceProviderTest.java
new file mode 100644
index 000000000..f4ab6061e
--- /dev/null
+++ b/models-interactions/model-actors/actor.guard/src/test/java/org/onap/policy/controlloop/actor/guard/GuardActorServiceProviderTest.java
@@ -0,0 +1,41 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP
+ * ================================================================================
+ * Copyright (C) 2020 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.controlloop.actor.guard;
+
+import static org.junit.Assert.assertEquals;
+
+import java.util.Arrays;
+import java.util.stream.Collectors;
+import org.junit.Test;
+
+public class GuardActorServiceProviderTest {
+
+    @Test
+    public void test() {
+        final GuardActorServiceProvider prov = new GuardActorServiceProvider();
+
+        // verify that it has the operators we expect
+        var expected = Arrays.asList(GuardOperation.NAME).stream().sorted().collect(Collectors.toList());
+        var actual = prov.getOperationNames().stream().sorted().collect(Collectors.toList());
+
+        assertEquals(expected.toString(), actual.toString());
+    }
+}
diff --git a/models-interactions/model-actors/actor.guard/src/test/java/org/onap/policy/controlloop/actor/guard/GuardOperationTest.java b/models-interactions/model-actors/actor.guard/src/test/java/org/onap/policy/controlloop/actor/guard/GuardOperationTest.java
new file mode 100644
index 000000000..505106041
--- /dev/null
+++ b/models-interactions/model-actors/actor.guard/src/test/java/org/onap/policy/controlloop/actor/guard/GuardOperationTest.java
@@ -0,0 +1,167 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP
+ * ================================================================================
+ * Copyright (C) 2020 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.controlloop.actor.guard;
+
+import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.concurrent.CompletableFuture;
+import org.junit.Before;
+import org.junit.Test;
+import org.onap.policy.common.utils.coder.CoderException;
+import org.onap.policy.controlloop.actor.test.BasicHttpOperation;
+import org.onap.policy.controlloop.actorserviceprovider.OperationOutcome;
+import org.onap.policy.controlloop.actorserviceprovider.Util;
+import org.onap.policy.controlloop.policy.PolicyResult;
+import org.onap.policy.models.decisions.concepts.DecisionRequest;
+import org.onap.policy.models.decisions.concepts.DecisionResponse;
+
+public class GuardOperationTest extends BasicHttpOperation<DecisionRequest> {
+
+    private GuardOperation oper;
+
+    /**
+     * Sets up.
+     */
+    @Before
+    public void setUp() throws Exception {
+        super.setUp();
+
+        oper = new GuardOperation(params, operator);
+    }
+
+    @Test
+    public void testConstructor() {
+        assertEquals(DEFAULT_ACTOR, oper.getActorName());
+        assertEquals(DEFAULT_OPERATION, oper.getName());
+    }
+
+    @Test
+    public void testStartOperationAsync() throws Exception {
+        CompletableFuture<OperationOutcome> future2 = oper.start();
+        executor.runAll(100);
+        assertFalse(future2.isDone());
+
+        DecisionResponse resp = new DecisionResponse();
+        resp.setStatus(GuardOperation.PERMIT);
+        when(rawResponse.readEntity(String.class)).thenReturn(Util.translate("", resp, String.class));
+
+        verify(client).post(callbackCaptor.capture(), any(), requestCaptor.capture(), any());
+        callbackCaptor.getValue().completed(rawResponse);
+
+        executor.runAll(100);
+        assertTrue(future2.isDone());
+
+        DecisionRequest request = requestCaptor.getValue().getEntity();
+        verifyRequest("makeReqStd.json", request, "requestId");
+
+        assertEquals(PolicyResult.SUCCESS, future2.get().getResult());
+    }
+
+    @Test
+    public void testMakeRequest() throws CoderException {
+        verifyPayload("makeReqStd.json", makePayload());
+        verifyPayload("makeReqDefault.json", new TreeMap<>());
+
+        Map<String, String> payload = new TreeMap<>();
+        payload.put("action", "some action");
+        payload.put("hello", "world");
+        payload.put("r u there?", "yes");
+        payload.put("requestId", "some request id");
+        payload.put("resource.abc", "def");
+        payload.put("resource.ghi", "jkl");
+        payload.put("some.other", "unused");
+
+        verifyPayload("makeReq.json", payload);
+
+        // null payload - start with fresh parameters and operation
+        params = params.toBuilder().payload(null).build();
+        oper = new GuardOperation(params, operator);
+        assertThatIllegalArgumentException().isThrownBy(() -> oper.makeRequest());
+    }
+
+    private void verifyPayload(String expectedJsonFile, Map<String, String> payload) throws CoderException {
+        params.getPayload().clear();
+        params.getPayload().putAll(payload);
+
+        Map<String, Object> requestMap = oper.makeRequest();
+
+        verifyRequest(expectedJsonFile, requestMap, "requestId");
+    }
+
+    @Test
+    public void testPostProcessResponse() {
+        DecisionResponse response = new DecisionResponse();
+
+        // null status
+        response.setStatus(null);
+        verifyOutcome(response, PolicyResult.FAILURE, "response contains no status");
+
+        // permit, mixed case
+        response.setStatus("peRmit");
+        verifyOutcome(response, PolicyResult.SUCCESS, "peRmit");
+
+        // indeterminate, mixed case
+        response.setStatus("inDETerminate");
+        verifyOutcome(response, PolicyResult.SUCCESS, "inDETerminate");
+
+        // deny, mixed case
+        response.setStatus("deNY");
+        verifyOutcome(response, PolicyResult.FAILURE, "deNY");
+
+        // unknown status
+        response.setStatus("unknown");
+        verifyOutcome(response, PolicyResult.FAILURE, "unknown");
+    }
+
+    private void verifyOutcome(DecisionResponse response, PolicyResult expectedResult, String expectedMessage) {
+        oper.postProcessResponse(outcome, BASE_URI, rawResponse, response);
+        assertEquals(expectedResult, outcome.getResult());
+        assertEquals(expectedMessage, outcome.getMessage());
+    }
+
+    @Override
+    protected Map<String, String> makePayload() {
+        DecisionRequest req = new DecisionRequest();
+        req.setAction("my-action");
+        req.setOnapComponent("my-onap-component");
+        req.setOnapInstance("my-onap-instance");
+        req.setOnapName("my-onap-name");
+        req.setRequestId("my-request-id");
+
+        @SuppressWarnings("unchecked")
+        Map<String, String> map = Util.translate("", req, LinkedHashMap.class);
+
+        // add resources
+        map.put(GuardOperation.RESOURCE_PREFIX + "actor", "resource-actor");
+        map.put(GuardOperation.RESOURCE_PREFIX + "operation", "resource-operation");
+
+        return map;
+    }
+}
diff --git a/models-interactions/model-actors/actor.guard/src/test/resources/makeReq.json b/models-interactions/model-actors/actor.guard/src/test/resources/makeReq.json
new file mode 100644
index 000000000..2716d030e
--- /dev/null
+++ b/models-interactions/model-actors/actor.guard/src/test/resources/makeReq.json
@@ -0,0 +1,10 @@
+{
+  "action": "some action",
+  "hello": "world",
+  "r u there?": "yes",
+  "requestId": "abcdefghi",
+  "resource": {
+    "abc": "def",
+    "ghi": "jkl"
+  }
+}
diff --git a/models-interactions/model-actors/actor.guard/src/test/resources/makeReqDefault.json b/models-interactions/model-actors/actor.guard/src/test/resources/makeReqDefault.json
new file mode 100644
index 000000000..9e9df7b22
--- /dev/null
+++ b/models-interactions/model-actors/actor.guard/src/test/resources/makeReqDefault.json
@@ -0,0 +1,5 @@
+{
+  "action": "guard",
+  "requestId": "abcdefghi",
+  "resource": {}
+}
diff --git a/models-interactions/model-actors/actor.guard/src/test/resources/makeReqStd.json b/models-interactions/model-actors/actor.guard/src/test/resources/makeReqStd.json
new file mode 100644
index 000000000..5437ae896
--- /dev/null
+++ b/models-interactions/model-actors/actor.guard/src/test/resources/makeReqStd.json
@@ -0,0 +1,11 @@
+{
+  "ONAPName": "my-onap-name",
+  "ONAPComponent": "my-onap-component",
+  "ONAPInstance": "my-onap-instance",
+  "requestId": "abcdefghi",
+  "action": "my-action",
+  "resource": {
+    "actor": "resource-actor",
+    "operation": "resource-operation"
+  }
+}
\ No newline at end of file