diff options
author | liamfallon <liam.fallon@est.tech> | 2019-11-22 17:28:02 +0000 |
---|---|---|
committer | liamfallon <liam.fallon@est.tech> | 2019-11-27 11:33:51 +0000 |
commit | 996f42812551f874c857fab7fe8d2b24bdc32404 (patch) | |
tree | 3c3b254686512a4373e1cd52de5209e758d48a7f | |
parent | 37bd15efd41962e237575ea0c26728e5040abbe1 (diff) |
Reduce volume of log information on A&AI calls
The AaiManager class is logging all the http requests and responses to
and from A&AI to logger.info, creating a large volume of logging text,
the logging of these messages is now set logger.debug, so they are off
by default but can be enabled for debugging.
Issue-ID: POLICY-2125
Change-Id: I5f9674db0f9e5b271606e7af34d5218f5c629b09
Signed-off-by: liamfallon <liam.fallon@est.tech>
-rw-r--r-- | models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/AaiManager.java | 34 | ||||
-rw-r--r-- | models-interactions/model-impl/aai/src/test/resources/logback-test.xml | 42 |
2 files changed, 61 insertions, 15 deletions
diff --git a/models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/AaiManager.java b/models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/AaiManager.java index eae1dca8e..923b8d329 100644 --- a/models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/AaiManager.java +++ b/models-interactions/model-impl/aai/src/main/java/org/onap/policy/aai/AaiManager.java @@ -148,19 +148,22 @@ public final class AaiManager { logger.debug("RestManager.put after"); if (httpDetails == null) { - logger.info("AAI POST Null Response to {}", url); + NetLoggerUtil.log(EventType.IN, CommInfrastructure.REST, url, "AAI POST Null Response"); + logger.debug("AAI POST Null Response to {}", url); return null; } int httpResponseCode = httpDetails.first; - logger.info(url); - logger.info("{}", httpResponseCode); - logger.info(httpDetails.second); + NetLoggerUtil.log(EventType.IN, CommInfrastructure.REST, url, "Response code: " + httpResponseCode); + NetLoggerUtil.getNetworkLogger().debug(httpDetails.second); + + logger.debug(url); + logger.debug("{}", httpResponseCode); + logger.debug(httpDetails.second); if (httpDetails.second != null) { - String resp = httpDetails.second; - return new AaiCqResponse(resp); + return new AaiCqResponse(httpDetails.second); } return null; } @@ -188,21 +191,22 @@ public final class AaiManager { NetLoggerUtil.getNetworkLogger().info("[OUT|{}|{}|]", CommInfrastructure.REST, urlGet); Pair<Integer, String> httpDetailsGet = restManager.get(urlGet, username, password, headers); if (httpDetailsGet == null) { - logger.info("AAI GET Null Response to {}", urlGet); + NetLoggerUtil.log(EventType.IN, CommInfrastructure.REST, url, "AAI POST Null Response"); + logger.debug("AAI GET Null Response to {}", urlGet); return null; } int httpResponseCode = httpDetailsGet.first; - logger.info(urlGet); - logger.info("{}", httpResponseCode); - logger.info(httpDetailsGet.second); + NetLoggerUtil.log(EventType.IN, CommInfrastructure.REST, url, "Response code: " + httpResponseCode); + NetLoggerUtil.getNetworkLogger().debug(httpDetailsGet.second); + + logger.debug(urlGet); + logger.debug("{}", httpResponseCode); + logger.debug(httpDetailsGet.second); - if (httpResponseCode == 200) { - String responseGet = httpDetailsGet.second; - if (responseGet != null) { - return responseGet; - } + if (httpResponseCode == 200 && httpDetailsGet.second != null) { + return httpDetailsGet.second; } try { Thread.sleep(1000); diff --git a/models-interactions/model-impl/aai/src/test/resources/logback-test.xml b/models-interactions/model-impl/aai/src/test/resources/logback-test.xml new file mode 100644 index 000000000..b5a897433 --- /dev/null +++ b/models-interactions/model-impl/aai/src/test/resources/logback-test.xml @@ -0,0 +1,42 @@ +<!-- + ============LICENSE_START======================================================= + Copyright (C) 2019 Nordix Foundation. + ================================================================================ + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + + SPDX-License-Identifier: Apache-2.0 + ============LICENSE_END========================================================= +--> + +<configuration scan="true" scanPeriod="30 seconds" debug="false"> + + <contextName>ModelImplAai</contextName> + <statusListener class="ch.qos.logback.core.status.OnConsoleStatusListener" /> + <property name="LOG_DIR" value="${java.io.tmpdir}/pf_logging/" /> + + <!-- USE FOR STD OUT ONLY --> + <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> + <encoder> + <Pattern>%d %contextName [%t] %level %logger{36} - %msg%n</Pattern> + </encoder> + </appender> + + <root level="info"> + <appender-ref ref="STDOUT" /> + </root> + + <logger name="org.onap.policy.aai" level="debug" additivity="false"> + <appender-ref ref="STDOUT" /> + </logger> + +</configuration> |