summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJim Hahn <jrh3@att.com>2019-04-01 18:29:16 -0400
committerJim Hahn <jrh3@att.com>2019-04-01 19:11:00 -0400
commit221e242e74ffc3da7d3efc78df3f2d6def0f4c38 (patch)
tree74dee84ed3d9c79e9b9b394149ff3ac23feb8cff
parent0ac03692ecd0fbe69660b1246ca0c1fbac53e623 (diff)
Remove pdpType from PdpUpdate
The pdpType field is redundant; it has the same value as the pdpSubgroup field. Change-Id: Id5cd0c726ffcf73aa82d35eb8cdbf1d7e3c2abc8 Issue-ID: POLICY-1542 Signed-off-by: Jim Hahn <jrh3@att.com>
-rw-r--r--models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpUpdate.java2
-rw-r--r--models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/TestPdpUpdate.java5
2 files changed, 2 insertions, 5 deletions
diff --git a/models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpUpdate.java b/models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpUpdate.java
index c8c8783df..80d4e94bd 100644
--- a/models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpUpdate.java
+++ b/models-pdp/src/main/java/org/onap/policy/models/pdp/concepts/PdpUpdate.java
@@ -40,7 +40,6 @@ import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicy;
public class PdpUpdate extends PdpMessage {
private String name;
- private String pdpType;
private String description;
private String pdpGroup;
private String pdpSubgroup;
@@ -63,7 +62,6 @@ public class PdpUpdate extends PdpMessage {
super(PdpMessageType.PDP_UPDATE);
this.name = source.name;
- this.pdpType = source.pdpType;
this.description = source.description;
this.pdpGroup = source.pdpGroup;
this.pdpSubgroup = source.pdpSubgroup;
diff --git a/models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/TestPdpUpdate.java b/models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/TestPdpUpdate.java
index 5f8819b48..3d4359a7a 100644
--- a/models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/TestPdpUpdate.java
+++ b/models-pdp/src/test/java/org/onap/policy/models/pdp/concepts/TestPdpUpdate.java
@@ -42,7 +42,7 @@ public class TestPdpUpdate {
PdpUpdate orig = new PdpUpdate();
// verify with null values
- assertEquals("PdpUpdate(name=null, pdpType=null, description=null, pdpGroup=null, "
+ assertEquals("PdpUpdate(name=null, description=null, pdpGroup=null, "
+ "pdpSubgroup=null, policies=null)", new PdpUpdate(orig).toString());
// verify with all values
@@ -50,7 +50,6 @@ public class TestPdpUpdate {
orig.setName("my-name");
orig.setPdpGroup("my-group");
orig.setPdpSubgroup("my-subgroup");
- orig.setPdpType("my-type");
ToscaPolicy policy1 = new ToscaPolicy();
policy1.setName("policy-a");
@@ -65,7 +64,7 @@ public class TestPdpUpdate {
PdpUpdate other = new PdpUpdate(orig);
- assertEquals("PdpUpdate(name=my-name, pdpType=my-type, description=my-description, "
+ assertEquals("PdpUpdate(name=my-name, description=my-description, "
+ "pdpGroup=my-group, pdpSubgroup=my-subgroup, policies=["
+ "ToscaPolicy(super=ToscaEntity(name=policy-a, version=1.2.3, derivedFrom=null, "
+ "metadata=null, description=null), type=null, typeVersion=null, properties=null), "