Age | Commit message (Collapse) | Author | Files | Lines |
|
removed / from start of Rest path, hard coded it - resolves code smell issue
small code smell changes regarding passing variables to functions that have access to the variable from its current scope
reintroduced data parameter being passed in MonitoringUtils.js, can look into this more later
fixed pom for parent version, commons step up
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Id8b6a8b41e9b3c2f362821750d3fa728b93336a0
Signed-off-by: mkidd <michael.kidd@est.tech>
|
|
used await method inside an if statement that now runs the same code as the accompanying finally block.
removed unused variables from ApexContextAlbumEditForm.js
refactored vars that were redelared - this was not needed as there were variables of this name within scope
added ! operator
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Idadf4dd6938be5410fef62140de8b265bbaca138
|
|
removed redundant variables that re declared themselves
refactored coded that repeated as a function
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: I14be896ecb8d2f50ee5dc0c61009c6c2cab3e442
|
|
|
|
Issue-ID: POLICY-3069
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: Ie91e60667707df110c53b65fdac8918acb07f6e1
|
|
Addressed the following issues (java only):
- assignment to static field
- expression is always true
- duplicate character in regex
- duplicate code
- remove Thread.sleep() from junit test
Issue-ID: POLICY-3063
Change-Id: I70951ed47defad5baa6c957852663688e51fa88a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Update dependencies in gui-pdp-monitoring and gui-editor-apex to align with Node version. Deprecated dependencies removed.
Issue-ID: POLICY-2886
Change-Id: I62137b85d8ca56cd2cdeeeae5ee62ed18b5306ee
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
When we upgrade to oparent, these will fail as oparent upgrades
to 8.37 of puppycrawl which fixes a few bugs that should have
flagged these previously.
Issue-ID: POLICY-2887
Change-Id: Iaf0cf4966efc8655a2ea78d9b607ab0df91dd56b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The node.js code and repos are used only during unit test and should not
be included in the released artifacts. Not having them in the released
artifacts also eliminates a number of security and licensing issues with
node.js modules.
Issue-ID: POLICY-2825
Change-Id: Icb9c0a0e3d1ebb01aa9b6346ce51f0c76c5cdd0f
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
JavaScript tests added to improve code coverage for policy-gui
Issue-ID: POLICY-2783
Change-Id: Ie12fb6089b872842bb5c668a8126675f89772d79
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Edited SonarCloud lcov reports path. Removed from pdp-monitoring
pom.xml. Added node binary source executable path and sources sonar
properties to pom.xml.
Issue-ID: POLICY-2610
Change-Id: I6354e65d358ca5e9bd8c18f032330aa5063a0889
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Moved the generated Jest Coverage report from policy-gui/gui-pdp-monitoring/src/webapp/coverage to policy-gui/target/code-coverage in order for SonarCloud to display the JS Code Coverage results.
Issue-ID: POLICY-2610
Change-Id: I1d86203afa45ad1b0a51d729fec4326607585988
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Added to pom.xml for SonarCloud to point to lcov reports generated by Jest coverage.
Issue-ID: POLICY-2610
Change-Id: I2954517cb0b91d8e43e3c2065f4776258e391cea
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Jest JS Coverage setup
1) Generate coverage in reports/test-reporter.xml and in
coverage/clover.xml
2) Config needed in SonarCloud project itself to pick up these reports
Issue-ID: POLICY-2610
Change-Id: I1b639ff649cd6eb690762420118b3e8f595e970b
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
This review moves the code for the apex policy editor from the apex repo
to the GUI repo.
The docker part of the build will be moved in the next review because it
is intertwined with the other two legacy apex GUIs and needs to be
disentangled.
Subsequent reviews on the apex repo will remove this code from there.
Issue-ID: POLICY-2621
Change-Id: Ib9a43f463b839201656208a48ab48869a19f963a
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
policy-gup goes to 2.1.0-SNAPSHOT
Issue-ID: POLICY-2621
Change-Id: I660c7537a2e56ce2c6f8788cbc142c1680e53465
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2188
Change-Id: I87701431e5f5c248ed7240eb5cdb7ca0682434c1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2311
Change-Id: I1961d9fac8c1a11e599034ed2c6cf8f1c4a799ee
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
|
|
Issue-ID: POLICY-2311
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: I031a1498fa79f7c8cdebce45689aa75d3c6b1efa
|
|
Issue-ID: POLICY-2311
Change-Id: I12a041f59bf07ed4e8688545522e64a338cdb326
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
|
|
|
|
(1) Use frontend-maven-plugin to integrate frontend development
(2) Use jest as test tool
(3) Use webpack to create webapp bundle
(4) Coverage data is saved in target/jscoverage
Issue-ID: POLICY-2311
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: I34fb7487c1e0ca29114eb7accba8bb7c4812da34
|
|
Testing these with openpojos should get code coverage above
55%.
Issue-ID: POLICY-2420
Change-Id: I9e7ef6f42f04d5c9f090f9b6cd305950a8180f3c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Monitorning GUI to monitor PDPs Statistics, including
Web and Rest Server by embeded jetty.
Issue-ID: POLICY-2311
Signed-off-by: Hengye <yehui.wang@est.tech>
Change-Id: I9bd0d50eaa7ae4dbd07d17389da2cf107e854c61
|