summaryrefslogtreecommitdiffstats
path: root/gui-editors/gui-editor-apex
AgeCommit message (Collapse)AuthorFilesLines
2021-06-14Fix sonar in policy/guiRam Krishna Verma5-11/+14
use "var" for local variables Issue-ID: POLICY-3077 Change-Id: I6e31317bfda3d2b9bdde038cec709a3398f2f655 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-06-04Merge "Increase code coverage on gui.editors.apex.rest"Liam Fallon9-1/+613
2021-06-03Increase code coverage on gui.editors.apex.restarkadiusz.adamski9-1/+613
- increase code coverage on gui.editors.apex.rest Issue-ID: POLICY-3351 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: I481ecea3b77ec4e7b7fbdd0475becec0ccea11dc
2021-05-28Merge "React Front-End UI"Jim Hahn1-1/+1
2021-05-27React Front-End UIbrunomilitzer1-1/+1
This commit is to move the React front end files from the Clamp Policy Repo to the Onap Gui Policy Repo. Also created the added Maven featue to compile the React project via Node and NPM, and copy the production files to the target directory. Fixed in gitignore that was ignoring the contents inside the logs/ directory. Reformated JS spacing files from 4 spaces to 2 spaces. Fixed Broken JEST test Applied Jim's Code Review as well updated Node Version from 12.18 to 14.17 accross the modules. Unfortunately cannot apply NPM version since it broke npm install. Fixed ONAP Job Builder Linting Error Applied Jim's Second Code Review Issue-ID: POLICY-3218 Signed-off-by: brunomilitzer <bruno.militzer@est.tech> Change-Id: I01f95c350d27d72f941c835592fd596472601d6e
2021-05-20gui-editor-apex doesn't contain webapp correctlyarkadiusz.adamski1-1/+6
- change location of css, js and html files in jar. Issue-ID: POLICY-3322 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: I712e84cc3a923bdfd6f7857afec914a37f47a54d
2021-05-10Fix sonars in policy-guiJim Hahn16-71/+70
Fixed: - use "var" Only fixed the ones I saw visually, as SonarLint wouldn't run - something about missing node.js. Issue-ID: POLICY-3094 Change-Id: I594d424b42ce446d86724d75b1dd9ec868c14f2b Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-23Fix gui-editor-apex fails to startarkadiusz.adamski1-22/+26
- fix NullPointerException when gui-editor is started with command line - clean up code Issue-ID: POLICY-3235 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: Ia05a4a808c3fa266e702f627959a382b0344f5db
2021-04-13Update version of maven resources pluginJim Hahn1-26/+12
Policy parent specifies a newer version of the maven resources plugin. Modified the pom to work with it. According to the docs, copy-resources is only needed when copying from directories outside of src/main/resources. Issue-ID: POLICY-3182 Change-Id: Icb125914dd0fc15a9b2da4290b7e06338a0fae4a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-12Use alternate repo for npmJim Hahn1-1/+3
Also updated version of npm, as 6.14.4 does not appear within the repo. Issue-ID: POLICY-3182 Change-Id: I61ec07ad525d165828bb7c97af00bb740d939cc3 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-29Fix sonarqube code Bugmkidd3-10/+8
ApexEditorParameters has a URI that sonar does not like, hard coding the leading forward slash removes the complaint ApexEditorMain was receiving args and a print stream in the form of System.err and then System.out, both of these were null values, while Sonar sees System.out or err as a bug as it should be a logger, simply passing null in its place is not an issue to sonar BeanBase.java Removed an if statement that always asserted to be true, as it is inside an if statement that confirmed that condition. removed an accessibility change as sonar sees this as a violation Issue-ID: POLICY-3095 Signed-off-by: mkidd <michael.kidd@est.tech> Change-Id: I1bbdfe9cc6db085195e95da3dbfbc8b29d9a5ff5 Signed-off-by: mkidd <michael.kidd@est.tech>
2021-03-25Fix sonarqube code smellsmkidd18-135/+108
Making changed regarding code smells. Some variables being declared twice while in scope. renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name. renamed some of the for loop control variables so that sonarqube doesnt see it as an issue Made changes based on reviews Issue-ID: POLICY-3095 Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993 Signed-off-by: mkidd <michael.kidd@est.tech>
2021-03-12Fix tests code smells - less assertions per testmkidd1-16/+204
ApexEditorRestResourceTest.java - separate test methods into smaller methods so that less assertions are made per method Issue-ID: POLICY-3095 Change-Id: Ic7f54916a130dbb403102dec51e6e2fec708f0cf Signed-off-by: mkidd <michael.kidd@est.tech>
2021-03-03fix code smells and vulnerabilitiesmkidd1-13/+7
used await method inside an if statement that now runs the same code as the accompanying finally block. removed unused variables from ApexContextAlbumEditForm.js refactored vars that were redelared - this was not needed as there were variables of this name within scope added ! operator Issue-ID: POLICY-3095 Signed-off-by: mkidd <michael.kidd@est.tech> Change-Id: Idadf4dd6938be5410fef62140de8b265bbaca138
2021-02-19Fix sonars in guiJim Hahn9-136/+46
Addressed the following issues (java only): - assignment to static field - expression is always true - duplicate character in regex - duplicate code - remove Thread.sleep() from junit test Issue-ID: POLICY-3063 Change-Id: I70951ed47defad5baa6c957852663688e51fa88a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-19Fix policy-gui build failureswaynedunican1-0/+1
maven-resources-plugin has been updated to v3.2.0. This is causing our gui build to fail, due to it not allowing more than a certain number of files to be copied. Reverted to v3.1.0 in apex-editor to fix this issue. Issue-ID: POLICY-3063 Change-Id: I7b8a207f63de82ed44747c5d2c470b5345cb84c6 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-11-09Update dependencies in policy/guiwaynedunican2-4/+6
Update dependencies in gui-pdp-monitoring and gui-editor-apex to align with Node version. Deprecated dependencies removed. Issue-ID: POLICY-2886 Change-Id: I62137b85d8ca56cd2cdeeeae5ee62ed18b5306ee Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-10-02JS Testing added for apex-editorwaynedunican55-530/+1527
Last apex-editor/pom.xml change to exclude the /dist folder Issue-ID: POLICY-2783 Change-Id: I076aac4e503c7e5f2ea39fa9291153be4b119808 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-09-30Pick up userId from apex editor URLliamfallon3-3/+9
The userId must be picked up from the URL passed to the policy editor and then passed to the server. Issue-ID: POLICY-2850 Change-Id: I98948f2e0a2bf8090926751ee98c26c46d272fcf Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-16Exclude unit test files from released artifactsliamfallon3-11062/+20
The node.js code and repos are used only during unit test and should not be included in the released artifacts. Not having them in the released artifacts also eliminates a number of security and licensing issues with node.js modules. Issue-ID: POLICY-2825 Change-Id: Icb9c0a0e3d1ebb01aa9b6346ce51f0c76c5cdd0f Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-11Add TOSCA support to Apex editorliamfallon45-3362/+1960
The APEX editor now loads, saves, and downloads files in TOSCA format, the same as the apex-pdp does. The non-standard TOSCA handling for file upload has been refactored to be aligned with the Policy Frameowkr TOSCA support. Issue-ID: POLICY-2621 Change-Id: I1ec7475cbcc6ffc23de92687c9f284ac7dfbdd80 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-08Merge "Cosmetic changes to the apex-editor GUI"Ram Krishna Verma7-51/+38
2020-09-08Cosmetic changes to the apex-editor GUIliamfallon7-51/+38
Some minor changes to remove some eclipse warnings and to tidy the the tets and formatting in the APEX policy editor GUI. Issue-ID: POLICY-2621 Change-Id: Ib9b9b054fbe146feec4e477434097094e8ecae26 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-07JavaScript tests for apex-editorwaynedunican26-10/+11541
JavaScript tests added to improve code coverage for policy-gui Issue-ID: POLICY-2783 Change-Id: Ie12fb6089b872842bb5c668a8126675f89772d79 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-08-10Passing userId to upload policyKrupaNagabhushan6-21/+59
Issue-ID: POLICY-2751 Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech> Change-Id: Ifc91bba369161a63f2ad759dcdc014bb12837e88
2020-08-07Upload policy featureandre.schmid56-16/+4595
Implements an upload feature that can be enable/disabled through configuration properties. An upload endpoint must be provided also by configuration. The upload has similar feature as the download, but it sends the file to the provided endpoint instead, converting it to TOSCA YAML. Creates an configuration endpoint so the front-end can read it. Introduces a pub/sub feature in the front-end so it can asynchronous read configuration information and send configuration ready message to components that depends on it. Issue-ID: POLICY-2751 Signed-off-by: andre.schmid <andre.schmid@est.tech> Change-Id: I5e8e91616a7d4dc69e6739604fcd36528cce0028
2020-07-20Make APEX policy editor run as a single jarandre.schmid3-1/+43
Fix missing jquery library and produces an executable jar Issue-ID: POLICY-2721 Signed-off-by: andre.schmid <andre.schmid@est.tech> Change-Id: I66e10326e6348807384caae706e1286835e97b63
2020-07-17Move apex policy editor to policy-guiliamfallon513-0/+52334
This review moves the code for the apex policy editor from the apex repo to the GUI repo. The docker part of the build will be moved in the next review because it is intertwined with the other two legacy apex GUIs and needs to be disentangled. Subsequent reviews on the apex repo will remove this code from there. Issue-ID: POLICY-2621 Change-Id: Ib9a43f463b839201656208a48ab48869a19f963a Signed-off-by: liamfallon <liam.fallon@est.tech>