aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-04-23Fix gui-editor-apex fails to startarkadiusz.adamski1-22/+26
- fix NullPointerException when gui-editor is started with command line - clean up code Issue-ID: POLICY-3235 Signed-off-by: arkadiusz.adamski <aadamski@est.tech> Change-Id: Ia05a4a808c3fa266e702f627959a382b0344f5db
2021-04-15Address plugin-not-found issuesJim Hahn1-31/+0
Removed references to archetype-packaging and lifecycle-mapping, where unnecessary due to pom inheritance. Issue-ID: POLICY-3136 Change-Id: Iae3278accea933a18224f10b63a01658948b39db Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-13Update version of maven resources pluginJim Hahn1-26/+12
Policy parent specifies a newer version of the maven resources plugin. Modified the pom to work with it. According to the docs, copy-resources is only needed when copying from directories outside of src/main/resources. Issue-ID: POLICY-3182 Change-Id: Icb125914dd0fc15a9b2da4290b7e06338a0fae4a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-12Use alternate repo for npmJim Hahn2-2/+6
Also updated version of npm, as 6.14.4 does not appear within the repo. Issue-ID: POLICY-3182 Change-Id: I61ec07ad525d165828bb7c97af00bb740d939cc3 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-04-08Upgrade dependencies in guiJim Hahn1-4/+4
The gui builds are failing, because the policy dependencies cannot be found. Upgraded the dependency versions to the latest policy snapshots. Issue-ID: POLICY-3180 Change-Id: Id90addb5a15bbdaa4842c1751ac0022f38417e49 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-03-29Fix sonarqube code Bugmkidd3-10/+8
ApexEditorParameters has a URI that sonar does not like, hard coding the leading forward slash removes the complaint ApexEditorMain was receiving args and a print stream in the form of System.err and then System.out, both of these were null values, while Sonar sees System.out or err as a bug as it should be a logger, simply passing null in its place is not an issue to sonar BeanBase.java Removed an if statement that always asserted to be true, as it is inside an if statement that confirmed that condition. removed an accessibility change as sonar sees this as a violation Issue-ID: POLICY-3095 Signed-off-by: mkidd <michael.kidd@est.tech> Change-Id: I1bbdfe9cc6db085195e95da3dbfbc8b29d9a5ff5 Signed-off-by: mkidd <michael.kidd@est.tech>
2021-03-25Fix sonarqube code smellsmkidd18-135/+108
Making changed regarding code smells. Some variables being declared twice while in scope. renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name. renamed some of the for loop control variables so that sonarqube doesnt see it as an issue Made changes based on reviews Issue-ID: POLICY-3095 Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993 Signed-off-by: mkidd <michael.kidd@est.tech>
2021-03-12Fix tests code smells - less assertions per testmkidd1-16/+204
ApexEditorRestResourceTest.java - separate test methods into smaller methods so that less assertions are made per method Issue-ID: POLICY-3095 Change-Id: Ic7f54916a130dbb403102dec51e6e2fec708f0cf Signed-off-by: mkidd <michael.kidd@est.tech>
2021-03-11Merge "fix code smells and vulnerabilities monitoring"Liam Fallon3-8/+8
2021-03-10fix code smells and vulnerabilities monitoringmkidd4-11/+11
removed / from start of Rest path, hard coded it - resolves code smell issue small code smell changes regarding passing variables to functions that have access to the variable from its current scope reintroduced data parameter being passed in MonitoringUtils.js, can look into this more later fixed pom for parent version, commons step up Issue-ID: POLICY-3095 Signed-off-by: mkidd <michael.kidd@est.tech> Change-Id: Id8b6a8b41e9b3c2f362821750d3fa728b93336a0 Signed-off-by: mkidd <michael.kidd@est.tech>
2021-03-10pom file changes for snapshotmkidd1-3/+3
pointed parent to 3.3.1-SNAPSHOT pointed policy.common to 1.8.1-SNAPSHOT pointed policy.models to 2.4.2-SNAPSHOT Issue-ID: POLICY-3095 Signed-off-by: mkidd <michael.kidd@est.tech> Change-Id: Ic5ebe398abb289c7fba6e8de14bf5d11a5c0e449 Signed-off-by: mkidd <michael.kidd@est.tech>
2021-03-03fix code smells and vulnerabilitiesmkidd2-15/+11
used await method inside an if statement that now runs the same code as the accompanying finally block. removed unused variables from ApexContextAlbumEditForm.js refactored vars that were redelared - this was not needed as there were variables of this name within scope added ! operator Issue-ID: POLICY-3095 Signed-off-by: mkidd <michael.kidd@est.tech> Change-Id: Idadf4dd6938be5410fef62140de8b265bbaca138
2021-03-03fix bugs in MonitoringChart.jsmkidd1-46/+33
removed redundant variables that re declared themselves refactored coded that repeated as a function Issue-ID: POLICY-3095 Signed-off-by: mkidd <michael.kidd@est.tech> Change-Id: I14be896ecb8d2f50ee5dc0c61009c6c2cab3e442
2021-02-24Update info.yaml in guiRam Krishna Verma1-2/+2
Issue-ID: POLICY-3028 Change-Id: I1e2fcc49f28a8fe620f39326dbe820bfc993e4da Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-02-22Merge "Refactor Policy-Gui to use Instant from Date"Jim Hahn1-3/+3
2021-02-19Refactor Policy-Gui to use Instant from Daterameshiyer271-3/+3
Issue-ID: POLICY-3069 Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech> Change-Id: Ie91e60667707df110c53b65fdac8918acb07f6e1
2021-02-19Fix sonars in guiJim Hahn11-142/+79
Addressed the following issues (java only): - assignment to static field - expression is always true - duplicate character in regex - duplicate code - remove Thread.sleep() from junit test Issue-ID: POLICY-3063 Change-Id: I70951ed47defad5baa6c957852663688e51fa88a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-02-19Fix policy-gui build failureswaynedunican1-0/+1
maven-resources-plugin has been updated to v3.2.0. This is causing our gui build to fail, due to it not allowing more than a certain number of files to be copied. Reverted to v3.1.0 in apex-editor to fix this issue. Issue-ID: POLICY-3063 Change-Id: I7b8a207f63de82ed44747c5d2c470b5345cb84c6 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-11-09Merge "Update dependencies in policy/gui"Jim Hahn4-9/+13
2020-11-09Update dependencies in policy/guiwaynedunican4-9/+13
Update dependencies in gui-pdp-monitoring and gui-editor-apex to align with Node version. Deprecated dependencies removed. Issue-ID: POLICY-2886 Change-Id: I62137b85d8ca56cd2cdeeeae5ee62ed18b5306ee Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-11-06Fix upcoming checkstyle issuesPamela Dragosh1-1/+1
When we upgrade to oparent, these will fail as oparent upgrades to 8.37 of puppycrawl which fixes a few bugs that should have flagged these previously. Issue-ID: POLICY-2887 Change-Id: Iaf0cf4966efc8655a2ea78d9b607ab0df91dd56b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-27Point to snapshot versionsJim Hahn1-3/+3
Issue-ID: POLICY-2875 Change-Id: I2fe7e65beaaab70c888e258b2d45ce91d1339423 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-10-20Point gui to models 2.3.6 SNAPSHOTPamela Dragosh1-1/+1
Issue-ID: POLICY-2869 Change-Id: Ie8787c6d906043a063bc862cdb59986c58a57e4a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-07Point to latest models snapshot 2.3.3Pamela Dragosh1-1/+1
Issue-ID: POLICY-2839 Change-Id: Ifdf4be2ee15af8cde32bbbbac0dd0a5e7244ab25 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-10-02JS Testing added for apex-editorwaynedunican56-531/+1528
Last apex-editor/pom.xml change to exclude the /dist folder Issue-ID: POLICY-2783 Change-Id: I076aac4e503c7e5f2ea39fa9291153be4b119808 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-09-30Pick up userId from apex editor URLliamfallon3-3/+9
The userId must be picked up from the URL passed to the policy editor and then passed to the server. Issue-ID: POLICY-2850 Change-Id: I98948f2e0a2bf8090926751ee98c26c46d272fcf Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-24Point to latest SNAPSHOTSPamela Dragosh1-2/+2
Issue-ID: POLICY-2789 Change-Id: Ia696e3a7336e8ff12804d5c2e04d3996e5aadcdf Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-09-16Exclude unit test files from released artifactsliamfallon5-25224/+24
The node.js code and repos are used only during unit test and should not be included in the released artifacts. Not having them in the released artifacts also eliminates a number of security and licensing issues with node.js modules. Issue-ID: POLICY-2825 Change-Id: Icb9c0a0e3d1ebb01aa9b6346ce51f0c76c5cdd0f Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-11Add TOSCA support to Apex editorliamfallon45-3362/+1960
The APEX editor now loads, saves, and downloads files in TOSCA format, the same as the apex-pdp does. The non-standard TOSCA handling for file upload has been refactored to be aligned with the Policy Frameowkr TOSCA support. Issue-ID: POLICY-2621 Change-Id: I1ec7475cbcc6ffc23de92687c9f284ac7dfbdd80 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-08Merge "Cosmetic changes to the apex-editor GUI"Ram Krishna Verma7-51/+38
2020-09-08Merge "JavaScript tests for apex-editor"Jim Hahn27-11/+11542
2020-09-08Cosmetic changes to the apex-editor GUIliamfallon7-51/+38
Some minor changes to remove some eclipse warnings and to tidy the the tets and formatting in the APEX policy editor GUI. Issue-ID: POLICY-2621 Change-Id: Ib9b9b054fbe146feec4e477434097094e8ecae26 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-09-07JavaScript tests for apex-editorwaynedunican27-11/+11542
JavaScript tests added to improve code coverage for policy-gui Issue-ID: POLICY-2783 Change-Id: Ie12fb6089b872842bb5c668a8126675f89772d79 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-09-04Use released parent 3.2.0 in guiJim Hahn1-1/+1
Issue-ID: POLICY-2789 Change-Id: Id81b09c0b0c8b0d088f1b813cb0858d28236d4d5 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-08-25Jest JS Coveragewaynedunican4-4/+16
Edited SonarCloud lcov reports path. Removed from pdp-monitoring pom.xml. Added node binary source executable path and sources sonar properties to pom.xml. Issue-ID: POLICY-2610 Change-Id: I6354e65d358ca5e9bd8c18f032330aa5063a0889 Signed-off-by: waynedunican <wayne.dunican@est.tech> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2020-08-19JS Coverage Report directorywaynedunican2-1/+3
Moved the generated Jest Coverage report from policy-gui/gui-pdp-monitoring/src/webapp/coverage to policy-gui/target/code-coverage in order for SonarCloud to display the JS Code Coverage results. Issue-ID: POLICY-2610 Change-Id: I1d86203afa45ad1b0a51d729fec4326607585988 Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-08-18Merge "JavaScript coverage SonarCloud"Jim Hahn1-1/+1
2020-08-18JavaScript coverage SonarCloudwaynedunican1-1/+1
Added to pom.xml for SonarCloud to point to lcov reports generated by Jest coverage. Issue-ID: POLICY-2610 Change-Id: I2954517cb0b91d8e43e3c2065f4776258e391cea Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-08-10Passing userId to upload policyKrupaNagabhushan6-21/+59
Issue-ID: POLICY-2751 Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech> Change-Id: Ifc91bba369161a63f2ad759dcdc014bb12837e88
2020-08-10Merge "Upload policy feature"Ajith Sreekumar56-16/+4595
2020-08-07Upload policy featureandre.schmid56-16/+4595
Implements an upload feature that can be enable/disabled through configuration properties. An upload endpoint must be provided also by configuration. The upload has similar feature as the download, but it sends the file to the provided endpoint instead, converting it to TOSCA YAML. Creates an configuration endpoint so the front-end can read it. Introduces a pub/sub feature in the front-end so it can asynchronous read configuration information and send configuration ready message to components that depends on it. Issue-ID: POLICY-2751 Signed-off-by: andre.schmid <andre.schmid@est.tech> Change-Id: I5e8e91616a7d4dc69e6739604fcd36528cce0028
2020-08-06Merge "Jest JS Coverage setup"Ram Krishna Verma4-975/+4898
2020-08-05Jest JS Coverage setupwaynedunican4-975/+4898
Jest JS Coverage setup 1) Generate coverage in reports/test-reporter.xml and in coverage/clover.xml 2) Config needed in SonarCloud project itself to pick up these reports Issue-ID: POLICY-2610 Change-Id: I1b639ff649cd6eb690762420118b3e8f595e970b Signed-off-by: waynedunican <wayne.dunican@est.tech>
2020-07-30Update info yaml in policy/guiRam Krishna Verma1-12/+16
Issue-ID: POLICY-2738 Change-Id: If374565c4a213c17785277325e58769940aaab41 Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2020-07-27Add default branch to gitreview for policy/guiJim Hahn1-0/+1
Issue-ID: POLICY-2741 Change-Id: If1e8c31bed56b369bd060e0457aa795ae6b63161 Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-24Add Ajith to policy/gui infoJim Hahn1-6/+14
Issue-ID: POLICY-2738 Change-Id: I2904591da8dcde2fdff622c8ca64ae96712b145d Signed-off-by: Jim Hahn <jrh3@att.com>
2020-07-20Make APEX policy editor run as a single jarandre.schmid3-1/+43
Fix missing jquery library and produces an executable jar Issue-ID: POLICY-2721 Signed-off-by: andre.schmid <andre.schmid@est.tech> Change-Id: I66e10326e6348807384caae706e1286835e97b63
2020-07-17Move apex policy editor to policy-guiliamfallon516-2/+52483
This review moves the code for the apex policy editor from the apex repo to the GUI repo. The docker part of the build will be moved in the next review because it is intertwined with the other two legacy apex GUIs and needs to be disentangled. Subsequent reviews on the apex repo will remove this code from there. Issue-ID: POLICY-2621 Change-Id: Ib9a43f463b839201656208a48ab48869a19f963a Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-07-17Bump version of policy-gui for GUILINliamfallon4-6/+6
policy-gup goes to 2.1.0-SNAPSHOT Issue-ID: POLICY-2621 Change-Id: I660c7537a2e56ce2c6f8788cbc142c1680e53465 Signed-off-by: liamfallon <liam.fallon@est.tech>
2020-07-14Pointing to latest snapshotsPamela Dragosh1-4/+4
Other snapshots will be deleted by LF in less than 20 days. Updated license header, git log shows only 2020 for this pom.xml existing. Issue-ID: POLICY-2695 Change-Id: Ia1834a1c9d22b53f690271a1a5a8c563fa1d429f Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>