Age | Commit message (Collapse) | Author | Files | Lines |
|
Added in header, using existing styling
Integrated with existing FE
Issue-ID: POLICY-3222
Change-Id: I5b6a9f4be3296b2969baa559a7a48c87d2ab9258
Signed-off-by: saul.gill <saul.gill@est.tech>
|
|
According to a Diff differences from one repo to the other, there was some missing changes from the original clamp repo to the policy gui repo.
Issue-ID: POLICY-3267
Change-Id: I9a71841732dc5c3d9623bca9c1384866f4c826a6
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
|
|
|
|
- increase code coverage on gui.editors.apex.rest
Issue-ID: POLICY-3351
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I481ecea3b77ec4e7b7fbdd0475becec0ccea11dc
|
|
Issue-ID: POLICY-3325
Change-Id: Ie3d1ee46c9ac351ba9438b4b0a2bcaa47486d7ac
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
|
|
|
|
This commit is to move the React front end files from the Clamp Policy Repo to the Onap Gui Policy Repo.
Also created the added Maven featue to compile the React project via Node and NPM, and copy the production files to the target directory.
Fixed in gitignore that was ignoring the contents inside the logs/ directory.
Reformated JS spacing files from 4 spaces to 2 spaces.
Fixed Broken JEST test
Applied Jim's Code Review as well updated Node Version from 12.18 to 14.17 accross the modules. Unfortunately cannot apply NPM version since it broke npm install.
Fixed ONAP Job Builder Linting Error
Applied Jim's Second Code Review
Issue-ID: POLICY-3218
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
Change-Id: I01f95c350d27d72f941c835592fd596472601d6e
|
|
- change location of css, js and html files in jar.
Issue-ID: POLICY-3322
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I712e84cc3a923bdfd6f7857afec914a37f47a54d
|
|
|
|
Issue-ID: POLICY-3218
Change-Id: Icc74332c71b69a059178985b5b63b3bfff7ff956
Signed-off-by: brunomilitzer <bruno.militzer@est.tech>
|
|
Fixed:
- use "var"
Only fixed the ones I saw visually, as SonarLint wouldn't run -
something about missing node.js.
Issue-ID: POLICY-3094
Change-Id: I594d424b42ce446d86724d75b1dd9ec868c14f2b
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
- fix NullPointerException when gui-editor is started with command line
- clean up code
Issue-ID: POLICY-3235
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Ia05a4a808c3fa266e702f627959a382b0344f5db
|
|
Removed references to archetype-packaging and lifecycle-mapping, where
unnecessary due to pom inheritance.
Issue-ID: POLICY-3136
Change-Id: Iae3278accea933a18224f10b63a01658948b39db
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Policy parent specifies a newer version of the maven resources plugin.
Modified the pom to work with it. According to the docs, copy-resources
is only needed when copying from directories outside of
src/main/resources.
Issue-ID: POLICY-3182
Change-Id: Icb125914dd0fc15a9b2da4290b7e06338a0fae4a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Also updated version of npm, as 6.14.4 does not appear within the repo.
Issue-ID: POLICY-3182
Change-Id: I61ec07ad525d165828bb7c97af00bb740d939cc3
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The gui builds are failing, because the policy dependencies cannot be
found. Upgraded the dependency versions to the latest policy snapshots.
Issue-ID: POLICY-3180
Change-Id: Id90addb5a15bbdaa4842c1751ac0022f38417e49
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
ApexEditorParameters has a URI that sonar does not like, hard coding the leading forward slash removes the complaint
ApexEditorMain was receiving args and a print stream in the form of System.err and then System.out, both of these were null values, while Sonar sees System.out or err as a bug as it should be a logger, simply passing null in its place is not an issue to sonar
BeanBase.java Removed an if statement that always asserted to be true, as it is inside an if statement that confirmed that condition.
removed an accessibility change as sonar sees this as a violation
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: I1bbdfe9cc6db085195e95da3dbfbc8b29d9a5ff5
Signed-off-by: mkidd <michael.kidd@est.tech>
|
|
Making changed regarding code smells. Some variables being declared twice while in scope.
renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name.
renamed some of the for loop control variables so that sonarqube doesnt see it as an issue
Made changes based on reviews
Issue-ID: POLICY-3095
Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993
Signed-off-by: mkidd <michael.kidd@est.tech>
|
|
ApexEditorRestResourceTest.java - separate test methods into smaller methods so that less assertions are made per method
Issue-ID: POLICY-3095
Change-Id: Ic7f54916a130dbb403102dec51e6e2fec708f0cf
Signed-off-by: mkidd <michael.kidd@est.tech>
|
|
|
|
removed / from start of Rest path, hard coded it - resolves code smell issue
small code smell changes regarding passing variables to functions that have access to the variable from its current scope
reintroduced data parameter being passed in MonitoringUtils.js, can look into this more later
fixed pom for parent version, commons step up
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Id8b6a8b41e9b3c2f362821750d3fa728b93336a0
Signed-off-by: mkidd <michael.kidd@est.tech>
|
|
pointed parent to 3.3.1-SNAPSHOT
pointed policy.common to 1.8.1-SNAPSHOT
pointed policy.models to 2.4.2-SNAPSHOT
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Ic5ebe398abb289c7fba6e8de14bf5d11a5c0e449
Signed-off-by: mkidd <michael.kidd@est.tech>
|
|
used await method inside an if statement that now runs the same code as the accompanying finally block.
removed unused variables from ApexContextAlbumEditForm.js
refactored vars that were redelared - this was not needed as there were variables of this name within scope
added ! operator
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Idadf4dd6938be5410fef62140de8b265bbaca138
|
|
removed redundant variables that re declared themselves
refactored coded that repeated as a function
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: I14be896ecb8d2f50ee5dc0c61009c6c2cab3e442
|
|
Issue-ID: POLICY-3028
Change-Id: I1e2fcc49f28a8fe620f39326dbe820bfc993e4da
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
|
|
|
|
Issue-ID: POLICY-3069
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: Ie91e60667707df110c53b65fdac8918acb07f6e1
|
|
Addressed the following issues (java only):
- assignment to static field
- expression is always true
- duplicate character in regex
- duplicate code
- remove Thread.sleep() from junit test
Issue-ID: POLICY-3063
Change-Id: I70951ed47defad5baa6c957852663688e51fa88a
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
maven-resources-plugin has been updated to v3.2.0. This is causing our
gui build to fail, due to it not allowing more than a certain number of
files to be copied. Reverted to v3.1.0 in apex-editor to fix this issue.
Issue-ID: POLICY-3063
Change-Id: I7b8a207f63de82ed44747c5d2c470b5345cb84c6
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
|
|
Update dependencies in gui-pdp-monitoring and gui-editor-apex to align with Node version. Deprecated dependencies removed.
Issue-ID: POLICY-2886
Change-Id: I62137b85d8ca56cd2cdeeeae5ee62ed18b5306ee
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
When we upgrade to oparent, these will fail as oparent upgrades
to 8.37 of puppycrawl which fixes a few bugs that should have
flagged these previously.
Issue-ID: POLICY-2887
Change-Id: Iaf0cf4966efc8655a2ea78d9b607ab0df91dd56b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2875
Change-Id: I2fe7e65beaaab70c888e258b2d45ce91d1339423
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Issue-ID: POLICY-2869
Change-Id: Ie8787c6d906043a063bc862cdb59986c58a57e4a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2839
Change-Id: Ifdf4be2ee15af8cde32bbbbac0dd0a5e7244ab25
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Last apex-editor/pom.xml change to exclude the /dist folder
Issue-ID: POLICY-2783
Change-Id: I076aac4e503c7e5f2ea39fa9291153be4b119808
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
The userId must be picked up from the URL passed to the policy editor
and then passed to the server.
Issue-ID: POLICY-2850
Change-Id: I98948f2e0a2bf8090926751ee98c26c46d272fcf
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2789
Change-Id: Ia696e3a7336e8ff12804d5c2e04d3996e5aadcdf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
The node.js code and repos are used only during unit test and should not
be included in the released artifacts. Not having them in the released
artifacts also eliminates a number of security and licensing issues with
node.js modules.
Issue-ID: POLICY-2825
Change-Id: Icb9c0a0e3d1ebb01aa9b6346ce51f0c76c5cdd0f
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
The APEX editor now loads, saves, and downloads files in TOSCA format,
the same as the apex-pdp does.
The non-standard TOSCA handling for file upload has been refactored to
be aligned with the Policy Frameowkr TOSCA support.
Issue-ID: POLICY-2621
Change-Id: I1ec7475cbcc6ffc23de92687c9f284ac7dfbdd80
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
|
|
Some minor changes to remove some eclipse warnings and to tidy the the
tets and formatting in the APEX policy editor GUI.
Issue-ID: POLICY-2621
Change-Id: Ib9b9b054fbe146feec4e477434097094e8ecae26
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
JavaScript tests added to improve code coverage for policy-gui
Issue-ID: POLICY-2783
Change-Id: Ie12fb6089b872842bb5c668a8126675f89772d79
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Issue-ID: POLICY-2789
Change-Id: Id81b09c0b0c8b0d088f1b813cb0858d28236d4d5
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Edited SonarCloud lcov reports path. Removed from pdp-monitoring
pom.xml. Added node binary source executable path and sources sonar
properties to pom.xml.
Issue-ID: POLICY-2610
Change-Id: I6354e65d358ca5e9bd8c18f032330aa5063a0889
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Moved the generated Jest Coverage report from policy-gui/gui-pdp-monitoring/src/webapp/coverage to policy-gui/target/code-coverage in order for SonarCloud to display the JS Code Coverage results.
Issue-ID: POLICY-2610
Change-Id: I1d86203afa45ad1b0a51d729fec4326607585988
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
|
|
Added to pom.xml for SonarCloud to point to lcov reports generated by Jest coverage.
Issue-ID: POLICY-2610
Change-Id: I2954517cb0b91d8e43e3c2065f4776258e391cea
Signed-off-by: waynedunican <wayne.dunican@est.tech>
|
|
Issue-ID: POLICY-2751
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
Change-Id: Ifc91bba369161a63f2ad759dcdc014bb12837e88
|