diff options
author | 2021-03-24 12:26:31 +0000 | |
---|---|---|
committer | 2021-03-25 16:14:07 +0000 | |
commit | aabae2a75c606a8f44fd5e0b38d840bf8cd767dc (patch) | |
tree | d9a4a1f0c6addb20cde96bb5edd6c60259bda868 /gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextAlbumTab.js | |
parent | e13710d3bd6c6aa1c02ccc3ee9e1ecf8b77581c0 (diff) |
Fix sonarqube code smells
Making changed regarding code smells. Some variables being declared twice while in scope.
renaming some modelFileName in ApexFiles.js that is being declared while there is a constant with the same name.
renamed some of the for loop control variables so that sonarqube doesnt see it as an issue
Made changes based on reviews
Issue-ID: POLICY-3095
Change-Id: If38934247a4e4ff9c48043feb3adde5505c46993
Signed-off-by: mkidd <michael.kidd@est.tech>
Diffstat (limited to 'gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextAlbumTab.js')
-rw-r--r-- | gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextAlbumTab.js | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextAlbumTab.js b/gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextAlbumTab.js index 2b1a5e8..f749b28 100644 --- a/gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextAlbumTab.js +++ b/gui-editors/gui-editor-apex/src/main/resources/webapp/js/ApexContextAlbumTab.js @@ -1,7 +1,7 @@ /* * ============LICENSE_START======================================================= * Copyright (C) 2016-2018 Ericsson. All rights reserved. - * Modifications Copyright (C) 2020 Nordix Foundation. + * Modifications Copyright (C) 2020-2021 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -41,8 +41,6 @@ function contextAlbumTab_activate() { var contextAlbum = JSON.parse(data.messages.message[i]).apexContextAlbum; var contextAlbumRow_tr = document.createElement("tr"); - var contextAlbumid = contextAlbum.key.name + ":" + contextAlbum.key.version; - var contextAlbumTableRow = "<td>" + @@ -84,7 +82,7 @@ function contextAlbumTab_create() { return } - var contextAlbumTabContent = document.createElement("contextAlbumTabContent"); + contextAlbumTabContent = document.createElement("contextAlbumTabContent"); contextAlbumTab.appendChild(contextAlbumTabContent); contextAlbumTabContent.setAttribute("id", "contextAlbumTabContent"); contextAlbumTabContent.addEventListener('contextmenu', rightClickMenu_scopePreserver("contextAlbumTabContent", "contextAlbum",null, null)); |