aboutsummaryrefslogtreecommitdiffstats
path: root/PolicyEngineAPI
AgeCommit message (Collapse)AuthorFilesLines
2018-11-08Update dmaap 1.1.9 changesPamela Dragosh1-1/+1
Upgrading policy/parent to v1.1.9 requires these code changes to occur. Need to change to policy/parent 2.0.1 for the right dmaap to be included. Upgrade policy common and drools-applications to 1.3.3 released artifacts. Also just included the change from gerrit review https://gerrit.onap.org/r/#/c/72026/ instead of cherry picking it. Updating release to 1.3.3-SNAPSHOT Issue-ID: POLICY-1229 Change-Id: I16f4bbd9ba2d46cdc3b94feba1f2e7f20d837dad Signed-off-by: Pamela Dragosh <pdragosh@research.att.com> (cherry picked from commit fe8b9e72cafa4acf31db4239593a74a5ccf89a4a) Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-31Step version for Casablanca supportliamfallon1-4/+2
Issue-ID: POLICY-1233 Change-Id: I1d388e1f4a872cf4e3013f8968e9026460e847f3 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-10-26Fix random failures in ManualClientEndTest3.0.0-ONAPJim Hahn4-46/+41
Don't know if this is the cause of the intermittent failures, but it could be, and it is certainly a bug: the classes manipulate data, that isn't marked volatile, from more than one thread at a time. Updated licenses. Change-Id: Ifca84cf8f915ec703a9ce8980db2475dacf97980 Issue-ID: POLICY-1092 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-25Fix refering to snapshot in policy/engineramverma1-1/+1
Issue-ID: POLICY-1213 Change-Id: I6666585a176b9e981976777018e4b7616e47ffc7 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-10-23Remove unused commons-fileuploadPamela Dragosh1-5/+0
This flags a security vulnerability. But it is unused so we can remove it. Issue-ID: POLICY-1212 Change-Id: I8343d56324cc94d7a163f26d0af322d232c5c02e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-14Upgrade springframework 4.3.18.RELEASEPamela Dragosh1-1/+1
To resolve security issue for 4.3.15.RELEASE and also have a single place where the dependency is defined for the sub-modules. NOTE: 4.2.0.RELEASE is left alone in Policy SDK App due to Portal SDK dependency. Issue-ID: POLICY-1063 Change-Id: Ibdc464b16b4771faccb2c8c472efa7fbcbf3352c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-11Merge "New min/max Guard Policy"Pamela Dragosh1-3/+7
2018-09-11New min/max Guard PolicyMichael Mokry1-3/+7
Made changes to support Guard policy create/update and other policy manager functions including deletePolicy and pushPolicy. Includes changes for new Guard policy support using GUI and API (Rest and Java Client) Made changes to address Jim's comments Made changes to address Liam's comments Change-Id: I133fe1fd9287ea77ea41a2788de90c7642c36b6a Issue-ID: POLICY-1038 Signed-off-by: Mike Mokry <mm117s@att.com>
2018-09-11Change websockets to managed versionliamfallon1-1/+0
Change-Id: Iff8f9053640752f86e6f5aa94c1f16f6d3e01d6a Issue-ID: POLICY-884 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-05XACML Platform Enhancementsrb71472-3/+16
To Support Raw Policy Creation from GUI and API. GetDecision on combining algorithim with Policy Set. Issue-ID: POLICY-902 Change-Id: Ie3189f8ded2e03366bc7d65d15b95b88c89b0acd Signed-off-by: rb7147 <rb7147@att.com>
2018-08-30Upgrade to policy/parentPamela Dragosh1-110/+104
Change from oparent to policy/parent which inherit from the latest oparent. The latest oparent has dependencyManagement recommendations from the ONAP Security sub committee that the policy team is adhering as part of the effort to consolidate security work across projects. Change-Id: I1a43fc5a04dbc8c4cb2b7bedbca67ad3e9dd120b Issue-ID: INT-619 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-07Resolve sonar issue in Policy parametersKrishnajinka3-1903/+2064
Fix sonar issue of Method has 9 parameters, which is greater than 7 authorized in PolicyParameters class and related test class.Rework2 Issue-ID: POLICY-1016 Change-Id: I3096566d958e093439bcc95d92f1fe92e0ac57be Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-26Refactor code for nested stmts in policy stdKrishnajinka3-293/+312
Refactor code for nested control statements in PolicyEngineAPI policy.std package. These issues are flagged by Sonar as Major issues. Rework based on review comments Issue-ID: POLICY-1012 Change-Id: I6925dd5d56b653ef4cefe5ae64686a49f9741125 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-06-08Remove "&quot;" from logback xml filesJim Hahn1-1/+1
Logback complains if %d{} values contain "&quot;", but it works fine without them, thus they have been removed. Update licenses. Change-Id: Id1f21d3d51bb2495a92f54fcf5c3ad978612c375 Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-05Update engine to SNAPSHOT-1.3.0liamfallon1-1/+1
Snapshot updated for Casablanca. Change-Id: Ieb2c9a990c0f36f31c974038465e7d38aaa21e5d Issue-ID: POLICY-875 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-21Update Policy Engine to 1.2.3-SNAPSHOTliamfallon1-1/+1
These reviews must be merged in order because of layering. This review should be merged FOURTH. Change-Id: Ifca8e33b79085a4032164b44dae3401f8179f5f6 Issue-ID: POLICY-844 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-16Upgrade SNAPSHOT to 1.2.2liamfallon1-1/+1
These reviews must be merged in order because of layering. This review should be merged SECOND Note: In order to get past the following layering problems, there are temporary chages to the following POMs to temporarily use 1.2.1-SNAPSHOT for those dependencies. They are ONAP-PAP-REST/pom.xml org.onap.policy.drools-applications.controlloop.common.policy-yaml ONAP-PDP/pom.xml org.onap.policy.drools-pdp.policy-endpoints A separate review will be used to restore these dependencies to 1.2.2-SNAPSHOT once the drools-pdp and drools-applications reviews are submitted and merged PLD added version.properties Issue-ID: POLICY-798 Change-Id: Id7e83f2ba12181c63cc8845b7eeccf2004d2bab9 Signed-off-by: liamfallon <liam.fallon@ericsson.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com> Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-08fixing NullPointException incase of db exceptionwaqas.ikram1-83/+99
Making changes for NullPointerException it was triggered by - SQL Query Failed in PAP return unhandled reponse code > activeVersion variable is set to null > if statement in DeletePolicyService (!activeVersion.equalsIgnoreCase("0") result into NullPointerException Change-Id: Iad9de0d31b6cf16d1eafd6175d1c355b07481db9 Issue-ID: POLICY-773 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-05-01Remove sysout from junit and disable assert.pa834y4-16/+8
Updated BRMS Gateway junit tests to be less strict on hit counts on queries to Nexus. Draft version passed build son now submitting as full submission. Change-Id: Iab81d14be69835faefbb96fb0af17b3f3759575b Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com> Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-26Incorporate Liam code reviewpa834y4-58/+68
Change-Id: I387a54b8bd8c619c521c512258928669a8c1b791 Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com>
2018-04-24Add websocket client code.pa834y5-629/+475
Change-Id: I2d3939c698a0df6bec068063f08566226f65bfd3 Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com>
2018-04-18Remove insecure dependency on PolicyEngineAPIliamfallon4-34/+85
The insecure dependency tyrus-container-grizzly-client is part of Tyrus, a Java web socket implementation library. A direct substitution of this library is not available so the code in AutoClientEnd.java and ManualClientEnd.java was adapted to work with the library org.java-websocket.Java-WebSocket that does not seem to have any vulnerabilities when tested with the org.owasp.dependency-check-maven plugin. The purpose of this submission is to see if the new library does indeed remove the vulnerability. If so, the implementation in AutoClientEnd and ManualClientEnd must be cleaned up. Change-Id: I961635aaea42c2f847edf11ee77e2961cdfb097b Issue-ID: POLICY-744 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-13Upgrade to SNAPSHOT 1.2.1Pamela Dragosh1-1/+1
Issue-ID: POLICY-736 Change-Id: If5c959aa1c0a123c7fd9eee281e39e1d646b6b03 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-03ONAP log files consolidationChou, Joseph (JC2555)2-11/+11
Check in changes for pap,pdp,console,brmsgw,paplp and pdplp Change-Id: I23525a44e0f269d04d9870c3eed18b6b8daacb2c Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-03-30POM fixes due to update in cadi-aafbobbymander1-5/+0
Issue-ID: POLICY-507 Change-Id: I493233f8e0e90eaf24e9c09c7433c6fb9fadb268 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-28POM changes to centralize test scope depsbobbymander1-34/+0
Issue-ID: POLICY-600 Change-Id: I870317bbd125c6016818ec435ea7a406123c66c1 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-28Merge "ONAP code change for log files consolidation"Jorge Hernandez1-4/+4
2018-03-28ONAP code change for log files consolidationChou, Joseph (JC2555)1-4/+4
Undo the change so this would not block other test activity Change-Id: I4f7dd2e14f30034eefbf958be3c912af2962e8a2 Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-03-27JUnit additions and powermock pom fixesbobbymander2-651/+725
Issue-ID: POLICY-602 Change-Id: I2484b47cc52a07413de69c1022a056fd0cf2d7d7 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-26Merge "New Optimization Policy"Pamela Dragosh4-2/+15
2018-03-26New Optimization PolicyMichael Mokry4-2/+15
This is the new Optimization Policy to support the Integration of the OOF Policy Model into the Policy Platform. Added changes from Frank Wang to fix the following issues with existing Model Parser: 1. TOSCA Rendering issues 2. Matching Attributes support 3. ImportModelAPI to support TOSCA model upload via REST API Running local Sonar tonight to start fixing Sonar issues Added changes per review comments and fixed Sonar issues Change-Id: Ia8ce09c28a718ce4460475e76a750caef774bd6b Issue-ID: POLICY-622 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-03-23ONAP code change for log files consolidationChou, Joseph (JC2555)1-4/+4
Code change for log files consolidation of PAP, PDP, BRMSGW, Console and db script Issue-ID: POLICY-562 Change-Id: I416ba7748b841bb2b1a31682e2b1631e279549e8 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-03-08ClientEndpoint needs to be instantiabepa834y1-4/+0
Issue-ID: POLICY-660 Change-Id: I0d377eb9d500218933217faeb224929548da0e5a Signed-off-by: pa834y <pa834y@att.com>
2018-03-08Merge "JUnit additions for BRMS,API"Jorge Hernandez1-0/+52
2018-03-07JUnit additions for BRMS,APIbobbymander1-0/+52
Issue-ID: POLICY-598 Change-Id: I6a41d510d95afd8538e7775fe12d6e07771dd307 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-06Add new constructorDeterme, Sebastien (sd378r)3-26/+73
Add a new constructor to PolicyEngine to support Properties parameters instead of a file. Issue-ID: CLAMP-136 Change-Id: Id82a736cac8ac5603ff3627a9ce2ac5af4197a45 Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
2018-03-05Remove auto generated rule to the drlpa834y1-2/+2
Issue-ID: POLICY-488 Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b Signed-off-by: pa834y <pa834y@att.com>
2018-03-01JUnit additions for PAP-REST,APIbobbymander1-0/+45
Issue-ID: POLICY-600 Change-Id: I68020230d370950c0323a544910ad54015e1a08a Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-01Adding fix for BRMSGW issueMichael Mokry1-1/+1
This should fix the issue with the BRMSGW getting notification to create the rules jar Change-Id: Ie575a0b4717c999b8ab9deecc667ceaba99e7327 Issue-ID: POLICY-660 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-02-23Add JUnit tests policy/engine PolicyEngineAPIwaqas.ikram7-613/+1910
Change-Id: I8d7a76836759b042c83349c2b875fb77085b531c Issue-ID: POLICY-606 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-02-21Updated the Policy Logging Patternrb71471-41/+35
Updated the logback.xml to save logs for 30 days. Issue-ID: POLICY-644 Change-Id: I578570fa5a7f86ba464c37cddab43a2fabcdae7f Signed-off-by: rb7147 <rb7147@att.com>
2018-02-20JUnit test for policy/engine PolicyEngineAPIwaqas.ikram26-3293/+2973
Change-Id: I31991245bb5cc877722f7ce14530222a102d6472 Issue-ID: POLICY-606 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-02-16New JUnit for PolicyEngineAPIbobbymander1-0/+75
Issue-ID: POLICY-338 Change-Id: I711bb0c219534a537c3d35331b8ef8703423ad63 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-07Upgrade dependencies to clear security issuesPamela Dragosh1-4/+4
A bit of consolidation too - which could use a lot more work. These were simple security upgrades for fixes identified by LF weekly LCM job. Added some missing license headers. Issue-ID: POLICY-507 Change-Id: If285b0f95d30a1084c9363bf6a41b48d52fb3aff Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-05Fix last technical debtPamela Dragosh1-1/+1
Last one that I dare to fix. Issue-ID: POLICY-477 Change-Id: Ieb1c159b781fa2f0dd80f7dea92dcbf72c3e8364 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-05Technical debt and fix JUnit testPamela Dragosh1-13/+0
* One statement per line * private constructor for class with statics * Fix silly JUnit test Issue-ID: POLICY-474 Change-Id: Ie760826879febbbc4db4f03079ae1f847f2194dd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-02Technical debt reductionPamela Dragosh7-19/+20
* empty constructor * Unnecessary imports * try-with-resources * missing @Override * useless parens * proper boolean detection * useless imports * Use Set vs HashSet * moving statements to separate lines Issue-ID: POLICY-477 Change-Id: I5fae9c5c8e7d30f731a1caefc8a5271cf382e0a0 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-01Reduce technical debt and add JUnitPamela Dragosh39-439/+921
* Addressed some very simple cyclic complexity * Added simple JUnit tests and finished others * Removed useless assignments Issue-ID: POLICY-477 Change-Id: Ic919bbf78ad2732a430c32f1feb3c88678be710d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-12Merge "Sonar cleanup for PolicyEngineUtils"Jorge Hernandez1-2/+3
2017-12-21Sonar cleanup for PolicyEngineUtilsMagnusen, Drew (dm741q)1-2/+3
Changes to resolve some sonar "major" issues in the PolicyEngineUtils module. Patch 2: Updated the NotificationStoreTest junit to account for the return of a "Collections.emptyList()" rather than "null" in StdPDPNotification class. Patch 3: Updated the StdPDPNotificationTest junit to account for the return of a "Collections.emptyList()" rather than "null" in StdPDPNotifaction class. Issue-ID: POLICY-474 Change-Id: I925774ac181fd38d1206637f47ab27ba499629ef Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>