Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
Will not clear any CLM issue but this for uses a version that is
using the latest lucene-queryparser. It is noted in the CVE for
lucene-queryparser that elasticsearch is not affected by the
issue. We will upgrade to keep up with the latest code.
Issue-ID: POLICY-507
Change-Id: I8580dbc704c48245faf298304b8aec76c9e773c4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-600
Change-Id: Ie2a3257e26382f68d8cb008dc5ac512d6ac49c8b
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
|
|
Move the GUARD_BL_YAML string literal on the left side of this string comparison
DecisionPolicyController.java:L208
Sonar Link:
https://sonar.onap.org/issues?myIssues=true&open=AV2blO9u5bp_wwmIURef&resolved=false&severities=CRITICAL%2CMAJOR
Location:
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java
Line Number:208
Change-Id: I04199190cbb4afd50bcfa0a2725e6f2fef8dddba
Issue-ID: POLICY-689
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Moved file tmp object from try resources block. due to not closing the
stream the inputstream read by xacmlpolicyscanner ended with premature
file error.
Cleaned unused code.
Issue-ID: POLICY-584
Change-Id: I92c4d000d94a144736d9ac46db384785a7512593
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Move the null string literal on the left side of this string comparison
CreateFirewallController.java:L347
Sonar Link:
https://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AWBFphN0-08if2a6vI7H&resolved=false&severities=MAJOR
Location:
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java
Change-Id: I744a66f3622fb7db0933c7c7dabc520e859cff4d
Issue-ID: POLICY-685
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Issue-ID: POLICY-598
Change-Id: Ic3d9ca2a5f6c29f772bd747612d6c7caeb15eb7f
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
|
|
The ng-click on MS version dropbox triggered event function even for the
same MS version and called the event function again after selected
a different version.
Issue-ID: POLICY-655
Change-Id: I4e007f08e574ddd7899f0fde133bda2cac1be7d5
Signed-off-by: guangxingwang <gw1218@att.com>
Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Issue-ID: POLICY-600
Change-Id: Ib96b7ccede0fa09e71f02ff073c89682e9aa7089
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Issue-ID: POLICY-488
Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b
Signed-off-by: pa834y <pa834y@att.com>
|
|
|
|
|
|
Issue-ID: POLICY-584
Change-Id: I4bb91b18122c7f61bb71b1a9e39d51cd65af70bd
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Cleaned the duplicate code for all dictionary controllers and created
Utils class.
Issue-ID: POLICY-600
Change-Id: I65b8574d9f667758407515a5c55bc28f636be477
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Local variables should not shadow class field:L992 L1719
Issue-ID: POLICY-649
Sonar Link: https://sonar.onap.org/issues?myIssues=true&projectUuids=AV2blNLJ5bp_wwmIUP3L&resolved=false&severities=CRITICAL%2CMAJOR&types=CODE_SMELL
Location:POLICY-SDK-APP\src\main\java\org\onap\policy\controller\CreateDcaeMicroServiceController.java
Change-Id: I1d038829867c7d019473909650946a9539b5e736
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
|
|
Issue-ID: POLICY-645
Change-Id: Ie83b4c91c8186433e582cccadf5c3d32209a88f4
Signed-off-by: rb7147 <rb7147@att.com>
|
|
|
|
Issue-ID: POLICY-584
Change-Id: I306f3484f466accf11ca4fd59864a4b402dcb733
Signed-off-by: uj426b <uj426b@att.com>
|
|
Clenaed the unsued code.
Cleaned the duplication of code and moved to ONAP-REST.
Added Junits for PAP-REST
Issue-ID: POLICY-600
Change-Id: I56e6e8f2f547def9eaf8624a9e0dd52dc05ad136
Signed-off-by: rb7147 <rb7147@att.com>
|
|
First submit for re-organizing pom.xml dependencies. H2 is ONLY
used for testing and should be loaded otherwise. We removed it
from policy/common so that is affecting these test.
Issue-ID: POLICY-626
Change-Id: Iba86e89f2cb26581b2b465091e829d6bdd66a37b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
1) Fix Fortify Header Manipulation issue by checking the format of the
message before adding it response header.
2) Fix Fortify Hardcoded Password issue by using encryption and decryption
Issue-ID: POLICY-543
Change-Id: I16b44b9b0670b1af75094c9ae9d1f7d352fa894a
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
|
|
Cleaned the unused constructors.
Cleaned the unused code.
Added Junits for all JPAS.
Renamed the Junit class names on removing classes.
Issue-ID: POLICY-603
Change-Id: I0709ccecd7a2f3ec49367ff85f5a6d273479493e
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Issue-ID: POLICY-584
Change-Id: I90aaec29e908b742f0866d2754d426f75e1b8953
Signed-off-by: uj426b <uj426b@att.com>
|
|
On editor screen, sometimes click on + button only one click, it creates
more than text fields
Issue-ID: POLICY-629
Change-Id: I9acc95fa0a4a7df3828e579f994c06bfa3199eb5
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Fix Fortify logging issue
Issue-ID: POLICY-544
Change-Id: Ibfc7665dcab229a705ec3f999545b14675c24430
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
|
|
Issue-ID: POLICY-620
Change-Id: Ib7cf286f62e945edcf5720ce2c53957b8456126d
Signed-off-by: rb7147 <rb7147@att.com>
|
|
|
|
- Provides validation for MS policy input content body that matches the GUI validations when create/update MS policy from API
- Added changes to satisfy review comments and updated copywright
headers for modified and new files
Change-Id: I02bfa639bffb48520badd0e4fa34eb36418547ae
Issue-ID: POLICY-377
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Missing extra fields added by clicking add buton if they are more than
10 on view screen
Issue-ID: POLICY-613
Change-Id: I9e718b62301f24b71a4f6506d3e63e6185e0b1ce
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
A bit of consolidation too - which could use a lot more work. These
were simple security upgrades for fixes identified by LF weekly LCM job.
Added some missing license headers.
Issue-ID: POLICY-507
Change-Id: If285b0f95d30a1084c9363bf6a41b48d52fb3aff
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Resolved the issue on updating the configuration files when
rename/clone/export/move actions are done through GUI.
Fixed the PolicyManagerServlet code.
Added test cases for newly added files.
Issue-ID: POLICY-609
Change-Id: I9d14f19fe20bbc0e3b3844f85d81f26e34bb26ec
Signed-off-by: rb7147 <rb7147@att.com>
|
|
* String literals on the left
* Unnecessary initialization of variables
* Change ArrayList to using List
* Remove extra semicolons
* Empty Constructor comments
* Useless parenthesis
I also added a comment on some code that is suspicious. Not comfortable
with changing that code.
Issue-ID: POLICY-482
Change-Id: I89d889737d398d047fab4b25cb5d962ee1ecdd03
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-550
Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Added hover messages for all policy templates.
Resolved few sonar issues.
Added fixes for Policy GUI Validations.
Issue-ID: POLICY-597
Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c
Signed-off-by: rb7147 <rb7147@att.com>
|
|
|
|
Fixed the sonar technical dept primarily for the POLICY-REST module, and
accordingly updated the other policy-engine modules for successful built.
Issue-ID: POLICY-476
Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698
Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
|
|
The last for technical debt I believe. The last try-with-resources I dare to
fix. Useless import that I missed last time. Did a couple of minor
reductions in cyclomatic complexity that I think are harmless.
And lastly introduce a new variable instead of reusing a parameter.
Issue-ID: POLICY-482
Change-Id: I5f2e5abbdd472496b48cf12e485fc9b4d903f35a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removed some duplicate code across some of the classes. For CheckPDP, got the code coverage
above 80%.
Issue-ID: POLICY-482
Change-Id: I41495cf9f92e8fd248350bf33f5a183c876f38f2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Focused on iterating over entrySet along with more fixes for
dead stores, unnecessary exceptions. I'm also starting to work
on reducing the number of code lines.
* Iterate using entrySet
* Remove useless assignments
* Unnecessary exceptions
* Use StringBuilder instead of StringBuffer due to synchronization
* Potential null exceptions being thrown
* Returning a empty collection vs null
Issue-ID: POLICY-482
Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Focusing on easy try-with-resources changes. Plus some other minor items.
I did not get all of them yet, as some have some heavy refactoring. These
try-with-resources seem to be fairly harmless.
* Utilize try-with-resources
* Remove unnecessary parenthesis
* Merging simple if statements
* Remove useless assignment
* Moving string literals to left hand side
Issue-ID: POLICY-482
Change-Id: If519ec8ea96f6b90bf82ac2676ffea9cd0cd2daf
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Also enhanced JUnit tests to ensure this will work. Reduced code.
Issue-ID: POLICY-482
Change-Id: If07e17df274bdb709f7ca60078bd1fbd78d1aaaa
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Mainly use StringBuilder() to improve speed
* Use StringBuilder
* Remove superflous exceptions in constructor
* Remove unnecessary casts
* Remove unnecessary toString()
* Combine return into one statement
* Move string literal to LHS
Issue-ID: POLICY-482
Change-Id: Id196728d92dda7fab7e83d6eea07633c5be37f7c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
* Using booleans true and false
* Using already predefined static strings
* Adding private constructors to hide implicit
* Adding empty constructor comment to satisfy SONAR
* Using single quotes for indexOf to use faster method
* Preferred use of .isEmpty()
* Ordering of public static synchronized syntax
* Removing commented out code
* Using an already defined constant
* Unnecessary declaration of runtime exceptions
* Unnecessary casts
* Unused variables and imports
* Unnecessary use of toString()
* Just using return vs storing into a local var and returning that
* Extra semicolons
Issue-ID: POLICY-482
Change-Id: I6b9dcc5211dd52895a8787239b9df3059928fa45
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Restrict file upload size in Policy Editory using a configurable value (in
bytes) set in xacml.admin.properties. Default value is 30MB.
Issue-ID: POLICY-538
Change-Id: I4d8539ab33320446aed250ea4fdc51de585d5f2a
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
|
|
*Renamed the local variable to othername
Change-Id: I5f1e1b8b9140acf73de241f78b0437dc9e5805b5
Issue-ID: POLICY-336
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
|