Age | Commit message (Collapse) | Author | Files | Lines |
|
- code cleanup, reduce cognitive complexity, extract constants etc
Issue-ID: POLICY-1615
Change-Id: Ie0f634b1848076bba4c3ea3cbf9252b9faba0f8f
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
|
|
- Code cleanup & formatting, attempts to reduce cognitive complexity
Issue-ID: POLICY-1615
Change-Id: I340fcaee185c1bc84d954863c413896120a51cb0
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
|
|
Changes ported from ECOMP into ONAP for multi-role functionality in Policy Editor GUI
Issue-ID: POLICY-1419
Change-Id: I438c074e935c28b014be44ae2eab1d49b45e11e2
Signed-off-by: Polina Volodina <pv789v@att.com>
|
|
Reformat test cases to follow ONAP style
https://wiki.onap.org/display/DW/Java+code+style
Format changes mainly consist of conversions of tabs to 4 spaces
Samsung modifications copyrights added
Change-Id: I60b666d879960c80c80f8b1c41fc98fd0703f4d4
Issue-ID: POLICY-1506
Signed-off-by: kaihlavi <l.kaihlavirt@partner.samsung.com>
|
|
|
|
Change-Id: Iaaf16a8e7e30174509cfb40702185c9b2fc2961a
Issue-ID: POLICY-1432
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
|
|
Change-Id: I8b2ea531c1cfa6620a2240c3ae029c3c284f5cd7
Issue-ID: POLICY-1432
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
|
|
Change-Id: Ifae0a81b6bfbbf08a68deb84b1514b88f2d19dea
Issue-ID: POLICY-1432
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
|
|
Modified the java code to check dataOrderInfo format when getting data from
model stored in the db table.
Modified js code to check for type string when replacing 'equal-sign'
with '=' in enum value list
Change-Id: Iac804bc59da756f03073266703a684382d4afaff
Issue-ID: POLICY-1243
Signed-off-by: Michael Mokry <michael.mokry@att.com>
(cherry picked from commit 32d9ca08e62acee4239a2b02464bc332bebbaf32)
|
|
|
|
Fix the a bug in this html file by adding msPolicyloader
Issue-ID: POLICY-1118
Change-Id: I7a45b232ed0680f1c8233b8ed71fdde685fbb9c9
Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
|
|
|
|
|
|
Import policy should report to end users if there are missing required
matching fields in policy template.
Issue-ID: POLICY-1117
Change-Id: Iac4485259b73784e641f42a22d5a12c524f4b8e2
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
|
|
Upgraded SDK version.
Added SQL script with encrypt key.
Added a function to save role on reading from session in
PolicyController.java
Addressed Check Style warnings in PolicyController.java
Issue-ID: POLICY-1088
Change-Id: I446b6c1a0db2a989ad3f4e982e5cdba845f81045
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Made changes to support Guard policy create/update and other policy manager
functions including deletePolicy and pushPolicy.
Includes changes for new Guard policy support using GUI and API (Rest and Java Client)
Made changes to address Jim's comments
Made changes to address Liam's comments
Change-Id: I133fe1fd9287ea77ea41a2788de90c7642c36b6a
Issue-ID: POLICY-1038
Signed-off-by: Mike Mokry <mm117s@att.com>
|
|
Issue-ID: POLICY-902
Change-Id: If22627dfe7df993b5c725ddf3a66c10ebbaa73ca
Signed-off-by: rb7147 <rb7147@att.com>
|
|
|
|
To Support Raw Policy Creation from GUI and API.
GetDecision on combining algorithim with Policy Set.
Issue-ID: POLICY-902
Change-Id: Ie3189f8ded2e03366bc7d65d15b95b88c89b0acd
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Add those features below to existing TOSCA Policy model:
1. Set default value to HTML element
2. Set description of a property as a tooltip
3. Support Boolean type
4. User defined object can be re-used by different properties in the same yaml file
Issue-ID: POLICY-900
Change-Id: I337107828ce8130b9a68a2ba000ee719bbcb923e
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Enhancement on dashboard by including more info related to CRUD actions
on policies and also providing an advanced search feature.
Issue-ID: POLICY-1042
Change-Id: I987e0ca13824413f90299a366fb4464fca7de06a
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Issue-ID: POLICY-901
Change-Id: I3776d3c4ed01bb27ed930c074c370361e33b100a
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Issue-ID: POLICY-901
Change-Id: I30e1d075dd8eb4739bcb5aa1f2503a016900ff75
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Fix basic sonar issues in policy manager servlet
major and minor issues reported by sonar
Basic refactoring
Issue-ID: POLICY-1016
Change-Id: If3c19943c04d9af43807090b6340547d69ca6a19
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Fix Sonar reported major issues regarding extracting constants,
method complexity, duplicated code blocks, more than 3 nested
control blocks. Rework3 after self review.
Issue-ID: POLICY-1016
Change-Id: Icbf940c966c51a8ef4319a94a3832cb1e8c360ba
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Fix major issues reported by sonar in POLICY SDK APP files such as
CreateBRMSParamController, PolicyManagerServlet. Also modify tabs to
space. Rework2 based on review comments
Issue-ID: POLICY-1016
Change-Id: I5407ade1ce9f597fa91d9ca18506f5ac2d8b1411
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
|
|
Fix issues related to unused method variables, extract constants,
not nest more than 3 control stmts, use try with res in policy
engine project. Rework for comments
Issue-ID: POLICY-1008
Change-Id: If0953de9e802110df14862707f3b525652cdf112
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
|
|
While creating a decision Bl Guard Policy we are allowing to add
Blacklist entries through file upload for bulk from GUI.
Issue-ID: POLICY-901
Change-Id: I4031fd4a96937b9facc330cecf72777d701d4678
Signed-off-by: rb7147 <rb7147@att.com>
|
|
|
|
For the files which are modified add
modified copyright notices as per comments from earlier review
Issue-ID: POLICY-1002
Change-Id: I873b3ccc986d5f3d138ddb9e9b3c2307a0b127a6
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
SONAR flagged issues related with complexity of method being high
and more than 3 nested loops in the PolicyNotificationMail
Issue-ID: POLICY-986
Change-Id: Ife3e6b5610cec4bcf3898fdcad4cc2c9a3d61932
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
refactor the code for nested try blocks and rework
based on comments and fix nested loops complexity
Issue-ID: POLICY-976
Change-Id: Ied02b7838b5e4839a4906f79ff37c4fd6afeccfe
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Fix sonar issues to convert try blocks to
try with resources plus change tabs 2 space
Issue-ID: POLICY-961
Change-Id: I553d6a42f1efaab5b7eb3a53bab945a3360e69bb
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
This reverts commit 240bbdbdc76e0e91af9f18164eadb2708d14c6fb, reversing
changes made to 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf.
Change-Id: I61f07ead1d7d3e89c512a2224efecf9ac440df10
Issue-ID: POLICY-961
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Issue-ID: POLICY-961
Change-Id: Ia1f388368007a4a82a57520dc6ddd99cc484a393
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Logback complains if %d{} values contain """, but it works fine
without them, thus they have been removed.
Update licenses.
Change-Id: Id1f21d3d51bb2495a92f54fcf5c3ad978612c375
Issue-ID: POLICY-785
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
These reviews must be merged in order because of layering.
This review should be merged SECOND
Note: In order to get past the following layering problems, there
are temporary chages to the following POMs to temporarily use 1.2.1-SNAPSHOT
for those dependencies. They are
ONAP-PAP-REST/pom.xml
org.onap.policy.drools-applications.controlloop.common.policy-yaml
ONAP-PDP/pom.xml
org.onap.policy.drools-pdp.policy-endpoints
A separate review will be used to restore these dependencies to 1.2.2-SNAPSHOT
once the drools-pdp and drools-applications reviews are submitted and merged
PLD added version.properties
Issue-ID: POLICY-798
Change-Id: Id7e83f2ba12181c63cc8845b7eeccf2004d2bab9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
see companion docker review.
The failOverReadOnly .. flags should only be used when a DB high
availability environment is used, such as a master/slave
configuration.
As they are the jdbc parameters have caused bad interactions
with the underlying persistence libraries rendering the PAP
useless.
It is thought that this may perhaps solve
POLICY-773, POLICY-775, POLICY-779, and perhaps POLICY-776.
Change-Id: Icb69a3afc0a19969a34af40d960fa8e1b94aabc0
Issue-ID: POLICY-777
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Added license to various files.
Updated XACMLPolicyScanner to work even when license comment
is added to the Policy.xml file.
Moved DOCTYPE before license in html files.
Removed license from css files, as many are generated or
come from third-party software.
Removed license from other generated files.
Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e
Issue-ID: POLICY-741
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Since MS configure name was changed in server side, its name needs to be
updated in the JS file also.
Issue-ID: POLICY-743
Change-Id: Iaed37a8d2b4dcfc5fb5ccd746b9aeb2270289338
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Fix wrong data names due to reponse changes
Issue-ID: POLICY-740
Change-Id: I28db745f88ccecd67f3daa30adf70cc69645b496
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Add more validations on TOSCA MS model file name and content format
Issue-ID: POLICY-721
Change-Id: Ic3dfe1887791be1e11bca5695866a77909334536
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Fix a bug in checking required fields if the object has include function
Issue-ID: POLICY-717
Change-Id: I766da50c9ac02081dd4e711b8c78be0f3c25e5bd
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
I added an INSERT to the sql upgrade file and some sonar fixes and
Junits
Change-Id: I37139d5a8ad78d9d46ee01f81c2edd052672712e
Issue-ID: POLICY-639
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
To make MS template layout better for complex MS models and also add
parent level elments first in view mode.
Issue-ID: POLICY-714
Change-Id: If6bf472a504f15fd9bde05253e9369ba43bb082e
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
This is the new Optimization Policy to support the Integration of
the OOF Policy Model into the Policy Platform.
Added changes from Frank Wang to fix the following issues with existing Model
Parser:
1. TOSCA Rendering issues
2. Matching Attributes support
3. ImportModelAPI to support TOSCA model upload via REST API
Running local Sonar tonight to start fixing Sonar issues
Added changes per review comments and fixed Sonar issues
Change-Id: Ia8ce09c28a718ce4460475e76a750caef774bd6b
Issue-ID: POLICY-622
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Issue-ID: POLICY-603
Change-Id: Id7d2c1a835d028e88337db67d55f139aa1764826
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Issue-ID: POLICY-584
Change-Id: I3b16e2a957e67ecfe5c28d2afaa09771ae891216
Signed-off-by: bobbymander <bobby.mander@att.com>
|