Age | Commit message (Collapse) | Author | Files | Lines |
|
These reviews must be merged in order because of layering.
This review should be merged SECOND
Note: In order to get past the following layering problems, there
are temporary chages to the following POMs to temporarily use 1.2.1-SNAPSHOT
for those dependencies. They are
ONAP-PAP-REST/pom.xml
org.onap.policy.drools-applications.controlloop.common.policy-yaml
ONAP-PDP/pom.xml
org.onap.policy.drools-pdp.policy-endpoints
A separate review will be used to restore these dependencies to 1.2.2-SNAPSHOT
once the drools-pdp and drools-applications reviews are submitted and merged
PLD added version.properties
Issue-ID: POLICY-798
Change-Id: Id7e83f2ba12181c63cc8845b7eeccf2004d2bab9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
see companion docker review.
The failOverReadOnly .. flags should only be used when a DB high
availability environment is used, such as a master/slave
configuration.
As they are the jdbc parameters have caused bad interactions
with the underlying persistence libraries rendering the PAP
useless.
It is thought that this may perhaps solve
POLICY-773, POLICY-775, POLICY-779, and perhaps POLICY-776.
Change-Id: Icb69a3afc0a19969a34af40d960fa8e1b94aabc0
Issue-ID: POLICY-777
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Added license to various files.
Updated XACMLPolicyScanner to work even when license comment
is added to the Policy.xml file.
Moved DOCTYPE before license in html files.
Removed license from css files, as many are generated or
come from third-party software.
Removed license from other generated files.
Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e
Issue-ID: POLICY-741
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Since MS configure name was changed in server side, its name needs to be
updated in the JS file also.
Issue-ID: POLICY-743
Change-Id: Iaed37a8d2b4dcfc5fb5ccd746b9aeb2270289338
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Fix wrong data names due to reponse changes
Issue-ID: POLICY-740
Change-Id: I28db745f88ccecd67f3daa30adf70cc69645b496
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Add more validations on TOSCA MS model file name and content format
Issue-ID: POLICY-721
Change-Id: Ic3dfe1887791be1e11bca5695866a77909334536
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Fix a bug in checking required fields if the object has include function
Issue-ID: POLICY-717
Change-Id: I766da50c9ac02081dd4e711b8c78be0f3c25e5bd
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
I added an INSERT to the sql upgrade file and some sonar fixes and
Junits
Change-Id: I37139d5a8ad78d9d46ee01f81c2edd052672712e
Issue-ID: POLICY-639
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
To make MS template layout better for complex MS models and also add
parent level elments first in view mode.
Issue-ID: POLICY-714
Change-Id: If6bf472a504f15fd9bde05253e9369ba43bb082e
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
This is the new Optimization Policy to support the Integration of
the OOF Policy Model into the Policy Platform.
Added changes from Frank Wang to fix the following issues with existing Model
Parser:
1. TOSCA Rendering issues
2. Matching Attributes support
3. ImportModelAPI to support TOSCA model upload via REST API
Running local Sonar tonight to start fixing Sonar issues
Added changes per review comments and fixed Sonar issues
Change-Id: Ia8ce09c28a718ce4460475e76a750caef774bd6b
Issue-ID: POLICY-622
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Issue-ID: POLICY-603
Change-Id: Id7d2c1a835d028e88337db67d55f139aa1764826
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Issue-ID: POLICY-584
Change-Id: I3b16e2a957e67ecfe5c28d2afaa09771ae891216
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Fixed the missing function of matching fields for TOSCA Model
Issue-ID: POLICY-655
Change-Id: I41017a4cf01df7f4c36e086f76d169e3e216dc34
Signed-off-by: guangxingwang <gw1218@att.com>
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Issue-ID: POLICY-604
Change-Id: I2e2cdb3037a70af7d8d85a4a6274b3e361510bc1
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Issue-ID: POLICY-604
Change-Id: I9abc8418ddab1f487385c38c0424db601f8746e2
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Issue-ID: POLICY-604
Change-Id: Ib48f22dfe0db68348cb820d4186e7d3a79864b3f
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
|
|
|
|
Issue-ID: POLICY-600
Change-Id: Ie2a3257e26382f68d8cb008dc5ac512d6ac49c8b
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
|
|
Move the GUARD_BL_YAML string literal on the left side of this string comparison
DecisionPolicyController.java:L208
Sonar Link:
https://sonar.onap.org/issues?myIssues=true&open=AV2blO9u5bp_wwmIURef&resolved=false&severities=CRITICAL%2CMAJOR
Location:
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java
Line Number:208
Change-Id: I04199190cbb4afd50bcfa0a2725e6f2fef8dddba
Issue-ID: POLICY-689
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Moved file tmp object from try resources block. due to not closing the
stream the inputstream read by xacmlpolicyscanner ended with premature
file error.
Cleaned unused code.
Issue-ID: POLICY-584
Change-Id: I92c4d000d94a144736d9ac46db384785a7512593
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Move the null string literal on the left side of this string comparison
CreateFirewallController.java:L347
Sonar Link:
https://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AWBFphN0-08if2a6vI7H&resolved=false&severities=MAJOR
Location:
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java
Change-Id: I744a66f3622fb7db0933c7c7dabc520e859cff4d
Issue-ID: POLICY-685
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Issue-ID: POLICY-598
Change-Id: Ic3d9ca2a5f6c29f772bd747612d6c7caeb15eb7f
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
|
|
The ng-click on MS version dropbox triggered event function even for the
same MS version and called the event function again after selected
a different version.
Issue-ID: POLICY-655
Change-Id: I4e007f08e574ddd7899f0fde133bda2cac1be7d5
Signed-off-by: guangxingwang <gw1218@att.com>
Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Issue-ID: POLICY-600
Change-Id: Ib96b7ccede0fa09e71f02ff073c89682e9aa7089
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Issue-ID: POLICY-488
Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b
Signed-off-by: pa834y <pa834y@att.com>
|
|
|
|
|
|
Issue-ID: POLICY-584
Change-Id: I4bb91b18122c7f61bb71b1a9e39d51cd65af70bd
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Cleaned the duplicate code for all dictionary controllers and created
Utils class.
Issue-ID: POLICY-600
Change-Id: I65b8574d9f667758407515a5c55bc28f636be477
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Local variables should not shadow class field:L992 L1719
Issue-ID: POLICY-649
Sonar Link: https://sonar.onap.org/issues?myIssues=true&projectUuids=AV2blNLJ5bp_wwmIUP3L&resolved=false&severities=CRITICAL%2CMAJOR&types=CODE_SMELL
Location:POLICY-SDK-APP\src\main\java\org\onap\policy\controller\CreateDcaeMicroServiceController.java
Change-Id: I1d038829867c7d019473909650946a9539b5e736
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
|
|
|
|
Issue-ID: POLICY-584
Change-Id: I306f3484f466accf11ca4fd59864a4b402dcb733
Signed-off-by: uj426b <uj426b@att.com>
|
|
Clenaed the unsued code.
Cleaned the duplication of code and moved to ONAP-REST.
Added Junits for PAP-REST
Issue-ID: POLICY-600
Change-Id: I56e6e8f2f547def9eaf8624a9e0dd52dc05ad136
Signed-off-by: rb7147 <rb7147@att.com>
|
|
1) Fix Fortify Header Manipulation issue by checking the format of the
message before adding it response header.
2) Fix Fortify Hardcoded Password issue by using encryption and decryption
Issue-ID: POLICY-543
Change-Id: I16b44b9b0670b1af75094c9ae9d1f7d352fa894a
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
|
|
Cleaned the unused constructors.
Cleaned the unused code.
Added Junits for all JPAS.
Renamed the Junit class names on removing classes.
Issue-ID: POLICY-603
Change-Id: I0709ccecd7a2f3ec49367ff85f5a6d273479493e
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Issue-ID: POLICY-584
Change-Id: I90aaec29e908b742f0866d2754d426f75e1b8953
Signed-off-by: uj426b <uj426b@att.com>
|
|
On editor screen, sometimes click on + button only one click, it creates
more than text fields
Issue-ID: POLICY-629
Change-Id: I9acc95fa0a4a7df3828e579f994c06bfa3199eb5
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Fix Fortify logging issue
Issue-ID: POLICY-544
Change-Id: Ibfc7665dcab229a705ec3f999545b14675c24430
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
|
|
- Provides validation for MS policy input content body that matches the GUI validations when create/update MS policy from API
- Added changes to satisfy review comments and updated copywright
headers for modified and new files
Change-Id: I02bfa639bffb48520badd0e4fa34eb36418547ae
Issue-ID: POLICY-377
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Missing extra fields added by clicking add buton if they are more than
10 on view screen
Issue-ID: POLICY-613
Change-Id: I9e718b62301f24b71a4f6506d3e63e6185e0b1ce
Signed-off-by: guangxingwang <gw1218@att.com>
|
|
Resolved the issue on updating the configuration files when
rename/clone/export/move actions are done through GUI.
Fixed the PolicyManagerServlet code.
Added test cases for newly added files.
Issue-ID: POLICY-609
Change-Id: I9d14f19fe20bbc0e3b3844f85d81f26e34bb26ec
Signed-off-by: rb7147 <rb7147@att.com>
|
|
* String literals on the left
* Unnecessary initialization of variables
* Change ArrayList to using List
* Remove extra semicolons
* Empty Constructor comments
* Useless parenthesis
I also added a comment on some code that is suspicious. Not comfortable
with changing that code.
Issue-ID: POLICY-482
Change-Id: I89d889737d398d047fab4b25cb5d962ee1ecdd03
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-550
Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Added hover messages for all policy templates.
Resolved few sonar issues.
Added fixes for Policy GUI Validations.
Issue-ID: POLICY-597
Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c
Signed-off-by: rb7147 <rb7147@att.com>
|
|
|