aboutsummaryrefslogtreecommitdiffstats
path: root/POLICY-SDK-APP/src
AgeCommit message (Collapse)AuthorFilesLines
2019-08-12Fix issue for policies not loading on GUI push tabMichael Mokry1-1/+9
- found the problem to be with a line of code to add all the scopes from the role to a Set of scopes. when the scopes attribute in the role object is null it logs an exception and fails to load policies. I added a new method to check the value of the roles.getScopes() for null and only attempt to add the scope to the set if it is not null - I created a separate method to do this in order to avoid an increase in technical debt as it would have added to the complexity if I kept it in the same method. - PATCH 4: Added scopes to the method arguments in order to avoid overwriting scopes that are added in prevous interations of the loop. - PATCH 5: removed redundant scopes assignment per Jorge's review. Change-Id: Ifcc8775d3db8ecc722ee6806310a58ecb4e15856 Issue-ID: POLICY-1981 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-04-09Merge "Add Additional Junit and fix Sonar new bug."Pamela Dragosh1-4/+4
2019-04-09Merge "Fix Sonar issues in org.onap.policy.controller pkg"Pamela Dragosh4-1070/+1056
2019-04-09Add Additional Junit and fix Sonar new bug.uj426b1-4/+4
Issue-ID: POLICY-1416 Signed-off-by: uj426b <uj426b@att.com> Change-Id: Ie4e6e91d555be448caa290bce36eb58075046619 Signed-off-by: uj426b <uj426b@att.com>
2019-04-09Fix Sonar issues in org.onap.policy.controller pkgRashmi Pujar4-1070/+1056
Issue-ID: POLICY-1615 Change-Id: I3f7c6d754084d7c740876e817bf963a6cc8c194b Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
2019-04-08CLAMP Model policy creation supportuj426b13-1139/+1892
Change-Id: Ia69f061c078e4f6ed4b4d2cd12f03f58514f2123 Issue-ID: POLICY-1416 Signed-off-by: uj426b <uj426b@att.com>
2019-04-04Auditing User Operations Push or Delete Policies.uj426b3-443/+474
Change-Id: I39d5fc01e68e9d711c5dd09790dc34beb68783c3 Issue-ID: POLICY-1421 Signed-off-by: uj426b <uj426b@att.com>
2019-03-31Enhancement to use the common CryptoUtilspa834y5-142/+164
Change-Id: I06718526382b424eab991f39a7dac1b5cf4f1b74 Issue-ID: POLICY-1422 Signed-off-by: pa834y <pa834y@att.com>
2019-03-29Merge "FIx Sonar Issues reported on ActionPolicyController"Jorge Hernandez4-247/+251
2019-03-29Merge "Fix Sonar Issues policy/engine POLICY-SDK-APP module"Jorge Hernandez9-465/+383
2019-03-28Merge "Fix sonar new bugs and vulnerabilities"Jorge Hernandez1-61/+82
2019-03-28FIx Sonar Issues reported on ActionPolicyControllerRashmi Pujar4-247/+251
- code cleanup, reduce cognitive complexity, extract constants etc Issue-ID: POLICY-1615 Change-Id: Ie0f634b1848076bba4c3ea3cbf9252b9faba0f8f Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
2019-03-28Fix Sonar Issues policy/engine POLICY-SDK-APP moduleRashmi Pujar9-465/+383
- Code cleanup & formatting, attempts to reduce cognitive complexity Issue-ID: POLICY-1615 Change-Id: I340fcaee185c1bc84d954863c413896120a51cb0 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
2019-03-27Fix sonar new bugs and vulnerabilitiespa834y1-61/+82
Change-Id: I7fbfe70e856d48f40ad831a6d0451e46024bf6de Issue-ID: POLICY-1417 Signed-off-by: pa834y <pa834y@att.com>
2019-03-27Merge "Model enhancement to support embedded JSON"Jorge Hernandez1-1379/+1536
2019-03-26Add capability for multi-role supportPolina Volodina10-1105/+1515
Changes ported from ECOMP into ONAP for multi-role functionality in Policy Editor GUI Issue-ID: POLICY-1419 Change-Id: I438c074e935c28b014be44ae2eab1d49b45e11e2 Signed-off-by: Polina Volodina <pv789v@att.com>
2019-03-21Model enhancement to support embedded JSONuj426b1-1379/+1536
Change-Id: Ic7796d0800f320e9543b59a4eabf0570ca080f09 Issue-ID: POLICY-1420 Signed-off-by: uj426b <uj426b@att.com>
2019-02-15Reformat POLICY-SDK-APP test caseskaihlavi19-2593/+2767
Reformat test cases to follow ONAP style https://wiki.onap.org/display/DW/Java+code+style Format changes mainly consist of conversions of tabs to 4 spaces Samsung modifications copyrights added Change-Id: I60b666d879960c80c80f8b1c41fc98fd0703f4d4 Issue-ID: POLICY-1506 Signed-off-by: kaihlavi <l.kaihlavirt@partner.samsung.com>
2019-01-22Merge "Improved snar issues"Pamela Dragosh1-4/+7
2019-01-21Improved snar issuesburdziak1-4/+7
Change-Id: Iaaf16a8e7e30174509cfb40702185c9b2fc2961a Issue-ID: POLICY-1432 Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
2019-01-21Sonar issues improvedburdziak1-27/+33
Change-Id: I8b2ea531c1cfa6620a2240c3ae029c3c284f5cd7 Issue-ID: POLICY-1432 Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
2019-01-17Small sonar issuesburdziak1-14/+17
Change-Id: Ifae0a81b6bfbbf08a68deb84b1514b88f2d19dea Issue-ID: POLICY-1432 Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
2018-11-07Fix issue with rendering 'identity' key in GUIMichael Mokry4-5/+14
Modified the java code to check dataOrderInfo format when getting data from model stored in the db table. Modified js code to check for type string when replacing 'equal-sign' with '=' in enum value list Change-Id: Iac804bc59da756f03073266703a684382d4afaff Issue-ID: POLICY-1243 Signed-off-by: Michael Mokry <michael.mokry@att.com> (cherry picked from commit 32d9ca08e62acee4239a2b02464bc332bebbaf32)
2018-09-18Merge "Fix Policy GUI Template Issue"Pamela Dragosh1-1/+1
2018-09-18Fix Policy GUI Template IssueWang, Frank(gw1218)1-1/+1
Fix the a bug in this html file by adding msPolicyloader Issue-ID: POLICY-1118 Change-Id: I7a45b232ed0680f1c8233b8ed71fdde685fbb9c9 Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
2018-09-18Merge "Added validation on matching required fields"Jorge Hernandez2-436/+777
2018-09-18Merge "AAF integration in Policy SDK"Pamela Dragosh2-1001/+1146
2018-09-17Added validation on matching required fieldsWang,Frank(gw1218)2-436/+777
Import policy should report to end users if there are missing required matching fields in policy template. Issue-ID: POLICY-1117 Change-Id: Iac4485259b73784e641f42a22d5a12c524f4b8e2 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com> Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
2018-09-17AAF integration in Policy SDKrb71472-1001/+1146
Upgraded SDK version. Added SQL script with encrypt key. Added a function to save role on reading from session in PolicyController.java Addressed Check Style warnings in PolicyController.java Issue-ID: POLICY-1088 Change-Id: I446b6c1a0db2a989ad3f4e982e5cdba845f81045 Signed-off-by: rb7147 <rb7147@att.com>
2018-09-11New min/max Guard PolicyMichael Mokry3-8/+136
Made changes to support Guard policy create/update and other policy manager functions including deletePolicy and pushPolicy. Includes changes for new Guard policy support using GUI and API (Rest and Java Client) Made changes to address Jim's comments Made changes to address Liam's comments Change-Id: I133fe1fd9287ea77ea41a2788de90c7642c36b6a Issue-ID: POLICY-1038 Signed-off-by: Mike Mokry <mm117s@att.com>
2018-09-10Resolved XACML Platform Sonar issuesrb71471-26/+27
Issue-ID: POLICY-902 Change-Id: If22627dfe7df993b5c725ddf3a66c10ebbaa73ca Signed-off-by: rb7147 <rb7147@att.com>
2018-09-06Merge "XACML Platform Enhancements"Jorge Hernandez3-604/+708
2018-09-05XACML Platform Enhancementsrb71473-604/+708
To Support Raw Policy Creation from GUI and API. GetDecision on combining algorithim with Policy Set. Issue-ID: POLICY-902 Change-Id: Ie3189f8ded2e03366bc7d65d15b95b88c89b0acd Signed-off-by: rb7147 <rb7147@att.com>
2018-08-30TOSCA model enhancementsWang,Frank(gw1218)1-54/+238
Add those features below to existing TOSCA Policy model: 1. Set default value to HTML element 2. Set description of a property as a tooltip 3. Support Boolean type 4. User defined object can be re-used by different properties in the same yaml file Issue-ID: POLICY-900 Change-Id: I337107828ce8130b9a68a2ba000ee719bbcb923e Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-08-23Enhancement on DashboardWang,Frank(gw1218)8-368/+1000
Enhancement on dashboard by including more info related to CRUD actions on policies and also providing an advanced search feature. Issue-ID: POLICY-1042 Change-Id: I987e0ca13824413f90299a366fb4464fca7de06a Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-08-14Junit Coverage for Import Black List Entriesrb71471-68/+36
Issue-ID: POLICY-901 Change-Id: I3776d3c4ed01bb27ed930c074c370361e33b100a Signed-off-by: rb7147 <rb7147@att.com>
2018-08-14Resolved the Sonar issuesrb71472-92/+92
Issue-ID: POLICY-901 Change-Id: I30e1d075dd8eb4739bcb5aa1f2503a016900ff75 Signed-off-by: rb7147 <rb7147@att.com>
2018-08-06Modify Policy manager servlet for sonar issuesKrishnajinka1-103/+100
Fix basic sonar issues in policy manager servlet major and minor issues reported by sonar Basic refactoring Issue-ID: POLICY-1016 Change-Id: If3c19943c04d9af43807090b6340547d69ca6a19 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-03Fix major sonar issues in SDK APP admin modKrishnajinka3-479/+524
Fix Sonar reported major issues regarding extracting constants, method complexity, duplicated code blocks, more than 3 nested control blocks. Rework3 after self review. Issue-ID: POLICY-1016 Change-Id: Icbf940c966c51a8ef4319a94a3832cb1e8c360ba Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-31Fix major sonar issues in SDK APPKrishnajinka2-666/+714
Fix major issues reported by sonar in POLICY SDK APP files such as CreateBRMSParamController, PolicyManagerServlet. Also modify tabs to space. Rework2 based on review comments Issue-ID: POLICY-1016 Change-Id: I5407ade1ce9f597fa91d9ca18506f5ac2d8b1411 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-26Merge "Fix issues reported by sonar"Liam Fallon5-709/+703
2018-07-25Fix issues reported by sonarKrishnajinka5-709/+703
Fix issues related to unused method variables, extract constants, not nest more than 3 control stmts, use try with res in policy engine project. Rework for comments Issue-ID: POLICY-1008 Change-Id: If0953de9e802110df14862707f3b525652cdf112 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-25Merge "Decision BlackList Guard Enhancements"Jorge Hernandez6-225/+919
2018-07-24Decision BlackList Guard Enhancementsrb71476-225/+919
While creating a decision Bl Guard Policy we are allowing to add Blacklist entries through file upload for bulk from GUI. Issue-ID: POLICY-901 Change-Id: I4031fd4a96937b9facc330cecf72777d701d4678 Signed-off-by: rb7147 <rb7147@att.com>
2018-07-24Merge "Refactor PolicyNotificationMail for sonar issues"Pamela Dragosh1-118/+152
2018-07-23Add modified copyright noticeKrishnajinka5-82/+87
For the files which are modified add modified copyright notices as per comments from earlier review Issue-ID: POLICY-1002 Change-Id: I873b3ccc986d5f3d138ddb9e9b3c2307a0b127a6 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-23Refactor PolicyNotificationMail for sonar issuesKrishnajinka1-118/+152
SONAR flagged issues related with complexity of method being high and more than 3 nested loops in the PolicyNotificationMail Issue-ID: POLICY-986 Change-Id: Ife3e6b5610cec4bcf3898fdcad4cc2c9a3d61932 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-20FIX SONAR ISSUE NESTED TRY BLOCKSKrishnajinka5-1685/+1724
refactor the code for nested try blocks and rework based on comments and fix nested loops complexity Issue-ID: POLICY-976 Change-Id: Ied02b7838b5e4839a4906f79ff37c4fd6afeccfe Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-17USE TRY WITH RESOURCESKrishnajinka2-849/+860
Fix sonar issues to convert try blocks to try with resources plus change tabs 2 space Issue-ID: POLICY-961 Change-Id: I553d6a42f1efaab5b7eb3a53bab945a3360e69bb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-13Reverting "Merge "fix try block""Jorge Hernandez2-18/+8
This reverts commit 240bbdbdc76e0e91af9f18164eadb2708d14c6fb, reversing changes made to 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf. Change-Id: I61f07ead1d7d3e89c512a2224efecf9ac440df10 Issue-ID: POLICY-961 Signed-off-by: Jorge Hernandez <jh1730@att.com>