summaryrefslogtreecommitdiffstats
path: root/POLICY-SDK-APP/src
AgeCommit message (Collapse)AuthorFilesLines
2018-03-26New Optimization PolicyMichael Mokry23-779/+4321
This is the new Optimization Policy to support the Integration of the OOF Policy Model into the Policy Platform. Added changes from Frank Wang to fix the following issues with existing Model Parser: 1. TOSCA Rendering issues 2. Matching Attributes support 3. ImportModelAPI to support TOSCA model upload via REST API Running local Sonar tonight to start fixing Sonar issues Added changes per review comments and fixed Sonar issues Change-Id: Ia8ce09c28a718ce4460475e76a750caef774bd6b Issue-ID: POLICY-622 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-03-23JUnit additions for PAP-REST,RESTbobbymander1-2/+7
Issue-ID: POLICY-603 Change-Id: Id7d2c1a835d028e88337db67d55f139aa1764826 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-21JUnit additions for PDP-REST,REST,SDK-APPbobbymander1-0/+41
Issue-ID: POLICY-584 Change-Id: I3b16e2a957e67ecfe5c28d2afaa09771ae891216 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-20Add Matching Fields For MS ModelWang,Frank(gw1218)2-4/+35
Fixed the missing function of matching fields for TOSCA Model Issue-ID: POLICY-655 Change-Id: I41017a4cf01df7f4c36e086f76d169e3e216dc34 Signed-off-by: guangxingwang <gw1218@att.com> Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-03-16JUnit additions for SDK-APPbobbymander1-33/+76
Issue-ID: POLICY-604 Change-Id: I2e2cdb3037a70af7d8d85a4a6274b3e361510bc1 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-15JUnit addition for SDK-APPbobbymander2-59/+117
Issue-ID: POLICY-604 Change-Id: I9abc8418ddab1f487385c38c0424db601f8746e2 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-14JUnit addition for SDK-APPbobbymander1-0/+164
Issue-ID: POLICY-604 Change-Id: Ib48f22dfe0db68348cb820d4186e7d3a79864b3f Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-13Merge "JUnit additions for PAP-REST,SDK-APP"Jorge Hernandez1-0/+41
2018-03-13Merge "Fixed the SDK Junits and cleaned unused code"Jorge Hernandez3-491/+10
2018-03-13JUnit additions for PAP-REST,SDK-APPbobbymander1-0/+41
Issue-ID: POLICY-600 Change-Id: Ie2a3257e26382f68d8cb008dc5ac512d6ac49c8b Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-13Merge "Sonar Major"Pamela Dragosh1-1/+1
2018-03-13Sonar MajorSP005016381-1/+1
Move the GUARD_BL_YAML string literal on the left side of this string comparison DecisionPolicyController.java:L208 Sonar Link: https://sonar.onap.org/issues?myIssues=true&open=AV2blO9u5bp_wwmIURef&resolved=false&severities=CRITICAL%2CMAJOR Location: POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java Line Number:208 Change-Id: I04199190cbb4afd50bcfa0a2725e6f2fef8dddba Issue-ID: POLICY-689 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-13Fixed the SDK Junits and cleaned unused coderb71473-491/+10
Moved file tmp object from try resources block. due to not closing the stream the inputstream read by xacmlpolicyscanner ended with premature file error. Cleaned unused code. Issue-ID: POLICY-584 Change-Id: I92c4d000d94a144736d9ac46db384785a7512593 Signed-off-by: rb7147 <rb7147@att.com>
2018-03-12Sonar MajorSP005016381-1/+1
Move the null string literal on the left side of this string comparison CreateFirewallController.java:L347 Sonar Link: https://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AWBFphN0-08if2a6vI7H&resolved=false&severities=MAJOR Location: POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java Change-Id: I744a66f3622fb7db0933c7c7dabc520e859cff4d Issue-ID: POLICY-685 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-08JUnit additions for BRMS,POLICY-SDK-APPbobbymander3-0/+182
Issue-ID: POLICY-598 Change-Id: Ic3d9ca2a5f6c29f772bd747612d6c7caeb15eb7f Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-08Merge "Change ng-click to ng-change"Jorge Hernandez1-1/+1
2018-03-07Change ng-click to ng-changeWang,Frank(gw1218)1-1/+1
The ng-click on MS version dropbox triggered event function even for the same MS version and called the event function again after selected a different version. Issue-ID: POLICY-655 Change-Id: I4e007f08e574ddd7899f0fde133bda2cac1be7d5 Signed-off-by: guangxingwang <gw1218@att.com> Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com> Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-03-06Added Junits for POLICY-SDK-APPrb71472-5/+93
Issue-ID: POLICY-600 Change-Id: Ib96b7ccede0fa09e71f02ff073c89682e9aa7089 Signed-off-by: rb7147 <rb7147@att.com>
2018-03-05Remove auto generated rule to the drlpa834y3-30/+35
Issue-ID: POLICY-488 Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b Signed-off-by: pa834y <pa834y@att.com>
2018-02-27Merge "JUnit additions for XACML,REST,POLICY-SDK"Jorge Hernandez1-0/+64
2018-02-27Merge "Policy:Major"Pamela Dragosh1-6/+6
2018-02-27JUnit additions for XACML,REST,POLICY-SDKbobbymander1-0/+64
Issue-ID: POLICY-584 Change-Id: I4bb91b18122c7f61bb71b1a9e39d51cd65af70bd Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-27Code Clean Up for Policy PAP-RESTrb71474-27/+22
Cleaned the duplicate code for all dictionary controllers and created Utils class. Issue-ID: POLICY-600 Change-Id: I65b8574d9f667758407515a5c55bc28f636be477 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-27Policy:MajorManamohan Satapathy1-6/+6
Local variables should not shadow class field:L992 L1719 Issue-ID: POLICY-649 Sonar Link: https://sonar.onap.org/issues?myIssues=true&projectUuids=AV2blNLJ5bp_wwmIUP3L&resolved=false&severities=CRITICAL%2CMAJOR&types=CODE_SMELL Location:POLICY-SDK-APP\src\main\java\org\onap\policy\controller\CreateDcaeMicroServiceController.java Change-Id: I1d038829867c7d019473909650946a9539b5e736 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-02-21Merge "Added Junits for POLICY-SDK-APP controllers"Jorge Hernandez7-3/+270
2018-02-21Added Junits for POLICY-SDK-APP controllersuj426b7-3/+270
Issue-ID: POLICY-584 Change-Id: I306f3484f466accf11ca4fd59864a4b402dcb733 Signed-off-by: uj426b <uj426b@att.com>
2018-02-20Added Junits for Policy PAP-RESTrb71477-751/+4
Clenaed the unsued code. Cleaned the duplication of code and moved to ONAP-REST. Added Junits for PAP-REST Issue-ID: POLICY-600 Change-Id: I56e6e8f2f547def9eaf8624a9e0dd52dc05ad136 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-19Fix Fortify Scan Issue:guangxingwang3-9/+12
1) Fix Fortify Header Manipulation issue by checking the format of the message before adding it response header. 2) Fix Fortify Hardcoded Password issue by using encryption and decryption Issue-ID: POLICY-543 Change-Id: I16b44b9b0670b1af75094c9ae9d1f7d352fa894a Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-18Merge "Added Junis for Policy ONAP-REST"Jorge Hernandez1-14/+1
2018-02-16Added Junis for Policy ONAP-RESTrb71471-14/+1
Cleaned the unused constructors. Cleaned the unused code. Added Junits for all JPAS. Renamed the Junit class names on removing classes. Issue-ID: POLICY-603 Change-Id: I0709ccecd7a2f3ec49367ff85f5a6d273479493e Signed-off-by: rb7147 <rb7147@att.com>
2018-02-16Resolved the POLICY-SDK-APP junit issue.uj426b1-28/+23
Issue-ID: POLICY-584 Change-Id: I90aaec29e908b742f0866d2754d426f75e1b8953 Signed-off-by: uj426b <uj426b@att.com>
2018-02-13Fix a Bug on Editor Screenguangxingwang1-0/+7
On editor screen, sometimes click on + button only one click, it creates more than text fields Issue-ID: POLICY-629 Change-Id: I9acc95fa0a4a7df3828e579f994c06bfa3199eb5 Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-08Remove Password from Loggingguangxingwang1-2/+2
Fix Fortify logging issue Issue-ID: POLICY-544 Change-Id: Ibfc7665dcab229a705ec3f999545b14675c24430 Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-08Merge "MS Model Input Validation"Pamela Dragosh1-9/+11
2018-02-08MS Model Input ValidationMichael Mokry1-9/+11
- Provides validation for MS policy input content body that matches the GUI validations when create/update MS policy from API - Added changes to satisfy review comments and updated copywright headers for modified and new files Change-Id: I02bfa639bffb48520badd0e4fa34eb36418547ae Issue-ID: POLICY-377 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-02-07FFix the Bug of Missing fields on View Screenguangxingwang1-18/+47
Missing extra fields added by clicking add buton if they are more than 10 on view screen Issue-ID: POLICY-613 Change-Id: I9e718b62301f24b71a4f6506d3e63e6185e0b1ce Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-06Policy Resiliency Code Fixesrb71473-202/+314
Resolved the issue on updating the configuration files when rename/clone/export/move actions are done through GUI. Fixed the PolicyManagerServlet code. Added test cases for newly added files. Issue-ID: POLICY-609 Change-Id: I9d14f19fe20bbc0e3b3844f85d81f26e34bb26ec Signed-off-by: rb7147 <rb7147@att.com>
2018-02-05Remove technical debtPamela Dragosh4-16/+22
* String literals on the left * Unnecessary initialization of variables * Change ArrayList to using List * Remove extra semicolons * Empty Constructor comments * Useless parenthesis I also added a comment on some code that is suspicious. Not comfortable with changing that code. Issue-ID: POLICY-482 Change-Id: I89d889737d398d047fab4b25cb5d962ee1ecdd03 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-02Resolved Fortify System Information Leak issuesrb71473-3/+6
Issue-ID: POLICY-550 Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f Signed-off-by: rb7147 <rb7147@att.com>
2018-02-01Included Policy GUI Enhancements and validationsrb714739-627/+712
Added hover messages for all policy templates. Resolved few sonar issues. Added fixes for Policy GUI Validations. Issue-ID: POLICY-597 Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c Signed-off-by: rb7147 <rb7147@att.com>
2018-02-01Merge "Reduce technical debt"Jorge Hernandez3-102/+87
2018-01-31Fixed the Sonar technical debt.Ankitkumar Patel1-1/+1
Fixed the sonar technical dept primarily for the POLICY-REST module, and accordingly updated the other policy-engine modules for successful built. Issue-ID: POLICY-476 Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-01-31Reduce technical debtPamela Dragosh3-102/+87
The last for technical debt I believe. The last try-with-resources I dare to fix. Useless import that I missed last time. Did a couple of minor reductions in cyclomatic complexity that I think are harmless. And lastly introduce a new variable instead of reusing a parameter. Issue-ID: POLICY-482 Change-Id: I5f2e5abbdd472496b48cf12e485fc9b4d903f35a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-31Adding code coverage reduce duplicate linesPamela Dragosh11-126/+236
Removed some duplicate code across some of the classes. For CheckPDP, got the code coverage above 80%. Issue-ID: POLICY-482 Change-Id: I41495cf9f92e8fd248350bf33f5a183c876f38f2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-30Fix technical debt and reduce linesPamela Dragosh9-94/+83
Focused on iterating over entrySet along with more fixes for dead stores, unnecessary exceptions. I'm also starting to work on reducing the number of code lines. * Iterate using entrySet * Remove useless assignments * Unnecessary exceptions * Use StringBuilder instead of StringBuffer due to synchronization * Potential null exceptions being thrown * Returning a empty collection vs null Issue-ID: POLICY-482 Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-29Reduce technical debtPamela Dragosh17-218/+195
Focusing on easy try-with-resources changes. Plus some other minor items. I did not get all of them yet, as some have some heavy refactoring. These try-with-resources seem to be fairly harmless. * Utilize try-with-resources * Remove unnecessary parenthesis * Merging simple if statements * Remove useless assignment * Moving string literals to left hand side Issue-ID: POLICY-482 Change-Id: If519ec8ea96f6b90bf82ac2676ffea9cd0cd2daf Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-26Use try-with-resourcesPamela Dragosh2-26/+48
Also enhanced JUnit tests to ensure this will work. Reduced code. Issue-ID: POLICY-482 Change-Id: If07e17df274bdb709f7ca60078bd1fbd78d1aaaa Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-23Reduce technical debtPamela Dragosh10-100/+98
Mainly use StringBuilder() to improve speed * Use StringBuilder * Remove superflous exceptions in constructor * Remove unnecessary casts * Remove unnecessary toString() * Combine return into one statement * Move string literal to LHS Issue-ID: POLICY-482 Change-Id: Id196728d92dda7fab7e83d6eea07633c5be37f7c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-23Addressing Technical Debt for POLICY-SDK-APPPamela Dragosh27-177/+161
* Using booleans true and false * Using already predefined static strings * Adding private constructors to hide implicit * Adding empty constructor comment to satisfy SONAR * Using single quotes for indexOf to use faster method * Preferred use of .isEmpty() * Ordering of public static synchronized syntax * Removing commented out code * Using an already defined constant * Unnecessary declaration of runtime exceptions * Unnecessary casts * Unused variables and imports * Unnecessary use of toString() * Just using return vs storing into a local var and returning that * Extra semicolons Issue-ID: POLICY-482 Change-Id: I6b9dcc5211dd52895a8787239b9df3059928fa45 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-16Restrict file upload size in policy editorMagnusen, Drew (dm741q)2-10/+28
Restrict file upload size in Policy Editory using a configurable value (in bytes) set in xacml.admin.properties. Default value is 30MB. Issue-ID: POLICY-538 Change-Id: I4d8539ab33320446aed250ea4fdc51de585d5f2a Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>