summaryrefslogtreecommitdiffstats
path: root/POLICY-SDK-APP/src/main/java
AgeCommit message (Collapse)AuthorFilesLines
2018-02-01Merge "Reduce technical debt"Jorge Hernandez3-102/+87
2018-01-31Fixed the Sonar technical debt.Ankitkumar Patel1-1/+1
Fixed the sonar technical dept primarily for the POLICY-REST module, and accordingly updated the other policy-engine modules for successful built. Issue-ID: POLICY-476 Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-01-31Reduce technical debtPamela Dragosh3-102/+87
The last for technical debt I believe. The last try-with-resources I dare to fix. Useless import that I missed last time. Did a couple of minor reductions in cyclomatic complexity that I think are harmless. And lastly introduce a new variable instead of reusing a parameter. Issue-ID: POLICY-482 Change-Id: I5f2e5abbdd472496b48cf12e485fc9b4d903f35a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-31Adding code coverage reduce duplicate linesPamela Dragosh6-123/+134
Removed some duplicate code across some of the classes. For CheckPDP, got the code coverage above 80%. Issue-ID: POLICY-482 Change-Id: I41495cf9f92e8fd248350bf33f5a183c876f38f2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-30Fix technical debt and reduce linesPamela Dragosh9-94/+83
Focused on iterating over entrySet along with more fixes for dead stores, unnecessary exceptions. I'm also starting to work on reducing the number of code lines. * Iterate using entrySet * Remove useless assignments * Unnecessary exceptions * Use StringBuilder instead of StringBuffer due to synchronization * Potential null exceptions being thrown * Returning a empty collection vs null Issue-ID: POLICY-482 Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-29Reduce technical debtPamela Dragosh17-218/+195
Focusing on easy try-with-resources changes. Plus some other minor items. I did not get all of them yet, as some have some heavy refactoring. These try-with-resources seem to be fairly harmless. * Utilize try-with-resources * Remove unnecessary parenthesis * Merging simple if statements * Remove useless assignment * Moving string literals to left hand side Issue-ID: POLICY-482 Change-Id: If519ec8ea96f6b90bf82ac2676ffea9cd0cd2daf Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-26Use try-with-resourcesPamela Dragosh1-26/+13
Also enhanced JUnit tests to ensure this will work. Reduced code. Issue-ID: POLICY-482 Change-Id: If07e17df274bdb709f7ca60078bd1fbd78d1aaaa Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-23Reduce technical debtPamela Dragosh10-100/+98
Mainly use StringBuilder() to improve speed * Use StringBuilder * Remove superflous exceptions in constructor * Remove unnecessary casts * Remove unnecessary toString() * Combine return into one statement * Move string literal to LHS Issue-ID: POLICY-482 Change-Id: Id196728d92dda7fab7e83d6eea07633c5be37f7c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-23Addressing Technical Debt for POLICY-SDK-APPPamela Dragosh27-177/+161
* Using booleans true and false * Using already predefined static strings * Adding private constructors to hide implicit * Adding empty constructor comment to satisfy SONAR * Using single quotes for indexOf to use faster method * Preferred use of .isEmpty() * Ordering of public static synchronized syntax * Removing commented out code * Using an already defined constant * Unnecessary declaration of runtime exceptions * Unnecessary casts * Unused variables and imports * Unnecessary use of toString() * Just using return vs storing into a local var and returning that * Extra semicolons Issue-ID: POLICY-482 Change-Id: I6b9dcc5211dd52895a8787239b9df3059928fa45 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-16Restrict file upload size in policy editorMagnusen, Drew (dm741q)2-10/+28
Restrict file upload size in Policy Editory using a configurable value (in bytes) set in xacml.admin.properties. Default value is 30MB. Issue-ID: POLICY-538 Change-Id: I4d8539ab33320446aed250ea4fdc51de585d5f2a Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2018-01-12Local and Class variable name conflict resolvedSRINIVAS V1-3/+3
*Renamed the local variable to othername Change-Id: I5f1e1b8b9140acf73de241f78b0437dc9e5805b5 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-12Fixed as per Java Code Conventionsroot11-9/+9
*Moved the constructors after the variables Change-Id: I099f75aea285f0bb845d464065d1e5f031d44a13 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-11Removed useless parenthesesroot11-1/+1
*Removed those useless parentheses Change-Id: I19e9e027182dfd7dc2211d71fbb4acd8bf6b8be5 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-11Merge "Fixed as code optimization"Pamela Dragosh1-4/+2
2018-01-11Fixed as per Java Code Conventionsroot11-2/+8
*Moved the constructors after the variables Change-Id: I531a911570867e05d2eabca98d349f4f2f26d0f9 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-09Fixed as code optimizationSRINIVAS V1-4/+2
*no need to create seperate object, so optimized Change-Id: I245d7fd26c0fabb26de6e9eb7c8bedf405d9d602 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-08Fixed as per Java Code ConventionsSRINIVAS V1-9/+11
*Moved the constructors after the variables *Deleted the commented code Change-Id: I6afa9ae5b04fe5c8280fc9e08352aef699117567 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-03Merge "Adding SONAR fixes for"Pamela Dragosh2-9/+1
2017-12-11Resolved the Policy GUI Javascript issuesrb71471-9/+29
Issue-ID: POLICY-440 Change-Id: I44d5304699da19bee7ae2997565802fc7d44cb0e Signed-off-by: rb7147 <rb7147@att.com>
2017-12-11Adding SONAR fixes forMichael Mokry2-9/+1
- pushPolicy defect fixes for POLICY-486 - Common Policy Validation feature for POLIYC-449 Change-Id: I8d54aa5a9b819c6eb4427dfa47c4ce963a21c2e0 Issue-ID: POLICY-449,POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-12-08Upgraded the latest ONAP SDKrb714721-161/+268
Upgraded latest ONAP SDK Code. Change-Id: I669d6cfcefe068b1e4c078889d7d6c77ce788e2e Issue-ID: POLICY-432 Signed-off-by: rb7147 <rb7147@att.com>
2017-12-04Refactor to provide Common Policy ValidationMichael Mokry3-581/+19
Provides a common class to perform policy validation during create/udpate of policies by the GUI and API for consistency. Change-Id: Ied459e73d48517bb50064cd10d6a1c871b8311e5 Issue-ID: POLICY-449 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-11-02Resolved Policy Blocker issuerb71471-11/+5
Issue-ID: POLICY-411 Change-Id: I9579a1fa58a4b40aa6aa70a3007b3ce7c02f5ca2 Signed-off-by: rb7147 <rb7147@att.com>
2017-10-31Merge "Fixed TOSCA parsing bugs"Jorge Hernandez1-23/+204
2017-10-31Fixed TOSCA parsing bugsguangxingwang1-23/+204
Fixed TOSCA paring bugs and retuned error messages to front-end. Issue-ID: POLICY-405 Change-Id: Idc6efd062360acbb4ceb143af8619b5f7def723a Signed-off-by: guangxingwang <gw1218@att.com>
2017-10-26Updated the DB Script with New TOSCA modelrb71471-0/+8
Added the caching issue while uploading the model to db. Issue-ID: POLICY-372 Change-Id: I10bfcead0a5cbcb1484858a79976b7c86fba3ece Signed-off-by: rb7147 <rb7147@att.com>
2017-10-10Fixing the BRMS rule generation issueTej, Tarun1-6/+6
Fixing the rule params section to look for PapParams istead of Params. This will be a temporary solution for now. Issue-Id: POLICY-302 Change-Id: I4b6b415b3eacf121be374d2dfd50303049c35aba Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-10-06Fixed bug introduced by sql injeciton protection.Temoc Rodriguez2-61/+67
Added missing colon before the named parameters. Fixed a typo parameter name. Fixed bad cast by setParameter. This fixes issues encountered in the UI. Whenever a policy is moved, renamed, or deleted it makes a db call and that db call fails on setParameter method. This hibernate method is supposed to automatically detect the type of the object for the named parameters but it fails with type Long. It tries to convert to int and it fails. A check is now added for type Long. Issue-ID: POLICY-278 Change-Id: Idbb4067a5ec2cc9d9b040de9e574ba2564e1ee2c Signed-off-by: Temoc Rodriguez <cr056n@att.com>
2017-09-27Added R1 MS Tosca templaterb71471-1/+1
Added the MS Tosca template to db scripts and cleaned up old policies. Issue-Id: POLICY-264 Change-Id: I0ee5cffbb78d1f7df0379b71fe0f3368587aa9a6 Signed-off-by: rb7147 <rb7147@att.com>
2017-09-25String literal comparision on left siderama-huawei2-9/+9
Used isEmpty instead of size method Issue-ID: POLICY-239 Change-Id: I9007fa99b40e53000a972147079ec6db4ecc7a66 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-21Merge "Added Junits for POLICY-SDK-APP"Pamela Dragosh6-29/+44
2017-09-21Added Junits for POLICY-SDK-APPrb71476-29/+44
Issue-Id: POLICY-52 Change-Id: I439c95736f50fe9140e71cad5a598c5b5239161b Signed-off-by: rb7147 <rb7147@att.com>
2017-09-21Merge changes from topic '13891'Jorge Hernandez3-19/+22
* changes: String literal comparision on left side Used isEmpty to check collection is empty or not
2017-09-21String literal comparision on left siderama-huawei2-6/+12
Issue-ID: POLICY-239 Change-Id: Iee03160b28ffadb296f3926c7d7c5ac98fac535e Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-21Used isEmpty to check collection is empty or notrama-huawei1-13/+14
Issue-ID: POLICY-239 Change-Id: I5c6a43ac0f66e02b4f2f6644f0936a846708e2a5 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-20Merge "Fix for Sonar major issues"Pamela Dragosh3-26/+25
2017-09-20Fix for Sonar major issuesrama-huawei3-26/+25
Moved the string literal on the left side of the actual string comparison. Added the "@Override" annotation for method signature Removed the useless assignment to local variables Issue-ID: POLICY-239 Change-Id: I5fb84bb6109c03c8c0850100b69df095d865b404 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-19Added Junits for POLICY-SDK-APPrb71475-10/+83
Issue-Id: POLICY-52 Change-Id: Ic13cc5a6a32e65e301f1dcdc437f1de8ba6c00d8 Signed-off-by: rb7147 <rb7147@att.com>
2017-09-15Merge "Adding Junits for policy engine"Jorge Hernandez3-154/+30
2017-09-15Sonar MajorSwapnilPathak1-1/+1
Remove useless parentheses from CheckPDP.java Issue-ID: POLICY-224 Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab453ae7 Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
2017-09-15Adding Junits for policy engineTej, Tarun3-154/+30
Adding Junits to Policy Engine Utils project, removed duplicates, fixed few defects along the way and fixes to projects. Issue-Id: POLICY-52 Change-Id: Ia0598300f9bd60f5372b9ef7d8984657478a1611 Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-09-14Fix sonar blocker to close handlePamela Dragosh1-5/+8
Upgraded the dependency also. What was strange was the documentation that came up did not match with the existing dependency code implementation. Issue-ID: POLICY-113 Change-Id: Ide7830851cda6535ed335e89cdfc0e0a3964e3eb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-14Sonar MajorSwapnilPathak1-3/+1
Merge this if statement with the enclosing one Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab453ae8 Issue-ID: POLICY-233 Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
2017-09-12Resolved Policy GUI Issuesrb71479-110/+39
Resolved the time to leave date issue field to support all browsers. Resolved Export and Import Policy Functionality. Added few GUI cosmetic fixes. Issue-Id : POLICY-221 Change-Id: I920a4d9c8e16ae1cffcd13df3319e109a992ba55 Signed-off-by: rb7147 <rb7147@att.com>
2017-09-11sonar blocker/critical fixesTej, Tarun2-2/+2
Fixes for sonar critical and blocker issues Issue-Id: POLICY-113 Change-Id: I33bf28abfc52bf289401c58409beaac01b5c2fa6 Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-09-11Enhanced MS JSON Generationguangxingwang1-5/+116
This enhancement excludes empty attributes and objects from creating MS Json file. Issure-Id: POLICY-193 Change-Id: I139012456fdc44b0ef6d58c208f1ee5db6bcf910 Signed-off-by: guangxingwang <gw1218@att.com>
2017-09-06Added missing license headersTej, Tarun1-0/+20
Added license headers for files missing them. Issue-Id: POLICY-205 Change-Id: If4124bbf0f7737df58b8289472e1f3c0d2bbf587 Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-08-23Fixes for sonar critical issuesTej, Tarun15-273/+312
Fixes for critical and blocker issues reported in sonar. Issue-Id: POLICY-113 Change-Id: I50969fe93a94b0497f3fb30864a6c45e63208fe6 Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-08-14Add fix for SQL injection.Rodriguez, Cuauhtemoctzin (cr056n)8-133/+232
Add fix for SQL injection by passing parameters into getDataByQuery method and binding parameters. Add junit test file. Override equals and hashcode methods for more thorough testing on ActionBodyEntity, ConfigurationDataEntity, PolicyEntity, PolicyVersion, WatchPolicyNotificationTable classes. Issue-Id: [POLICY-158] Change-Id: Icebe1ca1ff01c8ea7435729967f4d349a1026054 Signed-off-by: ITSERVICES\cr056n <cr056n@att.com>
2017-08-10Fix console issuesTej, Tarun7-26/+7
Reverted package names to org.openecomp to fix portal issues Issue-ID: POLICY-144 Change-Id: Ie108db431b9d211b15c59a29e564517c785e0da5 Signed-off-by: Tarun Tej Velaga <tt3868@att.com>