summaryrefslogtreecommitdiffstats
path: root/ONAP-XACML
AgeCommit message (Collapse)AuthorFilesLines
2018-08-14Optimize PAP policy constructor with builderKrishnajinka3-248/+240
Fix sonar issue about constructor using more than 7 params. Use builder parameters object for setting the attributes of std pap policy.Recommit1 Issue-ID: POLICY-1016 Change-Id: Id9631a42813960baa78df4ab0c0f6706244c3180 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-13Modify std pap policy to use builder in constrKrishnajinka3-68/+190
Fix sonar issue about constructor using more than 7 params. Use builder parameters object for setting the attributes of std pap policy.Rework2 Issue-ID: POLICY-1016 Change-Id: If26f7daa8d5b5d387238aad74daeddd49a8b95bb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-10Add PAP Policy parameter builder xacml policykrishnajinka3-948/+1216
Fix Sonar flagged major issue about 14 params instead of 9 in the constructor of std pap policy class. Commit5 for modify constrctor.fix test Issue-ID: POLICY-1016 Change-Id: I79c8482b7fc4e203cb18402ba2b5a68a120c57b1 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-08-08Fix sonar issue with constrctr in xacml compkrishnajinka3-318/+550
Fix sonar issue of Method has 9 parameters, which is greater than 7 authorized in StdPDPPolicy. Make the actual sonar fix Issue-ID: POLICY-1016 Change-Id: Ibc79ddce81a6209ec190c7f393557e9c569df453 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-07-23Add modified copyright noticeKrishnajinka1-244/+245
For the files which are modified add modified copyright notices as per comments from earlier review Issue-ID: POLICY-1002 Change-Id: I873b3ccc986d5f3d138ddb9e9b3c2307a0b127a6 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-20FIX SONAR ISSUE NESTED TRY BLOCKSKrishnajinka1-1/+1
refactor the code for nested try blocks and rework based on comments and fix nested loops complexity Issue-ID: POLICY-976 Change-Id: Ied02b7838b5e4839a4906f79ff37c4fd6afeccfe Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-06-27Merge "Address missing files in junit tests"Liam Fallon2-0/+44
2018-06-27Merge "Don't use hard-coded tmp path"Liam Fallon2-8/+21
2018-06-27Merge "Fix console warning about xacml.properties"Liam Fallon1-0/+2
2018-06-26Address missing files in junit testsJim Hahn2-0/+44
Renamed logback.xml to logback-test.xml. Added policyLogger.properties to config directories. Change-Id: Ib6f50666a13c3258482b4007e7ceeb742f2e87a6 Issue-ID: POLICY-784 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-26Remove %h from log file namesJim Hahn1-2/+2
Modified code, either removing "%h" or replacing it with a directory name that is relative to the junit test. Change-Id: I6ea3e3139a04fefadca42340454be36a5b54445d Issue-ID: POLICY-784 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-26Fix console warning about xacml.propertiesJim Hahn1-0/+2
Configured location of property file. Change-Id: I58a89b34aa58f4efd6ed3ee0f984869ee7bf2f6c Issue-ID: POLICY-921 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-26Don't use hard-coded tmp pathJim Hahn2-8/+21
Modified code to use java system variable to identify temp directory. Change-Id: Ib656dd2a2d57e43febb0daaa25cf90cb1b9330a7 Issue-ID: POLICY-920 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-08Remove "&quot;" from logback xml filesJim Hahn1-2/+2
Logback complains if %d{} values contain "&quot;", but it works fine without them, thus they have been removed. Update licenses. Change-Id: Id1f21d3d51bb2495a92f54fcf5c3ad978612c375 Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-05Update engine to SNAPSHOT-1.3.0liamfallon1-1/+1
Snapshot updated for Casablanca. Change-Id: Ieb2c9a990c0f36f31c974038465e7d38aaa21e5d Issue-ID: POLICY-875 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-21Update Policy Engine to 1.2.3-SNAPSHOTliamfallon1-1/+1
These reviews must be merged in order because of layering. This review should be merged FOURTH. Change-Id: Ifca8e33b79085a4032164b44dae3401f8179f5f6 Issue-ID: POLICY-844 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-16Upgrade SNAPSHOT to 1.2.2liamfallon1-1/+1
These reviews must be merged in order because of layering. This review should be merged SECOND Note: In order to get past the following layering problems, there are temporary chages to the following POMs to temporarily use 1.2.1-SNAPSHOT for those dependencies. They are ONAP-PAP-REST/pom.xml org.onap.policy.drools-applications.controlloop.common.policy-yaml ONAP-PDP/pom.xml org.onap.policy.drools-pdp.policy-endpoints A separate review will be used to restore these dependencies to 1.2.2-SNAPSHOT once the drools-pdp and drools-applications reviews are submitted and merged PLD added version.properties Issue-ID: POLICY-798 Change-Id: Id7e83f2ba12181c63cc8845b7eeccf2004d2bab9 Signed-off-by: liamfallon <liam.fallon@ericsson.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com> Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-20Build fails when build host running web serverliamfallon1-3/+3
If the host on which the policy engine is running a web server that respoonds with a HTTP response on the URL "http://localhost", the build fails because one of the tests in ONAP-XACML expects a ConnectException on this URL. When the URL returns a valid respose the test fails causing the buld to fail. This fix changes the URL to "http://localhost:54287", which I guess could also exist but is much less liekly to exist. Change-Id: I2f80d12a80d29a9bc7b2067f35c286f01c4d9550 Issue-ID: POLICY-700 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-19Add license to policy-engine filesJim Hahn9-46/+188
Added license to various files. Updated XACMLPolicyScanner to work even when license comment is added to the Policy.xml file. Moved DOCTYPE before license in html files. Removed license from css files, as many are generated or come from third-party software. Removed license from other generated files. Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e Issue-ID: POLICY-741 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-04-13Upgrade to SNAPSHOT 1.2.1Pamela Dragosh1-1/+1
Issue-ID: POLICY-736 Change-Id: If5c959aa1c0a123c7fd9eee281e39e1d646b6b03 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-02JUnit additions for PDP,PDP-REST,SDK,XACMLbobbymander1-29/+51
Issue-ID: POLICY-600 Change-Id: I8052451c3f66116f361f2963fcc2727c022dd4d9 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-30JUnit additions for XACML,PAP-RESTbobbymander3-75/+391
Issue-ID: POLICY-605 Change-Id: I4b55a85eacf989ddb55743300e7f75e4b72882d0 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-28POM changes to centralize test scope depsbobbymander1-44/+1
Issue-ID: POLICY-600 Change-Id: I870317bbd125c6016818ec435ea7a406123c66c1 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-27JUnit additions and powermock pom fixesbobbymander3-23/+103
Issue-ID: POLICY-602 Change-Id: I2484b47cc52a07413de69c1022a056fd0cf2d7d7 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-26New Optimization PolicyMichael Mokry1-1/+1
This is the new Optimization Policy to support the Integration of the OOF Policy Model into the Policy Platform. Added changes from Frank Wang to fix the following issues with existing Model Parser: 1. TOSCA Rendering issues 2. Matching Attributes support 3. ImportModelAPI to support TOSCA model upload via REST API Running local Sonar tonight to start fixing Sonar issues Added changes per review comments and fixed Sonar issues Change-Id: Ia8ce09c28a718ce4460475e76a750caef774bd6b Issue-ID: POLICY-622 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-03-20Fix all bugs reported by Sonar in policy/engineeramkve1-11/+1
Code fixes for 27 bugs reported by Sonar in policy/engine Change-Id: I96da96b38a2e2954ec549e5cdf6ed3ad1d76722c Issue-ID: POLICY-662 Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>
2018-03-01Remove CLM issues with commons-collectionsPamela Dragosh1-0/+9
We know that we are not configuring an LDAP PIP in our use of the XACML open source. The LDAP implementation uses Apache Velocity, which uses a very old version of commons-collections that has security issues. So we can exclude commons-collections from the build. Issue-ID: POLICY-507 Change-Id: I735eae4fe507ad016d9b0b49e67536415edb9820 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-01JUnit additions for PAP-REST,REST,XACMLbobbymander2-0/+42
Issue-ID: POLICY-603 Change-Id: I78c5e302c474613cbb22a80e0d931b4f47dd3b63 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-27JUnit additions for XACML,REST,POLICY-SDKbobbymander1-0/+48
Issue-ID: POLICY-584 Change-Id: I4bb91b18122c7f61bb71b1a9e39d51cd65af70bd Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-22JUnit small additions for PAP-REST,PDP-REST,XACMLbobbymander1-3/+40
Issue-ID: POLICY-600 Change-Id: I1b012dd1dbc49c10cd47b5f100e8ccef6c92f70b Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-22Fix Fortify Path Manipulation Issueguangxingwang1-2/+2
Fix Fortify path manipulation issue by adding a validation on dictionary name. Issue-ID: POLICY-541 Change-Id: I87492b0d80bf96bebfc029d7d164cdd20ca5ef0f Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-21Fix Fortify Log Forging Issueguangxingwang1-3/+3
Fix Fortify log forging issue by removing properties info from logging. Issue-ID: POLICY-544 Change-Id: I6e7d39abe18698f864564844963d7bbddedd2e3b Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-16JUnit test for policy/engine ONAP-XACMLmmis8-740/+2076
Increased junits in package org.onap.policy.xacml.test.std.pap in policy/engine ONAP-XACML Change-Id: Ifef6fcc36044039b2c3d0c0dbffecffd3e242434 Issue-ID: POLICY-605 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-02-14Make drlRuleAndUIParams transient or serializableSwapnali Pode1-1/+1
Make drlRuleAndUIParams transient or serializable StdPAPPolicy.java:L72 Sonar Link: https://sonar.onap.org/project/issues?assignees=swapnalipode&id=org.onap.policy.engine%3APolicyEngineSuite&open=AWF91ipr8TZzbCgU6aom&resolved=false Location: src/main/java/org/onap/policy/xacml/std/pap/StdPAPPolicy.java Change-Id: I3524881e76c69518949a622a23084e0bc8ef26a2 Issue-ID: POLICY-631 Signed-off-by: Swapnali Pode <SP00501638@techmahindra.com>
2018-02-09Upgrading XACML jarPamela Dragosh1-1/+1
XACML was released with minor fixes for XML files with comments. Mainly it contained upgrade to dependencies that had fixed security issues. One still remains but will not be able to be fixed. Issue-ID: POLICY-617 Change-Id: Ib143c87156ed6a15cf4f0fe0ecbedb2407ca5b0d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-06Continue addressing technical debt for ONAP-XACMLGao, Chenfei (cg287m)15-155/+122
Fix all sonar issues that do not require code refactoring Issue-ID: POLICY-475 Change-Id: Iefa91e0048b7041c96d47bce7ec99034d6fcc427 Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
2018-02-02Resolved Fortify System Information Leak issuesrb71475-17/+3
Issue-ID: POLICY-550 Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f Signed-off-by: rb7147 <rb7147@att.com>
2018-01-31Continue addressing technical debt for ONAP-XACMLGao, Chenfei (cg287m)4-7/+5
Follow the list of acceptable fixes in POLICY-336 description Issue-ID: POLICY-475 Change-Id: I67f46bb383db1ac4feecb0223df98d180733fc95 Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
2018-01-29Addressing Technical Debt for ONAP-XACMLGao, Chenfei (cg287m)13-142/+137
Follow the list of acceptable fixes in POLICY-336 description Issue-ID: POLICY-475 Change-Id: I45cfb55c571d32601049beb8e5be8676216dcf5c Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
2018-01-16PDPGroup Audit FixMichael Mokry1-0/+1
*This fix will add new group to GroupEntity table if no default exists during initialization and therefore provides a permanent solution to the initialization errors on the PAP Change-Id: Ie394d76b9cbc02cad15d62d6adea6fc17938f734 Issue-ID: POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com> (cherry picked from commit 676d7d8dc9985e93d7c9cbc0412a26f2b19c23cd)
2017-12-05Modified the code to fix various pushPolicy issuesMichael Mokry1-1/+1
- Added modifications per Pam's review Change-Id: I5d67ee529cbc5245e7d1f8dbec6f2f2d453ce299 Issue-ID: POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-11-21Bump minor versionJessica Wagantall1-1/+1
Bump minor version in preparation for Amsterdam branching. Change-Id: I61e0ae91e3ece54ed09a88dad9b8dac173ccae07 Issue-ID: CIMAN-120 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-11-15Update to v1.1.2-SNAPSHOTPamela Dragosh1-1/+1
Release 1.1.1, moving patch to 1.1.2 Issue-ID: POLICY-436 Change-Id: Iabde3e56c04c68ca966efde09b5780e6275cb8a8 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-11-08Update SNAPSHOT versionPamela Dragosh1-1/+1
Releasing v1.1.0 so need to update to v1.1.1 Issue-ID: POLICY-436 Change-Id: Ic575e75d0321c3de2074f8e23d2d0bbd11f6a229 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-26Policy API support for Rainy Day Decision PolicyMichael Mokry2-6/+18
Enhances the Rainy Day Decision Policy by providing API support to manage Rainy Day Decision policies and dictionaries Change-Id: Ia7c49199ac057fa8bcc9de74f5e0b8dba395d43a Issue-ID: POLICY-269 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-09-22Merge "Add New Junit Tests For ONAP-XACML"Pamela Dragosh3-0/+546
2017-09-22Add New Junit Tests For ONAP-XACMLguangxingwang3-0/+546
Add three new java junit test files to ONAP-XACML Issue-ID: POLICY-52 Change-Id: I900f09c9baf773e46dadddf9d715af6033ffce0e Signed-off-by: guangxingwang <gw1218@att.com>
2017-09-21Add New Junit For ONAP-XACMLguangxingwang2-0/+644
Add new junit tests for ONAP-XAML Change-Id: I4b18b0ef7c693fed3848447d674321fb45437cb5 Issue-ID: POLICY-52 Signed-off-by: guangxingwang <gw1218@att.com>
2017-09-11sonar blocker/critical fixesTej, Tarun2-5/+5
Fixes for sonar critical and blocker issues Issue-Id: POLICY-113 Change-Id: I33bf28abfc52bf289401c58409beaac01b5c2fa6 Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-09-11Health check issue fixesTej, Tarun1-3/+3
Fixes to PDP log parser failure issues and sonar fixes Issue-Id: POLICY-211 Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab452ae7 Signed-off-by: Tej, Tarun <tt3868@att.com>