summaryrefslogtreecommitdiffstats
path: root/ONAP-PDP-REST/src
AgeCommit message (Collapse)AuthorFilesLines
2018-10-05Fix sonar bugPamela Dragosh1-243/+274
Somehow this creeped into sonar. Not sure why it wasn't flagged before. Fixed tabs and indentation. Removed unnecessary close() statement for a try-with- resources statement. Issue-ID: POLICY-1186 Change-Id: I5499279fe7adf642a7f7dc8a53c1a27c24a0dcb3 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-25CADI AAF changes for policy/engineMichael Mokry1-134/+144
Added cadi properties and modified policy aaf client code. Fixed issue with namespace and modified code to reverse it for structuring the username sent in AAF API call Added properties for keystore and keystore password after getting error response from AAF when setting up the connection to AAF Missed a fix for one of Jorge's comments in last patch, here it is. Change-Id: Ic164ade8aa34da95a560c1592656e0caf990a595 Issue-ID: POLICY-913 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-09-18Fixes for oparent upgradePamela Dragosh1-1/+1
Clean up mariadb so that it is consistent, allow jetty to be defined by oparent, and fixes to fully support google guava upgrade. Issue-ID: POLICY-1126 Change-Id: Ic0c2fba5f6f5f1a41e53770b95861606a5b4bbe6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-10Resolved XACML Platform Sonar issuesrb71471-83/+54
Issue-ID: POLICY-902 Change-Id: If22627dfe7df993b5c725ddf3a66c10ebbaa73ca Signed-off-by: rb7147 <rb7147@att.com>
2018-09-05XACML Platform Enhancementsrb71474-1392/+1713
To Support Raw Policy Creation from GUI and API. GetDecision on combining algorithim with Policy Set. Issue-ID: POLICY-902 Change-Id: Ie3189f8ded2e03366bc7d65d15b95b88c89b0acd Signed-off-by: rb7147 <rb7147@att.com>
2018-08-30Upgrade to policy/parentPamela Dragosh1-316/+358
Change from oparent to policy/parent which inherit from the latest oparent. The latest oparent has dependencyManagement recommendations from the ONAP Security sub committee that the policy team is adhering as part of the effort to consolidate security work across projects. Change-Id: I1a43fc5a04dbc8c4cb2b7bedbca67ad3e9dd120b Issue-ID: INT-619 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-20Use builder for std pap policyKrishnajinka6-25/+115
Modify constructor in stdpappolicy to use builder this will fix the sonar issue related with more than 7 parameters method parameters Issue-ID: POLICY-1016 Change-Id: Id736a66e5ea48f0f233cffb640cdce8aaa8f2c0d Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-14Optimize PAP policy constructor with builderKrishnajinka5-12/+41
Fix sonar issue about constructor using more than 7 params. Use builder parameters object for setting the attributes of std pap policy.Recommit1 Issue-ID: POLICY-1016 Change-Id: Id9631a42813960baa78df4ab0c0f6706244c3180 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-13Modify std pap policy to use builder in constrKrishnajinka3-12/+33
Fix sonar issue about constructor using more than 7 params. Use builder parameters object for setting the attributes of std pap policy.Rework2 Issue-ID: POLICY-1016 Change-Id: If26f7daa8d5b5d387238aad74daeddd49a8b95bb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-10Add PAP Policy parameter builder xacml policykrishnajinka11-761/+824
Fix Sonar flagged major issue about 14 params instead of 9 in the constructor of std pap policy class. Commit5 for modify constrctor.fix test Issue-ID: POLICY-1016 Change-Id: I79c8482b7fc4e203cb18402ba2b5a68a120c57b1 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-07-25Fix issues reported by sonarKrishnajinka2-298/+282
Fix issues related to unused method variables, extract constants, not nest more than 3 control stmts, use try with res in policy engine project. Rework for comments Issue-ID: POLICY-1008 Change-Id: If0953de9e802110df14862707f3b525652cdf112 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-23Add modified copyright noticeKrishnajinka1-0/+1
For the files which are modified add modified copyright notices as per comments from earlier review Issue-ID: POLICY-1002 Change-Id: I873b3ccc986d5f3d138ddb9e9b3c2307a0b127a6 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-17USE TRY WITH RESOURCESKrishnajinka1-35/+35
Fix sonar issues to convert try blocks to try with resources plus change tabs 2 space Issue-ID: POLICY-961 Change-Id: I553d6a42f1efaab5b7eb3a53bab945a3360e69bb Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-07-13Reverting "Merge "fix try block""Jorge Hernandez1-2/+7
This reverts commit 240bbdbdc76e0e91af9f18164eadb2708d14c6fb, reversing changes made to 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf. Change-Id: I61f07ead1d7d3e89c512a2224efecf9ac440df10 Issue-ID: POLICY-961 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-07-13fix try blockKrishnajinka1-7/+2
Issue-ID: POLICY-961 Change-Id: Ia1f388368007a4a82a57520dc6ddd99cc484a393 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-06-08Remove "&quot;" from logback xml filesJim Hahn1-1/+1
Logback complains if %d{} values contain "&quot;", but it works fine without them, thus they have been removed. Update licenses. Change-Id: Id1f21d3d51bb2495a92f54fcf5c3ad978612c375 Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-05-08fixing NullPointException incase of db exceptionwaqas.ikram2-322/+310
Making changes for NullPointerException it was triggered by - SQL Query Failed in PAP return unhandled reponse code > activeVersion variable is set to null > if statement in DeletePolicyService (!activeVersion.equalsIgnoreCase("0") result into NullPointerException Change-Id: Iad9de0d31b6cf16d1eafd6175d1c355b07481db9 Issue-ID: POLICY-773 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-04-19Add license to policy-engine filesJim Hahn2-0/+40
Added license to various files. Updated XACMLPolicyScanner to work even when license comment is added to the Policy.xml file. Moved DOCTYPE before license in html files. Removed license from css files, as many are generated or come from third-party software. Removed license from other generated files. Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e Issue-ID: POLICY-741 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-04-03ONAP log files consolidationChou, Joseph (JC2555)2-9/+9
Check in changes for pap,pdp,console,brmsgw,paplp and pdplp Change-Id: I23525a44e0f269d04d9870c3eed18b6b8daacb2c Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-04-02JUnit additions for PDP,PDP-REST,SDK,XACMLbobbymander1-80/+106
Issue-ID: POLICY-600 Change-Id: I8052451c3f66116f361f2963fcc2727c022dd4d9 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-28Merge "ONAP code change for log files consolidation"Jorge Hernandez2-9/+9
2018-03-28ONAP code change for log files consolidationChou, Joseph (JC2555)2-9/+9
Undo the change so this would not block other test activity Change-Id: I4f7dd2e14f30034eefbf958be3c912af2962e8a2 Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-03-27JUnit additions and powermock pom fixesbobbymander2-487/+473
Issue-ID: POLICY-602 Change-Id: I2484b47cc52a07413de69c1022a056fd0cf2d7d7 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-26Merge "New Optimization Policy"Pamela Dragosh10-9/+258
2018-03-26New Optimization PolicyMichael Mokry10-9/+258
This is the new Optimization Policy to support the Integration of the OOF Policy Model into the Policy Platform. Added changes from Frank Wang to fix the following issues with existing Model Parser: 1. TOSCA Rendering issues 2. Matching Attributes support 3. ImportModelAPI to support TOSCA model upload via REST API Running local Sonar tonight to start fixing Sonar issues Added changes per review comments and fixed Sonar issues Change-Id: Ia8ce09c28a718ce4460475e76a750caef774bd6b Issue-ID: POLICY-622 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-03-26Merge "ONAP code change for log files consolidation"Jorge Hernandez2-9/+9
2018-03-23ONAP code change for log files consolidationChou, Joseph (JC2555)2-9/+9
Code change for log files consolidation of PAP, PDP, BRMSGW, Console and db script Issue-ID: POLICY-562 Change-Id: I416ba7748b841bb2b1a31682e2b1631e279549e8 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-03-22Merge "Fix vulnerabilities and bugs in policy/engine"Jorge Hernandez9-36/+34
2018-03-21JUnit additions for PDP-REST,REST,SDK-APPbobbymander1-0/+82
Issue-ID: POLICY-584 Change-Id: I3b16e2a957e67ecfe5c28d2afaa09771ae891216 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-21Fix vulnerabilities and bugs in policy/engineeramkve9-36/+34
Code fixes for 1 bug and 17 vulnerabilities reported by Sonar in policy/engine Change-Id: I7b641795c790ec15418bd9ae3a414279e1b0f733 Issue-ID: POLICY-662 Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>
2018-03-21Merge "Fix all bugs reported by Sonar in policy/engine"Pamela Dragosh3-3/+12
2018-03-20Fix all bugs reported by Sonar in policy/engineeramkve3-3/+12
Code fixes for 27 bugs reported by Sonar in policy/engine Change-Id: I96da96b38a2e2954ec549e5cdf6ed3ad1d76722c Issue-ID: POLICY-662 Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>
2018-03-14Update oparent version to 1.1.0liamfallon7-3/+15
Directive from ONAP project that all repos should be updated. Change vierified with a build with .m2 /org/onap cleared. The test cases are updated becasue changing the oparent version changed the order of test execution and tests failed due to the static data in PAPServices not being cleared. Clearing of PAPServices data in those test cases is now done in an @After method. The test case in the test below has a test dependency: ONAP-PDP-REST/src/test/java/org/onap/policy/pdp/rest/notifications/test/NotificationTest.java depends on com.att.aft.dme2 version 3.1.200-oss That dependency was added to the POM of ONAP-PDP-REST Issue-ID: POLICY-693 Change-Id: Ie070f9e94216f4a81f114380782a834ce8663fd5 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-03-08JUnit additions for PDP-REST,ONAP-SDK-APPbobbymander3-0/+144
Issue-ID: POLICY-602 Change-Id: I354415df7292656d60ce573fb5b004f5de25899a Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-06PolicyApiUtils junitsMagnusen, Drew (dm741q)1-0/+268
Added some junits for the PolicyApiUtils class. Issue-ID: POLICY-602 Change-Id: I393b636021c18d2406341f7fd8246fd342ab6f11 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2018-03-01Added Junits for Policy PAP-RESTrb71471-2/+2
Issue-ID: POLICY-600 Change-Id: Icb67ac587e614f663416b3ea0a03ca6e5b02c621 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-28More junits for PDP-RESTMagnusen, Drew (dm741q)4-6/+512
More junits for the org.onap.policy.pdp.rest.impl/jmx packages. Issue-ID: POLICY-602 Change-Id: I2af2fc3280314a8d6c1e9c352eda042c7fea7932 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2018-02-26Merge "Added junits to increase coverage"Pamela Dragosh4-15/+512
2018-02-26Added junits to increase coverageMAGNUSEN4-15/+512
This commit adds some junits which touch several classes in the notifications package in the ONAP-PDP-REST project. Issue-ID: POLICY-602 Change-Id: Ie99ddd03841d4063aba64781bf08a38d2a25f0ed Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2018-02-26JUnit additions for BRMS,PDP-REST,RESTbobbymander4-3/+88
Issue-ID: POLICY-598 Change-Id: I397ed925bdb43a4b2f7a94cc4692b6506f650ede Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-26JUnit additions for PDP,PDP-RESTbobbymander1-0/+52
Issue-ID: POLICY-600 Change-Id: Ia5584011cbd42b9b49953d714efbeb5956b9b295 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-22JUnit small additions for PAP-REST,PDP-REST,XACMLbobbymander1-0/+53
Issue-ID: POLICY-600 Change-Id: I1b012dd1dbc49c10cd47b5f100e8ccef6c92f70b Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-21Updated the Policy Logging Patternrb71471-40/+33
Updated the logback.xml to save logs for 30 days. Issue-ID: POLICY-644 Change-Id: I578570fa5a7f86ba464c37cddab43a2fabcdae7f Signed-off-by: rb7147 <rb7147@att.com>
2018-02-20Merge "Added Junits to ONAP-PDP-REST"Jorge Hernandez6-0/+606
2018-02-20Added Junits to ONAP-PDP-RESTMichael Mokry6-0/+606
Junits to cover classes in the api/services package that were at 0% coverage Change-Id: Ic92b9db4a8beea827b9b85de826da909b02ea1bd Issue-ID: POLICY-338 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-02-19Fix Fortify Scan Issue:guangxingwang2-4/+6
1) Fix Fortify Header Manipulation issue by checking the format of the message before adding it response header. 2) Fix Fortify Hardcoded Password issue by using encryption and decryption Issue-ID: POLICY-543 Change-Id: I16b44b9b0670b1af75094c9ae9d1f7d352fa894a Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-19Fix compilation issue due to generic ExceptionJim Hahn2-8/+6
After modifying common to remove generic Exceptions, policy/engine would no longer compile. Had to modify policy/engine to accomodate the specific exception. Change-Id: If339285235994119009a8dcf9484bc81016e2600 Issue-ID: POLICY-246 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-02-15Adding Junits in ONAP-PDP-RESTMichael Mokry2-2/+85
- This commit adds one Junit for PAPServices - I needed to make a minor modification to the PAPServices class in order to set the PAPs Change-Id: Ia54650307e8d9e96d40ce6e68ad18508d4030a4a Issue-ID: POLICY-338 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-02-08MS Model Input ValidationMichael Mokry9-59/+102
- Provides validation for MS policy input content body that matches the GUI validations when create/update MS policy from API - Added changes to satisfy review comments and updated copywright headers for modified and new files Change-Id: I02bfa639bffb48520badd0e4fa34eb36418547ae Issue-ID: POLICY-377 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-02-02Resolved Fortify System Information Leak issuesrb71471-10/+6
Issue-ID: POLICY-550 Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f Signed-off-by: rb7147 <rb7147@att.com>