Age | Commit message (Collapse) | Author | Files | Lines |
|
These reviews must be merged in order because of layering.
This review should be merged SECOND
Note: In order to get past the following layering problems, there
are temporary chages to the following POMs to temporarily use 1.2.1-SNAPSHOT
for those dependencies. They are
ONAP-PAP-REST/pom.xml
org.onap.policy.drools-applications.controlloop.common.policy-yaml
ONAP-PDP/pom.xml
org.onap.policy.drools-pdp.policy-endpoints
A separate review will be used to restore these dependencies to 1.2.2-SNAPSHOT
once the drools-pdp and drools-applications reviews are submitted and merged
PLD added version.properties
Issue-ID: POLICY-798
Change-Id: Id7e83f2ba12181c63cc8845b7eeccf2004d2bab9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
see companion docker review.
The failOverReadOnly .. flags should only be used when a DB high
availability environment is used, such as a master/slave
configuration.
As they are the jdbc parameters have caused bad interactions
with the underlying persistence libraries rendering the PAP
useless.
It is thought that this may perhaps solve
POLICY-773, POLICY-775, POLICY-779, and perhaps POLICY-776.
Change-Id: Icb69a3afc0a19969a34af40d960fa8e1b94aabc0
Issue-ID: POLICY-777
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Added license to various files.
Updated XACMLPolicyScanner to work even when license comment
is added to the Policy.xml file.
Moved DOCTYPE before license in html files.
Removed license from css files, as many are generated or
come from third-party software.
Removed license from other generated files.
Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e
Issue-ID: POLICY-741
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Forgot one place for hibernator and need to upgrade netty to
clear CLM issue.
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-2156
Issue-ID: POLICY-722
Change-Id: I741c47110af916c222f92329791217b0c3bc07df
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Upgrade to fix 3 security issues:
https://nvd.nist.gov/vuln/detail/CVE-2018-1270
https://nvd.nist.gov/vuln/detail/CVE-2016-9878
https://nvd.nist.gov/vuln/detail/CVE-2018-1271
Issue-ID: POLICY-722
Change-Id: Icfa5775905ad091dbe55eadfb4414c67abebc13a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-736
Change-Id: If5c959aa1c0a123c7fd9eee281e39e1d646b6b03
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Fixed the issue with creating the config file with the wrong file name
so that the PDP can pick it up when pushing the policy and getCOnfig
will return the Config retrieved rather than a CONFIG_NOT_FOUND 400
status.
I found this issue in the new CSIT tests for HPA policies and this
should also resolve the failed test in Integration as well.
Change-Id: I617133a188f3ba915feafd79da4f3e9d0b0eb4a6
Issue-ID: POLICY-738
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Fix Forfity issue on group Id by adding a validation on this input
value.
Issue-ID: POLICY-734
Change-Id: I83321a5ffd1ddca84f985b5fd8659e502ca967d7
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
|
|
Check in changes for pap,pdp,console,brmsgw,paplp and pdplp
Change-Id: I23525a44e0f269d04d9870c3eed18b6b8daacb2c
Issue-ID: POLICY-562
Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
|
|
Issue-ID: POLICY-605
Change-Id: I4b55a85eacf989ddb55743300e7f75e4b72882d0
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Issue-ID: POLICY-507
Change-Id: I493233f8e0e90eaf24e9c09c7433c6fb9fadb268
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Issue-ID: POLICY-600
Change-Id: I870317bbd125c6016818ec435ea7a406123c66c1
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
|
|
Undo the change so this would not block other test activity
Change-Id: I4f7dd2e14f30034eefbf958be3c912af2962e8a2
Issue-ID: POLICY-562
Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
|
|
|
|
This is the new Optimization Policy to support the Integration of
the OOF Policy Model into the Policy Platform.
Added changes from Frank Wang to fix the following issues with existing Model
Parser:
1. TOSCA Rendering issues
2. Matching Attributes support
3. ImportModelAPI to support TOSCA model upload via REST API
Running local Sonar tonight to start fixing Sonar issues
Added changes per review comments and fixed Sonar issues
Change-Id: Ia8ce09c28a718ce4460475e76a750caef774bd6b
Issue-ID: POLICY-622
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
|
|
|
|
|
|
Code change for log files consolidation of PAP, PDP, BRMSGW, Console and db
script
Issue-ID: POLICY-562
Change-Id: I416ba7748b841bb2b1a31682e2b1631e279549e8
Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
|
|
|
|
Issue-ID: POLICY-603
Change-Id: Id7d2c1a835d028e88337db67d55f139aa1764826
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Code fixes for final 10 vulnerabilities in policy/engine
Change-Id: I234194b596bdacd5f3f9fd1becd4da9d6d0b5cf4
Issue-ID: POLICY-662
Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>
|
|
|
|
This issue arose due to the order of execution of JUnit tests.
The tests in XACMLPAPTest failed becasue the database was not initialized.
Up till now, the @Before method in the test class
org.onap.policy.pap.ia.DbAuditCompareEntriesTesti initiated the database.
THis bug fix adds a similar @Before method to the XACMLPAPTest class
to initialize the database.
All other classes in the module were tested with both @Before methods
commented out to ensure that no other tests will fail due to this issue.
Issue-ID: POLICY-707
Change-Id: Ibce5fad5c006f7a92b3ef77bde4dc5ed6f7039ed
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-706
Change-Id: I2425e305ed660ea07662e0a26e713cc91ed92e72
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Code fixes for 1 bug and 17 vulnerabilities reported by Sonar in
policy/engine
Change-Id: I7b641795c790ec15418bd9ae3a414279e1b0f733
Issue-ID: POLICY-662
Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>
|
|
|
|
Issue-ID: POLICY-600
Change-Id: I9a432f9e8af43184d116d5eeb2fbbac65472564e
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Code fixes for 27 bugs reported by Sonar in policy/engine
Change-Id: I96da96b38a2e2954ec549e5cdf6ed3ad1d76722c
Issue-ID: POLICY-662
Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>
|
|
|
|
|
|
Will not clear any CLM issue but this for uses a version that is
using the latest lucene-queryparser. It is noted in the CVE for
lucene-queryparser that elasticsearch is not affected by the
issue. We will upgrade to keep up with the latest code.
Issue-ID: POLICY-507
Change-Id: I8580dbc704c48245faf298304b8aec76c9e773c4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Issue-ID: POLICY-600
Change-Id: Ie2a3257e26382f68d8cb008dc5ac512d6ac49c8b
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Move the api string literal on the left side of this string comparison
XACMLPapServlet.java:L1179
Sonar Link:
https://sonar.onap.org/issues?myIssues=true&open=AV2blOo25bp_wwmIUQnh&resolved=false&severities=MAJOR
Location:
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/XACMLPapServlet.java
Line Number:1179
Change-Id: I937caaca01107d2a11be4050ff7be5e5dc66acb6
Issue-ID: POLICY-690
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Use try-with-resources to close this JarFile:L264 L265
Issue-ID: POLICY-683
Sonar Link: https://sonar.onap.org/issues?myIssues=true&open=AWF91iwf8TZzbCgU6arv&resolved=false
Location:ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/ActionPolicy.java
Change-Id: Ie9adb5b50dbb61c923bf73fa107fd19366f24304
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
|
|
Use try-with-resources or close this BufferedWriter in a finally clause
FirewallConfigPolicy.java:107
Sonar Link:
https://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AWF91ixe8TZzbCgU6ar2&resolved=false&severities=BLOCKER
Location:
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/FirewallConfigPolicy.java
Change-Id: I0ab8bf61fb9a6eb32ebdb5fccb66a67a8ac36b77
Issue-ID: POLICY-687
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Merge this if statement with the enclosing one
CreateBrmsParamPolicy.java:L218
Sonar Link:
hhttps://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AV2blOqK5bp_wwmIUQqX&resolved=false&severities=MAJOR
Location:
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateBrmsParamPolicy.java
Change-Id: I0f9885a2491735878d688a2c812afd15a052f481
Issue-ID: POLICY-686
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Move from github version to the onap version.
Issue-ID: POLICY-568
Change-Id: I30f91b07cb690e50e829c14725c1bf05a1f4200b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-600
Change-Id: Id705865614faf42dfc604b1b88066122614f866c
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Remove this useless assignment to local variable temp
CreateNewMicroServiceModel.java:L195
Sonar Link:
https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOqq5bp_wwmIUQr6&resolved=false
Location:
src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java
Change-Id: Icdd79502962e1173d83bca442d2d739b058932ba
Issue-ID: POLICY-682
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Remove this useless assignment to local variable em
PolicyDBDao.java:L361
Sonar Link:
https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOr_5bp_wwmIUQxy&resolved=false
Location:
src/main/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDao.java
Change-Id: I2ef3046c1902768589db51127aaf320f94342a9c
Issue-ID: POLICY-679
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
Remove this useless assignment to local variable xMessage
ElkConnectorImpl.java:L169
Sonar Link:
https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOwt5bp_wwmIUREc&resolved=false
Location:
src/main/java/org/onap/policy/pap/xacml/rest/elk/client/ElkConnectorImpl.java
Change-Id: Ia397ffa7cb93b8c1ce8f5f02a09685656c74ddc0
Issue-ID: POLICY-678
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
|
|
Issue-ID: POLICY-600
Change-Id: I9d4d986b0703c67f65b67eedabca8d0d56965f2d
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
|
|
This has some cleanup for overriding managed dependencies, a
duplicate entry for mariadb, unnecessary inclusion of older
EELF library, an upgrade of swagger tools to fix a security
issue and lastly an override of a depedency to clear a
security issue.
Issue-ID: POLICY-507
Change-Id: I8767f6edc37551c559010d96d350afdd5961f13d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-600
Change-Id: I59117fff52a2cd37c1260aafaae4ebe922053202
Signed-off-by: bobbymander <bobby.mander@att.com>
|