summaryrefslogtreecommitdiffstats
path: root/ONAP-PAP-REST
AgeCommit message (Collapse)AuthorFilesLines
2018-03-23Merge "Add database initialization to XACML PDP test"Pamela Dragosh1-1/+50
2018-03-23Merge "Resolved the Policy Removal issue from PDP"Jorge Hernandez1-1/+1
2018-03-22Add database initialization to XACML PDP testliamfallon1-1/+50
This issue arose due to the order of execution of JUnit tests. The tests in XACMLPAPTest failed becasue the database was not initialized. Up till now, the @Before method in the test class org.onap.policy.pap.ia.DbAuditCompareEntriesTesti initiated the database. THis bug fix adds a similar @Before method to the XACMLPAPTest class to initialize the database. All other classes in the module were tested with both @Before methods commented out to ensure that no other tests will fail due to this issue. Issue-ID: POLICY-707 Change-Id: Ibce5fad5c006f7a92b3ef77bde4dc5ed6f7039ed Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-03-22Resolved the Policy Removal issue from PDPrb71471-1/+1
Issue-ID: POLICY-706 Change-Id: I2425e305ed660ea07662e0a26e713cc91ed92e72 Signed-off-by: rb7147 <rb7147@att.com>
2018-03-21Fix vulnerabilities and bugs in policy/engineeramkve2-39/+53
Code fixes for 1 bug and 17 vulnerabilities reported by Sonar in policy/engine Change-Id: I7b641795c790ec15418bd9ae3a414279e1b0f733 Issue-ID: POLICY-662 Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>
2018-03-21Merge "JUnit additions for PAP-REST,REST,Utils"Pamela Dragosh1-0/+51
2018-03-21JUnit additions for PAP-REST,REST,Utilsbobbymander1-0/+51
Issue-ID: POLICY-600 Change-Id: I9a432f9e8af43184d116d5eeb2fbbac65472564e Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-20Fix all bugs reported by Sonar in policy/engineeramkve10-111/+153
Code fixes for 27 bugs reported by Sonar in policy/engine Change-Id: I96da96b38a2e2954ec549e5cdf6ed3ad1d76722c Issue-ID: POLICY-662 Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>
2018-03-13Merge "Upgrade to latest elasticsearch"Pamela Dragosh1-1/+1
2018-03-13Merge "JUnit additions for PAP-REST,SDK-APP"Jorge Hernandez1-0/+37
2018-03-13Upgrade to latest elasticsearchPamela Dragosh1-1/+1
Will not clear any CLM issue but this for uses a version that is using the latest lucene-queryparser. It is noted in the CVE for lucene-queryparser that elasticsearch is not affected by the issue. We will upgrade to keep up with the latest code. Issue-ID: POLICY-507 Change-Id: I8580dbc704c48245faf298304b8aec76c9e773c4 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-13Merge "Policy:Blocker"Pamela Dragosh1-4/+1
2018-03-13JUnit additions for PAP-REST,SDK-APPbobbymander1-0/+37
Issue-ID: POLICY-600 Change-Id: Ie2a3257e26382f68d8cb008dc5ac512d6ac49c8b Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-13Sonar MajorSP005016381-1/+1
Move the api string literal on the left side of this string comparison XACMLPapServlet.java:L1179 Sonar Link: https://sonar.onap.org/issues?myIssues=true&open=AV2blOo25bp_wwmIUQnh&resolved=false&severities=MAJOR Location: ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/XACMLPapServlet.java Line Number:1179 Change-Id: I937caaca01107d2a11be4050ff7be5e5dc66acb6 Issue-ID: POLICY-690 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-13Policy:BlockerManamohan Satapathy1-4/+1
Use try-with-resources to close this JarFile:L264 L265 Issue-ID: POLICY-683 Sonar Link: https://sonar.onap.org/issues?myIssues=true&open=AWF91iwf8TZzbCgU6arv&resolved=false Location:ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/ActionPolicy.java Change-Id: Ie9adb5b50dbb61c923bf73fa107fd19366f24304 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-03-13Sonar BlockerSP005016381-20/+9
Use try-with-resources or close this BufferedWriter in a finally clause FirewallConfigPolicy.java:107 Sonar Link: https://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AWF91ixe8TZzbCgU6ar2&resolved=false&severities=BLOCKER Location: ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/FirewallConfigPolicy.java Change-Id: I0ab8bf61fb9a6eb32ebdb5fccb66a67a8ac36b77 Issue-ID: POLICY-687 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-13Sonar MajorSP005016381-3/+1
Merge this if statement with the enclosing one CreateBrmsParamPolicy.java:L218 Sonar Link: hhttps://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AV2blOqK5bp_wwmIUQqX&resolved=false&severities=MAJOR Location: ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateBrmsParamPolicy.java Change-Id: I0f9885a2491735878d688a2c812afd15a052f481 Issue-ID: POLICY-686 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-09Use org.onap.aaf dependenciesPamela Dragosh1-1/+1
Move from github version to the onap version. Issue-ID: POLICY-568 Change-Id: I30f91b07cb690e50e829c14725c1bf05a1f4200b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-09JUnit additions for PAP-RESTbobbymander3-0/+178
Issue-ID: POLICY-600 Change-Id: Id705865614faf42dfc604b1b88066122614f866c Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-09Sonar MajorSP005016381-1/+1
Remove this useless assignment to local variable temp CreateNewMicroServiceModel.java:L195 Sonar Link: https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOqq5bp_wwmIUQr6&resolved=false Location: src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java Change-Id: Icdd79502962e1173d83bca442d2d739b058932ba Issue-ID: POLICY-682 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-08Sonar MajorSP005016381-1/+1
Remove this useless assignment to local variable em PolicyDBDao.java:L361 Sonar Link: https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOr_5bp_wwmIUQxy&resolved=false Location: src/main/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDao.java Change-Id: I2ef3046c1902768589db51127aaf320f94342a9c Issue-ID: POLICY-679 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-08Sonar MajorSP005016381-1/+1
Remove this useless assignment to local variable xMessage ElkConnectorImpl.java:L169 Sonar Link: https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOwt5bp_wwmIUREc&resolved=false Location: src/main/java/org/onap/policy/pap/xacml/rest/elk/client/ElkConnectorImpl.java Change-Id: Ia397ffa7cb93b8c1ce8f5f02a09685656c74ddc0 Issue-ID: POLICY-678 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-07Merge "Clean up pom.xml and fix CLM"Pamela Dragosh1-1/+0
2018-03-06JUnit workaround for PAP-REST, sonar bugbobbymander2-2/+3
Issue-ID: POLICY-600 Change-Id: I9d4d986b0703c67f65b67eedabca8d0d56965f2d Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-06Merge "Remove auto generated rule to the drl"Jorge Hernandez3-61/+25
2018-03-05Clean up pom.xml and fix CLMPamela Dragosh1-1/+0
This has some cleanup for overriding managed dependencies, a duplicate entry for mariadb, unnecessary inclusion of older EELF library, an upgrade of swagger tools to fix a security issue and lastly an override of a depedency to clear a security issue. Issue-ID: POLICY-507 Change-Id: I8767f6edc37551c559010d96d350afdd5961f13d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-05JUnit additions for PAP-RESTbobbymander2-2/+149
Issue-ID: POLICY-600 Change-Id: I59117fff52a2cd37c1260aafaae4ebe922053202 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-05Remove auto generated rule to the drlpa834y3-61/+25
Issue-ID: POLICY-488 Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b Signed-off-by: pa834y <pa834y@att.com>
2018-03-05JUnit addition/fix for PAP-RESTbobbymander1-8/+21
Issue-ID: POLICY-600 Change-Id: I342bc97f85739f73b0dac6aaea19f6f4b2ded470 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-02JUnit remove one flaky test for nowbobbymander1-0/+2
Issue-ID: POLICY-600 Change-Id: I8b32cb3658e9a145a6493639787abc0145a04991 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-02Merge "JUnit additions for PAP-REST,API"Jorge Hernandez2-0/+116
2018-03-01JUnit additions for PAP-REST,APIbobbymander2-0/+116
Issue-ID: POLICY-600 Change-Id: I68020230d370950c0323a544910ad54015e1a08a Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-01Added Junits for Policy PAP-RESTrb714712-240/+553
Issue-ID: POLICY-600 Change-Id: Icb67ac587e614f663416b3ea0a03ca6e5b02c621 Signed-off-by: rb7147 <rb7147@att.com>
2018-03-01JUnit additions for PAP-REST,REST,XACMLbobbymander1-0/+68
Issue-ID: POLICY-603 Change-Id: I78c5e302c474613cbb22a80e0d931b4f47dd3b63 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-28Merge "JUnit additions for ONAP-PAP-REST"Jorge Hernandez3-0/+137
2018-02-28JUnit additions for ONAP-PAP-RESTbobbymander3-0/+137
Issue-ID: POLICY-600 Change-Id: I6e458335b04b88146d88fea2f6fd908779d842fc Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-27Added Junits for Policy PAP-RESTrb714730-483/+583
Issue-ID: POLICY-600 Change-Id: I1d42a3a880c9d81115d48794a77fadb89562e136 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-27Code Clean Up for Policy PAP-RESTrb714722-5278/+2193
Cleaned the duplicate code for all dictionary controllers and created Utils class. Issue-ID: POLICY-600 Change-Id: I65b8574d9f667758407515a5c55bc28f636be477 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-22JUnit small additions for PAP-REST,PDP-REST,XACMLbobbymander1-0/+53
Issue-ID: POLICY-600 Change-Id: I1b012dd1dbc49c10cd47b5f100e8ccef6c92f70b Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-22Merge "JUnit additions for ONAP-PAP-REST xacml.rest"Jorge Hernandez2-0/+142
2018-02-22Merge "Fix Fortify Path Manipulation Issue"Jorge Hernandez3-0/+194
2018-02-22Fix Fortify Path Manipulation Issueguangxingwang3-0/+194
Fix Fortify path manipulation issue by adding a validation on dictionary name. Issue-ID: POLICY-541 Change-Id: I87492b0d80bf96bebfc029d7d164cdd20ca5ef0f Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-22JUnit additions for ONAP-PAP-REST xacml.restbobbymander2-0/+142
Issue-ID: POLICY-600 Change-Id: Ia6ccc2904efd7c1e7ec206caaedd8552c83d92a5 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-21Updated the Policy Logging Patternrb71471-41/+31
Updated the logback.xml to save logs for 30 days. Issue-ID: POLICY-644 Change-Id: I578570fa5a7f86ba464c37cddab43a2fabcdae7f Signed-off-by: rb7147 <rb7147@att.com>
2018-02-21Merge "JUnit additions for ONAP-PAP-REST"Pamela Dragosh4-1/+322
2018-02-21JUnit additions for ONAP-PAP-RESTbobbymander4-1/+322
Issue-ID: POLICY-600 Change-Id: I2e6d0d656a9be77b038a08568d43d1bb7efefe57 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-20Added Junits for Policy PAP-RESTrb714719-1562/+618
Clenaed the unsued code. Cleaned the duplication of code and moved to ONAP-REST. Added Junits for PAP-REST Issue-ID: POLICY-600 Change-Id: I56e6e8f2f547def9eaf8624a9e0dd52dc05ad136 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-20Merge "Fix Fortify Scan Issue:"Pamela Dragosh5-91/+86
2018-02-19Fix Fortify Scan Issue:guangxingwang5-91/+86
1) Fix Fortify Header Manipulation issue by checking the format of the message before adding it response header. 2) Fix Fortify Hardcoded Password issue by using encryption and decryption Issue-ID: POLICY-543 Change-Id: I16b44b9b0670b1af75094c9ae9d1f7d352fa894a Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-19Rename maven modules in drools-applicationsliamfallon1-1/+1
All found references to drools-applications module names changed to new names Issue-ID: POLICY-238 Change-Id: I3cd453c91194699434a71c1a12d2dcccfa5df234 Signed-off-by: liamfallon <liam.fallon@ericsson.com>