Age | Commit message (Collapse) | Author | Files | Lines |
|
Added unit tests and fixed checkstyle and SONAR issues in the base
package of ONAPE-REST
There was a lot of knock-on automatic changes done by Eclipse when I
renamed the class XACMLRestProperties to XacmlRestProperties so ignore
the changes in all but the ONAP-REST package. I also didn't update the
licenses on files on those classes because the changes were automatic.
Issue-ID: POLICY-2131
Change-Id: I28823c844b5192f8d56de76a727996b13e7ea4a6
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Put common code into PolicyEngineUtils that the controllers use to
populate the PolicyRestController.
Also some more sonar cleanup and formatting of XML files.
Shortened 120 line characters. Removed some trailing spaces
from comments.
Fixed up one JUnit.
Licenses.
Issue-ID: POLICY-2133
Change-Id: Id7d8ac3ab60331535f048ec0f26aeb17a099414e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Some formatting and javadoc cleanup also.
Issue-ID: POLICY-2133
Change-Id: Icb0f76c7e69df87918b4bc5a02a013f9d2bfae89
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Updated logback xml files, replacing AlertSeverity with Severity.
Also fixed some spacing issues.
Change-Id: I3e4b9163d5d897fe4402028b69c741f497aecfc5
Issue-ID: POLICY-1989
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fixed breakages due to changes made in policy/common to satisfy
sonar.
Change-Id: I88090c7549ba19f9eb45fae311e8811e39f30318
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Released 1.5.0
Fixed compilation issue related with version upgrade of
policy/common.
Issue-ID: POLICY-1737
Change-Id: Ib2f56e8ffcb4b399dbe4a5453b70da10b0f87985
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Due to sonar changes in policy/models for guard.
Issue-ID: POLICY-1791
Change-Id: I2cdbe6d0e4ee8bad05b9d3bb1a83e82d4851973c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Change-Id: I1716af52ca6cdde93eef1a37f4a32a9f6f3e12f0
Issue-ID: POLICY-1417
Signed-off-by: pa834y <pa834y@att.com>
|
|
|
|
|
|
|
|
|
|
|
|
Issue-ID: POLICY-1416
Signed-off-by: uj426b <uj426b@att.com>
Change-Id: Ie4e6e91d555be448caa290bce36eb58075046619
Signed-off-by: uj426b <uj426b@att.com>
|
|
string xacmlId doesn t correspond to
anything in DecisionSettings
same for shotname in functionDefinition
Issue-ID: POLICY-1250
Change-Id: I7ac457666f341b50c761dbdabf806fa7efece5a9
Signed-off-by: Matthieu Cauffiez <matthieu.cauffiez@bell.ca>
|
|
small code cleanup of config policy
Issue-ID: POLICY-1250
Change-Id: I5f61d1a2e52cc89cfd4b470d82fe39b9f9a6af0e
Signed-off-by: Matthieu Cauffiez <matthieu.cauffiez@bell.ca>
|
|
remove duplicated code in firewallconfigPolicy
Issue-ID: POLICY-1250
Change-Id: I565d905cfe9b0c4ff2ed275ceac77ef0a2cb85d5
Signed-off-by: Matthieu Cauffiez <matthieu.cauffiez@bell.ca>
|
|
This patch clean up the getInnerDecisionApply
and break it in smaller pieces
Issue-ID: POLICY-1250
Change-Id: Iabe56ccb4edbac257a72fb4f1518f24ed1bd84df
Signed-off-by: Matthieu Cauffiez <matthieu.cauffiez@bell.ca>
|
|
Change-Id: Ia69f061c078e4f6ed4b4d2cd12f03f58514f2123
Issue-ID: POLICY-1416
Signed-off-by: uj426b <uj426b@att.com>
|
|
Change-Id: I39d5fc01e68e9d711c5dd09790dc34beb68783c3
Issue-ID: POLICY-1421
Signed-off-by: uj426b <uj426b@att.com>
|
|
|
|
|
|
Change-Id: I95a05898d299a96810abf4f3b7940e8a3a243000
Issue-ID: POLICY-1414
Signed-off-by: pa834y <pa834y@att.com>
|
|
Change-Id: I06718526382b424eab991f39a7dac1b5cf4f1b74
Issue-ID: POLICY-1422
Signed-off-by: pa834y <pa834y@att.com>
|
|
Change-Id: I7fbfe70e856d48f40ad831a6d0451e46024bf6de
Issue-ID: POLICY-1417
Signed-off-by: pa834y <pa834y@att.com>
|
|
|
|
When a user imports a model, save the original model file
Issue-ID: POLICY-1423
Change-Id: Ic7ccf2cc91ce466d7aac644cf566e35577888217
Signed-off-by: HOCKLA <ah999m@att.com>
|
|
Change-Id: I276b0946c5b03e5369a3c70468672378825c0766
Issue-ID: POLICY-1434
Signed-off-by: pa834y <pa834y@att.com>
|
|
Change-Id: Ifa655d56bda0ab4c748f188767122e7bd927155b
Issue-ID: POLICY-1417
Signed-off-by: pa834y <pa834y@att.com>
|
|
Added Junit tests for PolicyDBDao methods that were not covered after
observing that the code coverage dropped below 50% in SONAR.
Modified license headers with correct copywrite
Change-Id: Iad8e18d978236f4391363d963eb4624744f45099
Issue-ID: POLICY-1448
Signed-off-by: Michael Mokry <michael.mokry@att.com>
|
|
Changed license comment style in ddl files from C-style to SQL-style.
Added value for NOTIFICATION_DELAY.
Don't overwrite property and pom updates from previous commit.
Change-Id: I8c9fd50343c3503c797cb4165bbff5809e4d0740
Issue-ID: POLICY-1285
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Changed the condition to remove not from permit and have only one not
for deny
Change-Id: Ie4563aba000fa5366095fe23d23c37019b5224d4
Issue-ID: POLICY-1038
Signed-off-by: Michael Mokry <mm117s@att.com>
|
|
Made changes to support Guard policy create/update and other policy manager
functions including deletePolicy and pushPolicy.
Includes changes for new Guard policy support using GUI and API (Rest and Java Client)
Made changes to address Jim's comments
Made changes to address Liam's comments
Change-Id: I133fe1fd9287ea77ea41a2788de90c7642c36b6a
Issue-ID: POLICY-1038
Signed-off-by: Mike Mokry <mm117s@att.com>
|
|
Issue-ID: POLICY-902
Change-Id: If22627dfe7df993b5c725ddf3a66c10ebbaa73ca
Signed-off-by: rb7147 <rb7147@att.com>
|
|
To Support Raw Policy Creation from GUI and API.
GetDecision on combining algorithim with Policy Set.
Issue-ID: POLICY-902
Change-Id: Ie3189f8ded2e03366bc7d65d15b95b88c89b0acd
Signed-off-by: rb7147 <rb7147@att.com>
|
|
Fix issues about incorrect comparison in pap rest modules
indicated by analysis tools.Rework to fix review
comments1
Issue-ID: POLICY-1016
Change-Id: I7a0ee45a721307fc3ba89ab65e807613a3df2542
Signed-off-by: krisjinka <kris.jinka@samsung.com>
|
|
Modify tabs to space for checkstyle issue fix in ONAP PAP REST
module. It helps future reviews and refactoring. Remaining classes
Issue-ID: POLICY-1014
Change-Id: I677eadac9e8364b388be922024528c27fd1e2545
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Modify tabs to space for checkstyle issue fix in ONAP PAP REST
module. It helps future reviews and refactoring
Issue-ID: POLICY-1014
Change-Id: Idcf45689565f039c76a3ef0f40ad9a46b41bd8d6
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
|
|
Refactor code to not nest more than 3 condition or loop stmts
in policy PolicyEngineUtils. Rework based on review comments
Issue-ID: POLICY-1003
Change-Id: I95fcfa0f99c517c02357c85ca39cd2f934e8da4d
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
While creating a decision Bl Guard Policy we are allowing to add
Blacklist entries through file upload for bulk from GUI.
Issue-ID: POLICY-901
Change-Id: I4031fd4a96937b9facc330cecf72777d701d4678
Signed-off-by: rb7147 <rb7147@att.com>
|
|
For the files which are modified add
modified copyright notices as per comments from earlier review
Issue-ID: POLICY-1002
Change-Id: I873b3ccc986d5f3d138ddb9e9b3c2307a0b127a6
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
refactor the code for nested try blocks and rework
based on comments and fix nested loops complexity
Issue-ID: POLICY-976
Change-Id: Ied02b7838b5e4839a4906f79ff37c4fd6afeccfe
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Fix sonar issues to convert try blocks to
try with resources plus change tabs 2 space
Issue-ID: POLICY-961
Change-Id: I553d6a42f1efaab5b7eb3a53bab945a3360e69bb
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
This reverts commit 240bbdbdc76e0e91af9f18164eadb2708d14c6fb, reversing
changes made to 3ee69f1af0acddd1e06060ad88c0029fe7ceeaaf.
Change-Id: I61f07ead1d7d3e89c512a2224efecf9ac440df10
Issue-ID: POLICY-961
Signed-off-by: Jorge Hernandez <jh1730@att.com>
|
|
Issue-ID: POLICY-961
Change-Id: Ia1f388368007a4a82a57520dc6ddd99cc484a393
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
|
|
Changed the class. Modified the junit test to catch that type
of issue, refactoring it to extract common code.
Change-Id: Ibc3d22821f103cd3954d2f2f54d4d62307dbf4c6
Issue-ID: POLICY-909
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Logback complains if %d{} values contain """, but it works fine
without them, thus they have been removed.
Update licenses.
Change-Id: Id1f21d3d51bb2495a92f54fcf5c3ad978612c375
Issue-ID: POLICY-785
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added license to various files.
Updated XACMLPolicyScanner to work even when license comment
is added to the Policy.xml file.
Moved DOCTYPE before license in html files.
Removed license from css files, as many are generated or
come from third-party software.
Removed license from other generated files.
Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e
Issue-ID: POLICY-741
Signed-off-by: Jim Hahn <jrh3@att.com>
|