summaryrefslogtreecommitdiffstats
path: root/ONAP-PAP-REST/src/main
AgeCommit message (Collapse)AuthorFilesLines
2018-03-13Merge "Policy:Blocker"Pamela Dragosh1-4/+1
2018-03-13Sonar MajorSP005016381-1/+1
Move the api string literal on the left side of this string comparison XACMLPapServlet.java:L1179 Sonar Link: https://sonar.onap.org/issues?myIssues=true&open=AV2blOo25bp_wwmIUQnh&resolved=false&severities=MAJOR Location: ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/XACMLPapServlet.java Line Number:1179 Change-Id: I937caaca01107d2a11be4050ff7be5e5dc66acb6 Issue-ID: POLICY-690 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-13Policy:BlockerManamohan Satapathy1-4/+1
Use try-with-resources to close this JarFile:L264 L265 Issue-ID: POLICY-683 Sonar Link: https://sonar.onap.org/issues?myIssues=true&open=AWF91iwf8TZzbCgU6arv&resolved=false Location:ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/ActionPolicy.java Change-Id: Ie9adb5b50dbb61c923bf73fa107fd19366f24304 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-03-13Sonar BlockerSP005016381-20/+9
Use try-with-resources or close this BufferedWriter in a finally clause FirewallConfigPolicy.java:107 Sonar Link: https://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AWF91ixe8TZzbCgU6ar2&resolved=false&severities=BLOCKER Location: ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/FirewallConfigPolicy.java Change-Id: I0ab8bf61fb9a6eb32ebdb5fccb66a67a8ac36b77 Issue-ID: POLICY-687 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-13Sonar MajorSP005016381-3/+1
Merge this if statement with the enclosing one CreateBrmsParamPolicy.java:L218 Sonar Link: hhttps://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AV2blOqK5bp_wwmIUQqX&resolved=false&severities=MAJOR Location: ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateBrmsParamPolicy.java Change-Id: I0f9885a2491735878d688a2c812afd15a052f481 Issue-ID: POLICY-686 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-09Sonar MajorSP005016381-1/+1
Remove this useless assignment to local variable temp CreateNewMicroServiceModel.java:L195 Sonar Link: https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOqq5bp_wwmIUQr6&resolved=false Location: src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java Change-Id: Icdd79502962e1173d83bca442d2d739b058932ba Issue-ID: POLICY-682 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-08Sonar MajorSP005016381-1/+1
Remove this useless assignment to local variable em PolicyDBDao.java:L361 Sonar Link: https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOr_5bp_wwmIUQxy&resolved=false Location: src/main/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDao.java Change-Id: I2ef3046c1902768589db51127aaf320f94342a9c Issue-ID: POLICY-679 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-08Sonar MajorSP005016381-1/+1
Remove this useless assignment to local variable xMessage ElkConnectorImpl.java:L169 Sonar Link: https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOwt5bp_wwmIUREc&resolved=false Location: src/main/java/org/onap/policy/pap/xacml/rest/elk/client/ElkConnectorImpl.java Change-Id: Ia397ffa7cb93b8c1ce8f5f02a09685656c74ddc0 Issue-ID: POLICY-678 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-05Remove auto generated rule to the drlpa834y1-58/+22
Issue-ID: POLICY-488 Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b Signed-off-by: pa834y <pa834y@att.com>
2018-03-01Added Junits for Policy PAP-RESTrb71474-233/+213
Issue-ID: POLICY-600 Change-Id: Icb67ac587e614f663416b3ea0a03ca6e5b02c621 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-27Added Junits for Policy PAP-RESTrb71473-470/+228
Issue-ID: POLICY-600 Change-Id: I1d42a3a880c9d81115d48794a77fadb89562e136 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-27Code Clean Up for Policy PAP-RESTrb714712-5175/+2124
Cleaned the duplicate code for all dictionary controllers and created Utils class. Issue-ID: POLICY-600 Change-Id: I65b8574d9f667758407515a5c55bc28f636be477 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-22Merge "Fix Fortify Path Manipulation Issue"Jorge Hernandez2-0/+142
2018-02-22Fix Fortify Path Manipulation Issueguangxingwang2-0/+142
Fix Fortify path manipulation issue by adding a validation on dictionary name. Issue-ID: POLICY-541 Change-Id: I87492b0d80bf96bebfc029d7d164cdd20ca5ef0f Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-21Updated the Policy Logging Patternrb71471-41/+31
Updated the logback.xml to save logs for 30 days. Issue-ID: POLICY-644 Change-Id: I578570fa5a7f86ba464c37cddab43a2fabcdae7f Signed-off-by: rb7147 <rb7147@att.com>
2018-02-20Added Junits for Policy PAP-RESTrb714711-1469/+369
Clenaed the unsued code. Cleaned the duplication of code and moved to ONAP-REST. Added Junits for PAP-REST Issue-ID: POLICY-600 Change-Id: I56e6e8f2f547def9eaf8624a9e0dd52dc05ad136 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-19Fix Fortify Scan Issue:guangxingwang4-76/+86
1) Fix Fortify Header Manipulation issue by checking the format of the message before adding it response header. 2) Fix Fortify Hardcoded Password issue by using encryption and decryption Issue-ID: POLICY-543 Change-Id: I16b44b9b0670b1af75094c9ae9d1f7d352fa894a Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-19Fix compilation issue due to generic ExceptionJim Hahn1-1/+32
After modifying common to remove generic Exceptions, policy/engine would no longer compile. Had to modify policy/engine to accomodate the specific exception. Change-Id: If339285235994119009a8dcf9484bc81016e2600 Issue-ID: POLICY-246 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-02-16Added Junis for Policy ONAP-RESTrb71472-12/+10
Cleaned the unused constructors. Cleaned the unused code. Added Junits for all JPAS. Renamed the Junit class names on removing classes. Issue-ID: POLICY-603 Change-Id: I0709ccecd7a2f3ec49367ff85f5a6d273479493e Signed-off-by: rb7147 <rb7147@att.com>
2018-02-13Added Junits for Policy PAP-RESTrb71471-8/+8
Cleaned the unnecessary constructors and methods in onap-rest. Added Junits for JPA Classes in ONAP-REST. Issue-ID: POLICY-338 Change-Id: I7e4f928342315475db96d89e9ad3adac5cb7eb00 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-13Merge "Added Junits for Policy PAP-REST"Jorge Hernandez8-241/+190
2018-02-13Merge "Fix Fortify Scan Issue"Jorge Hernandez1-10/+48
2018-02-12Added Junits for Policy PAP-RESTrb71478-241/+190
Resolved the sonar issues. Added JUnits for ONAP-PAP-REST and ONAP-REST Component. Issue-ID: POLICY-338 Change-Id: Ibec2613f4f61e9ed426583af17c2a9d5b8c8d85d Signed-off-by: rb7147 <rb7147@att.com>
2018-02-12Fix Fortify Scan Issueguangxingwang1-10/+48
Fix Fortify Header Manipulation Issue by checking the format of a string before adding it to response header. Issue-ID: POLICY-543 Change-Id: I6539d22d5f8933ea29932361b152d34dd4f8857a Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-09Added Junits for ONAP-PAP-RESTrb71476-199/+43
Cleaned up unused imports. Cleaned up unused code. Added Junits for Dictionary controllers. Issue-ID: POLICY-338 Change-Id: If29b934e95fdaf60dcf82300a95a23ac3c980419 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-08Remove Password from Loggingguangxingwang1-3/+2
Fix Fortify logging issue Issue-ID: POLICY-544 Change-Id: Ibfc7665dcab229a705ec3f999545b14675c24430 Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-08MS Model Input ValidationMichael Mokry7-108/+148
- Provides validation for MS policy input content body that matches the GUI validations when create/update MS policy from API - Added changes to satisfy review comments and updated copywright headers for modified and new files Change-Id: I02bfa639bffb48520badd0e4fa34eb36418547ae Issue-ID: POLICY-377 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-02-07Merge "Adding JUNITs for ONAP-PAP-REST"Pamela Dragosh1-1/+4
2018-02-06Adding JUNITs for ONAP-PAP-RESTuj426b1-1/+4
Issue-ID: POLICY-338 Change-Id: I123a92872a236b23144c59e87ea2dffc9ee7fc48 Signed-off-by: uj426b <uj426b@att.com>
2018-02-06Policy Resiliency Code Fixesrb71472-0/+290
Resolved the issue on updating the configuration files when rename/clone/export/move actions are done through GUI. Fixed the PolicyManagerServlet code. Added test cases for newly added files. Issue-ID: POLICY-609 Change-Id: I9d14f19fe20bbc0e3b3844f85d81f26e34bb26ec Signed-off-by: rb7147 <rb7147@att.com>
2018-02-02Resolved Fortify System Information Leak issuesrb714712-558/+761
Issue-ID: POLICY-550 Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f Signed-off-by: rb7147 <rb7147@att.com>
2018-02-01Included Policy GUI Enhancements and validationsrb71471-0/+2
Added hover messages for all policy templates. Resolved few sonar issues. Added fixes for Policy GUI Validations. Issue-ID: POLICY-597 Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c Signed-off-by: rb7147 <rb7147@att.com>
2018-01-31Fixed the Sonar technical debt.Ankitkumar Patel2-30/+28
Fixed the sonar technical dept primarily for the POLICY-REST module, and accordingly updated the other policy-engine modules for successful built. Issue-ID: POLICY-476 Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-01-29Addressing Technical Debt for ONAP-XACMLGao, Chenfei (cg287m)1-2/+2
Follow the list of acceptable fixes in POLICY-336 description Issue-ID: POLICY-475 Change-Id: I45cfb55c571d32601049beb8e5be8676216dcf5c Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
2018-01-16PDPGroup Audit FixMichael Mokry1-1/+2
*This fix will add new group to GroupEntity table if no default exists during initialization and therefore provides a permanent solution to the initialization errors on the PAP Change-Id: Ie394d76b9cbc02cad15d62d6adea6fc17938f734 Issue-ID: POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com> (cherry picked from commit 676d7d8dc9985e93d7c9cbc0412a26f2b19c23cd)
2018-01-03Merge "Adding PolicyType to getConfig Response"Pamela Dragosh3-5/+0
2018-01-03Merge "Policy Elastic Search Validation Enhancements"Pamela Dragosh3-17/+27
2018-01-03Merge "Adding SONAR fixes for"Pamela Dragosh4-17/+12
2017-12-14Policy Elastic Search Validation Enhancementsrb71473-17/+27
Issue-ID: POLICY-497 Change-Id: If97fe30706bcdbeeafaf28e5cca8fae31998cb7c Signed-off-by: rb7147 <rb7147@att.com>
2017-12-13Adding PolicyType to getConfig ResponseTej, Tarun3-5/+0
Adding a new parameter PolicyType so that getConfig Response can be known based on type of policy. Fixes for project warnings and unused imports. Issue-ID: POLICY-434 Change-Id: I0874abb7e986a8bb42ae18561064a8d7534eade6 Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-12-12Merge "Fix audit log to contain ending timestamp"Pamela Dragosh1-1/+2
2017-12-12Fix audit log to contain ending timestampMike Babinski1-1/+2
Add transaction end method Change-Id: Ie818bb1650b0847800ce5481a85c5d2c8d7f4b9c Issue-ID: POLICY-494 Signed-off-by: Mike Babinski <mb1915@att.com>
2017-12-11Adding SONAR fixes forMichael Mokry4-17/+12
- pushPolicy defect fixes for POLICY-486 - Common Policy Validation feature for POLIYC-449 Change-Id: I8d54aa5a9b819c6eb4427dfa47c4ce963a21c2e0 Issue-ID: POLICY-449,POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-12-08Upgraded the latest ONAP SDKrb71471-5/+3
Upgraded latest ONAP SDK Code. Change-Id: I669d6cfcefe068b1e4c078889d7d6c77ce788e2e Issue-ID: POLICY-432 Signed-off-by: rb7147 <rb7147@att.com>
2017-12-06Merge "Refactor to provide Common Policy Validation"Pamela Dragosh1-0/+4
2017-12-05Modified the code to fix various pushPolicy issuesMichael Mokry4-107/+461
- Added modifications per Pam's review Change-Id: I5d67ee529cbc5245e7d1f8dbec6f2f2d453ce299 Issue-ID: POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-12-04Refactor to provide Common Policy ValidationMichael Mokry1-0/+4
Provides a common class to perform policy validation during create/udpate of policies by the GUI and API for consistency. Change-Id: Ied459e73d48517bb50064cd10d6a1c871b8311e5 Issue-ID: POLICY-449 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-10-11Added Policy GUI Cosmetic Fixesrb71471-3/+3
Fixed the Refresh cache issue. Fixed the Popup modal css issue. Fixed the cosmetic issues. Issue-Id: POLICY-310 Change-Id: Ib41713a6f9a6573667d7b4ae6836e411dc32c854 Signed-off-by: rb7147 <rb7147@att.com>
2017-10-10Fixing the BRMS rule generation issueTej, Tarun1-32/+28
Fixing the rule params section to look for PapParams istead of Params. This will be a temporary solution for now. Issue-Id: POLICY-302 Change-Id: I4b6b415b3eacf121be374d2dfd50303049c35aba Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-10-06Fixed bug introduced by sql injeciton protection.Temoc Rodriguez1-1/+6
Added missing colon before the named parameters. Fixed a typo parameter name. Fixed bad cast by setParameter. This fixes issues encountered in the UI. Whenever a policy is moved, renamed, or deleted it makes a db call and that db call fails on setParameter method. This hibernate method is supposed to automatically detect the type of the object for the named parameters but it fails with type Long. It tries to convert to int and it fails. A check is now added for type Long. Issue-ID: POLICY-278 Change-Id: Idbb4067a5ec2cc9d9b040de9e574ba2564e1ee2c Signed-off-by: Temoc Rodriguez <cr056n@att.com>