aboutsummaryrefslogtreecommitdiffstats
path: root/BRMSGateway
AgeCommit message (Collapse)AuthorFilesLines
2018-07-25Fix sonar issue about nested stmtsKrishnajinka1-88/+110
Refactor code to not nest more than 3 condition or loop stmts in policy PolicyEngineUtils. Rework based on review comments Issue-ID: POLICY-1003 Change-Id: I95fcfa0f99c517c02357c85ca39cd2f934e8da4d Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-06-08Remove "&quot;" from logback xml filesJim Hahn1-1/+1
Logback complains if %d{} values contain "&quot;", but it works fine without them, thus they have been removed. Update licenses. Change-Id: Id1f21d3d51bb2495a92f54fcf5c3ad978612c375 Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-05Update engine to SNAPSHOT-1.3.0liamfallon5-27/+27
Snapshot updated for Casablanca. Change-Id: Ieb2c9a990c0f36f31c974038465e7d38aaa21e5d Issue-ID: POLICY-875 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-21Update Policy Engine to 1.2.3-SNAPSHOTliamfallon5-27/+27
These reviews must be merged in order because of layering. This review should be merged FOURTH. Change-Id: Ifca8e33b79085a4032164b44dae3401f8179f5f6 Issue-ID: POLICY-844 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-16Upgrade SNAPSHOT to 1.2.2liamfallon5-27/+27
These reviews must be merged in order because of layering. This review should be merged SECOND Note: In order to get past the following layering problems, there are temporary chages to the following POMs to temporarily use 1.2.1-SNAPSHOT for those dependencies. They are ONAP-PAP-REST/pom.xml org.onap.policy.drools-applications.controlloop.common.policy-yaml ONAP-PDP/pom.xml org.onap.policy.drools-pdp.policy-endpoints A separate review will be used to restore these dependencies to 1.2.2-SNAPSHOT once the drools-pdp and drools-applications reviews are submitted and merged PLD added version.properties Issue-ID: POLICY-798 Change-Id: Id7e83f2ba12181c63cc8845b7eeccf2004d2bab9 Signed-off-by: liamfallon <liam.fallon@ericsson.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com> Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-08Configuration as argument to BRMS Gatewayliamfallon7-12/+90
Added the ability specify the parameter file for the BRMS Gateway as a argument to allow different configurations to be used during unit test. This will allow more thorought unit tests to be written. Replaced System.exit() calls with exeception throws becasue System.exit() call bring down the entire JVM during testing, terminating the test at that point. Changed the package path on four unit test files to the correct path for unit tests for the BRMS gateway. Added a unit test for sanity test of the configuraiton file argument. Issue-ID: POLICY-773 Change-Id: Ic095a5131ddb846eaf3b11157853fab71908c629 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-04Adding rollback for transaction handlingwaqas.ikram3-93/+128
Change-Id: I90887aafdd3cc49940bb4ed4b9283ec8a25aa205 Issue-ID: POLICY-773 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-05-01Remove sysout from junit and disable assert.pa834y1-11/+11
Updated BRMS Gateway junit tests to be less strict on hit counts on queries to Nexus. Draft version passed build son now submitting as full submission. Change-Id: Iab81d14be69835faefbb96fb0af17b3f3759575b Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com> Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-25Remove unit test Java version dependencyliamfallon1-4/+2
In the unit tests for the direct Sona Nexus Rest Interface, one of the unit tests only passed on an Oracle Java specific string. This test is fixed to now work on both Oracle and OpenJDK java Issue-ID: POLICY-700 Change-Id: Idae1aaf612a10ac003f2a91c0b5a80540152ac95 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-24Add JUnit for direct Sonar Nexus REST interfaceliamfallon8-84/+690
JUnit tests and changes to the source code to fix issues that were identified in JUnit testing. JUnit testing runs tests towards the Nexus server at https://nexus.onap.org If that server does not exist then the unit tests will fail but as the nexus serveir is required for the build to work then it should be OK to use that server for unit testing. This removes the need to write complex (and less effective) Mockito type unit tests. Issue-ID: POLICY-700 Change-Id: I4aa33a1022033b42bb1fd1fa36785a8e0216b887 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-24Implement Sonar Nexus REST interface directlyliamfallon11-44/+1029
The BRMS gateway used the obsolete nexus-rest-client-java library to query the Nexus repository. This change removes that dependency and implements an interface directly to Nexus servers using the Nexus REST interface. This change is being submitted to ensure that the security issues with the plugin are resolved. The unit test for the new code will be implemented in a later submission. Issue-ID: POLICY-700 Change-Id: Ia1044e432d370034fe13f42cf7ed55d75e21187a Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-19Add license to policy-engine filesJim Hahn1-0/+20
Added license to various files. Updated XACMLPolicyScanner to work even when license comment is added to the Policy.xml file. Moved DOCTYPE before license in html files. Removed license from css files, as many are generated or come from third-party software. Removed license from other generated files. Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e Issue-ID: POLICY-741 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-04-13Upgrade to SNAPSHOT 1.2.1Pamela Dragosh5-27/+27
Issue-ID: POLICY-736 Change-Id: If5c959aa1c0a123c7fd9eee281e39e1d646b6b03 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-03Merge "ONAP log files consolidation"Jorge Hernandez2-5/+5
2018-04-03ONAP log files consolidationChou, Joseph (JC2555)2-5/+5
Check in changes for pap,pdp,console,brmsgw,paplp and pdplp Change-Id: I23525a44e0f269d04d9870c3eed18b6b8daacb2c Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-04-03Fix BRMSGW Executable Jar Class PathDaniel Cruz1-1/+1
The BRMSGW is no longer able to start up in windriver due to recent changes to the package names. The class path to generate the executable jar now reflects the recent changes. Issue-ID: POLICY-681 Change-Id: I032e516e082defd6a7ad0daae559f8c3e60ae531 Signed-off-by: Daniel Cruz <dc443y@att.com>
2018-03-29Removed checkstyle warningswaqas.ikram24-1444/+1535
Change-Id: I0701333d2b36a0796b592ce92b8015c1a56f8258 Issue-ID: POLICY-711 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-03-28Remove security issue xstream and plexus-utilsPamela Dragosh1-1/+1
Some of these were ommitted from compile while others were not completely ommitted. Upgraded maven-compiler since it upgraded plexus-utils Upgraded latest version of jackson-databind 2.9.5 Issue-ID: POLICY-507 Change-Id: If92ff4355329c48fbe76e0245d6c8344ebb8084d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-28POM changes to centralize test scope depsbobbymander1-19/+0
Issue-ID: POLICY-600 Change-Id: I870317bbd125c6016818ec435ea7a406123c66c1 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-28ONAP code change for log files consolidationChou, Joseph (JC2555)1-4/+4
Undo the change so this would not block other test activity Change-Id: I4f7dd2e14f30034eefbf958be3c912af2962e8a2 Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-03-23ONAP code change for log files consolidationChou, Joseph (JC2555)1-4/+4
Code change for log files consolidation of PAP, PDP, BRMSGW, Console and db script Issue-ID: POLICY-562 Change-Id: I416ba7748b841bb2b1a31682e2b1631e279549e8 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-03-14Policy:BlockerManamohan Satapathy1-9/+11
Use try-with-resources to close this JarFile:L590 L617 Issue-ID: POLICY-688 Sonar link:https://sonar.onap.org/issues?myIssues=true&open=AWF91iXI8TZzbCgU6anv&resolved=false&severities=BLOCKER Location:BRMSGateway\src\main\java\org\onap\policy\brmsInterface\BRMSPush.java Change-Id: I11f07325e78d6c7a9760496db4685546d2910595 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-03-13JUnit additions for PAP-REST,SDK-APPbobbymander1-2/+0
Issue-ID: POLICY-600 Change-Id: Ie2a3257e26382f68d8cb008dc5ac512d6ac49c8b Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-09JUnit additions for BRMSGWbobbymander1-0/+127
Issue-ID: POLICY-598 Change-Id: I90bee429a303b6fbc27272f3a1aa38d89d473e50 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-09Fix brmsgw regex handling for dependeciespa834y1-2/+3
Issue-ID: POLICY-684 Change-Id: I3a8fbbaebf4fdfcd097edcc367e06ef8807aa3bc Signed-off-by: pa834y <pa834y@att.com>
2018-03-09Merge "Policy:Blocker"Jorge Hernandez1-8/+11
2018-03-08JUnit additions for BRMS,POLICY-SDK-APPbobbymander1-0/+93
Issue-ID: POLICY-598 Change-Id: Ic3d9ca2a5f6c29f772bd747612d6c7caeb15eb7f Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-08Policy:BlockerManamohan Satapathy1-8/+11
Use try-with-resources or close this FileOutputStream in a finally clause.:L574 L575 Issue-ID: POLICY-656 Sonar Link: https://sonar.onap.org/issues?myIssues=true&resolved=false Location:BRMSGateway\src\main\java\org\onap\policy\brmsInterface\BRMSPush.java Change-Id: Id9ce5e5505bb3c622652cd7ff1e844519c9c786f Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-03-07JUnit additions for BRMS,APIbobbymander2-0/+74
Issue-ID: POLICY-598 Change-Id: I6a41d510d95afd8538e7775fe12d6e07771dd307 Signed-off-by: bobbymander <bobby.mander@att.com>
2018-03-06Merge "Remove auto generated rule to the drl"Jorge Hernandez2-2/+12
2018-03-05Remove auto generated rule to the drlpa834y2-2/+12
Issue-ID: POLICY-488 Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b Signed-off-by: pa834y <pa834y@att.com>
2018-03-05Upgrade commons-collection for security fixPamela Dragosh1-0/+16
Force use of 3.2.2 to clear security issue for commons collections. Issue-ID: POLICY-507 Change-Id: Id9ac1e07b90dfb6594cde5ba4cec4e3867f43a76 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-26JUnit additions for BRMS,PDP-REST,RESTbobbymander3-0/+162
Issue-ID: POLICY-598 Change-Id: I397ed925bdb43a4b2f7a94cc4692b6506f650ede Signed-off-by: bobbymander <bobby.mander@att.com>
2018-02-21Updated the Policy Logging Patternrb71471-39/+33
Updated the logback.xml to save logs for 30 days. Issue-ID: POLICY-644 Change-Id: I578570fa5a7f86ba464c37cddab43a2fabcdae7f Signed-off-by: rb7147 <rb7147@att.com>
2018-02-20Fix for h2 missing from testingPamela Dragosh1-0/+5
First submit for re-organizing pom.xml dependencies. H2 is ONLY used for testing and should be loaded otherwise. We removed it from policy/common so that is affecting these test. Issue-ID: POLICY-626 Change-Id: Iba86e89f2cb26581b2b465091e829d6bdd66a37b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-19Rename maven modules in drools-applicationsliamfallon2-39/+40
All found references to drools-applications module names changed to new names Issue-ID: POLICY-238 Change-Id: I3cd453c91194699434a71c1a12d2dcccfa5df234 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-02-09Upgrading XACML jarPamela Dragosh1-1/+1
XACML was released with minor fixes for XML files with comments. Mainly it contained upgrade to dependencies that had fixed security issues. One still remains but will not be able to be fixed. Issue-ID: POLICY-617 Change-Id: Ib143c87156ed6a15cf4f0fe0ecbedb2407ca5b0d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-07Upgrade dependencies to clear security issuesPamela Dragosh1-6/+6
A bit of consolidation too - which could use a lot more work. These were simple security upgrades for fixes identified by LF weekly LCM job. Added some missing license headers. Issue-ID: POLICY-507 Change-Id: If285b0f95d30a1084c9363bf6a41b48d52fb3aff Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-12-05Fix Sonar Issues for BRMSGWDaniel Cruz1-13/+10
Removing additional sonar issues. Issue-ID: POLICY-472 Change-Id: Id447c0e31338321051b7d5f69e3087bbc95b504f Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-12-04Fix BRMSGW Sonar IssuesDaniel Cruz3-50/+62
Addressing sonar issues in the BRMSGW submodule. Issue-ID: POLICY-472 Change-Id: I31d532153ff88dafa55c74654fbdfe3874bfb65f Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-11-29Merge "Modified dmaapClient dependency GroupId/Version"Jorge Hernandez1-2/+2
2017-11-29Modified dmaapClient dependency GroupId/VersionMagnusen, Drew (dm741q)1-2/+2
Changed GroupId of dmaapClient deendency to org.onap.dmaap.messagerouter.mirroragent. Created a dmaap.version property in root pom and assigned it a value of 1.0.0. Issue-ID: POLICY-370 Change-Id: I6846f930783a65e4fc0f5afb6b9f832a972477bb Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-11-21Bump minor versionJessica Wagantall5-27/+27
Bump minor version in preparation for Amsterdam branching. Change-Id: I61e0ae91e3ece54ed09a88dad9b8dac173ccae07 Issue-ID: CIMAN-120 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-11-15Update to v1.1.2-SNAPSHOTPamela Dragosh5-27/+27
Release 1.1.1, moving patch to 1.1.2 Issue-ID: POLICY-436 Change-Id: Iabde3e56c04c68ca966efde09b5780e6275cb8a8 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-11-08Update SNAPSHOT versionPamela Dragosh5-29/+29
Releasing v1.1.0 so need to update to v1.1.1 Issue-ID: POLICY-436 Change-Id: Ic575e75d0321c3de2074f8e23d2d0bbd11f6a229 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-11-02Updated the External Dependencies Versionrb71471-1/+1
Resolved the Blocker issue and removed snapshot version Issue-ID: POLICY-406 Change-Id: I1ca4b32aca571610a3d50ae8a105fb45803fd002 Signed-off-by: rb7147 <rb7147@att.com>
2017-09-27New controller support from BRMSGWTej, Tarun4-38/+108
Amsterdam controller support from brmsgw persepective Issue-Id: POLICY-263 Change-Id: I6b28757128998d3dedb86abada02b1d1ea4d3a8a Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-09-21Merge "Added Junits for POLICY-SDK-APP"Pamela Dragosh1-2/+2
2017-09-21Added Junits for POLICY-SDK-APPrb71471-2/+2
Issue-Id: POLICY-52 Change-Id: I439c95736f50fe9140e71cad5a598c5b5239161b Signed-off-by: rb7147 <rb7147@att.com>
2017-09-21Used entrySet instead of keySetrama-huawei2-18/+19
Removed useless assignment to the local variables and useless parenthesis Moved string literal on the left side of the actual string comparison. Issue-ID: POLICY-239 Change-Id: Ie66c92dac548a17d73a976bf0bc57039fd99a5b6 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>