aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-11-05More JUnit additions for PAP-RESTbobbymander6-17/+215
Issue-ID: POLICY-2130 Change-Id: Ia64bdbb377d26ba209b2d3fc51bc95f5769a7729 Signed-off-by: bobbymander <bobby.mander@att.com>
2019-11-05Merge "Fixed Sonar issues for Console Logs"Pamela Dragosh15-2498/+2083
2019-11-04JUnit/SONAR/Checkstyle in ONAP-RESTliamfallon2-407/+570
Cleanup of the dao-impl package in ONAP-REST All enclosing try/catch blocks removed. Issue-ID: POLICY-2131 Change-Id: Iec73fc5a85b891a00ba8c029e9904051c51284c2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-04Fixed Sonar issues for Console Logsuj426b15-2498/+2083
Issue-ID: POLICY-2153 Change-Id: Id21a9dd4910ff0c831e49a1539f130ade1779577 Signed-off-by: utkarshJ <uj426b@att.com>
2019-11-01Add common Jersey versionliamfallon1-3/+9
Add a common version of Jersey for all Policy Framework components. Issue-ID: POLICY-2209 Change-Id: If376b0d1c1cb11c20a176c4ea9a5b674cb8c66da Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-01ONAP-REST DAO Sonar/Checkstyle clean and knock-onliamfallon16-648/+911
Clean up the ONAP-REST DAO package and also deal with knock-on chages in other packages. Issue-ID: POLICY-2131 Change-Id: I381d514d37ffbddb7a91b8f8a018c7354fc437b3 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-10-31Upgrade to drools 7.28.0.Finaljhh1-20/+2
Issue-ID: POLICY-1407 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia934906cb9f5b7a3f8aac59bb204d9426e994e1f Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-10-31Merge "Fixed SonarIssues Alerts to Bootstrap Notification"Pamela Dragosh56-3378/+3388
2019-10-31Merge "Fix unit test failure in ONAP-PDP-REST"Jorge Hernandez1-2/+9
2019-10-30Fixed SonarIssues Alerts to Bootstrap Notificationuj426b56-3378/+3388
Issue-ID: POLICY-2153 Change-Id: I0778ac8a35cc4677e86f93319818d0980fec365b Signed-off-by: utkarshJ <uj426b@att.com>
2019-10-30JUnit additions for PAP-REST, checkstyle fixesbobbymander6-84/+174
Issue-ID: POLICY-2130 Change-Id: Ia9fb294090a27ee86321249bc6b1cbdf20f33d06 Signed-off-by: bobbymander <bobby.mander@att.com>
2019-10-30Fix unit test failure in ONAP-PDP-RESTliamfallon1-2/+9
Unit test parameters were cleared by earlier tests, test setup changed to initiate paramters required by the test. Issue-ID: POLICY-2205 Change-Id: Ia460226ae5fb6e0c42ba9840bd4fe3952dbd1a13 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-10-29Fix knock on tabs/SONAR/Checkstyle issuesliamfallon2-735/+782
Changes in the last ONAP-REST review caused knock on changes in ONAP-PDP-REST. Those changes identified issues in two classes with tabs. While changing the tabs to spaces, some other easy to fix SONAR/Checkstyle issues were addressed. Issue-ID: POLICY-2132 Change-Id: I4e32089ada7b5095da0751993458cf7173cef064 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-10-29Merge "CHeckstyle and JUnit for base package in ONAP-REST"Liam Fallon41-535/+773
2019-10-25junit addition and update for PAP.bobbymander2-66/+73
Issue-ID: POLICY-2130 Change-Id: I33f25588c34fe72b12855a2486ba892afc04693c Signed-off-by: bobbymander <bobby.mander@att.com>
2019-10-24CHeckstyle and JUnit for base package in ONAP-RESTliamfallon41-535/+773
Added unit tests and fixed checkstyle and SONAR issues in the base package of ONAPE-REST There was a lot of knock-on automatic changes done by Eclipse when I renamed the class XACMLRestProperties to XacmlRestProperties so ignore the changes in all but the ONAP-REST package. I also didn't update the licenses on files on those classes because the changes were automatic. Issue-ID: POLICY-2131 Change-Id: I28823c844b5192f8d56de76a727996b13e7ea4a6 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-10-24Merge "Fixed the Policy GUI Editor tab right click issue."Liam Fallon2-5/+346
2019-10-24Fixed the Policy GUI Editor tab right click issue.uj426b2-5/+346
Issue-ID: POLICY-2159 Change-Id: Id659c56167613beb1dd28bcfd71d478209091647 Signed-off-by: utkarshJ <uj426b@att.com>
2019-10-23Consolidate PolicyRestAdapter setupPamela Dragosh155-4438/+4749
Put common code into PolicyEngineUtils that the controllers use to populate the PolicyRestController. Also some more sonar cleanup and formatting of XML files. Shortened 120 line characters. Removed some trailing spaces from comments. Fixed up one JUnit. Licenses. Issue-ID: POLICY-2133 Change-Id: Id7d8ac3ab60331535f048ec0f26aeb17a099414e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-22Remove useless imports and varsPamela Dragosh16-89/+60
Some formatting and javadoc cleanup also. Issue-ID: POLICY-2133 Change-Id: Icb0f76c7e69df87918b4bc5a02a013f9d2bfae89 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-22Format source code PolicyEngineClientPamela Dragosh22-1452/+1512
Formatting and sonar issues. Looks like this is all code used for demonstrating how to call the API's. Uses all main so actually no JUnit is being called. Unfortunately there are no associated test files for it. Would be interesting to see if adding a JUnit to call it with some test code would help to improve overall coverage. Future work. Issue-ID: POLICY-2145 Change-Id: I0d0f6d8898076a92d342553f45f70a56fd9d49f6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-18JUnit addition for PAP-RESTbobbymander1-0/+74
Issue-ID: POLICY-2130 Change-Id: I8b35a83b3eeb2760a99c3893604afba1bc5eafd7 Signed-off-by: bobbymander <bobby.mander@att.com>
2019-10-17Re-format source codePamela Dragosh37-1346/+1097
No longer need the onap-java-formatter.xml in the repo - just use command line to set path to it as this process is done manually anyway. Fixed missing javadoc, curly braces and variables names. One minor fix to remove redundant jump and then unnecessary lambda expression. Distance from usage - moved code. Fixed compilation error in PeCryptoUtils due to policy/common change. Fixed some test sources with consecutive capital letter in names. Updated licenses. Added some trivial code coverage. Issue-ID: POLICY-2145 Change-Id: I6c36650554e4fe31a3e71538d898535bc77e7e74 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-17Merge "Adding simple, missing junit"Jorge Hernandez1-0/+37
2019-10-16Adding simple, missing junitbobbymander1-0/+37
Issue-ID: POLICY-2130 Change-Id: I6bc88b7bf720e672bfaa97029453e8d39a706aae Signed-off-by: bobbymander <bobby.mander@att.com>
2019-10-14Sonar cleanup in controllers etcPamela Dragosh23-947/+964
Variable renaming of consecutive capital letters. Adding Javadoc Missing curly braces Re-writing some methods to reduce cyclomatic complexity Combining while's into a simple for statement. Addressing previous review comments No real effort on code coverage in this one. Issue-ID: POLICY-2133 Change-Id: I4afb3030203e1dbc743507e037ca3d57faf41f1d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-11Add coverage to a few ControllersPamela Dragosh7-67/+427
Cleaned up parts of the code that were useless. The coverage for 2 classes are now over 80%. The CreatePolicyController coverage is now 100% I have no idea what kind of policy the ActionPolicyController is expecting, seems bizarre so will have to leave it alone and move on. Issue-ID: POLICY-2133 Change-Id: I80629d3b6f2aba301483f3fa8c3cad16cc01ffbe Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-11More sonar cleanup and line consolidationPamela Dragosh23-753/+911
Missing javadoc and some variable naming to remove consecutive capitlization of letters. 120 line width reduction Missing curly braces Moving variables due to distance requirements Add missing rawtype suppression or useless ones There are some null return statements that are useless Started doing some combining of lines at the risk of making the code even more unreadable than it already is. Started addressing some nested if's. I see opportunity for a lot of common code to be combined or put into a base controller or utility method. Issue-ID: POLICY-2133 Change-Id: I6d4d9618bea685cf1d02899e3a9d4a43919a2a96 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-10Checkstyle and some coveragePamela Dragosh9-126/+251
Address some trailing space from previous review. Mostly this was checkstyle issues of naming methods and variables, distance from usage, missing javadoc, 120 character spacing. Did add a few trivial code coverage tests. Issue-ID: POLICY-2133 Change-Id: I159d1b27429b6bef046092ea3a4045fbd3a1071c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-08Cleanup POLICY-SDK-APP CheckPDPPamela Dragosh6-249/+264
Fixed sonar issues and added a small amount of code coverage. CheckPDP was renamed to comply with 2 consecutive capital letters. Various sonar issues done. Very difficult to get coverage on remaining area - over 82% anyway. RESTfulPAPEngine was updated to use the new renamed class and methods. Sonar issues were taken care of for the most part and added some coverage by consolidating the JUnit tests. Added in assertj as we will utilize that more throughout the repo. Issue-ID: POLICY-2133 Change-Id: Id0a9b050ebe373e155878699366d78df71bd0554 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-07Use lombok for data objectsPamela Dragosh9-337/+55
Removing lines to see if this will bump coverage. Some sonar for Junit tests and missing coverage. My next task will be to re-use some of this duplicate code for these object types and the controllers. Trailing spaces for patch #3. Issue-ID: POLICY-2133 Change-Id: Iaee123c6be4b63bd831172340709fe7597feaa78 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-07Merge "Format java POLICY-SDK-APP"Pamela Dragosh58-2924/+3250
2019-10-07Format java POLICY-SDK-APPPamela Dragosh58-2924/+3250
As a result of doing command maven reformat, these files are now changed. Updated licenses. Issue-ID: POLICY-2133 Change-Id: I19a8dd70eb10c0d879b97635f7780ab7f92a1753 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-04Remove unused vars and methodsPamela Dragosh16-141/+47
Removed unused variables and unused methods. Removed empty ';' statements. Combined if's that had no content. Not doing any formatting for javascript right now. Licenses. Issue-ID: POLICY-2134 Change-Id: Ib5ec178bd34154281509f57ed15f704e26101f05 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-02Update standalone legacy policy UI recipejhh1-5/+7
Issue-ID: PORTAL-760 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I02c96873768660403b86db736cb3762d0ff8f5ff Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-09-19Use snapshot version of models in policy/engineJim Hahn1-2/+2
Change-Id: I7c8ba1ed700a6a0c9e9017a19ab80ef510719bf4 Issue-ID: POLICY-2065 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-09-17Bump versions in policy/engine masterJim Hahn28-55/+56
Also added default branch to .gitreview to facilitate branching in the future. Switched internal properties to use snapshot versions of other repos per review comment. Change-Id: I23d71e67051d88cfaa07adc15e2d143289269027 Issue-ID: POLICY-2045 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-09-13Release policy/engine 1.5.25.0.0-ONAPPamela Dragosh1-0/+4
Official El Alto release 1.5.2 Issue-ID: POLICY-2045 Change-Id: I29e5b47530fe6a8e02891b0c5b1f15a09e1d332f Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-09-13Upgrade to portal 2.6.0 releasePamela Dragosh2-2/+2
Portal released 2.6.0 Issue-ID: POLICY-2045 Change-Id: I36537fca916be71a76e36f87ede0757397883b4b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-09-09Upgrade to released artifactsPamela Dragosh7-36/+36
Released parent, common and models Issue-ID: POLICY-2045 Change-Id: If26bd3e22f43396e61a53626b72d0d3e9d6bf5fb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-09-03Merge "Change AlertSeverity to Severity in policy/engine"Pamela Dragosh8-551/+551
2019-08-30Merge "Documentation: Legacy APIs"Pamela Dragosh1-2/+5
2019-08-30Documentation: Legacy APIsSaryu Shah1-2/+5
Identified the offered apis under platform as legacy Issue-ID: POLICY-1984 Change-Id: Iee46ded3e506a91181b1c18e1618d4509b8f8f90 Signed-off-by: Saryu Shah <ss3917@att.com>
2019-08-29Change AlertSeverity to Severity in policy/engineJim Hahn8-551/+551
Updated logback xml files, replacing AlertSeverity with Severity. Also fixed some spacing issues. Change-Id: I3e4b9163d5d897fe4402028b69c741f497aecfc5 Issue-ID: POLICY-1989 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-29Additional Changes for Portal SDK 2.6.0 upgradeMichael Mokry3-264/+306
- Modified policyEditor.html to upgrade the angular version to 1.4.13 which is compatible with 2.6.0 SDK - Created new sql script file for Portal db table upgrades in 2.5.0 and 2.6.0 - Modified top level pom to upgrade springframework version to 4.3.24 Change-Id: I5f6e719a2f57891a1b2b76312f446211b6b60abd Issue-ID: POLICY-1539 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-08-23Portal SDK upgrade to 2.6.0 in policy engineMichael Mokry2-2/+2
- Modified poms to upgrade epsdk dependency from 2.4.0 to 2.6.0-SNAPSHOT - Work in progress, still needs to be tested in the lab Change-Id: I5c7df08ed84ef12824d4fdc2ef6f578d6dce7488 Issue-ID: POLICY-1539 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-08-23Fix license on updated engine filesJim Hahn5-12/+11
Address review comment about license date on updated junits. Change-Id: I5dd6e47be243d6f0d5a001cb5cfb45e7ac31f9c8 Issue-ID: POLICY-1937 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-23Merge "Remove powermock to increase coverage"Pamela Dragosh5-49/+141
2019-08-22update keystorejhh1-0/+0
Issue-ID: POLICY-1988 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Icb0b5af7aa63516f82917245083834cacd8caed4 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-08-22Remove powermock to increase coverageJim Hahn5-49/+141
Removed powermock from the junit tests of these classes to increase reported sonar coverage: RESTfulPAPEngine BrmsGateway Typically added override methods to the classes under test, to replace the overrides originally provided by powermock. Also needed to add code to RESTfulPAPEngineTest to clear the XACML properties before the test ran. Modified to use the existing XACMLProperties.reloadProperties() method. Also modified PolicyNotificationMailTest to use a host/port that has no listener so that the test runs faster. Fixed some newly introduced sonar issues. Change-Id: I65e36b01e9506987032eb21baac808ed3dfd4f47 Issue-ID: POLICY-1937 Signed-off-by: Jim Hahn <jrh3@att.com>