summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-10-10Checkstyle and some coveragePamela Dragosh9-126/+251
Address some trailing space from previous review. Mostly this was checkstyle issues of naming methods and variables, distance from usage, missing javadoc, 120 character spacing. Did add a few trivial code coverage tests. Issue-ID: POLICY-2133 Change-Id: I159d1b27429b6bef046092ea3a4045fbd3a1071c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-08Cleanup POLICY-SDK-APP CheckPDPPamela Dragosh6-249/+264
Fixed sonar issues and added a small amount of code coverage. CheckPDP was renamed to comply with 2 consecutive capital letters. Various sonar issues done. Very difficult to get coverage on remaining area - over 82% anyway. RESTfulPAPEngine was updated to use the new renamed class and methods. Sonar issues were taken care of for the most part and added some coverage by consolidating the JUnit tests. Added in assertj as we will utilize that more throughout the repo. Issue-ID: POLICY-2133 Change-Id: Id0a9b050ebe373e155878699366d78df71bd0554 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-07Use lombok for data objectsPamela Dragosh9-337/+55
Removing lines to see if this will bump coverage. Some sonar for Junit tests and missing coverage. My next task will be to re-use some of this duplicate code for these object types and the controllers. Trailing spaces for patch #3. Issue-ID: POLICY-2133 Change-Id: Iaee123c6be4b63bd831172340709fe7597feaa78 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-07Merge "Format java POLICY-SDK-APP"Pamela Dragosh58-2924/+3250
2019-10-07Format java POLICY-SDK-APPPamela Dragosh58-2924/+3250
As a result of doing command maven reformat, these files are now changed. Updated licenses. Issue-ID: POLICY-2133 Change-Id: I19a8dd70eb10c0d879b97635f7780ab7f92a1753 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-04Remove unused vars and methodsPamela Dragosh16-141/+47
Removed unused variables and unused methods. Removed empty ';' statements. Combined if's that had no content. Not doing any formatting for javascript right now. Licenses. Issue-ID: POLICY-2134 Change-Id: Ib5ec178bd34154281509f57ed15f704e26101f05 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-02Update standalone legacy policy UI recipejhh1-5/+7
Issue-ID: PORTAL-760 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I02c96873768660403b86db736cb3762d0ff8f5ff Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-09-19Use snapshot version of models in policy/engineJim Hahn1-2/+2
Change-Id: I7c8ba1ed700a6a0c9e9017a19ab80ef510719bf4 Issue-ID: POLICY-2065 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-09-17Bump versions in policy/engine masterJim Hahn28-55/+56
Also added default branch to .gitreview to facilitate branching in the future. Switched internal properties to use snapshot versions of other repos per review comment. Change-Id: I23d71e67051d88cfaa07adc15e2d143289269027 Issue-ID: POLICY-2045 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-09-13Release policy/engine 1.5.25.0.0-ONAPPamela Dragosh1-0/+4
Official El Alto release 1.5.2 Issue-ID: POLICY-2045 Change-Id: I29e5b47530fe6a8e02891b0c5b1f15a09e1d332f Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-09-13Upgrade to portal 2.6.0 releasePamela Dragosh2-2/+2
Portal released 2.6.0 Issue-ID: POLICY-2045 Change-Id: I36537fca916be71a76e36f87ede0757397883b4b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-09-09Upgrade to released artifactsPamela Dragosh7-36/+36
Released parent, common and models Issue-ID: POLICY-2045 Change-Id: If26bd3e22f43396e61a53626b72d0d3e9d6bf5fb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-09-03Merge "Change AlertSeverity to Severity in policy/engine"Pamela Dragosh8-551/+551
2019-08-30Merge "Documentation: Legacy APIs"Pamela Dragosh1-2/+5
2019-08-30Documentation: Legacy APIsSaryu Shah1-2/+5
Identified the offered apis under platform as legacy Issue-ID: POLICY-1984 Change-Id: Iee46ded3e506a91181b1c18e1618d4509b8f8f90 Signed-off-by: Saryu Shah <ss3917@att.com>
2019-08-29Change AlertSeverity to Severity in policy/engineJim Hahn8-551/+551
Updated logback xml files, replacing AlertSeverity with Severity. Also fixed some spacing issues. Change-Id: I3e4b9163d5d897fe4402028b69c741f497aecfc5 Issue-ID: POLICY-1989 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-29Additional Changes for Portal SDK 2.6.0 upgradeMichael Mokry3-264/+306
- Modified policyEditor.html to upgrade the angular version to 1.4.13 which is compatible with 2.6.0 SDK - Created new sql script file for Portal db table upgrades in 2.5.0 and 2.6.0 - Modified top level pom to upgrade springframework version to 4.3.24 Change-Id: I5f6e719a2f57891a1b2b76312f446211b6b60abd Issue-ID: POLICY-1539 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-08-23Portal SDK upgrade to 2.6.0 in policy engineMichael Mokry2-2/+2
- Modified poms to upgrade epsdk dependency from 2.4.0 to 2.6.0-SNAPSHOT - Work in progress, still needs to be tested in the lab Change-Id: I5c7df08ed84ef12824d4fdc2ef6f578d6dce7488 Issue-ID: POLICY-1539 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-08-23Fix license on updated engine filesJim Hahn5-12/+11
Address review comment about license date on updated junits. Change-Id: I5dd6e47be243d6f0d5a001cb5cfb45e7ac31f9c8 Issue-ID: POLICY-1937 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-23Merge "Remove powermock to increase coverage"Pamela Dragosh5-49/+141
2019-08-22update keystorejhh1-0/+0
Issue-ID: POLICY-1988 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Icb0b5af7aa63516f82917245083834cacd8caed4 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-08-22Remove powermock to increase coverageJim Hahn5-49/+141
Removed powermock from the junit tests of these classes to increase reported sonar coverage: RESTfulPAPEngine BrmsGateway Typically added override methods to the classes under test, to replace the overrides originally provided by powermock. Also needed to add code to RESTfulPAPEngineTest to clear the XACML properties before the test ran. Modified to use the existing XACMLProperties.reloadProperties() method. Also modified PolicyNotificationMailTest to use a host/port that has no listener so that the test runs faster. Fixed some newly introduced sonar issues. Change-Id: I65e36b01e9506987032eb21baac808ed3dfd4f47 Issue-ID: POLICY-1937 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-22Upgrade elastic search to 6.8.2Pamela Dragosh1-1/+1
Clearing security issues - there are no workarounds. Issue-ID: POLICY-2005 Change-Id: I4deb0c1a42c507e1af6d99f24f4f973ab40217a1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-08-13Updated policy/engine GUI springframeworkMichael Mokry2-2/+2
- Modified springframework dependencies version in poms to 4.3.24.RELEASE in ONAP-SDK-APP and POLICY-SDK-APP Change-Id: I149ed2454e7a899b929f179bf46b80190b3bc80c Issue-ID: POLICY-1539 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-08-13Merge "Fix issue for policies not loading on GUI push tab"Jorge Hernandez1-1/+9
2019-08-12Fix issue for policies not loading on GUI push tabMichael Mokry1-1/+9
- found the problem to be with a line of code to add all the scopes from the role to a Set of scopes. when the scopes attribute in the role object is null it logs an exception and fails to load policies. I added a new method to check the value of the roles.getScopes() for null and only attempt to add the scope to the set if it is not null - I created a separate method to do this in order to avoid an increase in technical debt as it would have added to the complexity if I kept it in the same method. - PATCH 4: Added scopes to the method arguments in order to avoid overwriting scopes that are added in prevous interations of the loop. - PATCH 5: removed redundant scopes assignment per Jorge's review. Change-Id: Ifcc8775d3db8ecc722ee6806310a58ecb4e15856 Issue-ID: POLICY-1981 Signed-off-by: Michael Mokry <michael.mokry@att.com>
2019-08-08Review maven dependency for snakeyamlBruno Sakoto3-3/+1
Remove explicit version for snakeyaml maven dependency and inherit it from integration parent artifact. Upgrade snakeyaml to latest 1.24 version. Issue-ID: POLICY-1603 Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca> Change-Id: I93978f963dc37260e0fc4d153c92c7da8db0005d
2019-08-07Bump version of policy/engineJim Hahn27-56/+56
Change-Id: I77e7483bcecbc19d9a5a93087fd4c674aa898b52 Issue-ID: POLICY-1965 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-08-06Add release 1.5.1 filejhh1-0/+4
Issue-ID: POLICY-1953 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ief5e6342b4f24cf594b3bc6456be8a526c214bb8
2019-08-06Update to latest common/models released versionsjhh7-35/+35
policy/models: 2.1.2 policy/common: 1.5.1 Change-Id: Ifa72ed573fb7685710c7288da6fd16ffe6ea397f Issue-ID: POLICY-1953 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-07-31Expand AAF_NS to onap.org.osaaf.aafjhh2-12/+12
Change-Id: I19f284842976ca5e27e5baaa3f21a229ef18ec04 Issue-ID: POLICY-1959 Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-07-26Add lombok.config to policy/engineJim Hahn1-0/+2
This prevents sonar from checking lombok annotations for code coverage. Change-Id: Ia0164c0dd1adf746ef5fbac156fc44e17c424ed3 Issue-ID: POLICY-1938 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-22Javascript now required for code coveragePamela Dragosh1-3/+1
For El Alto, it is now required to pull coverage of Javascript code. Issue-ID: POLICY-1928 Change-Id: If1c0c2ba795b7a8f5faf69ab32ffbb953c411f78 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-07-08Fix policy/engine due to sonar changes in commonJim Hahn11-99/+100
Fixed breakages due to changes made in policy/common to satisfy sonar. Change-Id: I88090c7549ba19f9eb45fae311e8811e39f30318 Issue-ID: POLICY-1791 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-01Bump engine 1.5.1-SNAPSHOTPamela Dragosh26-79/+60
Released 1.5.0 Fixed compilation issue related with version upgrade of policy/common. Issue-ID: POLICY-1737 Change-Id: Ib2f56e8ffcb4b399dbe4a5453b70da10b0f87985 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com> Signed-off-by: Jim Hahn <jrh3@att.com>
2019-07-01Merge "Adding logging to JUnit"1.5.0Jim Hahn2-3/+65
2019-07-01Fix centos build issueJim Hahn1-0/+16
Seeing this when trying to build in centos: 10:04:12 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.459 s - in org.onap.policy.pap.ia.DbAuditCompareEntriesTest 10:04:12 [INFO] 10:04:12 [INFO] Results: 10:04:12 [INFO] 10:04:12 [ERROR] Failures: 10:04:12 [ERROR] XACMLPAPTest.testDummy:907 10:04:12 [ERROR] Errors: 10:04:12 [ERROR] XACMLPAPTest.getDictionary:886 ยป NullPointer ... Modified the junit test(s) to create the JPA entities needed by integrity audit, which is what was causing the above issues. Change-Id: I405798a1946d377770529a99210a1cc57390667f Issue-ID: POLICY-1737 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-06-28Adding logging to JUnitPamela Dragosh2-3/+65
Turning on logging. Issue-ID: POLICY-1876 Change-Id: I82b04609a07f5d33c88c3e0068959de1e628cb38 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-28Remove docker scriptsPamela Dragosh3-338/+0
These are no longer needed as we are now doing the docker maven plugin due to global-jjb changes. Issue-ID: POLICY-1737 Change-Id: I98e8f2a16a66cfe210ddcdf0c50cb55bdebfd687 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-27Remove trafficgenerator from dependency.jsonPamela Dragosh2-35/+27
This jar does not exist and breaks brmsgw when generating the amsterdam archetype. Update the dependency.json for local testing. Issue-ID: POLICY-1872 Change-Id: I5851462ea39c56693284854b5cd1d2cb5dd1dcdd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-24Upgrade to released common & modelsPamela Dragosh1-2/+2
Released common 1.5.0 and models 2.1.0 Issue-ID: POLICY-1737 Change-Id: Iecbf38e57a71907f320e3c8da55a6921ca371c44 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-20Merge "Upgrade to release 3.0.0 parent"Jim Hahn1-1/+1
2019-06-20Upgrade to release 3.0.0 parentPamela Dragosh1-1/+1
Policy/parent is released Issue-ID: POLICY-1737 Change-Id: I58d8a74f85a6bbc7499614093e7f0d73c54f95ed Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-19Improved tests performanceKrysiak Adam3-113/+144
* used mock instead of waiting till dmaap client fails * creating in memory DB only once Issue-ID: POLICY-1671 Change-Id: Ia1b6ce7ddad1bce0d17c2dbf14f3d82dd237673b Signed-off-by: Krysiak Adam <adam.krysiak@nokia.com>
2019-06-18Fix compile issue with guardPamela Dragosh1-39/+32
Due to sonar changes in policy/models for guard. Issue-ID: POLICY-1791 Change-Id: I2cdbe6d0e4ee8bad05b9d3bb1a83e82d4851973c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-17Use io.fabric8:docker-maven-plugin to build and push docker imagesRashmi Pujar3-128/+184
Issue-ID: POLICY-969 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca> Change-Id: Ic4fcec72d494df0a6e067aa353be49936136518c
2019-06-06Remove nexus staging pluginpdragosh1-10/+0
Unused Issue-ID: POLICY-1737 Change-Id: I3e287ecbca9707d04f566295ebc5d0d430980d81 Signed-off-by: pdragosh <pdragosh@research.att.com>
2019-06-05Fix header and remove linkPamela Dragosh2-2/+1
Missing and remove outdated installation instructions. Issue-ID: POLICY-1676 Change-Id: I8b27752bc05039d43a2fbbf22e7388d55469b5a7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-06-03Reference policy/parent for latest docPamela Dragosh2-2/+6
Point to new documentation. Issue-ID: POLICY-1676 Change-Id: I1a3e9a7f1147885c8de72a725c8637a86cd5eb7c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com> (cherry picked from commit 6b6cb44dd9f60df943c31188ec68a25852c0200b)
2019-05-31Bump engine to version 1.5.0Jim Hahn26-78/+63
Fixed license date. Change-Id: I711fb4e91afdb3813bc04b16265f584d80ac8e5d Issue-ID: POLICY-1747 Signed-off-by: Jim Hahn <jrh3@att.com>