Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
Fourth batch of JPA pojos (N-P), with JUnit added and SONAR/Checkstyle
issues addressed. In cases where a class name change caused an update in
another package, the license header on files for those knock on changes
are not updated.
Issue-ID: POLICY-2131
Change-Id: I9319b514b5c19e6837c34566dde770673d16bca3
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1895
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: Ice15aadbafd999b20594c3b6488e115063c985ce
|
|
Issue-ID: POLICY-2130
Change-Id: Ie9972bc0014def93acf04c4a2386585fb4accdef
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Third batch of JPA pojos (E-M), with JUnit added and SONAR/Checkstyle
issues addressed. In cases where a class name change caused an update in
another package, the license header on files for those knock on changes
are not updated.
Issue-ID: POLICY-2131
Change-Id: I4fee1e9fb9c8a69dd6f2f15d3e3a8844473b857b
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Changed the table name in multiple files.
Backed out some changes per review comments.
Change-Id: I31f75ebdef4aa70aff841c8a52185f6ab8a4e329
Issue-ID: POLICY-2131
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
policy/parent now has this plugin defined
Issue-ID: POLICY-2222
Change-Id: I855c7b2bbd65e93695f7bfe5242be6f474f416fc
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
If this backfires, we can turn it back off again.
Issue-ID: POLICY-2131
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I7375bf4a3fa63a7791c30b3a73813bff1a69055e
|
|
Second batch of JPA pojos (B-D), with JUnit added and SONAR/Checkstyle
issues addressed. In cases where a class name change caused an update in
another package, the license header on files for those knock on changes
are not updated.
Issue-ID: POLICY-2131
Change-Id: I9466f27ffa606001209ed978be592ae95d1b32c4
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
First batch of JPA pojos Lombok'd and some missing coverage updated
I'll be interested to see how Lomboking code shows up in SONAR, I have
not added much JUnit here but I have reduced a good bit of source code,
let's see what happens.
Issue-ID: POLICY-2131
Change-Id: I8f270ef57282f63821c1eb94dd6b50f8ae541028
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Issue-ID: POLICY-2130
Change-Id: Ia64bdbb377d26ba209b2d3fc51bc95f5769a7729
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
|
|
Cleanup of the dao-impl package in ONAP-REST
All enclosing try/catch blocks removed.
Issue-ID: POLICY-2131
Change-Id: Iec73fc5a85b891a00ba8c029e9904051c51284c2
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-2153
Change-Id: Id21a9dd4910ff0c831e49a1539f130ade1779577
Signed-off-by: utkarshJ <uj426b@att.com>
|
|
Add a common version of Jersey for all Policy Framework components.
Issue-ID: POLICY-2209
Change-Id: If376b0d1c1cb11c20a176c4ea9a5b674cb8c66da
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Clean up the ONAP-REST DAO package and also deal with knock-on chages in
other packages.
Issue-ID: POLICY-2131
Change-Id: I381d514d37ffbddb7a91b8f8a018c7354fc437b3
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Issue-ID: POLICY-1407
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia934906cb9f5b7a3f8aac59bb204d9426e994e1f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
|
|
|
|
Issue-ID: POLICY-2153
Change-Id: I0778ac8a35cc4677e86f93319818d0980fec365b
Signed-off-by: utkarshJ <uj426b@att.com>
|
|
Issue-ID: POLICY-2130
Change-Id: Ia9fb294090a27ee86321249bc6b1cbdf20f33d06
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Unit test parameters were cleared by earlier tests, test setup changed
to initiate paramters required by the test.
Issue-ID: POLICY-2205
Change-Id: Ia460226ae5fb6e0c42ba9840bd4fe3952dbd1a13
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
Changes in the last ONAP-REST review caused knock on changes in
ONAP-PDP-REST. Those changes identified issues in two classes with tabs.
While changing the tabs to spaces, some other easy to fix
SONAR/Checkstyle issues were addressed.
Issue-ID: POLICY-2132
Change-Id: I4e32089ada7b5095da0751993458cf7173cef064
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Issue-ID: POLICY-2130
Change-Id: I33f25588c34fe72b12855a2486ba892afc04693c
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Added unit tests and fixed checkstyle and SONAR issues in the base
package of ONAPE-REST
There was a lot of knock-on automatic changes done by Eclipse when I
renamed the class XACMLRestProperties to XacmlRestProperties so ignore
the changes in all but the ONAP-REST package. I also didn't update the
licenses on files on those classes because the changes were automatic.
Issue-ID: POLICY-2131
Change-Id: I28823c844b5192f8d56de76a727996b13e7ea4a6
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
|
|
|
Issue-ID: POLICY-2159
Change-Id: Id659c56167613beb1dd28bcfd71d478209091647
Signed-off-by: utkarshJ <uj426b@att.com>
|
|
Put common code into PolicyEngineUtils that the controllers use to
populate the PolicyRestController.
Also some more sonar cleanup and formatting of XML files.
Shortened 120 line characters. Removed some trailing spaces
from comments.
Fixed up one JUnit.
Licenses.
Issue-ID: POLICY-2133
Change-Id: Id7d8ac3ab60331535f048ec0f26aeb17a099414e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Some formatting and javadoc cleanup also.
Issue-ID: POLICY-2133
Change-Id: Icb0f76c7e69df87918b4bc5a02a013f9d2bfae89
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Formatting and sonar issues.
Looks like this is all code used for demonstrating how to call
the API's. Uses all main so actually no JUnit is being called.
Unfortunately there are no associated test files for it. Would be
interesting to see if adding a JUnit to call it with some test
code would help to improve overall coverage. Future work.
Issue-ID: POLICY-2145
Change-Id: I0d0f6d8898076a92d342553f45f70a56fd9d49f6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: POLICY-2130
Change-Id: I8b35a83b3eeb2760a99c3893604afba1bc5eafd7
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
No longer need the onap-java-formatter.xml in the repo - just
use command line to set path to it as this process is done
manually anyway.
Fixed missing javadoc, curly braces and variables names.
One minor fix to remove redundant jump and then unnecessary
lambda expression.
Distance from usage - moved code.
Fixed compilation error in PeCryptoUtils due to policy/common
change.
Fixed some test sources with consecutive capital letter in
names.
Updated licenses.
Added some trivial code coverage.
Issue-ID: POLICY-2145
Change-Id: I6c36650554e4fe31a3e71538d898535bc77e7e74
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
Issue-ID: POLICY-2130
Change-Id: I6bc88b7bf720e672bfaa97029453e8d39a706aae
Signed-off-by: bobbymander <bobby.mander@att.com>
|
|
Variable renaming of consecutive capital letters.
Adding Javadoc
Missing curly braces
Re-writing some methods to reduce cyclomatic complexity
Combining while's into a simple for statement.
Addressing previous review comments
No real effort on code coverage in this one.
Issue-ID: POLICY-2133
Change-Id: I4afb3030203e1dbc743507e037ca3d57faf41f1d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Cleaned up parts of the code that were useless.
The coverage for 2 classes are now over 80%. The
CreatePolicyController coverage is now 100%
I have no idea what kind of policy the ActionPolicyController
is expecting, seems bizarre so will have to leave it alone
and move on.
Issue-ID: POLICY-2133
Change-Id: I80629d3b6f2aba301483f3fa8c3cad16cc01ffbe
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Missing javadoc and some variable naming to remove consecutive
capitlization of letters.
120 line width reduction
Missing curly braces
Moving variables due to distance requirements
Add missing rawtype suppression or useless ones
There are some null return statements that are useless
Started doing some combining of lines at the risk of making the
code even more unreadable than it already is.
Started addressing some nested if's.
I see opportunity for a lot of common code to be combined or
put into a base controller or utility method.
Issue-ID: POLICY-2133
Change-Id: I6d4d9618bea685cf1d02899e3a9d4a43919a2a96
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Address some trailing space from previous review. Mostly this
was checkstyle issues of naming methods and variables, distance
from usage, missing javadoc, 120 character spacing.
Did add a few trivial code coverage tests.
Issue-ID: POLICY-2133
Change-Id: I159d1b27429b6bef046092ea3a4045fbd3a1071c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Fixed sonar issues and added a small amount of code coverage.
CheckPDP was renamed to comply with 2 consecutive capital letters. Various
sonar issues done.
Very difficult to get coverage on remaining area - over 82% anyway.
RESTfulPAPEngine was updated to use the new renamed class and methods.
Sonar issues were taken care of for the most part and added some coverage
by consolidating the JUnit tests.
Added in assertj as we will utilize that more throughout the repo.
Issue-ID: POLICY-2133
Change-Id: Id0a9b050ebe373e155878699366d78df71bd0554
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removing lines to see if this will bump coverage. Some sonar
for Junit tests and missing coverage.
My next task will be to re-use some of this duplicate code
for these object types and the controllers.
Trailing spaces for patch #3.
Issue-ID: POLICY-2133
Change-Id: Iaee123c6be4b63bd831172340709fe7597feaa78
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
As a result of doing command maven reformat, these files are
now changed.
Updated licenses.
Issue-ID: POLICY-2133
Change-Id: I19a8dd70eb10c0d879b97635f7780ab7f92a1753
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Removed unused variables and unused methods.
Removed empty ';' statements.
Combined if's that had no content.
Not doing any formatting for javascript right now.
Licenses.
Issue-ID: POLICY-2134
Change-Id: Ib5ec178bd34154281509f57ed15f704e26101f05
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Issue-ID: PORTAL-760
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I02c96873768660403b86db736cb3762d0ff8f5ff
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
|
|
Change-Id: I7c8ba1ed700a6a0c9e9017a19ab80ef510719bf4
Issue-ID: POLICY-2065
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Also added default branch to .gitreview to facilitate branching in
the future.
Switched internal properties to use snapshot versions of other
repos per review comment.
Change-Id: I23d71e67051d88cfaa07adc15e2d143289269027
Issue-ID: POLICY-2045
Signed-off-by: Jim Hahn <jrh3@att.com>
|