summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-02-01Merge "Reduce technical debt"Jorge Hernandez3-102/+87
2018-02-01Merge "Continue addressing technical debt for ONAP-XACML"Jorge Hernandez4-7/+5
2018-01-31Continue addressing technical debt for ONAP-XACMLGao, Chenfei (cg287m)4-7/+5
Follow the list of acceptable fixes in POLICY-336 description Issue-ID: POLICY-475 Change-Id: I67f46bb383db1ac4feecb0223df98d180733fc95 Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
2018-01-31Fixed the Sonar technical debt.Ankitkumar Patel91-486/+417
Fixed the sonar technical dept primarily for the POLICY-REST module, and accordingly updated the other policy-engine modules for successful built. Issue-ID: POLICY-476 Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-01-31Reduce technical debtPamela Dragosh3-102/+87
The last for technical debt I believe. The last try-with-resources I dare to fix. Useless import that I missed last time. Did a couple of minor reductions in cyclomatic complexity that I think are harmless. And lastly introduce a new variable instead of reusing a parameter. Issue-ID: POLICY-482 Change-Id: I5f2e5abbdd472496b48cf12e485fc9b4d903f35a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-31Adding code coverage reduce duplicate linesPamela Dragosh11-126/+236
Removed some duplicate code across some of the classes. For CheckPDP, got the code coverage above 80%. Issue-ID: POLICY-482 Change-Id: I41495cf9f92e8fd248350bf33f5a183c876f38f2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-31Merge "Fix technical debt and reduce lines"Pamela Dragosh9-94/+83
2018-01-31Merge "Addressing Technical Debt for ONAP-XACML"Pamela Dragosh16-147/+143
2018-01-30Fix technical debt and reduce linesPamela Dragosh9-94/+83
Focused on iterating over entrySet along with more fixes for dead stores, unnecessary exceptions. I'm also starting to work on reducing the number of code lines. * Iterate using entrySet * Remove useless assignments * Unnecessary exceptions * Use StringBuilder instead of StringBuffer due to synchronization * Potential null exceptions being thrown * Returning a empty collection vs null Issue-ID: POLICY-482 Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-29Addressing Technical Debt for ONAP-XACMLGao, Chenfei (cg287m)16-147/+143
Follow the list of acceptable fixes in POLICY-336 description Issue-ID: POLICY-475 Change-Id: I45cfb55c571d32601049beb8e5be8676216dcf5c Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
2018-01-29Reduce technical debtPamela Dragosh17-218/+195
Focusing on easy try-with-resources changes. Plus some other minor items. I did not get all of them yet, as some have some heavy refactoring. These try-with-resources seem to be fairly harmless. * Utilize try-with-resources * Remove unnecessary parenthesis * Merging simple if statements * Remove useless assignment * Moving string literals to left hand side Issue-ID: POLICY-482 Change-Id: If519ec8ea96f6b90bf82ac2676ffea9cd0cd2daf Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-26Use try-with-resourcesPamela Dragosh2-26/+48
Also enhanced JUnit tests to ensure this will work. Reduced code. Issue-ID: POLICY-482 Change-Id: If07e17df274bdb709f7ca60078bd1fbd78d1aaaa Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-23Reduce technical debtPamela Dragosh10-100/+98
Mainly use StringBuilder() to improve speed * Use StringBuilder * Remove superflous exceptions in constructor * Remove unnecessary casts * Remove unnecessary toString() * Combine return into one statement * Move string literal to LHS Issue-ID: POLICY-482 Change-Id: Id196728d92dda7fab7e83d6eea07633c5be37f7c Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-23Addressing Technical Debt for POLICY-SDK-APPPamela Dragosh27-177/+161
* Using booleans true and false * Using already predefined static strings * Adding private constructors to hide implicit * Adding empty constructor comment to satisfy SONAR * Using single quotes for indexOf to use faster method * Preferred use of .isEmpty() * Ordering of public static synchronized syntax * Removing commented out code * Using an already defined constant * Unnecessary declaration of runtime exceptions * Unnecessary casts * Unused variables and imports * Unnecessary use of toString() * Just using return vs storing into a local var and returning that * Extra semicolons Issue-ID: POLICY-482 Change-Id: I6b9dcc5211dd52895a8787239b9df3059928fa45 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-01-19Resolved the Critical issue reported by Sonarrb71471-2/+11
Issue-ID: POLICY-521 Change-Id: I2a7072076a1ed0924bfeacd6f3d2b6a910f30338 Signed-off-by: rb7147 <rb7147@att.com>
2018-01-17Resolved Security Vulnerability issuesrb71474-1/+69
Issue-ID: POLICY-553 Change-Id: I3e0e6a31226e561cef9ec578790659d57b2f65f4 Signed-off-by: rb7147 <rb7147@att.com>
2018-01-16Merge "Restrict file upload size in policy editor"Jorge Hernandez4-12/+36
2018-01-16Restrict file upload size in policy editorMagnusen, Drew (dm741q)4-12/+36
Restrict file upload size in Policy Editory using a configurable value (in bytes) set in xacml.admin.properties. Default value is 30MB. Issue-ID: POLICY-538 Change-Id: I4d8539ab33320446aed250ea4fdc51de585d5f2a Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2018-01-16PDPGroup Audit FixMichael Mokry2-1/+3
*This fix will add new group to GroupEntity table if no default exists during initialization and therefore provides a permanent solution to the initialization errors on the PAP Change-Id: Ie394d76b9cbc02cad15d62d6adea6fc17938f734 Issue-ID: POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com> (cherry picked from commit 676d7d8dc9985e93d7c9cbc0412a26f2b19c23cd)
2018-01-15Merge "Local and Class variable name conflict resolved"Jorge Hernandez1-3/+3
2018-01-15Merge "Fixed as per Java Code Conventions"Jorge Hernandez1-9/+9
2018-01-12Merge "Sonar cleanup for PolicyEngineUtils"Jorge Hernandez14-35/+63
2018-01-12Local and Class variable name conflict resolvedSRINIVAS V1-3/+3
*Renamed the local variable to othername Change-Id: I5f1e1b8b9140acf73de241f78b0437dc9e5805b5 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-12Fixed as per Java Code Conventionsroot11-9/+9
*Moved the constructors after the variables Change-Id: I099f75aea285f0bb845d464065d1e5f031d44a13 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-11Removed useless parenthesesroot11-1/+1
*Removed those useless parentheses Change-Id: I19e9e027182dfd7dc2211d71fbb4acd8bf6b8be5 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-11Merge "Fixed as code optimization"Pamela Dragosh1-4/+2
2018-01-11Fixed as per Java Code Conventionsroot11-2/+8
*Moved the constructors after the variables Change-Id: I531a911570867e05d2eabca98d349f4f2f26d0f9 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-09Fixed as code optimizationSRINIVAS V1-4/+2
*no need to create seperate object, so optimized Change-Id: I245d7fd26c0fabb26de6e9eb7c8bedf405d9d602 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-08Fixed as per Java Code ConventionsSRINIVAS V2-12/+13
*Moved the constructors after the variables *Deleted the commented code Change-Id: I6afa9ae5b04fe5c8280fc9e08352aef699117567 Issue-ID: POLICY-336 Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
2018-01-03Merge "Adding PolicyType to getConfig Response"Pamela Dragosh12-10/+83
2018-01-03Merge "Policy Elastic Search Validation Enhancements"Pamela Dragosh5-17/+132
2018-01-03Merge "Adding SONAR fixes for"Pamela Dragosh19-505/+907
2017-12-21Sonar cleanup for PolicyEngineUtilsMagnusen, Drew (dm741q)14-35/+63
Changes to resolve some sonar "major" issues in the PolicyEngineUtils module. Patch 2: Updated the NotificationStoreTest junit to account for the return of a "Collections.emptyList()" rather than "null" in StdPDPNotification class. Patch 3: Updated the StdPDPNotificationTest junit to account for the return of a "Collections.emptyList()" rather than "null" in StdPDPNotifaction class. Issue-ID: POLICY-474 Change-Id: I925774ac181fd38d1206637f47ab27ba499629ef Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-12-14Policy Elastic Search Validation Enhancementsrb71475-17/+132
Issue-ID: POLICY-497 Change-Id: If97fe30706bcdbeeafaf28e5cca8fae31998cb7c Signed-off-by: rb7147 <rb7147@att.com>
2017-12-13Adding PolicyType to getConfig ResponseTej, Tarun12-10/+83
Adding a new parameter PolicyType so that getConfig Response can be known based on type of policy. Fixes for project warnings and unused imports. Issue-ID: POLICY-434 Change-Id: I0874abb7e986a8bb42ae18561064a8d7534eade6 Signed-off-by: Tej, Tarun <tt3868@att.com>
2017-12-13Merge "Add ELK Security"Pamela Dragosh1-3/+3
2017-12-12Add ELK SecurityTemoc Rodriguez1-3/+3
Add security to ELk such that only localhost is able to access ELK. All other hosts will be denied service. This fixes the open elastic serach security vulnerability. Issue-ID: POLICY-495 Change-Id: I7f5d6fef5963f984c2bce6933c8b214c0bd3be2b Signed-off-by: Temoc Rodriguez <cr056n@att.com>
2017-12-12Merge "Fix audit log to contain ending timestamp"Pamela Dragosh3-4/+5
2017-12-12Fix audit log to contain ending timestampMike Babinski3-4/+5
Add transaction end method Change-Id: Ie818bb1650b0847800ce5481a85c5d2c8d7f4b9c Issue-ID: POLICY-494 Signed-off-by: Mike Babinski <mb1915@att.com>
2017-12-11Resolved the Policy GUI Javascript issuesrb714719-85/+191
Issue-ID: POLICY-440 Change-Id: I44d5304699da19bee7ae2997565802fc7d44cb0e Signed-off-by: rb7147 <rb7147@att.com>
2017-12-11Adding SONAR fixes forMichael Mokry19-505/+907
- pushPolicy defect fixes for POLICY-486 - Common Policy Validation feature for POLIYC-449 Change-Id: I8d54aa5a9b819c6eb4427dfa47c4ce963a21c2e0 Issue-ID: POLICY-449,POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-12-08Upgraded the latest ONAP SDKrb714780-1756/+1039
Upgraded latest ONAP SDK Code. Change-Id: I669d6cfcefe068b1e4c078889d7d6c77ce788e2e Issue-ID: POLICY-432 Signed-off-by: rb7147 <rb7147@att.com>
2017-12-06Merge "Refactor to provide Common Policy Validation"Pamela Dragosh17-671/+1864
2017-12-06Merge "Fix Sonar Issues for BRMSGW"Jorge Hernandez1-13/+10
2017-12-05Modified the code to fix various pushPolicy issuesMichael Mokry11-156/+600
- Added modifications per Pam's review Change-Id: I5d67ee529cbc5245e7d1f8dbec6f2f2d453ce299 Issue-ID: POLICY-486 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-12-05Fix Sonar Issues for BRMSGWDaniel Cruz1-13/+10
Removing additional sonar issues. Issue-ID: POLICY-472 Change-Id: Id447c0e31338321051b7d5f69e3087bbc95b504f Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-12-04Fix BRMSGW Sonar IssuesDaniel Cruz3-50/+62
Addressing sonar issues in the BRMSGW submodule. Issue-ID: POLICY-472 Change-Id: I31d532153ff88dafa55c74654fbdfe3874bfb65f Signed-off-by: Daniel Cruz <dc443y@att.com>
2017-12-04Refactor to provide Common Policy ValidationMichael Mokry17-671/+1864
Provides a common class to perform policy validation during create/udpate of policies by the GUI and API for consistency. Change-Id: Ied459e73d48517bb50064cd10d6a1c871b8311e5 Issue-ID: POLICY-449 Signed-off-by: Michael Mokry <mm117s@att.com>
2017-11-29Merge "Modified dmaapClient dependency GroupId/Version"Jorge Hernandez4-5/+6
2017-11-29Modified dmaapClient dependency GroupId/VersionMagnusen, Drew (dm741q)4-5/+6
Changed GroupId of dmaapClient deendency to org.onap.dmaap.messagerouter.mirroragent. Created a dmaap.version property in root pom and assigned it a value of 1.0.0. Issue-ID: POLICY-370 Change-Id: I6846f930783a65e4fc0f5afb6b9f832a972477bb Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>