aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-05-08fixing NullPointException incase of db exceptionwaqas.ikram3-405/+409
Making changes for NullPointerException it was triggered by - SQL Query Failed in PAP return unhandled reponse code > activeVersion variable is set to null > if statement in DeletePolicyService (!activeVersion.equalsIgnoreCase("0") result into NullPointerException Change-Id: Iad9de0d31b6cf16d1eafd6175d1c355b07481db9 Issue-ID: POLICY-773 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-05-08Merge "Configuration as argument to BRMS Gateway"Pamela Dragosh7-12/+90
2018-05-08Configuration as argument to BRMS Gatewayliamfallon7-12/+90
Added the ability specify the parameter file for the BRMS Gateway as a argument to allow different configurations to be used during unit test. This will allow more thorought unit tests to be written. Replaced System.exit() calls with exeception throws becasue System.exit() call bring down the entire JVM during testing, terminating the test at that point. Changed the package path on four unit test files to the correct path for unit tests for the BRMS gateway. Added a unit test for sanity test of the configuraiton file argument. Issue-ID: POLICY-773 Change-Id: Ic095a5131ddb846eaf3b11157853fab71908c629 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-07fix PE DB lock timeout problemsJorge Hernandez4-7/+7
see companion docker review. The failOverReadOnly .. flags should only be used when a DB high availability environment is used, such as a master/slave configuration. As they are the jdbc parameters have caused bad interactions with the underlying persistence libraries rendering the PAP useless. It is thought that this may perhaps solve POLICY-773, POLICY-775, POLICY-779, and perhaps POLICY-776. Change-Id: Icb69a3afc0a19969a34af40d960fa8e1b94aabc0 Issue-ID: POLICY-777 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-05-07automate dependency.json version populationJorge Hernandez5-13/+20
This avoids error-prone manual version changes to configuration files. Change-Id: I1a991ef9a8eb4cc7dd5fe26d9952286d8b5c0115 Issue-ID: POLICY-766 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-05-04Adding rollback for transaction handlingwaqas.ikram3-93/+128
Change-Id: I90887aafdd3cc49940bb4ed4b9283ec8a25aa205 Issue-ID: POLICY-773 Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
2018-05-03Updated policy documentationSaryu Shah4-19/+20
Updated policy documentation ------------------------------------------------------------- Change-Id: I840d17df857bb14fdc7e96e3c5f984037944c889 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-05-02Merge "Ignore directories created"Jorge Hernandez1-0/+5
2018-05-01Add INFO.yaml fileJessica Wagantall1-0/+37
Add INFO.yaml to list: - Project description - Properties - PTL information - Meeting information - Committer information Change-Id: Iab302b1e24c08980e3073d3fa34d53e4e81cabad Issue-ID: CIMAN-134 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2018-05-01Ignore directories createdPamela Dragosh1-0/+5
Clean up some outstanding logging side effects in .gitignore Issue-ID: POLICY-708 Change-Id: Ia3f268f0adf5615a11a109cb0d7d029a069b4520 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-05-01Fix Test fail with variable length memory addressliamfallon1-1/+2
The unit test class PIPConfigurationTest.java has a test that checks a configuration string for length. However, the length of the "piptype" field in that string can vary, causing the test to intermittently fail. Field that passes: piptype=org.onap.policy.rest.jpa.PIPType@71b3bc45 Field that fails: piptype=org.onap.policy.rest.jpa.PIPType@a8c1f44 This fix removes the memory address from the "piptype" field, so that the configuration string will now always be 323 characters in length. Change-Id: Ib3640ec6f69ac7d691dcc989c44a7822bcc9b7f7 Issue-ID: POLICY-765 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-01Updated installation documentationSaryu Shah5-54/+1028
Updated installation documentation ------------------------------------------------------------- Change-Id: I71d24c0806fc5d53691c505f87425c71e2f0a04f Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-05-01Merge "Remove sysout from junit and disable assert."Pamela Dragosh5-27/+19
2018-05-01Remove sysout from junit and disable assert.pa834y5-27/+19
Updated BRMS Gateway junit tests to be less strict on hit counts on queries to Nexus. Draft version passed build son now submitting as full submission. Change-Id: Iab81d14be69835faefbb96fb0af17b3f3759575b Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com> Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-27Updated policy documentationSaryu Shah10-296/+6
Fixed typos, Updated release notes, Deleted old release files ------------------------------------------------------------- Change-Id: I43bb64b7d1829e92b30bfd45ec3f3608a59672cf Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-26Incorporate Liam code reviewpa834y4-58/+68
Change-Id: I387a54b8bd8c619c521c512258928669a8c1b791 Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com>
2018-04-26Merge "Fix typo in documentation"Pamela Dragosh2-2/+4
2018-04-26Fix typo in documentationSaryu Shah2-2/+4
Fix typo in documentation ------------------------------------------------------------- Change-Id: I01b8849c97645e9e5ed81f99768088f2fa439e45 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-26Merge "Remove unit test Java version dependency"Pamela Dragosh1-4/+2
2018-04-25Remove unit test Java version dependencyliamfallon1-4/+2
In the unit tests for the direct Sona Nexus Rest Interface, one of the unit tests only passed on an Oracle Java specific string. This test is fixed to now work on both Oracle and OpenJDK java Issue-ID: POLICY-700 Change-Id: Idae1aaf612a10ac003f2a91c0b5a80540152ac95 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-25cook policy-keystore into pe imageJorge Hernandez3-4/+20
OOM team reported issues with ONAP installation in terms of config map sizes. After discussion with OOM team, one solution is to cook it in the docker image itself. This will solve the size issue on the OOM side. Change-Id: I2ca20bdc3aa8ee959c5e4c1d07483fe5f0c14607 Issue-ID: POLICY-747 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-04-25Merge "Add JUnit for direct Sonar Nexus REST interface"Jorge Hernandez8-84/+690
2018-04-24Add websocket client code.pa834y5-629/+475
Change-Id: I2d3939c698a0df6bec068063f08566226f65bfd3 Issue-ID: POLICY-756 Signed-off-by: pa834y <pa834y@att.com>
2018-04-24Add JUnit for direct Sonar Nexus REST interfaceliamfallon8-84/+690
JUnit tests and changes to the source code to fix issues that were identified in JUnit testing. JUnit testing runs tests towards the Nexus server at https://nexus.onap.org If that server does not exist then the unit tests will fail but as the nexus serveir is required for the build to work then it should be OK to use that server for unit testing. This removes the need to write complex (and less effective) Mockito type unit tests. Issue-ID: POLICY-700 Change-Id: I4aa33a1022033b42bb1fd1fa36785a8e0216b887 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-24Implement Sonar Nexus REST interface directlyliamfallon11-44/+1029
The BRMS gateway used the obsolete nexus-rest-client-java library to query the Nexus repository. This change removes that dependency and implements an interface directly to Nexus servers using the Nexus REST interface. This change is being submitted to ensure that the security issues with the plugin are resolved. The unit test for the new code will be implemented in a later submission. Issue-ID: POLICY-700 Change-Id: Ia1044e432d370034fe13f42cf7ed55d75e21187a Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-23Remove cookbook gifSaryu Shah2-12/+3
Remove cookbook picture from page ------------------------------------------------------------- Change-Id: I61edd0e4f336b19237421f05d6d36b61bb63170f Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-23Add license to policy/engine image filesJim Hahn99-0/+0
Added license to gif, jpg, and png files. Removed changes from gif files in POLICY-SDK-APP. Change-Id: Ief0c4be74cbdb844dd503040832be6c89bcc7ef9 Issue-ID: POLICY-741 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-04-20Build fails when build host running web serverliamfallon1-3/+3
If the host on which the policy engine is running a web server that respoonds with a HTTP response on the URL "http://localhost", the build fails because one of the tests in ONAP-XACML expects a ConnectException on this URL. When the URL returns a valid respose the test fails causing the buld to fail. This fix changes the URL to "http://localhost:54287", which I guess could also exist but is much less liekly to exist. Change-Id: I2f80d12a80d29a9bc7b2067f35c286f01c4d9550 Issue-ID: POLICY-700 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-19Add license to policy-engine filesJim Hahn98-46/+1925
Added license to various files. Updated XACMLPolicyScanner to work even when license comment is added to the Policy.xml file. Moved DOCTYPE before license in html files. Removed license from css files, as many are generated or come from third-party software. Removed license from other generated files. Change-Id: I9d98ca9f552a6eae17e80ef27fc7045cc4f27b8e Issue-ID: POLICY-741 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-04-19Merge "Remove insecure dependency on PolicyEngineAPI"Pamela Dragosh4-33/+84
2018-04-18Remove insecure dependency on PolicyEngineAPIliamfallon4-34/+85
The insecure dependency tyrus-container-grizzly-client is part of Tyrus, a Java web socket implementation library. A direct substitution of this library is not available so the code in AutoClientEnd.java and ManualClientEnd.java was adapted to work with the library org.java-websocket.Java-WebSocket that does not seem to have any vulnerabilities when tested with the org.owasp.dependency-check-maven plugin. The purpose of this submission is to see if the new library does indeed remove the vulnerability. If so, the implementation in AutoClientEnd and ManualClientEnd must be cleaned up. Change-Id: I961635aaea42c2f847edf11ee77e2961cdfb097b Issue-ID: POLICY-744 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-04-18Upgrade poi to clear CLMPamela Dragosh1-2/+2
https://nvd.nist.gov/vuln/detail/CVE-2017-12626 Issue-ID: POLICY-722 Change-Id: I016d2d357858729b402ad010d47a31af053d2799 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-17Upgrade hibernator and nettyPamela Dragosh1-2/+2
Forgot one place for hibernator and need to upgrade netty to clear CLM issue. http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-2156 Issue-ID: POLICY-722 Change-Id: I741c47110af916c222f92329791217b0c3bc07df Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-17Upgrade hibernator to clear clmPamela Dragosh2-2/+2
Upgrade hibernator to clear clm issue. https://nvd.nist.gov/vuln/detail/CVE-2017-7536 Issue-ID: POLICY-722 Change-Id: I1a4d9aa8ad3b477db0c91bd5a53a67932554213d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-17Upgrade spring 4.3.15-RELEASEPamela Dragosh1-1/+1
Forgot this reference to spring. Issue-ID: POLICY-722 Change-Id: I4335d860a883f925f1a6ba7bf28f6b59ed52511f Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-16Merge "Upgrade Spring to 4.3.15-RELEASE"Jorge Hernandez3-3/+3
2018-04-16Upgrade Spring to 4.3.15-RELEASEPamela Dragosh3-3/+3
Upgrade to fix 3 security issues: https://nvd.nist.gov/vuln/detail/CVE-2018-1270 https://nvd.nist.gov/vuln/detail/CVE-2016-9878 https://nvd.nist.gov/vuln/detail/CVE-2018-1271 Issue-ID: POLICY-722 Change-Id: Icfa5775905ad091dbe55eadfb4414c67abebc13a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-16Fix wrong data nameWang,Frank(gw1218)1-3/+3
Since MS configure name was changed in server side, its name needs to be updated in the JS file also. Issue-ID: POLICY-743 Change-Id: Iaed37a8d2b4dcfc5fb5ccd746b9aeb2270289338 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-04-14Merge "Upgrade to SNAPSHOT 1.2.1"Jorge Hernandez22-44/+44
2018-04-13Upgrade to SNAPSHOT 1.2.1Pamela Dragosh22-44/+44
Issue-ID: POLICY-736 Change-Id: If5c959aa1c0a123c7fd9eee281e39e1d646b6b03 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-12Fix Wrong Data NamesWang,Frank(gw1218)4-22/+37
Fix wrong data names due to reponse changes Issue-ID: POLICY-740 Change-Id: I28db745f88ccecd67f3daa30adf70cc69645b496 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-04-12Merge "OOF Policy Config File Creation Issue"v1.2.0Jorge Hernandez1-3/+5
2018-04-12OOF Policy Config File Creation IssueMichael Mokry1-3/+5
Fixed the issue with creating the config file with the wrong file name so that the PDP can pick it up when pushing the policy and getCOnfig will return the Config retrieved rather than a CONFIG_NOT_FOUND 400 status. I found this issue in the new CSIT tests for HPA policies and this should also resolve the failed test in Integration as well. Change-Id: I617133a188f3ba915feafd79da4f3e9d0b0eb4a6 Issue-ID: POLICY-738 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-04-12Merge "Fix Fortify Header Manipulation Issue"Pamela Dragosh1-1/+8
2018-04-11Update Release NotesSaryu Shah1-19/+5
Update Release Notes ------------------------------------------------------------- Change-Id: I3119427562112969afac284576b3fe799eac0887 Issue-ID: POLICY-536 Signed-off-by: Saryu Shah <ss3917@att.com>
2018-04-11Fix Fortify Header Manipulation IssueWang,Frank(gw1218)1-1/+8
Fix Forfity issue on group Id by adding a validation on this input value. Issue-ID: POLICY-734 Change-Id: I83321a5ffd1ddca84f985b5fd8659e502ca967d7 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
2018-04-10Modified DB Upgrade script for OptimizationModelsMichael Mokry3-10/+12
Changed the incorrect column 'dataorder' to 'dataorderinfo' Made changes to pom and AAF client code per AAF API changes in new depedency. Change-Id: Ic9bf0edec8282cc0f96d6fedd62fa9253d52070f Issue-ID: POLICY-731 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-04-04ONAP log files consolidationChou, Joseph (JC2555)2-1/+3
Check in changes for pap,pdp,console,brmsgw,paplp and pdplp Change-Id: I5b51368f8fed2d0ede848f1aa7f2f70c866dfe8b Issue-ID: POLICY-562 Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>
2018-04-04Merge "Add More Validations on TOSCA Model Format"Jorge Hernandez3-7/+114
2018-04-03Add More Validations on TOSCA Model FormatWang,Frank(gw1218)3-7/+114
Add more validations on TOSCA MS model file name and content format Issue-ID: POLICY-721 Change-Id: Ic3dfe1887791be1e11bca5695866a77909334536 Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>