summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-11-22Add and Modify JUnits for Code CoveragePeyton Puckett2-9/+94
Modify license Issue-ID: POLICY-2133 Change-Id: I1b58fcc1636a9bf8d45595480bc5e027d93bb277 Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
2019-11-20Merge "Build tar.gz without requiring docker image build"Pamela Dragosh1-0/+4
2019-11-20Merge "Unit/SONAR/Checkstyle in ONAP-REST"Ram Krishna Verma4-322/+2290
2019-11-19Build tar.gz without requiring docker image buildjhh1-0/+4
This allows the tar.gz to be released by LF jobs. Issue-ID: POLICY-2250 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: I7a6a2fa109328f9e479af019198877fd6421ede5
2019-11-19Unit/SONAR/Checkstyle in ONAP-RESTliamfallon4-322/+2290
Refactor of the PolicyValidationRequestWrapper class to make it testable and unit tests for the class. Issue-ID: POLICY-2131 Change-Id: Ie6b0b20aafd6a823fa778bb8070d057f27b28603 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-19Merge "Format ONAP-XACML and add JUnit"Jorge Hernandez38-4621/+4339
2019-11-19Format ONAP-XACML and add JUnitPamela Dragosh38-4621/+4339
Formatting and sonar issues. Cleaned up JUnit tests. Added more JUnit test coverage. Issue-ID: POLICY-2242 Change-Id: Ife0921971c6eb97de2a64b2f303cd16f992b4bd3 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-11-18Unit/SONAR/Checkstyle in ONAP-RESTliamfallon28-1191/+1852
Util package of ONAP-REST, with JUnit added and SONAR/Checkstyle issues addressed. In cases where a class name change caused an update in another package, the license header on files for those knock on changes are not updated. Issue-ID: POLICY-2131 Change-Id: Ic134408efe76b9838f5607a07f1735d12bd41032 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-18Merge "Unit/SONAR/Checkstyle in ONAP-REST"Liam Fallon41-1255/+743
2019-11-15More JUnit additions for PAP-RESTbobbymander5-25/+98
Issue-ID: POLICY-2130 Change-Id: Ia111e5fd6dfba1e03f157ff95f91ef65df293043 Signed-off-by: bobbymander <bobby.mander@att.com>
2019-11-15Merge "Cleanup drl files in policy/engine test modules"Jorge Hernandez5-2371/+197
2019-11-15Unit/SONAR/Checkstyle in ONAP-RESTliamfallon41-1255/+743
Fifth and final batch of JPA pojos (Q-Z), with JUnit added and SONAR/Checkstyle issues addressed. In cases where a class name change caused an update in another package, the license header on files for those knock on changes are not updated. Issue-ID: POLICY-2131 Change-Id: I1cc536a5b8a0cd3c6beff068dd72381f7ae10d12 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-15Merge "Unit/SONAR/Checkstyle in ONAP-REST"Pamela Dragosh85-3101/+2562
2019-11-13Unit/SONAR/Checkstyle in ONAP-RESTliamfallon85-3101/+2562
Fourth batch of JPA pojos (N-P), with JUnit added and SONAR/Checkstyle issues addressed. In cases where a class name change caused an update in another package, the license header on files for those knock on changes are not updated. Issue-ID: POLICY-2131 Change-Id: I9319b514b5c19e6837c34566dde770673d16bca3 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-13Cleanup drl files in policy/engine test modulesRashmi Pujar5-2371/+197
Issue-ID: POLICY-1895 Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca> Change-Id: Ice15aadbafd999b20594c3b6488e115063c985ce
2019-11-13Few JUnit additions for PAP-RESTbobbymander7-60/+257
Issue-ID: POLICY-2130 Change-Id: Ie9972bc0014def93acf04c4a2386585fb4accdef Signed-off-by: bobbymander <bobby.mander@att.com>
2019-11-12JUnit/SONAR/Checkstyle in ONAP-RESTliamfallon47-2447/+744
Third batch of JPA pojos (E-M), with JUnit added and SONAR/Checkstyle issues addressed. In cases where a class name change caused an update in another package, the license header on files for those knock on changes are not updated. Issue-ID: POLICY-2131 Change-Id: I4fee1e9fb9c8a69dd6f2f15d3e3a8844473b857b Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-11Fix table names for CSIT issueJim Hahn3-9/+9
Changed the table name in multiple files. Backed out some changes per review comments. Change-Id: I31f75ebdef4aa70aff841c8a52185f6ab8a4e329 Issue-ID: POLICY-2131 Signed-off-by: Jim Hahn <jrh3@att.com>
2019-11-08Do not hardcode io.fabric8 pluginPamela Dragosh1-1/+0
policy/parent now has this plugin defined Issue-ID: POLICY-2222 Change-Id: I855c7b2bbd65e93695f7bfe5242be6f474f416fc Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-11-08Merge "JUnit/SONAR/Checkstyle in ONAP-REST"Pamela Dragosh33-444/+1478
2019-11-07Turn on lombok code coverage for policy-engineJim Hahn1-1/+1
If this backfires, we can turn it back off again. Issue-ID: POLICY-2131 Signed-off-by: Jim Hahn <jrh3@att.com> Change-Id: I7375bf4a3fa63a7791c30b3a73813bff1a69055e
2019-11-07JUnit/SONAR/Checkstyle in ONAP-RESTliamfallon33-444/+1478
Second batch of JPA pojos (B-D), with JUnit added and SONAR/Checkstyle issues addressed. In cases where a class name change caused an update in another package, the license header on files for those knock on changes are not updated. Issue-ID: POLICY-2131 Change-Id: I9466f27ffa606001209ed978be592ae95d1b32c4 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-06JUnit/SONAR/Checkstyle in ONAP-RESTliamfallon9-577/+402
First batch of JPA pojos Lombok'd and some missing coverage updated I'll be interested to see how Lomboking code shows up in SONAR, I have not added much JUnit here but I have reduced a good bit of source code, let's see what happens. Issue-ID: POLICY-2131 Change-Id: I8f270ef57282f63821c1eb94dd6b50f8ae541028 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-05Merge "More JUnit additions for PAP-REST"Pamela Dragosh6-17/+215
2019-11-05More JUnit additions for PAP-RESTbobbymander6-17/+215
Issue-ID: POLICY-2130 Change-Id: Ia64bdbb377d26ba209b2d3fc51bc95f5769a7729 Signed-off-by: bobbymander <bobby.mander@att.com>
2019-11-05Merge "Fixed Sonar issues for Console Logs"Pamela Dragosh15-2498/+2083
2019-11-04JUnit/SONAR/Checkstyle in ONAP-RESTliamfallon2-407/+570
Cleanup of the dao-impl package in ONAP-REST All enclosing try/catch blocks removed. Issue-ID: POLICY-2131 Change-Id: Iec73fc5a85b891a00ba8c029e9904051c51284c2 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-04Fixed Sonar issues for Console Logsuj426b15-2498/+2083
Issue-ID: POLICY-2153 Change-Id: Id21a9dd4910ff0c831e49a1539f130ade1779577 Signed-off-by: utkarshJ <uj426b@att.com>
2019-11-01Add common Jersey versionliamfallon1-3/+9
Add a common version of Jersey for all Policy Framework components. Issue-ID: POLICY-2209 Change-Id: If376b0d1c1cb11c20a176c4ea9a5b674cb8c66da Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-11-01ONAP-REST DAO Sonar/Checkstyle clean and knock-onliamfallon16-648/+911
Clean up the ONAP-REST DAO package and also deal with knock-on chages in other packages. Issue-ID: POLICY-2131 Change-Id: I381d514d37ffbddb7a91b8f8a018c7354fc437b3 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-10-31Upgrade to drools 7.28.0.Finaljhh1-20/+2
Issue-ID: POLICY-1407 Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Change-Id: Ia934906cb9f5b7a3f8aac59bb204d9426e994e1f Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
2019-10-31Merge "Fixed SonarIssues Alerts to Bootstrap Notification"Pamela Dragosh56-3378/+3388
2019-10-31Merge "Fix unit test failure in ONAP-PDP-REST"Jorge Hernandez1-2/+9
2019-10-30Fixed SonarIssues Alerts to Bootstrap Notificationuj426b56-3378/+3388
Issue-ID: POLICY-2153 Change-Id: I0778ac8a35cc4677e86f93319818d0980fec365b Signed-off-by: utkarshJ <uj426b@att.com>
2019-10-30JUnit additions for PAP-REST, checkstyle fixesbobbymander6-84/+174
Issue-ID: POLICY-2130 Change-Id: Ia9fb294090a27ee86321249bc6b1cbdf20f33d06 Signed-off-by: bobbymander <bobby.mander@att.com>
2019-10-30Fix unit test failure in ONAP-PDP-RESTliamfallon1-2/+9
Unit test parameters were cleared by earlier tests, test setup changed to initiate paramters required by the test. Issue-ID: POLICY-2205 Change-Id: Ia460226ae5fb6e0c42ba9840bd4fe3952dbd1a13 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-10-29Fix knock on tabs/SONAR/Checkstyle issuesliamfallon2-735/+782
Changes in the last ONAP-REST review caused knock on changes in ONAP-PDP-REST. Those changes identified issues in two classes with tabs. While changing the tabs to spaces, some other easy to fix SONAR/Checkstyle issues were addressed. Issue-ID: POLICY-2132 Change-Id: I4e32089ada7b5095da0751993458cf7173cef064 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-10-29Merge "CHeckstyle and JUnit for base package in ONAP-REST"Liam Fallon41-535/+773
2019-10-25junit addition and update for PAP.bobbymander2-66/+73
Issue-ID: POLICY-2130 Change-Id: I33f25588c34fe72b12855a2486ba892afc04693c Signed-off-by: bobbymander <bobby.mander@att.com>
2019-10-24CHeckstyle and JUnit for base package in ONAP-RESTliamfallon41-535/+773
Added unit tests and fixed checkstyle and SONAR issues in the base package of ONAPE-REST There was a lot of knock-on automatic changes done by Eclipse when I renamed the class XACMLRestProperties to XacmlRestProperties so ignore the changes in all but the ONAP-REST package. I also didn't update the licenses on files on those classes because the changes were automatic. Issue-ID: POLICY-2131 Change-Id: I28823c844b5192f8d56de76a727996b13e7ea4a6 Signed-off-by: liamfallon <liam.fallon@est.tech>
2019-10-24Merge "Fixed the Policy GUI Editor tab right click issue."Liam Fallon2-5/+346
2019-10-24Fixed the Policy GUI Editor tab right click issue.uj426b2-5/+346
Issue-ID: POLICY-2159 Change-Id: Id659c56167613beb1dd28bcfd71d478209091647 Signed-off-by: utkarshJ <uj426b@att.com>
2019-10-23Consolidate PolicyRestAdapter setupPamela Dragosh155-4438/+4749
Put common code into PolicyEngineUtils that the controllers use to populate the PolicyRestController. Also some more sonar cleanup and formatting of XML files. Shortened 120 line characters. Removed some trailing spaces from comments. Fixed up one JUnit. Licenses. Issue-ID: POLICY-2133 Change-Id: Id7d8ac3ab60331535f048ec0f26aeb17a099414e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-22Remove useless imports and varsPamela Dragosh16-89/+60
Some formatting and javadoc cleanup also. Issue-ID: POLICY-2133 Change-Id: Icb0f76c7e69df87918b4bc5a02a013f9d2bfae89 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-22Format source code PolicyEngineClientPamela Dragosh22-1452/+1512
Formatting and sonar issues. Looks like this is all code used for demonstrating how to call the API's. Uses all main so actually no JUnit is being called. Unfortunately there are no associated test files for it. Would be interesting to see if adding a JUnit to call it with some test code would help to improve overall coverage. Future work. Issue-ID: POLICY-2145 Change-Id: I0d0f6d8898076a92d342553f45f70a56fd9d49f6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-18JUnit addition for PAP-RESTbobbymander1-0/+74
Issue-ID: POLICY-2130 Change-Id: I8b35a83b3eeb2760a99c3893604afba1bc5eafd7 Signed-off-by: bobbymander <bobby.mander@att.com>
2019-10-17Re-format source codePamela Dragosh37-1346/+1097
No longer need the onap-java-formatter.xml in the repo - just use command line to set path to it as this process is done manually anyway. Fixed missing javadoc, curly braces and variables names. One minor fix to remove redundant jump and then unnecessary lambda expression. Distance from usage - moved code. Fixed compilation error in PeCryptoUtils due to policy/common change. Fixed some test sources with consecutive capital letter in names. Updated licenses. Added some trivial code coverage. Issue-ID: POLICY-2145 Change-Id: I6c36650554e4fe31a3e71538d898535bc77e7e74 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2019-10-17Merge "Adding simple, missing junit"Jorge Hernandez1-0/+37
2019-10-16Adding simple, missing junitbobbymander1-0/+37
Issue-ID: POLICY-2130 Change-Id: I6bc88b7bf720e672bfaa97029453e8d39a706aae Signed-off-by: bobbymander <bobby.mander@att.com>
2019-10-14Sonar cleanup in controllers etcPamela Dragosh23-947/+964
Variable renaming of consecutive capital letters. Adding Javadoc Missing curly braces Re-writing some methods to reduce cyclomatic complexity Combining while's into a simple for statement. Addressing previous review comments No real effort on code coverage in this one. Issue-ID: POLICY-2133 Change-Id: I4afb3030203e1dbc743507e037ca3d57faf41f1d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>