summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-02-15Adding Junits in ONAP-PDP-RESTMichael Mokry2-2/+85
- This commit adds one Junit for PAPServices - I needed to make a minor modification to the PAPServices class in order to set the PAPs Change-Id: Ia54650307e8d9e96d40ce6e68ad18508d4030a4a Issue-ID: POLICY-338 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-02-14Merge "Added Junits for Policy PAP-REST"Jorge Hernandez37-642/+1299
2018-02-14Make drlRuleAndUIParams transient or serializableSwapnali Pode1-1/+1
Make drlRuleAndUIParams transient or serializable StdPAPPolicy.java:L72 Sonar Link: https://sonar.onap.org/project/issues?assignees=swapnalipode&id=org.onap.policy.engine%3APolicyEngineSuite&open=AWF91ipr8TZzbCgU6aom&resolved=false Location: src/main/java/org/onap/policy/xacml/std/pap/StdPAPPolicy.java Change-Id: I3524881e76c69518949a622a23084e0bc8ef26a2 Issue-ID: POLICY-631 Signed-off-by: Swapnali Pode <SP00501638@techmahindra.com>
2018-02-13Added Junits for Policy PAP-RESTrb714737-642/+1299
Cleaned the unnecessary constructors and methods in onap-rest. Added Junits for JPA Classes in ONAP-REST. Issue-ID: POLICY-338 Change-Id: I7e4f928342315475db96d89e9ad3adac5cb7eb00 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-14Merge "Fix a Bug on Editor Screen"Pamela Dragosh1-0/+7
2018-02-13Merge "Added Junits for Policy PAP-REST"Jorge Hernandez15-400/+1953
2018-02-13Fix a Bug on Editor Screenguangxingwang1-0/+7
On editor screen, sometimes click on + button only one click, it creates more than text fields Issue-ID: POLICY-629 Change-Id: I9acc95fa0a4a7df3828e579f994c06bfa3199eb5 Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-13Merge "Fix Fortify Scan Issue"Jorge Hernandez1-10/+48
2018-02-12Added Junits for Policy PAP-RESTrb714715-400/+1953
Resolved the sonar issues. Added JUnits for ONAP-PAP-REST and ONAP-REST Component. Issue-ID: POLICY-338 Change-Id: Ibec2613f4f61e9ed426583af17c2a9d5b8c8d85d Signed-off-by: rb7147 <rb7147@att.com>
2018-02-12Fix Fortify Scan Issueguangxingwang1-10/+48
Fix Fortify Header Manipulation Issue by checking the format of a string before adding it to response header. Issue-ID: POLICY-543 Change-Id: I6539d22d5f8933ea29932361b152d34dd4f8857a Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-10Merge "Added Junits for ONAP-PAP-REST"Pamela Dragosh13-523/+948
2018-02-09Added Junits for ONAP-PAP-RESTrb714713-523/+948
Cleaned up unused imports. Cleaned up unused code. Added Junits for Dictionary controllers. Issue-ID: POLICY-338 Change-Id: If29b934e95fdaf60dcf82300a95a23ac3c980419 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-09Merge "Upgrading XACML jar"Jorge Hernandez3-3/+3
2018-02-09Merge "Added JUNITS for ONAP-REST Component"Jorge Hernandez6-20/+762
2018-02-09Upgrading XACML jarPamela Dragosh3-3/+3
XACML was released with minor fixes for XML files with comments. Mainly it contained upgrade to dependencies that had fixed security issues. One still remains but will not be able to be fixed. Issue-ID: POLICY-617 Change-Id: Ib143c87156ed6a15cf4f0fe0ecbedb2407ca5b0d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-09Added JUNITS for ONAP-REST Componentrb71476-20/+762
Added JUnits for all Pojo classes. Issue-ID: POLICY-338 Change-Id: I0142903899f0793a8e147a01aeea83d467e49981 Signed-off-by: rb7147 <rb7147@att.com>
2018-02-08Remove Password from Loggingguangxingwang2-5/+4
Fix Fortify logging issue Issue-ID: POLICY-544 Change-Id: Ibfc7665dcab229a705ec3f999545b14675c24430 Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-08Merge "MS Model Input Validation"Pamela Dragosh22-236/+416
2018-02-08Downgraded the POLICY-SDK spring versionrb71471-1/+1
Issue-ID: POLICY-620 Change-Id: Ib7cf286f62e945edcf5720ce2c53957b8456126d Signed-off-by: rb7147 <rb7147@att.com>
2018-02-08Merge "Upgrade jackson-databind to fix security"Jorge Hernandez1-1/+1
2018-02-08Upgrade jackson-databind to fix securityPamela Dragosh1-1/+1
Missed this, I should have earlier upgraded to 2.9.4 Issue-ID: POLICY-507 Change-Id: Ic75cfd2d5a265f4a728e59777eac287a3d0894d1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-08Merge "FFix the Bug of Missing fields on View Screen"Jorge Hernandez1-18/+47
2018-02-08MS Model Input ValidationMichael Mokry22-236/+416
- Provides validation for MS policy input content body that matches the GUI validations when create/update MS policy from API - Added changes to satisfy review comments and updated copywright headers for modified and new files Change-Id: I02bfa639bffb48520badd0e4fa34eb36418547ae Issue-ID: POLICY-377 Signed-off-by: Michael Mokry <mm117s@att.com>
2018-02-08Merge "Upgrade dependencies to clear security issues"Jorge Hernandez11-39/+72
2018-02-07FFix the Bug of Missing fields on View Screenguangxingwang1-18/+47
Missing extra fields added by clicking add buton if they are more than 10 on view screen Issue-ID: POLICY-613 Change-Id: I9e718b62301f24b71a4f6506d3e63e6185e0b1ce Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-07Upgrade dependencies to clear security issuesPamela Dragosh11-39/+72
A bit of consolidation too - which could use a lot more work. These were simple security upgrades for fixes identified by LF weekly LCM job. Added some missing license headers. Issue-ID: POLICY-507 Change-Id: If285b0f95d30a1084c9363bf6a41b48d52fb3aff Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-07Fixed the sonar issues in ONAP-REST.Ankitkumar Patel8-36/+31
Minor Sonar issues are fixed in the ONAP_REST module. The copyright headers of the changed files are also updated. Issue-ID: POLICY-476 Change-Id: I920d8bcdd7b855e3e1660a002fb0e4e8d1674e44 Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
2018-02-07Merge "Implement Encryption on Passwords"Jorge Hernandez3-3/+3
2018-02-07Merge "Adding JUNITs for ONAP-PAP-REST"Pamela Dragosh2-1/+272
2018-02-07Merge "Continue addressing technical debt for ONAP-XACML"Pamela Dragosh15-155/+122
2018-02-06Merge "Implement Encryption on Passwords"Jorge Hernandez3-7/+38
2018-02-06Adding JUNITs for ONAP-PAP-RESTuj426b2-1/+272
Issue-ID: POLICY-338 Change-Id: I123a92872a236b23144c59e87ea2dffc9ee7fc48 Signed-off-by: uj426b <uj426b@att.com>
2018-02-06Continue addressing technical debt for ONAP-XACMLGao, Chenfei (cg287m)15-155/+122
Fix all sonar issues that do not require code refactoring Issue-ID: POLICY-475 Change-Id: Iefa91e0048b7041c96d47bce7ec99034d6fcc427 Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
2018-02-06Implement Encryption on Passwordsguangxingwang3-3/+3
Fix Fortify scan issue - hardcoded password in properties file Issue-ID: POLICY-542 Change-Id: Iea7b292c4dccf5f400320cd3f63309e955953f2d Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-06Policy Resiliency Code Fixesrb71478-204/+773
Resolved the issue on updating the configuration files when rename/clone/export/move actions are done through GUI. Fixed the PolicyManagerServlet code. Added test cases for newly added files. Issue-ID: POLICY-609 Change-Id: I9d14f19fe20bbc0e3b3844f85d81f26e34bb26ec Signed-off-by: rb7147 <rb7147@att.com>
2018-02-06Implement Encryption on Passwordsguangxingwang3-7/+38
Fix Fortify scan issue - hardcoded password in properties file Issue-ID: POLICY-542 Change-Id: Icefd4097dc2e20c0ec2b78c002599defb6034267 Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-05Merge "Fix last technical debt"Jorge Hernandez1-1/+1
2018-02-05Merge "Technical debt and fix JUnit test"Jorge Hernandez3-15/+4
2018-02-05Merge "Remove technical debt"Jorge Hernandez4-16/+22
2018-02-05Fix last technical debtPamela Dragosh1-1/+1
Last one that I dare to fix. Issue-ID: POLICY-477 Change-Id: Ieb1c159b781fa2f0dd80f7dea92dcbf72c3e8364 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-05Technical debt and fix JUnit testPamela Dragosh3-15/+4
* One statement per line * private constructor for class with statics * Fix silly JUnit test Issue-ID: POLICY-474 Change-Id: Ie760826879febbbc4db4f03079ae1f847f2194dd Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-05Implement Encryption on Passwordsguangxingwang2-0/+384
Fix Fortify scan issue - hardcoded password Issue-ID: POLICY-542 Change-Id: I722b9143fbddc48b67592bb35a44f36ed8b38aad Signed-off-by: guangxingwang <gw1218@att.com>
2018-02-05Remove technical debtPamela Dragosh4-16/+22
* String literals on the left * Unnecessary initialization of variables * Change ArrayList to using List * Remove extra semicolons * Empty Constructor comments * Useless parenthesis I also added a comment on some code that is suspicious. Not comfortable with changing that code. Issue-ID: POLICY-482 Change-Id: I89d889737d398d047fab4b25cb5d962ee1ecdd03 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-02Merge "Technical debt reduction"Jorge Hernandez7-19/+20
2018-02-02Resolved Fortify System Information Leak issuesrb714723-592/+777
Issue-ID: POLICY-550 Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f Signed-off-by: rb7147 <rb7147@att.com>
2018-02-02Technical debt reductionPamela Dragosh7-19/+20
* empty constructor * Unnecessary imports * try-with-resources * missing @Override * useless parens * proper boolean detection * useless imports * Use Set vs HashSet * moving statements to separate lines Issue-ID: POLICY-477 Change-Id: I5fae9c5c8e7d30f731a1caefc8a5271cf382e0a0 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-01Resolve LF license header issuePamela Dragosh7-73/+7
These were simple, we just forgot to remove the old license headers. Also needed to add a missed fix for a JUnit test. Not sure how this made it past verify. Issue-ID: POLICY-552 Change-Id: I30610ba4f8440ee16d0a5c372985f50429d60a34 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-02-01Merge "Included Policy GUI Enhancements and validations"Jorge Hernandez49-737/+1230
2018-02-01Included Policy GUI Enhancements and validationsrb714749-737/+1230
Added hover messages for all policy templates. Resolved few sonar issues. Added fixes for Policy GUI Validations. Issue-ID: POLICY-597 Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c Signed-off-by: rb7147 <rb7147@att.com>
2018-02-01Reduce technical debt and add JUnitPamela Dragosh39-439/+921
* Addressed some very simple cyclic complexity * Added simple JUnit tests and finished others * Removed useless assignments Issue-ID: POLICY-477 Change-Id: Ic919bbf78ad2732a430c32f1feb3c88678be710d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>